July 2023 - Wine-GitLab - list.winehq.org

[PATCH v6 0/1] MR3294: wow64win: Always use NtUserSetWindowLongPtr() for GWLP_WNDPROC.
by Sven Baars (＠sbaars) July 13, 2023

July 13, 2023

This fixes SetWindowLongPtr on WoW64. On 32-bit, we have ``` #define SetWindowLongPtrA SetWindowLongA #define SetWindowLongPtrW SetWindowLongW ``` meaning that on WoW64, all pointers passed would be padded with `0xffffffff` (because they are treated as LONG), and this is the cause of many of the failing WoW64 tests. This fixes that behavior. I'm not sure if this is the right place to fix it though. -- v6: wow64win: Always use NtUserSetWindowLongPtr() for GWLP_HINSTANCE and GWLP_WNDPROC. https://gitlab.winehq.org/wine/wine/-/merge_requests/3294

4 3

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 13, 2023

July 13, 2023

On Thu Jul 13 16:38:12 2023 +0000, Jeffrey Smith wrote: > Same issue with comparison of an enumeration. As above, this thread can be dismissed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38930

1 0

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 13, 2023

July 13, 2023

On Thu Jul 13 18:07:29 2023 +0000, Gabriel Ivăncescu wrote: > There's no need for a cast though. `ARRAY_SIZE` is already `size_t` > (because it's implemented with `sizeof`), and a comparison between a > signed integer and an unsigned integer with at least as many bits is > always promoted to unsigned. That is true. This thread can be dismissed then. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38929

1 0

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Gabriel Ivăncescu July 13, 2023

July 13, 2023

On Thu Jul 13 16:37:28 2023 +0000, Jeffrey Smith wrote: > Compilers can (and at least some do) treat an enumeration as a _signed_ > integer. For the comparison to work as desired you'll want to cast > `InformationClass` to an unsigned type. I think `size_t` would be appropriate. There's no need for a cast though. `ARRAY_SIZE` is already `size_t` (because it's implemented with `sizeof`), and a comparison between a signed integer and an unsigned integer with at least as many bits is always promoted to unsigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38928

1 0

[PATCH 0/1] MR3325: shell32: Don't fall back to $HOME for missing user special folders.
by Tim Clem (＠tclem) July 13, 2023

July 13, 2023

Fall through in create_link and allow SHGetFolderPathAndSubDirW to create an empty folder in place if the alternatives are not available. Creating a link back to $HOME makes a recursive directory structure, which results in crashes in programs that naively search %USERPROFILE% (e.g. Quicken). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3325

2 1

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 13, 2023

July 13, 2023

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "(unknown)", > + "(unknown)", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "(unknown)", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= ARRAY_SIZE(string_NameFormat)) Same issue with comparison of an enumeration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38927

1 0

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 13, 2023

July 13, 2023

Jeffrey Smith (@whydoubt) commented about dlls/advapi32/lsa.c: > + "PolicyReplicaSourceInformation", > + "PolicyDefaultQuotaInformation", > + "PolicyModificationInformation", > + "PolicyAuditFullSetInformation", > + "PolicyAuditFullQueryInformation", > + "PolicyDnsDomainInformation", > + "PolicyDnsDomainInformationInt", > + "PolicyLocalAccountDomainInformation", > + "PolicyMachineAccountInformation", > + "PolicyMachineAccountInformation2", > + "PolicyLastEntry" > +}; > + > +static LPCSTR debugstr_InformationClass(IN POLICY_INFORMATION_CLASS InformationClass) > +{ > + if (InformationClass >= ARRAY_SIZE(string_InformationClass)) Compilers can (and at least some do) treat an enumeration as a _signed_ integer. For the comparison to work as desired you'll want to cast `InformationClass` to an unsigned type. I think `size_t` would be appropriate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38926

1 0

Re: [PATCH v2 0/1] MR3315: ntdll: Fix NtContinue from within exception context on ARM64
by Jinoh Kang (＠iamahuman) July 13, 2023

July 13, 2023

This leads to a regression: NtContinue() can no longer properly restore X16 and X17, since they are clobbered by `__wine_syscall_dispatcher_return`. The proper fix is at https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/thr…, which is a superset of this patchset. I don't have an ARM64 build machine at the moment; can you rebase it and see if it works? Many thanks for your work! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3315#note_38925

1 0

[PATCH 0/1] MR3324: ntdll: Fail loudly if RtlActivateActivationContextEx fails to allocate memory.
by Jinoh Kang (＠iamahuman) July 13, 2023

July 13, 2023

Many built-in callers of ActivateActCtx() just assume that it will always succeed. If it ever fails, then DeactivateActCtx() will notice that the cookie is invalid and raise an exception anyway. Based on comment https://gitlab.winehq.org/wine/wine/-/merge_requests/2068#note_37340 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3324

3 2

[PATCH 0/1] MR3323: win32u: Don't clip captured mouse pointer only if it's done by the system.
by Gabriel Ivăncescu July 13, 2023

July 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3323

2 2