February 2024 - Wine-GitLab

[PATCH 0/1] MR4837: Draft: DEBUG Check if GitLab takes PARENTSRC into account.
by Francois Gouget (＠fgouget) May 28, 2024

May 28, 2024

It should run the xaudio2_7:xaudio2 test when xaudio2_8/tests/xaudio2.c is modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4837

5 4

[PATCH v2 0/1] MR5070: win32u: Cache is_virtual_desktop.
by Gabriel Ivăncescu May 28, 2024

May 28, 2024

It can be substantially faster in some cases. Notepad++ (with several plugins) start up goes down from around ~1.03 sec to ~0.61 sec on my machine (with wineprefix active). 9b7669592d6f8b40976b571b70f8543777d35167 is what introduced this performance regression. I don't know why exactly, but it made my Notepad++ noticeably slower when launched from a file manager (so it's not just at wineprefix startup overhead), which is very annoying. -- v2: win32u: Cache is_virtual_desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5070

2 7

[PATCH v4 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) May 28, 2024

May 28, 2024

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v4: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

3 4

[PATCH v66 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) May 28, 2024

May 28, 2024

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v66: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

7 22

[PATCH v2 0/5] MR4624: wined3d: More old-GL fixes.
by Matteo Bruni (＠Mystral) May 28, 2024

May 28, 2024

-- v2: d3d9/tests: Skip test_sample_attached_rendertarget() without pixel shaders support. wined3d: Don't override texture parameters for COND_NP2 on multisample textures. wined3d: Don't skip FFP projection transform update. d3d9: Don't do instanced draws in DrawPrimitive() and DrawPrimitiveUP(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4624

2 8

[PATCH 0/2] MR3929: ntdll: Remove entries from queue in RtlWakeAddressAll().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

This avoids one case of spurious wakeup of WaitOnAddress (which could be triggered by prior race on consequent WakeAddressAll and a thread trying to wake on that, leaving the waking thread in an alerted state). And fixes Resident Evil games randomly crashing due to unhandled spurious SleepConditionVariableCS wakeups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3929

4 8

[PATCH 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585)
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

5 11

[PATCH 0/2] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

6 15

[PATCH 0/10] MR4652: wined3d: A few more old-GL fixes.
by Matteo Bruni (＠Mystral) May 28, 2024

May 28, 2024

Here are 5 more patches on top of !4624, mostly along the same lines. I realize it's super late, no need to rush reviewing :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

4 16

[PATCH 0/1] MR4567: kernelbase: Silently handle exceptions if SEM_NOGPFAULTERRORBOX is set.
by Aida Jonikienė May 28, 2024

May 28, 2024

This finally solves a FIXME that was added back in 1997. NFS High Stakes (and Motor City Online) both emit a 0x190 access violation on startup (according to game's strings this was meant to be debugger detection; I think this was done to interfere in a DRM bypass but I'm probably wrong). But anyway that feature causes a Wine Debugger dialog to appear when starting the games (if you click "Show Details" though they suddenly start working normally but this is an extra annoyance for average people who just want to play the game). This change prevents that by not starting the debugger if the SEM_NOGPFAULTERRORBOX flag is set (if that flag wasn't set then people would be complaining about the game crashing every time) which lets the exception silently go through (it can still be seen with WINEDEBUG=+seh set though). I'm not sure how I can test for this exception handling behavior (I'm thinking of calling RaiseException() inside a __try/__except block but that might not be exactly what the games are doing). This patch was originally posted by Zeb in a diff form (so the patch description has been written by me, DodoGTA). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4567

3 5