February 2024 - Wine-GitLab

[PATCH 0/2] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) March 6, 2024

March 6, 2024

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

3 5

[PATCH 0/1] MR5165: wined3d: Slightly adjust an ERR in shader_spirv_compile_shader().
by Henri Verbeet (＠hverbeet) March 5, 2024

March 5, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5165

4 3

[PATCH v2 0/6] MR5171: wined3d/nvrc: Move state application to nvrc_apply_draw_state().
by Zebediah Figura (＠zfigura) March 5, 2024

March 5, 2024

-- v2: wined3d/nvrc: Remove now redundant WINED3D_TSS_RESULT_ARG handlers. wined3d/nvrc: Move alpha op application to nvrc_apply_draw_state(). wined3d/nvrc: Remove now redundant STATE_SAMPLER handlers. wined3d/nvrc: Move color ops from nvrc_colorop() to nvrc_apply_draw_state(). wined3d/nvrc: Move FFP bumpenv constant loading to nvrc_apply_draw_state(). wined3d/nvrc: Move TEXTUREFACTOR constant loading to nvrc_apply_draw_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5171

3 7

[PATCH v4 0/1] MR673: tests/shader-runner: Add sampler comparison tests.
by Conor McCarthy (＠cmccarthy) March 5, 2024

March 5, 2024

-- v4: tests/shader-runner: Add sampler comparison tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/673

3 2

[PATCH v2 0/6] MR5193: mouhid, win32u: Send and receive WM_POINTER messages.
by Rémi Bernon March 5, 2024

March 5, 2024

-- v2: win32u: Add support for sending and receiving WM_POINTER* messages. server: Add support for sending and receiving WM_POINTER* messages. mouhid.sys: Send WM_POINTER* messages on contact updates. dinput/tests: Test the WM_POINTER* message parameter values. win32u: Use a custom struct hid_input for NtUserSendHardwareInput. https://gitlab.winehq.org/wine/wine/-/merge_requests/5193

3 11

[PATCH v2 0/1] MR5083: server: Try to retrieve the unix name on handles created from file descriptors.
by Gabriel Ivăncescu March 4, 2024

March 4, 2024

Useful with unix integration of redirected standard handles. Simple testcase: ```c #include <windows.h> #include <stdio.h> int main(int argc, char **argv) { char buf[4096] = {0}; FILE_NAME_INFO *name_info = (FILE_NAME_INFO*)buf; if (!GetFileInformationByHandleEx(GetStdHandle(STD_OUTPUT_HANDLE), FileNameInfo, name_info, sizeof(buf))) { fprintf(stderr, "GetFileInformationByHandleEx failed %08lx\n", GetLastError()); return 1; } WriteFile(GetStdHandle(STD_ERROR_HANDLE), name_info->FileName, name_info->FileNameLength, NULL, NULL); return 0; } ``` On Windows: ``` test.exe > C:\Temp\test.txt ``` Output: ``` \Temp\test.txt ``` On wine: ``` wine test.exe > /tmp/wine/testprefix/drive_c/Temp/test.txt ``` Upstream output: ``` GetFileInformationByHandleEx failed 00000006 ``` With this MR: ``` \Temp\test.txt ``` -- v2: server: Try to retrieve the unix name on handles created from file https://gitlab.winehq.org/wine/wine/-/merge_requests/5083

2 5

[PATCH v2 0/1] MR5146: d3dcompiler: Enable semantic naming mapping in compatibility mode.
by Nikolay Sivov (＠nsivov) March 4, 2024

March 4, 2024

This was implemented in vkd3d 1.10. Another known feature that has to be enabled with compatibility flag is d3d9 style sampling functions. We currently don't do that, making them supported unconditionally. -- v2: d3dcompiler: Enable semantic names mapping in compatibility mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5146

3 2

[PATCH 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running.
by Zhiyi Zhang (＠zhiyi) March 4, 2024

March 4, 2024

Patch 2 fixes a race condition in theory. I haven't found it affecting any real-world applications. These two bugs are caused by race conditions. I don't think adding tests could demonstrate them reliably. This MR can probably fix the race condition mentioned at https://gitlab.winehq.org/wine/wine/-/merge_requests/4243 patch 3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158

3 4

[PATCH v2 0/7] MR5174: win32u: Simplify sysparams using ascii strings for registry operations when possible.
by Rémi Bernon March 4, 2024

March 4, 2024

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5137 -- v2: win32u: Introduce and use new reg_(open|create)_ascii_key helpers. win32u: Use set_reg_ascii_value whenever possible. win32u: Remove unnecessary class_guidW double check. win32u: Use REG_SZ instead of REG_BINARY for some adapter keys. win32u: Remove unused wine_devpropkey_monitor_adapternameW property. win32u: Simplify adapter key path creation from gpu_guid. win32u: Use char array for the device manager context gpuid. https://gitlab.winehq.org/wine/wine/-/merge_requests/5174

1 8

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.
by Paul Gofman (＠gofman) March 3, 2024

March 3, 2024

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

6 6