February 2024 - Wine-GitLab

Re: [PATCH v2 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) Feb. 20, 2024

Feb. 20, 2024

On Wed Nov 22 18:02:56 2023 +0000, eric pouech wrote: > my point is more about the way to implement the fix rather if the > propose fix passes the tests > cmd as of today is barely maintanable because of small adjustements here > and there, added over the years > your proposal is such a small adjustment by changing behavior of some > helper functions, depending on context, whereas IMO the cause of the > issue lies elsewhere I can appreciate the fact that Wine's cmd.exe implementation is kind of ugly. Nonetheless, in my opinion it's not reasonable to require a near-total rewrite of cmd.exe in order to fix this bug. `IF` is very special in cmd, and would still have to be treated specially even if cmd.exe were completely rewritten. The correct order of operations is to expand % variables, then parse the operands, then expand ! variables. Whether we have functions like handleExpansion, evaluate_if_condition, and do_delayed_expansion for those steps or whether we have a tokenizer that does it all, there has to be code to define the order, and that code would be similar in either case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4418#note_61991

1 0

[PATCH v5 0/3] MR629: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
by Conor McCarthy (＠cmccarthy) Feb. 20, 2024

Feb. 20, 2024

-- v5: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions. vkd3d-shader/dxil: Move the resource kind helper functions up. vkd3d-shader/spirv: Introduce a sample info flag value for a scalar uint dst parameter. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629

2 3

[PATCH v5 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) Feb. 20, 2024

Feb. 20, 2024

-- v5: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

2 6

[PATCH v4 0/2] MR3982: include: Move RTL functions that belong in ntifs.h from winternl.h to ntifs.h.
by Alex Henrie (＠alexhenrie) Feb. 20, 2024

Feb. 20, 2024

-- v4: include: Move RTL functions that belong in ntifs.h from winternl.h to ntifs.h. include: Define DEVICE_TYPE to be ULONG in winioctl.h https://gitlab.winehq.org/wine/wine/-/merge_requests/3982

3 5

[PATCH v2 0/2] MR5102: include: Move CPTABLEINFO and NLSTABLEINFO from winternl.h to ntnls.h.
by Alex Henrie (＠alexhenrie) Feb. 20, 2024

Feb. 20, 2024

This is a relatively small step towards cleaning up the dumping ground that Wine's winternl.h has become. -- v2: include: Move CPTABLEINFO and NLSTABLEINFO from winternl.h to ntnls.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/5102

3 7

[PATCH 0/1] MR5115: po: Update Lithuanian translation.
by Aurimas Fišeras Feb. 19, 2024

Feb. 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5115

2 2

[PATCH v2 0/4] MR656: vkd3d-shader/ir: Introduce a better CFG structurizer, part 1.
by Giovanni Mascellani (＠giomasce) Feb. 19, 2024

Feb. 19, 2024

This first MR create an internal structured representation of the CFG and computes the domination relationship. Over a few other MRs I will implement an algorithm inspired to [this article](https://medium.com/leaningtech/solving-the-structured-control-flow… to compute a better structure than the one we already have, but for the moment the computed data is immediately wasted. -- v2: vkd3d-shader/ir: Dump the domination relationship. vkd3d-shader/ir: Compute the domination relationship. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/656

2 6

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Zebediah Figura (＠zfigura) Feb. 19, 2024

Feb. 19, 2024

On Mon Feb 19 22:15:56 2024 +0000, Giovanni Mascellani wrote: > I guess `hlsl_types_are_equal()` should be updated too? Ah yes, that too, good catch. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61969

1 0

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Giovanni Mascellani (＠giomasce) Feb. 19, 2024

Feb. 19, 2024

On Mon Feb 19 22:15:56 2024 +0000, Henri Verbeet wrote: > How about the > [attached](/uploads/d104ebd37a462b4fd375640b9e97eb93/patches.mbox.xz) > series? I turns out that it's a bit awkward to make the > "rasteriser_ordered" flag specific to UAVs due to the way > "resource_format" is currently used, but making it a resource flag seems > close enough to me. The series has a minor conflict with 569. I guess `hlsl_types_are_equal()` should be updated too? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61968

1 0

Re: [PATCH v2 0/3] MR658: tests/shader_runner: Unify the checking and reporting of runner capabilities. - approved
by Alexandre Julliard (＠julliard) Feb. 19, 2024

Feb. 19, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/658

1 0