March 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR5398: configure: Quote ac_cv_lib_soname_MoltenVK when setting SONAME_LIBVULKAN.
by Rémi Bernon March 25, 2024

March 25, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5398

2 2

[PATCH 0/1] MR5396: gdi32/emf: Zero-initialize handles array (Valgrind).
by Nikolay Sivov (＠nsivov) March 25, 2024

March 25, 2024

It's checked in emr_reset(), and reallocation already zero-initializes new slots. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5396

3 2

Re: [PATCH v2 0/7] MR739: vkd3d-shader/hlsl: Parse state blocks, part 1.
by Nikolay Sivov (＠nsivov) March 25, 2024

March 25, 2024

On Fri Mar 22 21:12:59 2024 +0000, Zebediah Figura wrote: > You could probably avoid the duplication with a separate "%empty | > [int]" rule. Or alternatively use "arrays" and add an explicit check for > count > 1. > Is C_INTEGER correct here, or should we allow compile-time constants? It is correct. We should check for negative values only. Constant evaluated expressions are not allowed. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_65991

1 0

[PATCH 0/3] MR5130: mfmediaengine: Implement IMFMediaEngineEx::SetCurrentTime/Ex().
by Zhiyi Zhang (＠zhiyi) March 25, 2024

March 25, 2024

This is a split from MR3572. It's needed for Underworld Island (2150830) video seeking. Changes compared to the patches in MR3572: 1. Avoid making session state changes when in paused state. 2. Add tests to show that the MF_MEDIA_ENGINE_EVENT_SEEKING notification is most likely blocking because notify->seeking_event_received is TRUE right after a SetCurrentTime() call. Same for MF_MEDIA_ENGINE_EVENT_TIMEUPDATE when in paused state. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5130

4 5

[PATCH v28 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon March 25, 2024

March 25, 2024

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v28: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Return the desktop object info in get_thread_desktop. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 15

[PATCH 0/1] MR5391: crypt32: Fix CryptBinaryToStringA not adding a separator.
by Santino Mazza (＠tati1454) March 25, 2024

March 25, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5391

3 2

[PATCH v7 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Anton Baskanov (＠baskanov) March 25, 2024

March 25, 2024

-- v7: explorer: Restore display settings on process exit. winex11.drv: Process RRNotify events in xrandr14_get_id. user32/tests: Test that display settings are restored on process exit. https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

4 8

Re: [PATCH v4 0/5] MR5365: win32u: Introduce a new common vulkan source.
by Rémi Bernon March 25, 2024

March 25, 2024

On Mon Mar 25 05:11:24 2024 +0000, Brendan Shanks wrote: > This is causing build errors for me: > ``` > ../dlls/win32u/vulkan.c:91:35: error: use of undeclared identifier 'libMoltenVK' > if (!(vulkan_handle = dlopen( SONAME_LIBVULKAN, RTLD_NOW ))) > ^ > include/config.h:773:26: note: expanded from macro 'SONAME_LIBVULKAN' > #define SONAME_LIBVULKAN libMoltenVK.dylib > ^ > ../dlls/win32u/vulkan.c:93:37: error: use of undeclared identifier 'libMoltenVK' > ERR( "Failed to load %s\n", SONAME_LIBVULKAN ); > ^ > include/config.h:773:26: note: expanded from macro 'SONAME_LIBVULKAN' > #define SONAME_LIBVULKAN libMoltenVK.dylib > ^ > 2 errors generated. > make[1]: *** [dlls/win32u/vulkan.o] Error 1 > ``` > I think quotes are needed around `$ac_cv_lib_soname_MoltenVK`, that > results in `SONAME_LIBVULKAN` being correctly quoted. Sorry about that, I opened https://gitlab.winehq.org/wine/wine/-/merge_requests/5398 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5365#note_65962

1 0

[PATCH v19 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) March 25, 2024

March 25, 2024

-- v19: rtworkq: Release cancelled work items. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 9

[PATCH v2 0/5] MR5306: win32u: Move D3DKMT vulkan implementation out of winex11.
by Rémi Bernon March 25, 2024

March 25, 2024

With some intermediate refactoring to make the code simpler. I believe the failures that happened previously were coming from how NtGdiDdDDIOpenAdapterFromLuid initialized desc->hAdapter in win32u while winex11 was then relying on it. I missed this detail before and it should be working fine now that the vulkan path is only used to retrieve the physical device. -- v2: win32u: Move D3DKMT vulkan implementation out of winex11. winex11: Introduce a new find_adapter_from_handle helper. winex11: Introduce a new get_vulkan_physical_device helper. winex11: Initialize D3DKMT vulkan instance only once. win32u: Open adapters in NtGdiDdDDIEnumAdapters2 outside of the display devices lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/5306

3 10