March 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR5379: kernel32: Make MakeCriticalSectionGlobal() a noop.
by Paul Gofman (＠gofman) March 22, 2024

March 22, 2024

This fixes a performance regression introduced by 8b3944e1341baaf693927c8b758851d2dbba725a ("ntdll: Only allocate debug info in critical sections with RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO."). Critical section was using a fallback semaphore path if no debug info is present. That was apparently to support MakeCriticalSectionGlobal() which was deprecated and removed from kernel32 exports around Win2000. -- v2: kernel32: Make MakeCriticalSectionGlobal() a noop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5379

4 11

Re: [PATCH v2 0/7] MR739: vkd3d-shader/hlsl: Parse state blocks, part 1.
by Nikolay Sivov (＠nsivov) March 22, 2024

March 22, 2024

On Fri Mar 22 21:20:30 2024 +0000, Francisco Casas wrote: > well, first we have to find out if native does some compilation passes > such as copy-propagation and constant folding to lower complicated > expressions into constants, and apply those passes. For instance, are > rhs expressions such as `ANISOTROPIC + 1` marked as a of the _constant > load_ type in the effects metadata? > After applying the passes we have to check the type of the last > instruction of the block (or args[0], in case ths is not a complex > initializer with braces) which represents the whole expression, and see > if it is HLSL_IR_CONSTANT, HLSL_IR_INDEX (in which case we have to check > if the index part is constant) or HLSL_IR_EXPR. > We should also probably introduce a pass exclusive to fx.c to lower > known HLSL_IR_UNDECLARED_LOAD into constants, so constant folding (if > required) can work. > I don't know yet how complex initializers with braces work in this case, > if at all, but they parse. They are evaluated, yes. Destination index is not evaluated, it has to be an integer literal. So full format would be like this: property_name[<literal index>] = ( literal_constant | variable[literal_constant] | variable[index_variable] | <expression-for-anything-more-complicated> ) Expression case does not map directly to our internal opcodes, it does not follow the same conventions as d3dbc/tpf binaries do. But we can leave that out for now. Another case that does not fit into "args" array is examples like "compile ps_2_0, main(var)", or asm {} blocks, or asm{} blocks with leading decl{} part. Those will have to be handled separately. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_65867

1 0

Re: [PATCH v2 0/1] MR5390: user32/tests: Further updates for win11 TrackPopupMenu failures. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5390

1 0

Re: [PATCH v2 0/1] MR5389: kernel32, ntdll: Don't use debug info presence to detect critical section global status. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5389

1 0

Re: [PATCH v3 0/3] MR5387: msxml/tests: Move some of the validation tests to their modules. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5387

1 0

Re: [PATCH v3 0/1] MR5382: gitlab: Output collapsible section markers in test stage script. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5382

1 0

Re: [PATCH v2 0/1] MR5384: mfplat: Append MFVIDEOFORMAT user data after the structure padding. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5384

1 0

Re: [PATCH v4 0/5] MR5365: win32u: Introduce a new common vulkan source. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5365

1 0

Re: [PATCH v2 0/3] MR5386: user32: Add LoadKeyboardLayoutEx stub. - approved
by Alexandre Julliard (＠julliard) March 22, 2024

March 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5386

1 0

Re: [PATCH v2 0/7] MR739: vkd3d-shader/hlsl: Parse state blocks, part 1.
by Francisco Casas (＠fcasas) March 22, 2024

March 22, 2024

On Fri Mar 22 20:59:49 2024 +0000, Nikolay Sivov wrote: > My concern, just by looking at it, is about how hard would it be to > extract relevant cases from instructions. Is it easy to tell already > that we got a constant load, array variable load with constant index, > array variable load with variable index, or more complicated expression? > Those are important to distinguish, because they are encoded differently. well, first we have to find out if native does some compilation passes such as copy-propagation and constant folding to lower complicated expressions into constants, and apply those passes. For instance, are rhs expressions such as `ANISOTROPIC + 1` marked as a of the _constant load_ type in the effects metadata? After applying the passes we have to check the type of the last instruction of the block (or args[0], in case ths is not a complex initializer with braces) which represents the whole expression, and see if it is HLSL_IR_CONSTANT, HLSL_IR_INDEX (in which case we have to check if the index part is constant) or HLSL_IR_EXPR. We should also probably introduce a pass exclusive to fx.c to lower known HLSL_IR_UNDECLARED_LOAD into constants, so constant folding (if required) can work. I don't know yet how complex initializers with braces work in this case, if at all, but they parse. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_65852

1 0