- Wine-GitLab - list.winehq.org

[PATCH v3 0/1] MR2602: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock().
by Paul Gofman (＠gofman) April 26, 2023

April 26, 2023

-- v3: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2602

3 3

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

How bad would it be to duplicate tests in msxml3/4/6, removing version checks completely? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31211

1 0

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > } > > test = tests; > - while (test->xml) { > + while (test->xml) > + { > + if (test->versions && !(entry->ver & test->versions)) > + { > + test++; > + continue; > + } I don't see "versions" field set anywhere? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31210

1 0

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

This looks fine to me, if wine-specific modules are a problem, we'll need to build separate modules, increasing build size like @tclem said. But that's not my call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31209

1 0

[PATCH 0/2] MR2708: Two misc janitorings
by Michael Stefaniuc (＠mstefani) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2708

3 3

[PATCH v4 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v4: mfreadwrite/tests: Test GetService for MP4 sink writer. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 3

[PATCH 0/3] MR2705: d3dcompiler: D3DAssemble is a private export.
by Stefan Dösinger April 26, 2023

April 26, 2023

This series allows linking of our d3dx9.dll against d3dcompiler.lib from the Windows SDK. It presumably also fixes the d3dcompiler tests, although I didn't bother building them with Visual Studio so far. And yes, I did check, that stringification macro works on MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2705

3 11

[PATCH 0/5] MR2676: dxgi, d3d9: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2676

3 7

Re: [PATCH v2 0/1] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Giovanni Mascellani (＠giomasce) April 26, 2023

April 26, 2023

I think it would be preferable to have to test in the repository, even if it hardcodes the render target size. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179#note_31201

1 0

Re: [PATCH v2 0/1] MR171: Initialize a pointer for MSVC.
by Henri Verbeet (＠hverbeet) April 26, 2023

April 26, 2023

> The other issue I run into - and this is probably a Vulkan SDK thing, not MSVC as such - is that the options I have for GLSL.std.450.h are > > spirv-headers/GLSL.std.450.h spirv_cross/GLSL.std.450.h > > and not spirv/unified1/GLSL.std.450.h or vulkan/GLSL.std.450.h as checked by configure. Has the location changed in newer Vulkan SDK versions, or was this never tested on Windows (with any compiler) to begin with? I've tried building on Windows using MSYS2, and that generally worked fine, though it was some time ago. The vkd3d README does fairly explicitly mention depending on SPIRV-Headers and Vulkan-Headers, and I don't think it mentions the Vulkan SDK anywhere. We could of course add support for building against the Vulkan SDK if someone were to submit the patches... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171#note_31196

1 0