- Wine-GitLab - list.winehq.org

[PATCH 0/5] MR2177: win32u: Get monitor name from EDID when possible
by Paul Gofman (＠gofman) Feb. 13, 2023

Feb. 13, 2023

There are two common ways I observe how games get monitor name to display: 1. Registry key under Enum/Display (also present in EnumDisplayDevicesA result for monitors). On Windows this key is derived from edid as 'Manufacturer ID' (3 letters) combined with "Manufacturer product code" (4 hex digits). We currently have 'Default_Display' there for all the displays; 2. DisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). Windows sets friendlyNameFromEdid flag and returns a name from 'EDID Display Descriptor' with code 0xfc ("Display name"). As far as I could see by searching through the Windows registry this name doesn't seem to be explicitly present anywhere in registry (besides binary raw edid of course). The first patch removes name from the gdi driver's display structure. Now none of the drivers set anything genuine there. x11 and winemac always end up with "Generic Non-Pnp Monitor" string, wineandroid sets NULL there and "Generic Non-Pnp Monitor" is set in win32u in this case. That "Generic Non-Pnp Monitor" goes to "DeviceDesc" registry value. While our value doesn't match Windows string exactly, Windows also doesn't have any meaningful name under DeviceDesc (and contains "Generic Non-Pnp Monitor" as a part of it). So this patch is essentially a no-op currently. Going forward my idea is that we just want to have edid from drivers. If the raw one is not available we can generate fallback one ourselves based on the info about the monitor we might have from elsewhere in the drivers. My motivation is: - EDID is sometimes queried by apps directly, and it is better to provide a true one or a synthetic one with as much of accurate info as possible / reasonable; - There is more info in EDID, e. g., colorimetry for HDR support in d3d. As far as I can tell, there is no documented way to query HDR info on Windows besides dxgi interfaces (which in case on Wine are based on gdi drivers for such things and can hardly become a genine source of such info in Wine) and WinRT interface (for which I don't know where it takes the info on Windows but we probably don't want to make it a lower level source of such info in Wine). The alternative would be, instead of basing higher level win32u on EDID, parse EDID in drivers instead and add all the necessary info into gdi_monitor structure (instead of removing display name from there), but so far it seems less straightforward to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2177

2 5

[PATCH v5 0/1] MR2175: oleaut32: fix VarAbs function for BSTR with positive values
by Jason Millard (＠jsm174) Feb. 13, 2023

Feb. 13, 2023

While working in vbscript, I noticed abs on a `BSTR` value with a positive number would come back with an invalid value. Given the following script: ``` Dim x x = "30000" Debug.Print "x" & "=" & abs(x) ``` Outputs: ``` Script.Print 'x=3.08221696253945E-314' ``` After debugging, `pVarIn` gets the R8 value but is never shallow copied into `pVarOut`. I'm not sure how to write a test case in `oleaut32`, so I included a test case in `vbscript`. -- v5: oleaut32: fix VarAbs function for BSTR with positive values https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

2 1

[PATCH v4 0/1] MR2175: oleaut32: fix VarAbs function for BSTR with positive values
by Jason Millard (＠jsm174) Feb. 13, 2023

Feb. 13, 2023

While working in vbscript, I noticed abs on a `BSTR` value with a positive number would come back with an invalid value. Given the following script: ``` Dim x x = "30000" Debug.Print "x" & "=" & abs(x) ``` Outputs: ``` Script.Print 'x=3.08221696253945E-314' ``` After debugging, `pVarIn` gets the R8 value but is never shallow copied into `pVarOut`. I'm not sure how to write a test case in `oleaut32`, so I included a test case in `vbscript`. -- v4: oleaut32: fix VarAbs function for BSTR with positive values https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

3 2

[PATCH v3 0/1] MR2175: oleaut32: fix VarAbs function for BSTR with positive values
by Jason Millard (＠jsm174) Feb. 13, 2023

Feb. 13, 2023

While working in vbscript, I noticed abs on a `BSTR` value with a positive number would come back with an invalid value. Given the following script: ``` Dim x x = "30000" Debug.Print "x" & "=" & abs(x) ``` Outputs: ``` Script.Print 'x=3.08221696253945E-314' ``` After debugging, `pVarIn` gets the R8 value but is never shallow copied into `pVarOut`. I'm not sure how to write a test case in `oleaut32`, so I included a test case in `vbscript`. -- v3: oleaut32: fix VarAbs function for BSTR with positive values https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

3 2

[PATCH 0/1] MR2175: oleaut32: fix Abs function for BSTR with positive values
by Jason Millard (＠jsm174) Feb. 13, 2023

Feb. 13, 2023

While working in vbscript, I noticed abs on a `BSTR` value with a positive number would come back with an invalid value. Given the following script: ``` Dim x x = "30000" Debug.Print "x" & "=" & abs(x) ``` Outputs: ``` Script.Print 'x=3.08221696253945E-314' ``` After debugging, `pVarIn` gets the R8 value but is never shallow copied into `pVarOut`. I'm not sure how to write a test case in `oleaut32`, so I included a test case in `vbscript`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2175

3 2

[PATCH 0/1] MR2174: po: Update Lithuanian translation.
by Aurimas Fišeras Feb. 13, 2023

Feb. 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2174

1 1

Re: [PATCH v5 0/4] MR2138: Retry when clipboard operations fail. - approved
by Alexandre Julliard (＠julliard) Feb. 13, 2023

Feb. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2138

1 0

Re: [PATCH v2 0/4] MR2139: Implement decompression in ir50_32 driver. - approved
by Alexandre Julliard (＠julliard) Feb. 13, 2023

Feb. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2139

1 0

Re: [PATCH v2 0/7] MR2064: Implement kernelbase.EnumProcessModulesEx - approved
by Alexandre Julliard (＠julliard) Feb. 13, 2023

Feb. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2064

1 0

Re: [PATCH v3 0/2] MR269: ntdll: Respect zero_bits when mapping a PE file. - approved
by Alexandre Julliard (＠julliard) Feb. 13, 2023

Feb. 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/269

1 0