wine-commits November 2007

wine-commits@winehq.org

3 participants
757 discussions

Stefan Dösinger : wined3d: Avoid NOP additions.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: 0183f3e305ae1e40a806682ec85e8b4507e4ddd8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0183f3e305ae1e40a806682ec… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 01:50:20 2007 +0100 wined3d: Avoid NOP additions. --- dlls/wined3d/glsl_shader.c | 40 +++++++++++++++++++++++----------------- 1 files changed, 23 insertions(+), 17 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 9567a47..46f87aa 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -802,8 +802,15 @@ static void shader_glsl_get_register_name( glsl_src_param_t rel_param; shader_glsl_add_src_param(arg, addr_token, 0, WINED3DSP_WRITEMASK_0, &rel_param); - sprintf(tmpStr, "IN[%s + %u]", rel_param.param_str, - ((IWineD3DPixelShaderImpl *) This)->input_reg_map[reg]); + /* Removing a + 0 would be an obvious optimization, but macos doesn't see the NOP + * operation there + */ + if(((IWineD3DPixelShaderImpl *) This)->input_reg_map[reg]) { + sprintf(tmpStr, "IN[%s + %u]", rel_param.param_str, + ((IWineD3DPixelShaderImpl *) This)->input_reg_map[reg]); + } else { + sprintf(tmpStr, "IN[%s]", rel_param.param_str); + } } else { sprintf(tmpStr, "IN[%u]", ((IWineD3DPixelShaderImpl *) This)->input_reg_map[reg]); @@ -832,9 +839,18 @@ static void shader_glsl_get_register_name( if (WINED3DSHADER_VERSION_MAJOR(This->baseShader.hex_version) >= 2) { glsl_src_param_t rel_param; shader_glsl_add_src_param(arg, addr_token, 0, WINED3DSP_WRITEMASK_0, &rel_param); - sprintf(tmpStr, "%s[%s + %u]", prefix, rel_param.param_str, reg); - } else - sprintf(tmpStr, "%s[A0.x + %u]", prefix, reg); + if(reg) { + sprintf(tmpStr, "%s[%s + %u]", prefix, rel_param.param_str, reg); + } else { + sprintf(tmpStr, "%s[%s]", prefix, rel_param.param_str); + } + } else { + if(reg) { + sprintf(tmpStr, "%s[A0.x + %u]", prefix, reg); + } else { + sprintf(tmpStr, "%s[A0.x]", prefix); + } + } } else sprintf(tmpStr, "%s[%u]", prefix, reg); @@ -1299,18 +1315,8 @@ void shader_glsl_mov(SHADER_OPCODE_ARG* arg) { * shader versions WINED3DSIO_MOVA is used for this. */ if ((WINED3DSHADER_VERSION_MAJOR(shader->baseShader.hex_version) == 1 && !shader_is_pshader_version(shader->baseShader.hex_version) && - shader_get_regtype(arg->dst) == WINED3DSPR_ADDR)) { - /* This is a simple floor(). Msdn claims it is a round to nearest, but our test shows - * that it is just a floor(). ATI docs confirm that, and the test succeeds on the - * reference rasterizer too - */ - size_t mask_size = shader_glsl_get_write_mask_size(write_mask); - if (mask_size > 1) { - shader_addline(buffer, "ivec%d(floor(%s)));\n", mask_size, src0_param.param_str); - } else { - shader_addline(buffer, "int(floor(%s)));\n", src0_param.param_str); - } - } else if(arg->opcode->opcode == WINED3DSIO_MOVA) { + shader_get_regtype(arg->dst) == WINED3DSPR_ADDR) || + arg->opcode->opcode == WINED3DSIO_MOVA) { /* We need to *round* to the nearest int here. */ size_t mask_size = shader_glsl_get_write_mask_size(write_mask); if (mask_size > 1) {

1 0

Stefan Dösinger : wined3d: Replace the position fixup mul-add-add with a MAD.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: c7c785861af93448a22e3d6d6cab03a86ab7b5fc URL: http://source.winehq.org/git/wine.git/?a=commit;h=c7c785861af93448a22e3d6d6… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 2 01:11:15 2007 +0100 wined3d: Replace the position fixup mul-add-add with a MAD. --- dlls/wined3d/directx.c | 1 + dlls/wined3d/vertexshader.c | 30 ++++++++++++------------------ 2 files changed, 13 insertions(+), 18 deletions(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index ada76e2..9ccc47b 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2642,6 +2642,7 @@ static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT Adapter, } else { object->surface_alignment = 4; } + object->posFixup[0] = 1.0; /* This is needed to get the x coord unmodified through a MAD */ /* Set the state up as invalid until the device is fully created */ object->state = WINED3DERR_DRIVERINTERNALERROR; diff --git a/dlls/wined3d/vertexshader.c b/dlls/wined3d/vertexshader.c index e49e34a..4e2a7c5 100644 --- a/dlls/wined3d/vertexshader.c +++ b/dlls/wined3d/vertexshader.c @@ -333,20 +333,16 @@ static VOID IWineD3DVertexShaderImpl_GenerateShader( /* If this shader doesn't use fog copy the z coord to the fog coord so that we can use table fog */ if (!reg_maps->fog) shader_addline(&buffer, "gl_FogFragCoord = gl_Position.z;\n"); - + /* Write the final position. * * OpenGL coordinates specify the center of the pixel while d3d coords specify - * the corner. The offsets are stored in z and w in the 2nd row of the projection - * matrix to avoid wasting a free shader constant. Add them to the w and z coord - * of the 2nd row - */ - shader_addline(&buffer, "gl_Position.x = gl_Position.x + posFixup[2];\n"); - shader_addline(&buffer, "gl_Position.y = gl_Position.y + posFixup[3];\n"); - /* Account for any inverted textures (render to texture case) by reversing the y coordinate - * (this is handled in drawPrim() when it sets the MODELVIEW and PROJECTION matrices) + * the corner. The offsets are stored in z and w in posFixup. posFixup.y contains + * 1.0 or -1.0 to turn the rendering upside down for offscreen rendering. PosFixup.x + * contains 1.0 to allow a mad. */ - shader_addline(&buffer, "gl_Position.y = gl_Position.y * posFixup[1];\n"); + shader_addline(&buffer, "gl_Position.xy = gl_Position.xy * posFixup.xy + posFixup.zw;\n"); + /* Z coord [0;1]->[-1;1] mapping, see comment in transform_projection in state.c * * Basically we want(in homogenous coordinates) z = z * 2 - 1. However, shaders are run @@ -399,15 +395,13 @@ static VOID IWineD3DVertexShaderImpl_GenerateShader( /* Write the final position. * * OpenGL coordinates specify the center of the pixel while d3d coords specify - * the corner. The offsets are stored in the 2nd row of the projection matrix, - * the x offset in z and the y offset in w. Add them to the resulting position - */ - shader_addline(&buffer, "ADD TMP_OUT.x, TMP_OUT.x, posFixup.z;\n"); - shader_addline(&buffer, "ADD TMP_OUT.y, TMP_OUT.y, posFixup.w;\n"); - /* Account for any inverted textures (render to texture case) by reversing the y coordinate - * (this is handled in drawPrim() when it sets the MODELVIEW and PROJECTION matrices) + * the corner. The offsets are stored in z and w in posFixup. posFixup.y contains + * 1.0 or -1.0 to turn the rendering upside down for offscreen rendering. PosFixup.x + * contains 1.0 to allow a mad, but arb vs swizzles are too restricted for that. */ - shader_addline(&buffer, "MUL TMP_OUT.y, TMP_OUT.y, posFixup.y;\n"); + shader_addline(&buffer, "ADD TMP_OUT.x, TMP_OUT.x, posFixup.z;"); + shader_addline(&buffer, "MAD TMP_OUT.y, TMP_OUT.y, posFixup.y, posFixup.w;"); + /* Z coord [0;1]->[-1;1] mapping, see comment in transform_projection in state.c * and the glsl equivalent */

1 0

Stefan Dösinger : wined3d: mov to a0.x does a floor(), not a round to nearest.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: 6209b36acbef6e7f8edcf3a45a006bb09bffe4af URL: http://source.winehq.org/git/wine.git/?a=commit;h=6209b36acbef6e7f8edcf3a45… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Nov 7 19:41:56 2007 +0100 wined3d: mov to a0.x does a floor(), not a round to nearest. --- dlls/d3d9/tests/visual.c | 101 +++++++++++++++++++++++++++++--------------- dlls/wined3d/glsl_shader.c | 14 +++++- 2 files changed, 79 insertions(+), 36 deletions(-) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index 0673e99..6362b5c 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -323,13 +323,13 @@ typedef struct { } test_data_t; /* - * c7 rounded ARGB - * -2.4 -2 0x00ffff00 - * -1.6 -2 0x00ffff00 - * -0.4 0 0x0000ffff - * 0.4 0 0x0000ffff - * 1.6 2 0x00ff00ff - * 2.4 2 0x00ff00ff + * c7 mova ARGB mov ARGB + * -2.4 -2 0x00ffff00 -3 0x00ff0000 + * -1.6 -2 0x00ffff00 -2 0x00ffff00 + * -0.4 0 0x0000ffff -1 0x0000ff00 + * 0.4 0 0x0000ffff 0 0x0000ffff + * 1.6 2 0x00ff00ff 1 0x000000ff + * 2.4 2 0x00ff00ff 2 0x00ff00ff */ static void test_mova(IDirect3DDevice9 *device) { @@ -348,14 +348,39 @@ static void test_mova(IDirect3DDevice9 *device) 0x02000001, 0xc00f0000, 0x90e40000, /* mov oPos, v0 */ 0x0000ffff /* END */ }; + static const DWORD mov_test[] = { + 0xfffe0101, /* vs_1_1 */ + 0x0000001f, 0x80000000, 0x900f0000, /* dcl_position v0 */ + 0x00000051, 0xa00f0000, 0x3f800000, 0x00000000, 0x00000000, 0x3f800000, /* def c0, 1.0, 0.0, 0.0, 1.0 */ + 0x00000051, 0xa00f0001, 0x3f800000, 0x3f800000, 0x00000000, 0x3f800000, /* def c1, 1.0, 1.0, 0.0, 1.0 */ + 0x00000051, 0xa00f0002, 0x00000000, 0x3f800000, 0x00000000, 0x3f800000, /* def c2, 0.0, 1.0, 0.0, 1.0 */ + 0x00000051, 0xa00f0003, 0x00000000, 0x3f800000, 0x3f800000, 0x3f800000, /* def c3, 0.0, 1.0, 1.0, 1.0 */ + 0x00000051, 0xa00f0004, 0x00000000, 0x00000000, 0x3f800000, 0x3f800000, /* def c4, 0.0, 0.0, 1.0, 1.0 */ + 0x00000051, 0xa00f0005, 0x3f800000, 0x00000000, 0x3f800000, 0x3f800000, /* def c5, 1.0, 0.0, 1.0, 1.0 */ + 0x00000051, 0xa00f0006, 0x3f800000, 0x3f800000, 0x3f800000, 0x3f800000, /* def c6, 1.0, 1.0, 1.0, 1.0 */ + 0x00000001, 0xb0010000, 0xa0000007, /* mov a0.x, c7.x */ + 0x00000001, 0xd00f0000, 0xa0e42003, /* mov oD0, c[a0.x + 3] */ + 0x00000001, 0xc00f0000, 0x90e40000, /* mov oPos, v0 */ + 0x0000ffff /* END */ + }; - static const test_data_t test_data[] = { - {{-2.4f, 0.0f, 0.0f, 0.0f}, 0x00ffff00}, - {{-1.6f, 0.0f, 0.0f, 0.0f}, 0x00ffff00}, - {{-0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ffff}, - {{ 0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ffff}, - {{ 1.6f, 0.0f, 0.0f, 0.0f}, 0x00ff00ff}, - {{ 2.4f, 0.0f, 0.0f, 0.0f}, 0x00ff00ff} + static const test_data_t test_data[2][6] = { + { + {{-2.4f, 0.0f, 0.0f, 0.0f}, 0x00ff0000}, + {{-1.6f, 0.0f, 0.0f, 0.0f}, 0x00ffff00}, + {{-0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ff00}, + {{ 0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ffff}, + {{ 1.6f, 0.0f, 0.0f, 0.0f}, 0x000000ff}, + {{ 2.4f, 0.0f, 0.0f, 0.0f}, 0x00ff00ff} + }, + { + {{-2.4f, 0.0f, 0.0f, 0.0f}, 0x00ffff00}, + {{-1.6f, 0.0f, 0.0f, 0.0f}, 0x00ffff00}, + {{-0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ffff}, + {{ 0.4f, 0.0f, 0.0f, 0.0f}, 0x0000ffff}, + {{ 1.6f, 0.0f, 0.0f, 0.0f}, 0x00ff00ff}, + {{ 2.4f, 0.0f, 0.0f, 0.0f}, 0x00ff00ff} + } }; static const float quad[][3] = { @@ -372,43 +397,51 @@ static void test_mova(IDirect3DDevice9 *device) IDirect3DVertexDeclaration9 *vertex_declaration = NULL; IDirect3DVertexShader9 *mova_shader = NULL; + IDirect3DVertexShader9 *mov_shader = NULL; HRESULT hr; - int i; + int i, j; hr = IDirect3DDevice9_CreateVertexShader(device, mova_test, &mova_shader); ok(SUCCEEDED(hr), "CreateVertexShader failed (%08x)\n", hr); - hr = IDirect3DDevice9_SetVertexShader(device, mova_shader); - ok(SUCCEEDED(hr), "SetVertexShader failed (%08x)\n", hr); - + hr = IDirect3DDevice9_CreateVertexShader(device, mov_test, &mov_shader); + ok(SUCCEEDED(hr), "CreateVertexShader failed (%08x)\n", hr); hr = IDirect3DDevice9_CreateVertexDeclaration(device, decl_elements, &vertex_declaration); ok(SUCCEEDED(hr), "CreateVertexDeclaration failed (%08x)\n", hr); hr = IDirect3DDevice9_SetVertexDeclaration(device, vertex_declaration); ok(SUCCEEDED(hr), "SetVertexDeclaration failed (%08x)\n", hr); - for (i = 0; i < (sizeof(test_data) / sizeof(test_data_t)); ++i) + hr = IDirect3DDevice9_SetVertexShader(device, mov_shader); + ok(SUCCEEDED(hr), "SetVertexShader failed (%08x)\n", hr); + for(j = 0; j < 2; ++j) { - DWORD color; + for (i = 0; i < (sizeof(test_data[0]) / sizeof(test_data_t)); ++i) + { + DWORD color; - hr = IDirect3DDevice9_SetVertexShaderConstantF(device, 7, test_data[i].in, 1); - ok(SUCCEEDED(hr), "SetVertexShaderConstantF failed (%08x)\n", hr); + hr = IDirect3DDevice9_SetVertexShaderConstantF(device, 7, test_data[j][i].in, 1); + ok(SUCCEEDED(hr), "SetVertexShaderConstantF failed (%08x)\n", hr); - hr = IDirect3DDevice9_BeginScene(device); - ok(SUCCEEDED(hr), "BeginScene failed (%08x)\n", hr); + hr = IDirect3DDevice9_BeginScene(device); + ok(SUCCEEDED(hr), "BeginScene failed (%08x)\n", hr); - hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, &quad[0], 3 * sizeof(float)); - ok(SUCCEEDED(hr), "DrawPrimitiveUP failed (%08x)\n", hr); + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, &quad[0], 3 * sizeof(float)); + ok(SUCCEEDED(hr), "DrawPrimitiveUP failed (%08x)\n", hr); - hr = IDirect3DDevice9_EndScene(device); - ok(SUCCEEDED(hr), "EndScene failed (%08x)\n", hr); + hr = IDirect3DDevice9_EndScene(device); + ok(SUCCEEDED(hr), "EndScene failed (%08x)\n", hr); - hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); - ok(SUCCEEDED(hr), "Present failed (%08x)\n", hr); + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); + ok(SUCCEEDED(hr), "Present failed (%08x)\n", hr); - color = getPixelColor(device, 320, 240); - ok(color == test_data[i].out, "Expected color %08x, got %08x (for input %f)\n", test_data[i].out, color, test_data[i].in[0]); + color = getPixelColor(device, 320, 240); + ok(color == test_data[j][i].out, "Expected color %08x, got %08x (for input %f, instruction %s)\n", + test_data[j][i].out, color, test_data[j][i].in[0], j == 0 ? "mov" : "mova"); - hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0, 0.0f, 0); - ok(SUCCEEDED(hr), "Clear failed (%08x)\n", hr); + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0, 0.0f, 0); + ok(SUCCEEDED(hr), "Clear failed (%08x)\n", hr); + } + hr = IDirect3DDevice9_SetVertexShader(device, mova_shader); + ok(SUCCEEDED(hr), "SetVertexShader failed (%08x)\n", hr); } hr = IDirect3DDevice9_SetVertexShader(device, NULL); diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index c2da059..9567a47 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1299,8 +1299,18 @@ void shader_glsl_mov(SHADER_OPCODE_ARG* arg) { * shader versions WINED3DSIO_MOVA is used for this. */ if ((WINED3DSHADER_VERSION_MAJOR(shader->baseShader.hex_version) == 1 && !shader_is_pshader_version(shader->baseShader.hex_version) && - shader_get_regtype(arg->dst) == WINED3DSPR_ADDR) || - arg->opcode->opcode == WINED3DSIO_MOVA) { + shader_get_regtype(arg->dst) == WINED3DSPR_ADDR)) { + /* This is a simple floor(). Msdn claims it is a round to nearest, but our test shows + * that it is just a floor(). ATI docs confirm that, and the test succeeds on the + * reference rasterizer too + */ + size_t mask_size = shader_glsl_get_write_mask_size(write_mask); + if (mask_size > 1) { + shader_addline(buffer, "ivec%d(floor(%s)));\n", mask_size, src0_param.param_str); + } else { + shader_addline(buffer, "int(floor(%s)));\n", src0_param.param_str); + } + } else if(arg->opcode->opcode == WINED3DSIO_MOVA) { /* We need to *round* to the nearest int here. */ size_t mask_size = shader_glsl_get_write_mask_size(write_mask); if (mask_size > 1) {

1 0

Stefan Dösinger : wined3d: Get rid of the conditionals in the glsl lit implementation.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: 468309e055b5e14f6da919b173eb199954b65ef1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=468309e055b5e14f6da919b17… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Oct 28 21:21:24 2007 +0100 wined3d: Get rid of the conditionals in the glsl lit implementation. --- dlls/wined3d/glsl_shader.c | 25 +++++++++++++++++++++++-- 1 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 98cbcf8..c2da059 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1777,8 +1777,29 @@ void shader_glsl_lit(SHADER_OPCODE_ARG* arg) { shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_1, &src1_param); shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_3, &src3_param); - shader_addline(arg->buffer, "vec4(1.0, (%s > 0.0 ? %s : 0.0), (%s > 0.0 ? ((%s > 0.0) ? pow(%s, clamp(%s, -128.0, 128.0)) : 0.0) : 0.0), 1.0)%s);\n", - src0_param.param_str, src0_param.param_str, src0_param.param_str, src1_param.param_str, src1_param.param_str, src3_param.param_str, dst_mask); + /* The sdk specifies the instruction like this + * dst.x = 1.0; + * if(src.x > 0.0) dst.y = src.x + * else dst.y = 0.0. + * if(src.x > 0.0 && src.y > 0.0) dst.z = pow(src.y, power); + * else dst.z = 0.0; + * dst.w = 1.0; + * + * Obviously that has quite a few conditionals in it which we don't like. So the first step is this: + * dst.x = 1.0 ... No further explanation needed + * dst.y = max(src.y, 0.0); ... If x < 0.0, use 0.0, otherwise x. Same as the conditional + * dst.z = x > 0.0 ? pow(max(y, 0.0), p) : 0; ... 0 ^ power is 0, and otherwise we use y anyway + * dst.w = 1.0. ... Nothing fancy. + * + * So we still have one conditional in there. So do this: + * dst.z = pow(max(0.0, src.y) * step(0.0, src.x), power); + * + * step(0.0, x) will return 1 if src.x > 0.0, and 0 otherwise. So if y is 0 we get pow(0.0 * 1.0, power), + * which sets dst.z to 0. If y > 0, but x = 0.0, we get pow(y * 0.0, power), which results in 0 too. + * if both x and y are > 0, we get pow(y * 1.0, power), as it is supposed to + */ + shader_addline(arg->buffer, "vec4(1.0, max(%s, 0.0), pow(max(0.0, %s) * step(0.0, %s), clamp(%s, -128.0, 128.0)), 1.0)%s);\n", + src0_param.param_str, src1_param.param_str, src0_param.param_str, src3_param.param_str, dst_mask); } /** Process the WINED3DSIO_DST instruction in GLSL:

1 0

Stefan Dösinger : wined3d: Relative addressing offsets are limited to [-64; 63] in arb.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: fb0dde7b274fb3a4b2f0f911c9114ce8a832b98e URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb0dde7b274fb3a4b2f0f911c… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Nov 7 19:57:49 2007 +0100 wined3d: Relative addressing offsets are limited to [-64; 63] in arb. --- dlls/wined3d/arb_program_shader.c | 25 +++++++++++++++++++++---- dlls/wined3d/baseshader.c | 9 +++++++++ dlls/wined3d/directx.c | 36 +++++++++++++++++++++++++++++++++++- dlls/wined3d/vertexshader.c | 29 +++++++++++++++++++++++++---- dlls/wined3d/wined3d_private.h | 3 +++ include/wine/wined3d_gl.h | 2 ++ 6 files changed, 95 insertions(+), 9 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=fb0dde7b274fb3a4b2f0f…

1 0

Stefan Dösinger : wined3d: Remove the conditional from texdepth.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: aafcae4752f5806dded66a7c0490b9fd9152118d URL: http://source.winehq.org/git/wine.git/?a=commit;h=aafcae4752f5806dded66a7c0… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sun Oct 28 00:02:14 2007 +0200 wined3d: Remove the conditional from texdepth. --- dlls/wined3d/glsl_shader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 4083d56..98cbcf8 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -2230,7 +2230,7 @@ void pshader_glsl_texdepth(SHADER_OPCODE_ARG* arg) { * too is irrelevant, since if x = 0, any y value < 1.0 (and > 1.0 is not allowed) results in a result * >= 1.0 or < 0.0 */ - shader_addline(arg->buffer, "gl_FragDepth = (%s.y == 0.0) ? 1.0 : clamp((%s.x / min(%s.y, 1.0)), 0.0, 1.0);\n", dst_param.reg_name, dst_param.reg_name, dst_param.reg_name); + shader_addline(arg->buffer, "gl_FragDepth = clamp((%s.x / min(%s.y, 1.0)), 0.0, 1.0);\n", dst_param.reg_name, dst_param.reg_name, dst_param.reg_name); } /** Process the WINED3DSIO_TEXM3X2DEPTH instruction in GLSL:

1 0

Stefan Dösinger : wined3d: Fix the varying number comparison.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: 36330f05428951d752468de6a3eebdfc939231e1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=36330f05428951d752468de6a… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Wed Nov 7 18:22:00 2007 +0100 wined3d: Fix the varying number comparison. --- dlls/wined3d/pixelshader.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/pixelshader.c b/dlls/wined3d/pixelshader.c index 138e419..483c0ad 100644 --- a/dlls/wined3d/pixelshader.c +++ b/dlls/wined3d/pixelshader.c @@ -563,8 +563,8 @@ static HRESULT WINAPI IWineD3DPixelShaderImpl_SetFunction(IWineD3DPixelShader *i * achive anything anyway */ if(highest_reg_used < (GL_LIMITS(glsl_varyings) / 4) || - num_regs_used >= (GL_LIMITS(glsl_varyings) / 4) ) { - if(num_regs_used >= (GL_LIMITS(glsl_varyings) / 4)) { + num_regs_used > (GL_LIMITS(glsl_varyings) / 4) ) { + if(num_regs_used > (GL_LIMITS(glsl_varyings) / 4)) { /* This happens with relative addressing. The input mapper function * warns about this if the higher registers are declared too, so * don't write a FIXME here

1 0

Juan Lang : cfgmgr32: Forward cfgmgr32 functions to setupapi.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: f9f18bfb06e9e1b706eda7afeb1b1c892cc354f2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f9f18bfb06e9e1b706eda7afe… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Nov 7 10:38:49 2007 -0800 cfgmgr32: Forward cfgmgr32 functions to setupapi. --- dlls/cfgmgr32/Makefile.in | 3 -- dlls/cfgmgr32/cfgmgr32.spec | 6 ++-- dlls/cfgmgr32/main.c | 79 ------------------------------------------- 3 files changed, 3 insertions(+), 85 deletions(-) diff --git a/dlls/cfgmgr32/Makefile.in b/dlls/cfgmgr32/Makefile.in index 33360db..9974fbc 100644 --- a/dlls/cfgmgr32/Makefile.in +++ b/dlls/cfgmgr32/Makefile.in @@ -6,9 +6,6 @@ MODULE = cfgmgr32.dll IMPORTLIB = libcfgmgr32.$(IMPLIBEXT) IMPORTS = setupapi kernel32 -C_SRCS = \ - main.c - @MAKE_DLL_RULES@ @DEPENDENCIES@ # everything below this line is overwritten by make depend diff --git a/dlls/cfgmgr32/cfgmgr32.spec b/dlls/cfgmgr32/cfgmgr32.spec index 2d53dd1..b00648b 100644 --- a/dlls/cfgmgr32/cfgmgr32.spec +++ b/dlls/cfgmgr32/cfgmgr32.spec @@ -60,11 +60,11 @@ @ stub CM_Get_DevNode_Registry_Property_ExW @ stub CM_Get_DevNode_Status @ stub CM_Get_DevNode_Status_Ex -@ stdcall CM_Get_Device_IDA(ptr ptr long long) +@ stdcall CM_Get_Device_IDA(ptr ptr long long) setupapi.CM_Get_Device_IDA @ stub CM_Get_Device_IDW @ stub CM_Get_Device_ID_ExA @ stub CM_Get_Device_ID_ExW -@ stdcall CM_Get_Device_ID_ListA(ptr ptr long long) +@ stdcall CM_Get_Device_ID_ListA(ptr ptr long long) setupapi.CM_Get_Device_ID_ListA @ stub CM_Get_Device_ID_ListW @ stub CM_Get_Device_ID_List_ExA @ stub CM_Get_Device_ID_List_ExW @@ -72,7 +72,7 @@ @ stub CM_Get_Device_ID_List_SizeW @ stub CM_Get_Device_ID_List_Size_ExA @ stub CM_Get_Device_ID_List_Size_ExW -@ stdcall CM_Get_Device_ID_Size(ptr ptr long) +@ stdcall CM_Get_Device_ID_Size(ptr ptr long) setupapi.CM_Get_Device_ID_Size @ stub CM_Get_Device_ID_Size_Ex @ stub CM_Get_Device_Interface_AliasA @ stub CM_Get_Device_Interface_AliasW diff --git a/dlls/cfgmgr32/main.c b/dlls/cfgmgr32/main.c deleted file mode 100644 index 9f27a29..0000000 --- a/dlls/cfgmgr32/main.c +++ /dev/null @@ -1,79 +0,0 @@ -/* - * cfgmgr32 implementation - * - * Copyright 2004 Aric Stewart for CodeWeavers - * Copyright 2003 Mike McCormack for CodeWeavers - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include <stdarg.h> -#include "windef.h" -#include "winbase.h" -#include "winnt.h" -#include "cfgmgr32.h" - -#include "wine/debug.h" - -WINE_DEFAULT_DEBUG_CHANNEL(cfgmgr32); - -/*********************************************************************** - * DllMain (CFGMGR32.@) - */ -BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) -{ - switch(reason) - { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls( inst ); - break; - } - return TRUE; -} - -/*********************************************************************** - * CM_Get_Device_ID_ListA (CFGMGR32.@) - */ -CONFIGRET WINAPI CM_Get_Device_ID_ListA( - PCSTR pszFilter, PCHAR Buffer, ULONG BufferLen, ULONG ulFlags ) -{ - FIXME("%p %p %d %d\n", pszFilter, Buffer, BufferLen, ulFlags ); - memset(Buffer,0,2); - return CR_SUCCESS; -} - -/*********************************************************************** - * CM_Get_Device_ID_Size (CFGMGR32.@) - */ -CONFIGRET WINAPI CM_Get_Device_ID_Size( ULONG* pulLen, LPVOID dnDevInst, - ULONG ulFlags) -{ - FIXME("%p %p %u\n",pulLen, dnDevInst, ulFlags); - *pulLen = 1; - return CR_SUCCESS; -} - -/*********************************************************************** - * CM_Get_Device_IDA (CFGMGR32.@) - */ -CONFIGRET WINAPI CM_Get_Device_IDA( LPVOID dnDevInst, LPSTR Buffer, - ULONG BufferLen, ULONG ulFlags) -{ - FIXME("%p, %p, %u %u\n",dnDevInst, Buffer, BufferLen, ulFlags); - Buffer[0] = 0; - return CR_SUCCESS; -}

1 0

Juan Lang : setupapi: Add stubs for CM_Get_Device_IDA and CM_Get_Device_ID_Size.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: 4115598d5c13dfcc1421317d9d9b34e21990aa13 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4115598d5c13dfcc1421317d9… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Nov 7 10:38:16 2007 -0800 setupapi: Add stubs for CM_Get_Device_IDA and CM_Get_Device_ID_Size. --- dlls/setupapi/setupapi.spec | 4 ++-- dlls/setupapi/stubs.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec index 328a23e..ab62b6d 100644 --- a/dlls/setupapi/setupapi.spec +++ b/dlls/setupapi/setupapi.spec @@ -71,7 +71,7 @@ @ stub CM_Get_DevNode_Registry_Property_ExW @ stub CM_Get_DevNode_Status @ stub CM_Get_DevNode_Status_Ex -@ stub CM_Get_Device_IDA +@ stdcall CM_Get_Device_IDA(ptr ptr long long) @ stub CM_Get_Device_IDW @ stub CM_Get_Device_ID_ExA @ stub CM_Get_Device_ID_ExW @@ -83,7 +83,7 @@ @ stub CM_Get_Device_ID_List_SizeW @ stub CM_Get_Device_ID_List_Size_ExA @ stub CM_Get_Device_ID_List_Size_ExW -@ stub CM_Get_Device_ID_Size +@ stdcall CM_Get_Device_ID_Size(ptr ptr long) @ stub CM_Get_Device_ID_Size_Ex @ stub CM_Get_Device_Interface_AliasA @ stub CM_Get_Device_Interface_AliasW diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c index de1fec1..7d73be2 100644 --- a/dlls/setupapi/stubs.c +++ b/dlls/setupapi/stubs.c @@ -71,6 +71,17 @@ DWORD WINAPI CM_Disconnect_Machine(DWORD handle) } /*********************************************************************** + * CM_Get_Device_IDA (SETUPAPI.@) + */ +DWORD WINAPI CM_Get_Device_IDA( LPVOID dnDevInst, LPSTR Buffer, + ULONG BufferLen, ULONG ulFlags) +{ + FIXME("%p, %p, %u %u\n",dnDevInst, Buffer, BufferLen, ulFlags); + Buffer[0] = 0; + return CR_SUCCESS; +} + +/*********************************************************************** * CM_Get_Device_ID_ListA (SETUPAPI.@) */ @@ -83,6 +94,17 @@ DWORD WINAPI CM_Get_Device_ID_ListA( } /*********************************************************************** + * CM_Get_Device_ID_Size (SETUPAPI.@) + */ +DWORD WINAPI CM_Get_Device_ID_Size( ULONG* pulLen, LPVOID dnDevInst, + ULONG ulFlags) +{ + FIXME("%p %p %u\n",pulLen, dnDevInst, ulFlags); + *pulLen = 1; + return CR_SUCCESS; +} + +/*********************************************************************** * SetupInitializeFileLogW(SETUPAPI.@) */ HSPFILELOG WINAPI SetupInitializeFileLogW(LPCWSTR LogFileName, DWORD Flags)

1 0

Juan Lang : crypt32: Fail decoding a CRL entry if the serial number is empty.
by Alexandre Julliard 08 Nov '07

08 Nov '07

Module: wine Branch: master Commit: c5d5c5b63aa296439531dfa1da1692280593bf48 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5d5c5b63aa296439531dfa1d… Author: Juan Lang <juan.lang(a)gmail.com> Date: Wed Nov 7 14:00:10 2007 -0800 crypt32: Fail decoding a CRL entry if the serial number is empty. --- dlls/crypt32/decode.c | 6 ++++++ dlls/crypt32/tests/encode.c | 2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c index db2a3b3..8ceceac 100644 --- a/dlls/crypt32/decode.c +++ b/dlls/crypt32/decode.c @@ -1065,6 +1065,12 @@ static BOOL CRYPT_AsnDecodeCRLEntry(const BYTE *pbEncoded, DWORD cbEncoded, ret = CRYPT_AsnDecodeSequence(items, sizeof(items) / sizeof(items[0]), pbEncoded, cbEncoded, dwFlags, NULL, entry, pcbStructInfo, pcbDecoded, entry ? entry->SerialNumber.pbData : NULL); + if (ret && entry && !entry->SerialNumber.cbData) + { + WARN("empty CRL entry serial number\n"); + SetLastError(CRYPT_E_ASN1_CORRUPT); + ret = FALSE; + } return ret; } diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c index 74ebe3c..82d0344 100644 --- a/dlls/crypt32/tests/encode.c +++ b/dlls/crypt32/tests/encode.c @@ -4269,7 +4269,7 @@ static void test_decodeCRLToBeSigned(DWORD dwEncoding) ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, v1CRLWithIssuerAndEmptyEntry, v1CRLWithIssuerAndEmptyEntry[1] + 2, CRYPT_DECODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &size); - todo_wine ok(!ret && GetLastError() == CRYPT_E_ASN1_CORRUPT, + ok(!ret && GetLastError() == CRYPT_E_ASN1_CORRUPT, "Expected CRYPT_E_ASN1_CORRUPT, got %08x\n", GetLastError()); /* with a real CRL entry */ ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED,

1 0

← Newer
1
...
54
55
56
57
58
59
60
...
76
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits November 2007