ChangeSet ID: 31184
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 23:06:06
Modified files:
include : distribution.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Add a couple of comments and braces
Patch: http://cvs.winehq.org/patch.py?id=31184
Old revision New revision Changes Path
1.32 1.33 +4 -0 appdb/include/distribution.php
Index: appdb/include/distribution.php
diff -u -p appdb/include/distribution.php:1.32 appdb/include/distribution.php:1.33
--- appdb/include/distribution.php:1.32 11 Jun 2007 4: 6: 6 -0000
+++ appdb/include/distribution.php 11 Jun 2007 4: 6: 6 -0000
@@ -462,11 +462,15 @@ class distribution {
"<a href=\"$this->sUrl\">$this->sUrl</a>",
array(sizeof($this->aTestingIds), "align=\"right\""));
+ // add actions if the current user has permission to edit this object
if($this->canEdit())
{
+ // enable the 'delete' action if this distribution has no testing results
if(!sizeof($this->aTestingIds))
+ {
$shDeleteLink = " [<a href='".$oManager->makeUrl("delete",
$this->iDistributionId)."'>delete</a>]";
+ }
$aCells[] = array(
"[<a href='".$oManager->makeUrl("edit",
ChangeSet ID: 31183
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 21:53:57
Modified files:
include : testData.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Add some guidance to the 'Tested release' selection for a testData submission since we've
removed a bunch of versions lately, including 'CVS'.
Patch: http://cvs.winehq.org/patch.py?id=31183
Old revision New revision Changes Path
1.57 1.58 +12 -0 appdb/include/testData.php
Index: appdb/include/testData.php
diff -u -p appdb/include/testData.php:1.57 appdb/include/testData.php:1.58
--- appdb/include/testData.php:1.57 11 Jun 2007 2:53:57 -0000
+++ appdb/include/testData.php 11 Jun 2007 2:53:57 -0000
@@ -602,10 +602,22 @@ class testData{
echo '<td class=color0>',"\n";
distribution::make_distribution_list("iDistributionId", $this->iDistributionId);
echo '</td></tr>',"\n";
+
// Version List
echo '<tr><td class=color1><b>Tested release</b></td><td class=color0>',"\n";
make_bugzilla_version_list("sTestedRelease", $this->sTestedRelease);
+ // Give the user some information about our available versions
+ echo "<ul>\n";
+ echo "<li>If you are testing with a newer release than listed please";
+ echo " check back tomorrow, sometimes it takes us a day to update the list.</li>\n";
+ echo "<li>If you are testing with an older release than listed please";
+ echo " upgrade and test with a newer release.</li>\n";
+ echo "<li><b>NOTE: 'CVS' was recently removed as a version because we simply can't track";
+ echo " exactly which CVS version was used.<br/> If you haven't tested with one of the";
+ echo " listed versions please retest with a recent release and resubmit.</li>\n";
+ echo "</ul>\n";
echo '</td></tr>',"\n";
+
// Installs
echo '<tr><td class=color0><b>Installs?</b></td><td class=color0>',"\n";
testData::make_Installs_list("sInstalls", $this->sInstalls);
ChangeSet ID: 31182
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 20:27:29
Modified files:
include : url.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Url::normalize() shouldn't be prepending anything to empty strings
Patch: http://cvs.winehq.org/patch.py?id=31182
Old revision New revision Changes Path
1.19 1.20 +4 -0 appdb/include/url.php
Index: appdb/include/url.php
diff -u -p appdb/include/url.php:1.19 appdb/include/url.php:1.20
--- appdb/include/url.php:1.19 11 Jun 2007 1:27:29 -0000
+++ appdb/include/url.php 11 Jun 2007 1:27:29 -0000
@@ -502,6 +502,10 @@ class Url {
// and prepend "http://"
function normalize($sTheUrl)
{
+ // return if we have an empty string
+ if($sTheUrl == "")
+ return $sTheUrl;
+
// if we already have "://" in the url
// we can leave the url alone
if(strpos($sTheUrl, "://") === false)
ChangeSet ID: 31181
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 20:08:21
Modified files:
include : url.php
Log message:
Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>
Url constructor should use the id from the database query as the $iUrlId argument to the
constructor doesn't need to be valid
Patch: http://cvs.winehq.org/patch.py?id=31181
Old revision New revision Changes Path
1.18 1.19 +1 -1 appdb/include/url.php
Index: appdb/include/url.php
diff -u -p appdb/include/url.php:1.18 appdb/include/url.php:1.19
--- appdb/include/url.php:1.18 11 Jun 2007 1: 8:21 -0000
+++ appdb/include/url.php 11 Jun 2007 1: 8:21 -0000
@@ -39,7 +39,7 @@ class Url {
// we are working on an existing url
if($oRow)
{
- $this->iUrlId = $iUrlId;
+ $this->iUrlId = $oRow->id;
$this->sDescription = $oRow->description;
$this->iAppId = $oRow->appId;
$this->iVersionId = $oRow->versionId;
ChangeSet ID: 31180
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 19:25:50
Modified files:
include : util.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Remove "CVS" version from the array of Wine versions we present to the user. It was a dumb idea
to have a CVS version anyway since all CVS versions appear the same.
Patch: http://cvs.winehq.org/patch.py?id=31180
Old revision New revision Changes Path
1.91 1.92 +9 -10 appdb/include/util.php
Index: appdb/include/util.php
diff -u -p appdb/include/util.php:1.91 appdb/include/util.php:1.92
--- appdb/include/util.php:1.91 11 Jun 2007 0:25:50 -0000
+++ appdb/include/util.php 11 Jun 2007 0:25:50 -0000
@@ -168,29 +168,28 @@ function make_bugzilla_version_list($var
// and we can't use 'order by' since we have no column
// to order by, but the entries should come out in the
// order they were added
- // - Trim the list, we don't want every version of wine ever released
- // - Add 'CVS' explicitly since we trim it out
+ // - Trim the list, we don't want every version of wine ever released and
+ // we don't want the "CVS" version included since we can never figure out
+ // what version of Wine any given "CVS" version is
//
// TODO: if we ever get a reasonable way to order the list replace this code
// with that
$aVersions = array();
- while(list($value) = mysql_fetch_row($hResult))
+ while(list($sValue) = mysql_fetch_row($hResult))
{
- // exclude unspecified versions
- if($value != "unspecified")
- $aVersions[] = $value;
+ // exclude unspecified versions and the "CVS" version
+ if(($sValue != "unspecified") && ($sValue != "CVS"))
+ $aVersions[] = $sValue;
}
- // now reverse the array order
+ // now reverse the array order since the oldest
+ // versions were added first
$aVersions = array_reverse($aVersions);
// now trim off all but the last X versions
$iVersionsToKeep = 6;
$aVersions = array_slice($aVersions, 0, $iVersionsToKeep);
- // explicitly add 'CVS' since we are eliminating that above
- $aVersions[] = "CVS";
-
// DONE TRIMMING VERSIONS
/////////////////////////
ChangeSet ID: 31179
CVSROOT: /opt/cvs-commit
Module name: appdb
Changes by: wineowner(a)winehq.org 2007/06/10 19:12:08
Modified files:
include : util.php
Log message:
Chris Morgan <cmorgan(a)alum.wpi.edu>
Remove makeSafe(), we don't use this method anymore now that we have filter_gpc()
Patch: http://cvs.winehq.org/patch.py?id=31179
Old revision New revision Changes Path
1.90 1.91 +0 -7 appdb/include/util.php
Index: appdb/include/util.php
diff -u -p appdb/include/util.php:1.90 appdb/include/util.php:1.91
--- appdb/include/util.php:1.90 11 Jun 2007 0:12: 8 -0000
+++ appdb/include/util.php 11 Jun 2007 0:12: 8 -0000
@@ -24,13 +24,6 @@ function util_redirect_and_exit($url)
exit;
}
-function makeSafe($var)
-{
-/* Disable addslashes() until we can use more finely grained filtering on user input */
-/* $var = trim(addslashes($var)); */
- return $var;
-}
-
function build_urlarg($vars)
{
$arr = array();