winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
945 discussions
Start a n
N
ew thread
Jacek Caban : kernel32: Moved GetModuleFileNameEx[AW] to kernel32.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: 9bbf3f90752afe127f69bb89d62bd5849d2774d7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9bbf3f90752afe127f69bb89d…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 12 12:23:22 2011 +0000 kernel32: Moved GetModuleFileNameEx[AW] to kernel32. --- dlls/kernel32/kernel32.spec | 2 + dlls/kernel32/module.c | 55 ++++++++++++++++++++++++++++++++++++++++++ dlls/psapi/psapi.spec | 4 +- dlls/psapi/psapi_main.c | 56 ------------------------------------------- 4 files changed, 59 insertions(+), 58 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 4da6f06..3f85557 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -774,6 +774,8 @@ @ stdcall K32EnumProcesses(ptr long ptr) @ stdcall K32GetModuleBaseNameA(long long ptr long) @ stdcall K32GetModuleBaseNameW(long long ptr long) +@ stdcall K32GetModuleFileNameExA(long long ptr long) +@ stdcall K32GetModuleFileNameExW(long long ptr long) @ stdcall K32GetProcessMemoryInfo(long ptr long) @ stdcall K32QueryWorkingSet(long ptr long) @ stdcall K32QueryWorkingSetEx(long ptr long) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index 4e2c098..94d20c3 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -1228,6 +1228,61 @@ DWORD WINAPI K32GetModuleBaseNameA(HANDLE process, HMODULE module, return ret; } +/*********************************************************************** + * K32GetModuleFileNameExW (KERNEL32.@) + */ +DWORD WINAPI K32GetModuleFileNameExW(HANDLE process, HMODULE module, + LPWSTR file_name, DWORD size) +{ + LDR_MODULE ldr_module; + + if(!get_ldr_module(process, module, &ldr_module)) + return 0; + + size = min(ldr_module.FullDllName.Length / sizeof(WCHAR), size); + if (!ReadProcessMemory(process, ldr_module.FullDllName.Buffer, + file_name, size * sizeof(WCHAR), NULL)) + return 0; + + file_name[size] = 0; + return size; +} + +/*********************************************************************** + * K32GetModuleFileNameExA (KERNEL32.@) + */ +DWORD WINAPI K32GetModuleFileNameExA(HANDLE process, HMODULE module, + LPSTR file_name, DWORD size) +{ + WCHAR *ptr; + + TRACE("(hProcess=%p, hModule=%p, %p, %d)\n", process, module, file_name, size); + + if (!file_name || !size) return 0; + + if ( process == GetCurrentProcess() ) + { + DWORD len = GetModuleFileNameA( module, file_name, size ); + if (size) file_name[size - 1] = '\0'; + return len; + } + + if (!(ptr = HeapAlloc(GetProcessHeap(), 0, size * sizeof(WCHAR)))) return 0; + + if (!K32GetModuleFileNameExW(process, module, ptr, size)) + { + file_name[0] = '\0'; + } + else + { + if (!WideCharToMultiByte( CP_ACP, 0, ptr, -1, file_name, size, NULL, NULL )) + file_name[size - 1] = 0; + } + + HeapFree(GetProcessHeap(), 0, ptr); + return strlen(file_name); +} + #ifdef __i386__ /*********************************************************************** diff --git a/dlls/psapi/psapi.spec b/dlls/psapi/psapi.spec index 07e0cb5..0427891 100644 --- a/dlls/psapi/psapi.spec +++ b/dlls/psapi/psapi.spec @@ -12,8 +12,8 @@ @ stdcall GetMappedFileNameW(long ptr ptr long) @ stdcall GetModuleBaseNameA(long long ptr long) kernel32.K32GetModuleBaseNameA @ stdcall GetModuleBaseNameW(long long ptr long) kernel32.K32GetModuleBaseNameW -@ stdcall GetModuleFileNameExA(long long ptr long) -@ stdcall GetModuleFileNameExW(long long ptr long) +@ stdcall GetModuleFileNameExA(long long ptr long) kernel32.K32GetModuleFileNameExA +@ stdcall GetModuleFileNameExW(long long ptr long) kernel32.K32GetModuleFileNameExW @ stdcall GetModuleInformation(long long ptr long) @ stdcall GetPerformanceInfo(ptr long) @ stdcall GetProcessImageFileNameA(long ptr long) kernel32.K32GetProcessImageFileNameA diff --git a/dlls/psapi/psapi_main.c b/dlls/psapi/psapi_main.c index a2d7ac4..b4cabca 100644 --- a/dlls/psapi/psapi_main.c +++ b/dlls/psapi/psapi_main.c @@ -263,62 +263,6 @@ DWORD WINAPI GetMappedFileNameW(HANDLE hProcess, LPVOID lpv, LPWSTR lpFilename, } /*********************************************************************** - * GetModuleFileNameExA (PSAPI.@) - */ -DWORD WINAPI GetModuleFileNameExA(HANDLE hProcess, HMODULE hModule, - LPSTR lpFileName, DWORD nSize) -{ - WCHAR *ptr; - - TRACE("(hProcess=%p, hModule=%p, %p, %d)\n", - hProcess, hModule, lpFileName, nSize); - - if (!lpFileName || !nSize) return 0; - - if ( hProcess == GetCurrentProcess() ) - { - DWORD len = GetModuleFileNameA( hModule, lpFileName, nSize ); - if (nSize) lpFileName[nSize - 1] = '\0'; - return len; - } - - if (!(ptr = HeapAlloc(GetProcessHeap(), 0, nSize * sizeof(WCHAR)))) return 0; - - if (!GetModuleFileNameExW(hProcess, hModule, ptr, nSize)) - { - lpFileName[0] = '\0'; - } - else - { - if (!WideCharToMultiByte( CP_ACP, 0, ptr, -1, lpFileName, nSize, NULL, NULL )) - lpFileName[nSize - 1] = 0; - } - - HeapFree(GetProcessHeap(), 0, ptr); - return strlen(lpFileName); -} - -/*********************************************************************** - * GetModuleFileNameExW (PSAPI.@) - */ -DWORD WINAPI GetModuleFileNameExW(HANDLE hProcess, HMODULE hModule, - LPWSTR lpFileName, DWORD nSize) -{ - LDR_MODULE LdrModule; - - if(!PSAPI_GetLdrModule(hProcess, hModule, &LdrModule)) - return 0; - - nSize = min(LdrModule.FullDllName.Length / sizeof(WCHAR), nSize); - if (!ReadProcessMemory(hProcess, LdrModule.FullDllName.Buffer, - lpFileName, nSize * sizeof(WCHAR), NULL)) - return 0; - - lpFileName[nSize] = 0; - return nSize; -} - -/*********************************************************************** * GetModuleInformation (PSAPI.@) */ BOOL WINAPI GetModuleInformation(HANDLE hProcess, HMODULE hModule,
1
0
0
0
Jacek Caban : kernel32: Moved GetModuleBaseName[AW] implementation to kernel32.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: e6dd213d52cc807e76d8309257de3a4937297e5d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e6dd213d52cc807e76d830925…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 12 12:22:59 2011 +0000 kernel32: Moved GetModuleBaseName[AW] implementation to kernel32. --- dlls/kernel32/kernel32.spec | 2 + dlls/kernel32/module.c | 72 +++++++++++++++++++++++++++++++++++++++++++ dlls/psapi/psapi.spec | 4 +- dlls/psapi/psapi_main.c | 46 --------------------------- 4 files changed, 76 insertions(+), 48 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 458b425..4da6f06 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -772,6 +772,8 @@ @ stdcall K32GetProcessImageFileNameW(long ptr long) @ stdcall K32EnumProcessModules(long ptr long ptr) @ stdcall K32EnumProcesses(ptr long ptr) +@ stdcall K32GetModuleBaseNameA(long long ptr long) +@ stdcall K32GetModuleBaseNameW(long long ptr long) @ stdcall K32GetProcessMemoryInfo(long ptr long) @ stdcall K32QueryWorkingSet(long ptr long) @ stdcall K32QueryWorkingSetEx(long ptr long) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index 347d4aa..4e2c098 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -1125,6 +1125,29 @@ static int module_iterator_next(MODULE_ITERATOR *iter) return 1; } +static BOOL get_ldr_module(HANDLE process, HMODULE module, LDR_MODULE *ldr_module) +{ + MODULE_ITERATOR iter; + INT ret; + + if (!init_module_iterator(&iter, process)) + return FALSE; + + while ((ret = module_iterator_next(&iter)) > 0) + /* When hModule is NULL we return the process image - which will be + * the first module since our iterator uses InLoadOrderModuleList */ + if (!module || module == iter.ldr_module.BaseAddress) + { + *ldr_module = iter.ldr_module; + return TRUE; + } + + if (ret == 0) + SetLastError(ERROR_INVALID_HANDLE); + + return FALSE; +} + /*********************************************************************** * K32EnumProcessModules (KERNEL32.@) * @@ -1155,6 +1178,55 @@ BOOL WINAPI K32EnumProcessModules(HANDLE process, HMODULE *lphModule, return ret == 0; } +/*********************************************************************** + * K32GetModuleBaseNameW (KERNEL32.@) + */ +DWORD WINAPI K32GetModuleBaseNameW(HANDLE process, HMODULE module, + LPWSTR base_name, DWORD size) +{ + LDR_MODULE ldr_module; + + if (!get_ldr_module(process, module, &ldr_module)) + return 0; + + size = min(ldr_module.BaseDllName.Length / sizeof(WCHAR), size); + if (!ReadProcessMemory(process, ldr_module.BaseDllName.Buffer, + base_name, size * sizeof(WCHAR), NULL)) + return 0; + + base_name[size] = 0; + return size; +} + +/*********************************************************************** + * K32GetModuleBaseNameA (KERNEL32.@) + */ +DWORD WINAPI K32GetModuleBaseNameA(HANDLE process, HMODULE module, + LPSTR base_name, DWORD size) +{ + WCHAR *base_name_w; + DWORD len, ret = 0; + + if(!base_name || !size) { + SetLastError(ERROR_INVALID_PARAMETER); + return 0; + } + + base_name_w = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * size); + if(!base_name_w) + return 0; + + len = K32GetModuleBaseNameW(process, module, base_name_w, size); + TRACE("%d, %s\n", len, debugstr_w(base_name_w)); + if (len) + { + ret = WideCharToMultiByte(CP_ACP, 0, base_name_w, len, + base_name, size, NULL, NULL); + if (ret < size) base_name[ret] = 0; + } + HeapFree(GetProcessHeap(), 0, base_name_w); + return ret; +} #ifdef __i386__ diff --git a/dlls/psapi/psapi.spec b/dlls/psapi/psapi.spec index ad03716..07e0cb5 100644 --- a/dlls/psapi/psapi.spec +++ b/dlls/psapi/psapi.spec @@ -10,8 +10,8 @@ @ stdcall GetDeviceDriverFileNameW(ptr ptr long) @ stdcall GetMappedFileNameA(long ptr ptr long) @ stdcall GetMappedFileNameW(long ptr ptr long) -@ stdcall GetModuleBaseNameA(long long ptr long) -@ stdcall GetModuleBaseNameW(long long ptr long) +@ stdcall GetModuleBaseNameA(long long ptr long) kernel32.K32GetModuleBaseNameA +@ stdcall GetModuleBaseNameW(long long ptr long) kernel32.K32GetModuleBaseNameW @ stdcall GetModuleFileNameExA(long long ptr long) @ stdcall GetModuleFileNameExW(long long ptr long) @ stdcall GetModuleInformation(long long ptr long) diff --git a/dlls/psapi/psapi_main.c b/dlls/psapi/psapi_main.c index 0b8e5b0..a2d7ac4 100644 --- a/dlls/psapi/psapi_main.c +++ b/dlls/psapi/psapi_main.c @@ -263,52 +263,6 @@ DWORD WINAPI GetMappedFileNameW(HANDLE hProcess, LPVOID lpv, LPWSTR lpFilename, } /*********************************************************************** - * GetModuleBaseNameA (PSAPI.@) - */ -DWORD WINAPI GetModuleBaseNameA(HANDLE hProcess, HMODULE hModule, - LPSTR lpBaseName, DWORD nSize) -{ - WCHAR *lpBaseNameW; - DWORD buflenW, ret = 0; - - if(!lpBaseName || !nSize) { - SetLastError(ERROR_INVALID_PARAMETER); - return 0; - } - lpBaseNameW = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * nSize); - buflenW = GetModuleBaseNameW(hProcess, hModule, lpBaseNameW, nSize); - TRACE("%d, %s\n", buflenW, debugstr_w(lpBaseNameW)); - if (buflenW) - { - ret = WideCharToMultiByte(CP_ACP, 0, lpBaseNameW, buflenW, - lpBaseName, nSize, NULL, NULL); - if (ret < nSize) lpBaseName[ret] = 0; - } - HeapFree(GetProcessHeap(), 0, lpBaseNameW); - return ret; -} - -/*********************************************************************** - * GetModuleBaseNameW (PSAPI.@) - */ -DWORD WINAPI GetModuleBaseNameW(HANDLE hProcess, HMODULE hModule, - LPWSTR lpBaseName, DWORD nSize) -{ - LDR_MODULE LdrModule; - - if (!PSAPI_GetLdrModule(hProcess, hModule, &LdrModule)) - return 0; - - nSize = min(LdrModule.BaseDllName.Length / sizeof(WCHAR), nSize); - if (!ReadProcessMemory(hProcess, LdrModule.BaseDllName.Buffer, - lpBaseName, nSize * sizeof(WCHAR), NULL)) - return 0; - - lpBaseName[nSize] = 0; - return nSize; -} - -/*********************************************************************** * GetModuleFileNameExA (PSAPI.@) */ DWORD WINAPI GetModuleFileNameExA(HANDLE hProcess, HMODULE hModule,
1
0
0
0
Jacek Caban : kernel32: Moved K32EnumProcessModules to module.c.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: 8379893f967edfd35a890eabd73b9b7e1d736afe URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8379893f967edfd35a890eabd…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 12 12:19:52 2011 +0000 kernel32: Moved K32EnumProcessModules to module.c. --- dlls/kernel32/module.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/kernel32/process.c | 82 ----------------------------------------------- 2 files changed, 82 insertions(+), 82 deletions(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index d94850f..347d4aa 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -1073,6 +1073,88 @@ FARPROC WINAPI DelayLoadFailureHook( LPCSTR name, LPCSTR function ) return NULL; } +typedef struct { + HANDLE process; + PLIST_ENTRY head, current; + LDR_MODULE ldr_module; +} MODULE_ITERATOR; + +static BOOL init_module_iterator(MODULE_ITERATOR *iter, HANDLE process) +{ + PROCESS_BASIC_INFORMATION pbi; + PPEB_LDR_DATA ldr_data; + NTSTATUS status; + + /* Get address of PEB */ + status = NtQueryInformationProcess(process, ProcessBasicInformation, + &pbi, sizeof(pbi), NULL); + if (status != STATUS_SUCCESS) + { + SetLastError(RtlNtStatusToDosError(status)); + return FALSE; + } + + /* Read address of LdrData from PEB */ + if (!ReadProcessMemory(process, &pbi.PebBaseAddress->LdrData, + &ldr_data, sizeof(ldr_data), NULL)) + return FALSE; + + /* Read address of first module from LdrData */ + if (!ReadProcessMemory(process, + &ldr_data->InLoadOrderModuleList.Flink, + &iter->current, sizeof(iter->current), NULL)) + return FALSE; + + iter->head = &ldr_data->InLoadOrderModuleList; + iter->process = process; + + return TRUE; +} + +static int module_iterator_next(MODULE_ITERATOR *iter) +{ + if (iter->current == iter->head) + return 0; + + if (!ReadProcessMemory(iter->process, + CONTAINING_RECORD(iter->current, LDR_MODULE, InLoadOrderModuleList), + &iter->ldr_module, sizeof(iter->ldr_module), NULL)) + return -1; + + iter->current = iter->ldr_module.InLoadOrderModuleList.Flink; + return 1; +} + +/*********************************************************************** + * K32EnumProcessModules (KERNEL32.@) + * + * NOTES + * Returned list is in load order. + */ +BOOL WINAPI K32EnumProcessModules(HANDLE process, HMODULE *lphModule, + DWORD cb, DWORD *needed) +{ + MODULE_ITERATOR iter; + INT ret; + + if (!init_module_iterator(&iter, process)) + return FALSE; + + *needed = 0; + + while ((ret = module_iterator_next(&iter)) > 0) + { + if (cb >= sizeof(HMODULE)) + { + *lphModule++ = iter.ldr_module.BaseAddress; + cb -= sizeof(HMODULE); + } + *needed += sizeof(HMODULE); + } + + return ret == 0; +} + #ifdef __i386__ diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 2ec5905..f043b87 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -3502,88 +3502,6 @@ BOOL WINAPI K32EnumProcesses(DWORD *lpdwProcessIDs, DWORD cb, DWORD *lpcbUsed) return TRUE; } -typedef struct { - HANDLE process; - PLIST_ENTRY head, current; - LDR_MODULE ldr_module; -} MODULE_ITERATOR; - -static BOOL init_module_iterator(MODULE_ITERATOR *iter, HANDLE process) -{ - PROCESS_BASIC_INFORMATION pbi; - PPEB_LDR_DATA ldr_data; - NTSTATUS status; - - /* Get address of PEB */ - status = NtQueryInformationProcess(process, ProcessBasicInformation, - &pbi, sizeof(pbi), NULL); - if (status != STATUS_SUCCESS) - { - SetLastError(RtlNtStatusToDosError(status)); - return FALSE; - } - - /* Read address of LdrData from PEB */ - if (!ReadProcessMemory(process, &pbi.PebBaseAddress->LdrData, - &ldr_data, sizeof(ldr_data), NULL)) - return FALSE; - - /* Read address of first module from LdrData */ - if (!ReadProcessMemory(process, - &ldr_data->InLoadOrderModuleList.Flink, - &iter->current, sizeof(iter->current), NULL)) - return FALSE; - - iter->head = &ldr_data->InLoadOrderModuleList; - iter->process = process; - - return TRUE; -} - -static int module_iterator_next(MODULE_ITERATOR *iter) -{ - if (iter->current == iter->head) - return 0; - - if (!ReadProcessMemory(iter->process, - CONTAINING_RECORD(iter->current, LDR_MODULE, InLoadOrderModuleList), - &iter->ldr_module, sizeof(iter->ldr_module), NULL)) - return -1; - - iter->current = iter->ldr_module.InLoadOrderModuleList.Flink; - return 1; -} - -/*********************************************************************** - * K32EnumProcessModules (KERNEL32.@) - * - * NOTES - * Returned list is in load order. - */ -BOOL WINAPI K32EnumProcessModules(HANDLE process, HMODULE *lphModule, - DWORD cb, DWORD *needed) -{ - MODULE_ITERATOR iter; - INT ret; - - if (!init_module_iterator(&iter, process)) - return FALSE; - - *needed = 0; - - while ((ret = module_iterator_next(&iter)) > 0) - { - if (cb >= sizeof(HMODULE)) - { - *lphModule++ = iter.ldr_module.BaseAddress; - cb -= sizeof(HMODULE); - } - *needed += sizeof(HMODULE); - } - - return ret == 0; -} - /*********************************************************************** * K32QueryWorkingSet (KERNEL32.@) */
1
0
0
0
Jacek Caban : kernel32: Moved GetProcessMemoryInfo implementation to kernel32.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: 4ed94f7939a21c77bc565d0f697b1cd9aa8b4a74 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4ed94f7939a21c77bc565d0f6…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 12 12:19:40 2011 +0000 kernel32: Moved GetProcessMemoryInfo implementation to kernel32. --- dlls/kernel32/kernel32.spec | 1 + dlls/kernel32/process.c | 42 ++++++++++++++++++++++++++++++++++++++++++ dlls/psapi/psapi.spec | 2 +- dlls/psapi/psapi_main.c | 41 ----------------------------------------- 4 files changed, 44 insertions(+), 42 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index a4e45d6..458b425 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -772,6 +772,7 @@ @ stdcall K32GetProcessImageFileNameW(long ptr long) @ stdcall K32EnumProcessModules(long ptr long ptr) @ stdcall K32EnumProcesses(ptr long ptr) +@ stdcall K32GetProcessMemoryInfo(long ptr long) @ stdcall K32QueryWorkingSet(long ptr long) @ stdcall K32QueryWorkingSetEx(long ptr long) @ stdcall -i386 -private -register K32Thk1632Epilog() krnl386.exe16.K32Thk1632Epilog diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 5436c06..2ec5905 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -46,6 +46,7 @@ #define WIN32_NO_STATUS #include "winternl.h" #include "kernel_private.h" +#include "psapi.h" #include "wine/library.h" #include "wine/server.h" #include "wine/unicode.h" @@ -3622,6 +3623,47 @@ BOOL WINAPI K32QueryWorkingSetEx( HANDLE process, LPVOID buffer, DWORD size ) } /*********************************************************************** + * K32GetProcessMemoryInfo (KERNEL32.@) + * + * Retrieve memory usage information for a given process + * + */ +BOOL WINAPI K32GetProcessMemoryInfo(HANDLE process, + PPROCESS_MEMORY_COUNTERS pmc, DWORD cb) +{ + NTSTATUS status; + VM_COUNTERS vmc; + + if (cb < sizeof(PROCESS_MEMORY_COUNTERS)) + { + SetLastError(ERROR_INSUFFICIENT_BUFFER); + return FALSE; + } + + status = NtQueryInformationProcess(process, ProcessVmCounters, + &vmc, sizeof(vmc), NULL); + + if (status) + { + SetLastError(RtlNtStatusToDosError(status)); + return FALSE; + } + + pmc->cb = sizeof(PROCESS_MEMORY_COUNTERS); + pmc->PageFaultCount = vmc.PageFaultCount; + pmc->PeakWorkingSetSize = vmc.PeakWorkingSetSize; + pmc->WorkingSetSize = vmc.WorkingSetSize; + pmc->QuotaPeakPagedPoolUsage = vmc.QuotaPeakPagedPoolUsage; + pmc->QuotaPagedPoolUsage = vmc.QuotaPagedPoolUsage; + pmc->QuotaPeakNonPagedPoolUsage = vmc.QuotaPeakNonPagedPoolUsage; + pmc->QuotaNonPagedPoolUsage = vmc.QuotaNonPagedPoolUsage; + pmc->PagefileUsage = vmc.PagefileUsage; + pmc->PeakPagefileUsage = vmc.PeakPagefileUsage; + + return TRUE; +} + +/*********************************************************************** * ProcessIdToSessionId (KERNEL32.@) * This function is available on Terminal Server 4SP4 and Windows 2000 */ diff --git a/dlls/psapi/psapi.spec b/dlls/psapi/psapi.spec index 37d6e80..ad03716 100644 --- a/dlls/psapi/psapi.spec +++ b/dlls/psapi/psapi.spec @@ -18,7 +18,7 @@ @ stdcall GetPerformanceInfo(ptr long) @ stdcall GetProcessImageFileNameA(long ptr long) kernel32.K32GetProcessImageFileNameA @ stdcall GetProcessImageFileNameW(long ptr long) kernel32.K32GetProcessImageFileNameW -@ stdcall GetProcessMemoryInfo(long ptr long) +@ stdcall GetProcessMemoryInfo(long ptr long) kernel32.K32GetProcessMemoryInfo @ stdcall GetWsChanges(long ptr long) @ stdcall InitializeProcessForWsWatch(long) @ stdcall QueryWorkingSet(long ptr long) kernel32.K32QueryWorkingSet diff --git a/dlls/psapi/psapi_main.c b/dlls/psapi/psapi_main.c index 909e7ce..0b8e5b0 100644 --- a/dlls/psapi/psapi_main.c +++ b/dlls/psapi/psapi_main.c @@ -407,47 +407,6 @@ BOOL WINAPI GetPerformanceInfo( PPERFORMANCE_INFORMATION info, DWORD size ) } /*********************************************************************** - * GetProcessMemoryInfo (PSAPI.@) - * - * Retrieve memory usage information for a given process - * - */ -BOOL WINAPI GetProcessMemoryInfo(HANDLE hProcess, - PPROCESS_MEMORY_COUNTERS pmc, DWORD cb) -{ - NTSTATUS status; - VM_COUNTERS vmc; - - if (cb < sizeof(PROCESS_MEMORY_COUNTERS)) - { - SetLastError(ERROR_INSUFFICIENT_BUFFER); - return FALSE; - } - - status = NtQueryInformationProcess(hProcess, ProcessVmCounters, - &vmc, sizeof(vmc), NULL); - - if (status) - { - SetLastError(RtlNtStatusToDosError(status)); - return FALSE; - } - - pmc->cb = sizeof(PROCESS_MEMORY_COUNTERS); - pmc->PageFaultCount = vmc.PageFaultCount; - pmc->PeakWorkingSetSize = vmc.PeakWorkingSetSize; - pmc->WorkingSetSize = vmc.WorkingSetSize; - pmc->QuotaPeakPagedPoolUsage = vmc.QuotaPeakPagedPoolUsage; - pmc->QuotaPagedPoolUsage = vmc.QuotaPagedPoolUsage; - pmc->QuotaPeakNonPagedPoolUsage = vmc.QuotaPeakNonPagedPoolUsage; - pmc->QuotaNonPagedPoolUsage = vmc.QuotaNonPagedPoolUsage; - pmc->PagefileUsage = vmc.PagefileUsage; - pmc->PeakPagefileUsage = vmc.PeakPagefileUsage; - - return TRUE; -} - -/*********************************************************************** * GetWsChanges (PSAPI.@) */ BOOL WINAPI GetWsChanges( HANDLE process, PPSAPI_WS_WATCH_INFORMATION watchinfo, DWORD size )
1
0
0
0
Piotr Caban : msvcr: Update spec files.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: ed6c309fe5f89682acb6de39293a643d8885ca30 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ed6c309fe5f89682acb6de392…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:54 2011 +0200 msvcr: Update spec files. --- dlls/msvcr100/msvcr100.spec | 50 +++++++++++++++++++++--------------------- dlls/msvcr80/msvcr80.spec | 50 +++++++++++++++++++++--------------------- dlls/msvcr90/msvcr90.spec | 50 +++++++++++++++++++++--------------------- 3 files changed, 75 insertions(+), 75 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=ed6c309fe5f89682acb6d…
1
0
0
0
Piotr Caban : msvcrt: Added _strnicoll_l implementation.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: b5d1d8e2b520a2703d97f51e77e9626a84081c0b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b5d1d8e2b520a2703d97f51e7…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:43 2011 +0200 msvcrt: Added _strnicoll_l implementation. --- dlls/msvcrt/msvcrt.spec | 4 ++-- dlls/msvcrt/string.c | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index e7294a5..8957e42 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -938,8 +938,8 @@ @ cdecl _strncoll_l(str str long ptr) MSVCRT_strncoll @ cdecl _strnicmp(str str long) ntdll._strnicmp # stub _strnicmp_l(str str long ptr) -@ stub _strnicoll(str str long) -# stub _strnicoll_l(str str long ptr) +@ cdecl _strnicoll(str str long) MSVCRT__strnicoll +@ cdecl _strnicoll_l(str str long ptr) MSVCRT__strnicoll_l @ cdecl _strnset(str long long) MSVCRT__strnset # stub _strnset_s(str long long long) @ cdecl _strrev(str) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index b6fe68b..0e7da1e 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -586,6 +586,26 @@ int CDECL MSVCRT_strncoll( const char* str1, const char* str2, MSVCRT_size_t cou } /********************************************************************* + * _strnicoll_l (MSVCRT.@) + */ +int CDECL MSVCRT__strnicoll_l( const char* str1, const char* str2, MSVCRT_size_t count, MSVCRT__locale_t locale ) +{ + if(!locale) + locale = get_locale(); + + return CompareStringA(locale->locinfo->lc_handle[MSVCRT_LC_CTYPE], NORM_IGNORECASE, + str1, count, str2, count)-2; +} + +/********************************************************************* + * _strnicoll (MSVCRT.@) + */ +int CDECL MSVCRT__strnicoll( const char* str1, const char* str2, MSVCRT_size_t count ) +{ + return MSVCRT__strnicoll_l(str1, str2, count, NULL); +} + +/********************************************************************* * strcpy_s (MSVCRT.@) */ int CDECL MSVCRT_strcpy_s( char* dst, MSVCRT_size_t elem, const char* src )
1
0
0
0
Piotr Caban : msvcrt: Added _strncoll_l implementation.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: d32bc75a2f985f1e5c4186cbb56de10c47c68639 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d32bc75a2f985f1e5c4186cbb…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:31 2011 +0200 msvcrt: Added _strncoll_l implementation. --- dlls/msvcrt/msvcrt.spec | 4 ++-- dlls/msvcrt/string.c | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 958c6cb..e7294a5 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -934,8 +934,8 @@ @ cdecl _strlwr_l(str ptr) @ cdecl _strlwr_s(ptr long) @ cdecl _strlwr_s_l(ptr long ptr) -@ stub _strncoll(str str long) -# stub _strncoll_l(str str long ptr) +@ cdecl _strncoll(str str long) MSVCRT_strncoll_l +@ cdecl _strncoll_l(str str long ptr) MSVCRT_strncoll @ cdecl _strnicmp(str str long) ntdll._strnicmp # stub _strnicmp_l(str str long ptr) @ stub _strnicoll(str str long) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index 1e7e890..b6fe68b 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -567,6 +567,25 @@ int CDECL MSVCRT__stricoll( const char* str1, const char* str2 ) } /********************************************************************* + * _strncoll_l (MSVCRT.@) + */ +int CDECL MSVCRT_strncoll_l( const char* str1, const char* str2, MSVCRT_size_t count, MSVCRT__locale_t locale ) +{ + if(!locale) + locale = get_locale(); + + return CompareStringA(locale->locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, count, str2, count)-2; +} + +/********************************************************************* + * strncoll (MSVCRT.@) + */ +int CDECL MSVCRT_strncoll( const char* str1, const char* str2, MSVCRT_size_t count ) +{ + return MSVCRT_strncoll_l(str1, str2, count, NULL); +} + +/********************************************************************* * strcpy_s (MSVCRT.@) */ int CDECL MSVCRT_strcpy_s( char* dst, MSVCRT_size_t elem, const char* src )
1
0
0
0
Piotr Caban : msvcrt: Added _stricoll_l implementation.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: ff7cf637df2b3dc3d58f6a320a855f4b8212c48c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ff7cf637df2b3dc3d58f6a320…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:22 2011 +0200 msvcrt: Added _stricoll_l implementation. --- dlls/msvcrt/msvcrt.spec | 2 +- dlls/msvcrt/string.c | 30 ++++++++++++++++++++---------- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 605997c..958c6cb 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -929,7 +929,7 @@ @ cdecl _stricmp(str str) ntdll._stricmp # stub _stricmp_l(str str ptr) @ cdecl _stricoll(str str) MSVCRT__stricoll -# stub _stricoll_l(str str ptr) +@ cdecl _stricoll_l(str str ptr) MSVCRT__stricoll_l @ cdecl _strlwr(str) @ cdecl _strlwr_l(str ptr) @ cdecl _strlwr_s(ptr long) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index a3d8d57..1e7e890 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -547,6 +547,26 @@ int CDECL MSVCRT_strcoll( const char* str1, const char* str2 ) } /********************************************************************* + * _stricoll_l (MSVCRT.@) + */ +int CDECL MSVCRT__stricoll_l( const char* str1, const char* str2, MSVCRT__locale_t locale ) +{ + if(!locale) + locale = get_locale(); + + return CompareStringA(locale->locinfo->lc_handle[MSVCRT_LC_CTYPE], NORM_IGNORECASE, + str1, -1, str2, -1)-2; +} + +/********************************************************************* + * _stricoll (MSVCRT.@) + */ +int CDECL MSVCRT__stricoll( const char* str1, const char* str2 ) +{ + return MSVCRT__stricoll_l(str1, str2, NULL); +} + +/********************************************************************* * strcpy_s (MSVCRT.@) */ int CDECL MSVCRT_strcpy_s( char* dst, MSVCRT_size_t elem, const char* src ) @@ -644,16 +664,6 @@ MSVCRT_size_t CDECL MSVCRT_strxfrm( char *dest, const char *src, MSVCRT_size_t l return strxfrm( dest, src, len ); } -/********************************************************************* - * _stricoll (MSVCRT.@) - */ -int CDECL MSVCRT__stricoll( const char* str1, const char* str2 ) -{ - /* FIXME: handle collates */ - TRACE("str1 %s str2 %s\n", debugstr_a(str1), debugstr_a(str2)); - return lstrcmpiA( str1, str2 ); -} - /******************************************************************** * _atoldbl (MSVCRT.@) */
1
0
0
0
Piotr Caban : msvcrt: Added _strcoll_l implementation.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: e07dbe2c0a179c4143422d30c475867a1d452c70 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e07dbe2c0a179c4143422d30c…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:10 2011 +0200 msvcrt: Added _strcoll_l implementation. --- dlls/msvcrt/msvcrt.spec | 2 +- dlls/msvcrt/string.c | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 1766dbf..605997c 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -919,7 +919,7 @@ @ cdecl _stati64(str ptr) MSVCRT_stati64 @ cdecl _statusfp() @ cdecl _strcmpi(str str) ntdll._strcmpi -# stub _strcoll_l(str str ptr) +@ cdecl _strcoll_l(str str ptr) MSVCRT_strcoll_l @ cdecl _strdate(ptr) @ cdecl _strdate_s(ptr long) @ cdecl _strdup(str) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index 8316ff7..a3d8d57 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -31,6 +31,7 @@ #include <limits.h> #include <errno.h> #include "msvcrt.h" +#include "winnls.h" #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(msvcrt); @@ -527,12 +528,22 @@ int CDECL MSVCRT__atoflt_l( MSVCRT__CRT_FLOAT *value, char *str, MSVCRT__locale_ } /********************************************************************* + * _strcoll_l (MSVCRT.@) + */ +int CDECL MSVCRT_strcoll_l( const char* str1, const char* str2, MSVCRT__locale_t locale ) +{ + if(!locale) + locale = get_locale(); + + return CompareStringA(locale->locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, -1, str2, -1)-2; +} + +/********************************************************************* * strcoll (MSVCRT.@) */ int CDECL MSVCRT_strcoll( const char* str1, const char* str2 ) { - /* FIXME: handle Windows locale */ - return strcoll( str1, str2 ); + return MSVCRT_strcoll_l(str1, str2, NULL); } /*********************************************************************
1
0
0
0
Piotr Caban : kernel32/tests: Add locale specific CompareString test.
by Alexandre Julliard
12 May '11
12 May '11
Module: wine Branch: master Commit: b88c8518203149d37f6e5c5b9f58c4a623946a36 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b88c8518203149d37f6e5c5b9…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu May 12 11:39:01 2011 +0200 kernel32/tests: Add locale specific CompareString test. --- dlls/kernel32/tests/locale.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index 3774342..19f630b 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/kernel32/tests/locale.c @@ -1343,6 +1343,14 @@ static void test_CompareStringA(void) ret = lstrcmpi("#", "."); todo_wine ok(ret == -1, "\"#\" vs \".\" expected -1, got %d\n", ret); + + lcid = MAKELCID(MAKELANGID(LANG_POLISH, SUBLANG_DEFAULT), SORT_DEFAULT); + + /* \xB9 character lies between a and b */ + ret = CompareStringA(lcid, 0, "a", 1, "\xB9", 1); + todo_wine ok(ret == CSTR_LESS_THAN, "\'\\xB9\' character should be grater than \'a\'\n"); + ret = CompareStringA(lcid, 0, "\xB9", 1, "b", 1); + ok(ret == CSTR_LESS_THAN, "\'\\xB9\' character should be smaller than \'b\'\n"); } static void test_LCMapStringA(void)
1
0
0
0
← Newer
1
...
59
60
61
62
63
64
65
...
95
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
Results per page:
10
25
50
100
200