winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
945 discussions
Start a n
N
ew thread
Konstantin L. Metlov : gdi32: Handle pre-Unicode symbol TTFs with symbols at U+00XX.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: fb787da66afe35e3c5e2a3508d60bb38fbf21ab3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fb787da66afe35e3c5e2a3508…
Author: Konstantin L. Metlov <metlov(a)fti.dn.ua> Date: Wed May 11 19:01:59 2011 +0300 gdi32: Handle pre-Unicode symbol TTFs with symbols at U+00XX. --- dlls/gdi32/freetype.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index a3e9cec..79073a6 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -4553,12 +4553,13 @@ static FT_UInt get_glyph_index(const GdiFont *font, UINT glyph) return get_GSUB_vert_glyph(font,ret); } - if(font->ft_face->charmap->encoding == FT_ENCODING_MS_SYMBOL && glyph < 0x100) + if(font->ft_face->charmap->encoding == FT_ENCODING_MS_SYMBOL) { + if (glyph < 0x100) glyph += 0xf000; /* there is a number of old pre-Unicode "broken" TTFs, which do have symbols at U+00XX instead of U+f0XX */ - if (!(glyphId = pFT_Get_Char_Index(font->ft_face, glyph + 0xf000))) - glyphId = pFT_Get_Char_Index(font->ft_face, glyph); + if (!(glyphId = pFT_Get_Char_Index(font->ft_face, glyph))) + glyphId = pFT_Get_Char_Index(font->ft_face, glyph-0xf000); } else glyphId = pFT_Get_Char_Index(font->ft_face, glyph);
1
0
0
0
Vincent Povirk : mscoree: State the . NET and Mono versions when a runtime is missing.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 92563de3ea5165e071ae44bc1b97040b80d52d58 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=92563de3ea5165e071ae44bc1…
Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed May 11 10:07:23 2011 -0500 mscoree: State the .NET and Mono versions when a runtime is missing. --- dlls/mscoree/metahost.c | 23 ++++++++++++++++++----- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/dlls/mscoree/metahost.c b/dlls/mscoree/metahost.c index 878cdee..98f1cbb 100644 --- a/dlls/mscoree/metahost.c +++ b/dlls/mscoree/metahost.c @@ -97,6 +97,16 @@ static void CDECL do_nothing(void) { } +static void missing_runtime_message(const CLRRuntimeInfo *This) +{ + if (This->major == 1) + MESSAGE("wine: Install Mono 2.6 for Windows to run .NET 1.1 applications.\n"); + else if (This->major == 2) + MESSAGE("wine: Install Mono for Windows to run .NET 2.0 applications.\n"); + else if (This->major == 4) + MESSAGE("wine: Install Mono 2.8 or greater for Windows to run .NET 4.0 applications.\n"); +} + static HRESULT load_mono(CLRRuntimeInfo *This, loaded_mono **result) { static const WCHAR bin[] = {'\\','b','i','n',0}; @@ -109,11 +119,11 @@ static HRESULT load_mono(CLRRuntimeInfo *This, loaded_mono **result) int trace_size; char trace_setting[256]; - if (This->mono_abi_version == -1) - MESSAGE("wine: Install the Windows version of Mono to run .NET executables\n"); - if (This->mono_abi_version <= 0 || This->mono_abi_version > NUM_ABI_VERSIONS) + { + missing_runtime_message(This); return E_FAIL; + } *result = &loaded_monos[This->mono_abi_version-1]; @@ -1015,7 +1025,7 @@ static HRESULT WINAPI CLRMetaHost_GetRuntime(ICLRMetaHost* iface, return IUnknown_QueryInterface((IUnknown*)&runtimes[i], iid, ppRuntime); else { - ERR("Mono is missing %s runtime\n", debugstr_w(pwzVersion)); + missing_runtime_message(&runtimes[i]); return CLR_E_SHIM_RUNTIME; } } @@ -1309,7 +1319,10 @@ HRESULT get_runtime_info(LPCWSTR exefile, LPCWSTR version, LPCWSTR config_file, &IID_ICLRRuntimeInfo, (void**)result); } - ERR("No %s.NET runtime installed\n", legacy ? "legacy " : ""); + if (legacy) + missing_runtime_message(&runtimes[1]); + else + missing_runtime_message(&runtimes[NUM_RUNTIMES-1]); return CLR_E_SHIM_RUNTIME; }
1
0
0
0
Aric Stewart : usp10/tests: Test ScriptItemizeOpenType.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 4d8012795f8b5a6d3f45f83b94a382bc9daba0e2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4d8012795f8b5a6d3f45f83b9…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue May 10 13:09:57 2011 -0500 usp10/tests: Test ScriptItemizeOpenType. --- dlls/usp10/tests/usp10.c | 107 ++++++++++++++++++++++++++++++---------------- 1 files changed, 70 insertions(+), 37 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=4d8012795f8b5a6d3f45f…
1
0
0
0
Aric Stewart : usp10: Implement ScriptItemizeOpenType.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: f221aea66c5bf9c5e2f2a0cae950ffccd46a2c14 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f221aea66c5bf9c5e2f2a0cae…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue May 10 13:09:47 2011 -0500 usp10: Implement ScriptItemizeOpenType. --- dlls/usp10/shape.c | 6 -- dlls/usp10/usp10.c | 129 +++++++++++++++++++++++++++++++----------- dlls/usp10/usp10.spec | 2 +- dlls/usp10/usp10_internal.h | 6 ++ 4 files changed, 102 insertions(+), 41 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f221aea66c5bf9c5e2f2a…
1
0
0
0
Rico Schüller : d3dx9/tests: Add ID3DXEffect::Get/ SetStateManager() test.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 1ac8f4d472d7c59b630ddace9473193c6beb6996 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1ac8f4d472d7c59b630ddace9…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed May 11 16:47:10 2011 +0200 d3dx9/tests: Add ID3DXEffect::Get/SetStateManager() test. --- dlls/d3dx9_36/tests/effect.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 483efd4..6a8f04f 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -33,6 +33,7 @@ static void test_create_effect_and_pool(IDirect3DDevice9 *device) ID3DXBaseEffect *base; ULONG count; IDirect3DDevice9 *device2; + LPD3DXEFFECTSTATEMANAGER manager = (LPD3DXEFFECTSTATEMANAGER)0xdeadbeef; ID3DXEffectPool *pool = (ID3DXEffectPool *)0xdeadbeef, *pool2; hr = D3DXCreateEffect(NULL, effect_desc, sizeof(effect_desc), NULL, NULL, 0, NULL, NULL, NULL); @@ -53,6 +54,31 @@ static void test_create_effect_and_pool(IDirect3DDevice9 *device) hr = effect->lpVtbl->QueryInterface(effect, &IID_ID3DXBaseEffect, (void **)&base); ok(hr == E_NOINTERFACE, "QueryInterface failed, got %x, expected %x (E_NOINTERFACE)\n", hr, E_NOINTERFACE); + hr = effect->lpVtbl->GetStateManager(effect, NULL); + ok(hr == D3DERR_INVALIDCALL, "GetStateManager failed, got %x, expected %x (D3DERR_INVALIDCALL)\n", hr, D3DERR_INVALIDCALL); + + hr = effect->lpVtbl->GetStateManager(effect, &manager); + ok(hr == D3D_OK, "GetStateManager failed, got %x, expected 0 (D3D_OK)\n", hr); + ok(!manager, "GetStateManager failed, got %p\n", manager); + + /* this works, but it is not recommended! */ + hr = effect->lpVtbl->SetStateManager(effect, (LPD3DXEFFECTSTATEMANAGER) device); + ok(hr == D3D_OK, "SetStateManager failed, got %x, expected 0 (D3D_OK)\n", hr); + + hr = effect->lpVtbl->GetStateManager(effect, &manager); + ok(hr == D3D_OK, "GetStateManager failed, got %x, expected 0 (D3D_OK)\n", hr); + ok(manager != NULL, "GetStateManager failed\n"); + + IDirect3DDevice9_AddRef(device); + count = IDirect3DDevice9_Release(device); + ok(count == 4, "Release failed, got %u, expected 4\n", count); + + count = IUnknown_Release(manager); + ok(count == 3, "Release failed, got %u, expected 3\n", count); + + hr = effect->lpVtbl->SetStateManager(effect, NULL); + ok(hr == D3D_OK, "SetStateManager failed, got %x, expected 0 (D3D_OK)\n", hr); + hr = effect->lpVtbl->GetPool(effect, &pool); ok(hr == D3D_OK, "GetPool failed, got %x, expected 0 (D3D_OK)\n", hr); ok(!pool, "GetPool failed, got %p\n", pool);
1
0
0
0
Rico Schüller : d3dx9: Implement ID3DXEffect:: GetStateManager().
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 72d3ee3ab606bbc7ff22567697c567e675c1573b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=72d3ee3ab606bbc7ff2256769…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed May 11 16:47:06 2011 +0200 d3dx9: Implement ID3DXEffect::GetStateManager(). --- dlls/d3dx9_36/effect.c | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index f513a90..d8877c0 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -2445,13 +2445,22 @@ static HRESULT WINAPI ID3DXEffectImpl_SetStateManager(ID3DXEffect *iface, LPD3DX return D3D_OK; } -static HRESULT WINAPI ID3DXEffectImpl_GetStateManager(ID3DXEffect* iface, LPD3DXEFFECTSTATEMANAGER* manager) +static HRESULT WINAPI ID3DXEffectImpl_GetStateManager(ID3DXEffect *iface, LPD3DXEFFECTSTATEMANAGER *manager) { struct ID3DXEffectImpl *This = impl_from_ID3DXEffect(iface); - FIXME("(%p)->(%p): stub\n", This, manager); + TRACE("iface %p, manager %p\n", This, manager); - return E_NOTIMPL; + if (!manager) + { + WARN("Invalid argument supplied.\n"); + return D3DERR_INVALIDCALL; + } + + if (This->manager) IUnknown_AddRef(This->manager); + *manager = This->manager; + + return D3D_OK; } static HRESULT WINAPI ID3DXEffectImpl_BeginParameterBlock(ID3DXEffect* iface)
1
0
0
0
Rico Schüller : d3dx9: Implement ID3DXEffect:: SetStateManager().
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: cd121b10d6a896825cb412c61c6fc9496a6eedd1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cd121b10d6a896825cb412c61…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed May 11 16:47:02 2011 +0200 d3dx9: Implement ID3DXEffect::SetStateManager(). --- dlls/d3dx9_36/effect.c | 17 ++++++++++++++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 44f6b19..f513a90 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -95,6 +95,7 @@ struct ID3DXEffectImpl ID3DXEffect ID3DXEffect_iface; LONG ref; + LPD3DXEFFECTSTATEMANAGER manager; LPDIRECT3DDEVICE9 device; LPD3DXEFFECTPOOL pool; @@ -449,6 +450,11 @@ static void free_effect(struct ID3DXEffectImpl *effect) effect->pool->lpVtbl->Release(effect->pool); } + if (effect->manager) + { + IUnknown_Release(effect->manager); + } + IDirect3DDevice9_Release(effect->device); } @@ -2425,13 +2431,18 @@ static HRESULT WINAPI ID3DXEffectImpl_OnResetDevice(ID3DXEffect* iface) return E_NOTIMPL; } -static HRESULT WINAPI ID3DXEffectImpl_SetStateManager(ID3DXEffect* iface, LPD3DXEFFECTSTATEMANAGER manager) +static HRESULT WINAPI ID3DXEffectImpl_SetStateManager(ID3DXEffect *iface, LPD3DXEFFECTSTATEMANAGER manager) { struct ID3DXEffectImpl *This = impl_from_ID3DXEffect(iface); - FIXME("(%p)->(%p): stub\n", This, manager); + TRACE("iface %p, manager %p\n", This, manager); - return E_NOTIMPL; + if (This->manager) IUnknown_Release(This->manager); + if (manager) IUnknown_AddRef(manager); + + This->manager = manager; + + return D3D_OK; } static HRESULT WINAPI ID3DXEffectImpl_GetStateManager(ID3DXEffect* iface, LPD3DXEFFECTSTATEMANAGER* manager)
1
0
0
0
Dylan Smith : d3dx9: Implement D3DXMESHOPT_ATTRSORT|D3DXMESHOPT_IGNOREVERTS .
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: f203aa1746027885ceb0ce46f4274ca8d61ded22 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f203aa1746027885ceb0ce46f…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Wed May 11 05:30:55 2011 -0400 d3dx9: Implement D3DXMESHOPT_ATTRSORT|D3DXMESHOPT_IGNOREVERTS. --- dlls/d3dx9_36/mesh.c | 193 ++++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 181 insertions(+), 12 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f203aa1746027885ceb0c…
1
0
0
0
Dylan Smith : d3dx9: Create compact_mesh helper function for OptimizeInplace.
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 4ed3930e276f59061e26cdbc6ac14cfb0030433d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4ed3930e276f59061e26cdbc6…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Wed May 11 05:30:41 2011 -0400 d3dx9: Create compact_mesh helper function for OptimizeInplace. --- dlls/d3dx9_36/mesh.c | 78 +++++++++++++++++++++++++++++-------------------- 1 files changed, 46 insertions(+), 32 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index eca9332..95b967b 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -652,6 +652,48 @@ static HRESULT WINAPI ID3DXMeshImpl_Optimize(ID3DXMesh *iface, DWORD flags, CONS return E_NOTIMPL; } +/* Creates a vertex_remap that removes unused vertices. + * Indices are updated according to the vertex_remap. */ +static HRESULT compact_mesh(ID3DXMeshImpl *This, DWORD *indices, DWORD *new_num_vertices, ID3DXBuffer **vertex_remap) +{ + HRESULT hr; + DWORD *vertex_remap_ptr; + DWORD num_used_vertices; + DWORD i; + + hr = D3DXCreateBuffer(This->numvertices * sizeof(DWORD), vertex_remap); + if (FAILED(hr)) return hr; + vertex_remap_ptr = ID3DXBuffer_GetBufferPointer(*vertex_remap); + + for (i = 0; i < This->numfaces * 3; i++) + vertex_remap_ptr[indices[i]] = 1; + + /* create old->new vertex mapping */ + num_used_vertices = 0; + for (i = 0; i < This->numvertices; i++) { + if (vertex_remap_ptr[i]) + vertex_remap_ptr[i] = num_used_vertices++; + else + vertex_remap_ptr[i] = -1; + } + /* convert indices */ + for (i = 0; i < This->numfaces * 3; i++) + indices[i] = vertex_remap_ptr[indices[i]]; + + /* create new->old vertex mapping */ + num_used_vertices = 0; + for (i = 0; i < This->numvertices; i++) { + if (vertex_remap_ptr[i] != -1) + vertex_remap_ptr[num_used_vertices++] = i; + } + for (i = num_used_vertices; i < This->numvertices; i++) + vertex_remap_ptr[i] = -1; + + *new_num_vertices = num_used_vertices; + + return D3D_OK; +} + static HRESULT WINAPI ID3DXMeshImpl_OptimizeInplace(ID3DXMesh *iface, DWORD flags, CONST DWORD *adjacency_in, DWORD *adjacency_out, DWORD *face_remap_out, LPD3DXBUFFER *vertex_remap_out) { @@ -661,7 +703,7 @@ static HRESULT WINAPI ID3DXMeshImpl_OptimizeInplace(ID3DXMesh *iface, DWORD flag ID3DXBuffer *vertex_remap = NULL; DWORD *dword_indices = NULL; DWORD new_num_vertices = 0; - DWORD new_vertex_buffer_size = 0; + DWORD new_num_alloc_vertices = 0; IDirect3DVertexBuffer9 *vertex_buffer = NULL; DWORD i; @@ -700,36 +742,9 @@ static HRESULT WINAPI ID3DXMeshImpl_OptimizeInplace(ID3DXMesh *iface, DWORD flag if ((flags & (D3DXMESHOPT_COMPACT | D3DXMESHOPT_IGNOREVERTS)) == D3DXMESHOPT_COMPACT) { - /* Remove unused vertices. */ - DWORD *vertex_remap_ptr; - - new_vertex_buffer_size = This->numvertices; - hr = D3DXCreateBuffer(This->numvertices * sizeof(DWORD), &vertex_remap); + new_num_alloc_vertices = This->numvertices; + hr = compact_mesh(This, dword_indices, &new_num_vertices, &vertex_remap); if (FAILED(hr)) goto cleanup; - vertex_remap_ptr = ID3DXBuffer_GetBufferPointer(vertex_remap); - - for (i = 0; i < This->numfaces * 3; i++) - vertex_remap_ptr[dword_indices[i]] = 1; - - /* create old->new vertex mapping */ - for (i = 0; i < This->numvertices; i++) { - if (vertex_remap_ptr[i]) - vertex_remap_ptr[i] = new_num_vertices++; - else - vertex_remap_ptr[i] = -1; - } - /* convert indices */ - for (i = 0; i < This->numfaces * 3; i++) - dword_indices[i] = vertex_remap_ptr[dword_indices[i]]; - - /* create new->old vertex mapping */ - new_num_vertices = 0; - for (i = 0; i < This->numvertices; i++) { - if (vertex_remap_ptr[i] != -1) - vertex_remap_ptr[new_num_vertices++] = i; - } - for (i = new_num_vertices; i < This->numvertices; i++) - vertex_remap_ptr[i] = -1; } if (vertex_remap) @@ -744,8 +759,7 @@ static HRESULT WINAPI ID3DXMeshImpl_OptimizeInplace(ID3DXMesh *iface, DWORD flag hr = IDirect3DVertexBuffer9_GetDesc(This->vertex_buffer, &vertex_desc); if (FAILED(hr)) goto cleanup; - new_vertex_buffer_size *= vertex_size; - hr = IDirect3DDevice9_CreateVertexBuffer(This->device, new_vertex_buffer_size, + hr = IDirect3DDevice9_CreateVertexBuffer(This->device, new_num_alloc_vertices * vertex_size, vertex_desc.Usage, This->fvf, vertex_desc.Pool, &vertex_buffer, NULL); if (FAILED(hr)) goto cleanup;
1
0
0
0
Marcus Meissner : krnl386.exe16: Fixed if that always succeeds (Coverity).
by Alexandre Julliard
11 May '11
11 May '11
Module: wine Branch: master Commit: 428e0312b7254fda023432d096a0d1a87ff5aa30 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=428e0312b7254fda023432d09…
Author: Marcus Meissner <meissner(a)suse.de> Date: Wed May 11 14:36:16 2011 +0200 krnl386.exe16: Fixed if that always succeeds (Coverity). --- dlls/krnl386.exe16/ne_segment.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/krnl386.exe16/ne_segment.c b/dlls/krnl386.exe16/ne_segment.c index d231fb9..1ceb714 100644 --- a/dlls/krnl386.exe16/ne_segment.c +++ b/dlls/krnl386.exe16/ne_segment.c @@ -533,7 +533,8 @@ static void NE_FixupSegmentPrologs(NE_MODULE *pModule, WORD segnum) if (!pModule->ne_autodata) return; - if (!(dgroup = SEL(pSegTable[pModule->ne_autodata-1].hSeg))) return; + if (!pSegTable[pModule->ne_autodata-1].hSeg) return; + dgroup = SEL(pSegTable[pModule->ne_autodata-1].hSeg); pSeg = MapSL( MAKESEGPTR(sel, 0) );
1
0
0
0
← Newer
1
...
62
63
64
65
66
67
68
...
95
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
Results per page:
10
25
50
100
200