winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2011
----- 2025 -----
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
770 discussions
Start a n
N
ew thread
Jacek Caban : mshtml: Wine Gecko 1.3 release.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: bf4b8691527cc518077b3d2dfdc2d1028a7a71b6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bf4b8691527cc518077b3d2df…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Aug 23 14:07:02 2011 +0200 mshtml: Wine Gecko 1.3 release. --- dlls/appwiz.cpl/addons.c | 6 +- dlls/mshtml/htmlbody.c | 12 +-- dlls/mshtml/htmlcurstyle.c | 23 +--- dlls/mshtml/htmldoc3.c | 10 +-- dlls/mshtml/htmlelem.c | 18 +-- dlls/mshtml/htmlelem2.c | 11 +- dlls/mshtml/htmlevent.c | 15 +-- dlls/mshtml/htmlwindow.c | 19 +--- dlls/mshtml/mutation.c | 2 +- dlls/mshtml/npplugin.c | 24 +-- dlls/mshtml/nsiface.idl | 333 ++++++++++++++++---------------------------- dlls/mshtml/nsio.c | 174 ++++++++++++++++------- 12 files changed, 266 insertions(+), 381 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=bf4b8691527cc518077b3…
1
0
0
0
Francois Gouget : notepad: Tweak an error message for consistency.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: 18c24345d635efa57d76c4762576d043d67760b0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=18c24345d635efa57d76c4762…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:40:28 2011 +0200 notepad: Tweak an error message for consistency. --- po/ar.po | 5 +++-- po/bg.po | 5 +++-- po/ca.po | 4 ++-- po/cs.po | 5 +++-- po/da.po | 5 +++-- po/de.po | 5 +++-- po/el.po | 4 ++-- po/en.po | 4 ++-- po/en_US.po | 8 ++++---- po/eo.po | 5 +++-- po/es.po | 5 +++-- po/fa.po | 5 +++-- po/fi.po | 5 +++-- po/fr.po | 5 +++-- po/he.po | 5 +++-- po/hi.po | 4 ++-- po/hu.po | 5 +++-- po/it.po | 5 +++-- po/ja.po | 5 +++-- po/ko.po | 5 +++-- po/lt.po | 5 +++-- po/ml.po | 4 ++-- po/nb_NO.po | 5 +++-- po/nl.po | 5 +++-- po/or.po | 4 ++-- po/pa.po | 4 ++-- po/pl.po | 5 +++-- po/pt_BR.po | 5 +++-- po/pt_PT.po | 5 +++-- po/rm.po | 4 ++-- po/ro.po | 5 +++-- po/ru.po | 5 +++-- po/sk.po | 4 ++-- po/sl.po | 5 +++-- po/sr_RS(a)cyrillic.po | 5 +++-- po/sr_RS(a)latin.po | 5 +++-- po/sv.po | 5 +++-- po/te.po | 4 ++-- po/th.po | 5 +++-- po/tr.po | 5 +++-- po/uk.po | 5 +++-- po/wa.po | 5 +++-- po/wine.pot | 4 ++-- po/zh_CN.po | 5 +++-- po/zh_TW.po | 5 +++-- programs/notepad/notepad.rc | 4 ++-- 46 files changed, 127 insertions(+), 94 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=18c24345d635efa57d76c…
1
0
0
0
Francois Gouget : shdoclc: Convert some unneeded popup menu labels to comments.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: 7ae341e2ce0908a4a2e8bfcb270e6a78749ba0f4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7ae341e2ce0908a4a2e8bfcb2…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:38:06 2011 +0200 shdoclc: Convert some unneeded popup menu labels to comments. --- dlls/shdoclc/shdoclc.rc | 24 ++++++++++---------- po/ar.po | 48 ------------------------------------------ po/bg.po | 48 ------------------------------------------ po/ca.po | 48 ------------------------------------------ po/cs.po | 48 ------------------------------------------ po/da.po | 53 ----------------------------------------------- po/de.po | 48 ------------------------------------------ po/el.po | 48 ------------------------------------------ po/en.po | 48 ------------------------------------------ po/en_US.po | 48 ------------------------------------------ po/eo.po | 48 ------------------------------------------ po/es.po | 53 ----------------------------------------------- po/fa.po | 48 ------------------------------------------ po/fi.po | 53 ----------------------------------------------- po/fr.po | 48 ------------------------------------------ po/he.po | 48 ------------------------------------------ po/hi.po | 48 ------------------------------------------ po/hu.po | 48 ------------------------------------------ po/it.po | 48 ------------------------------------------ po/ja.po | 48 ------------------------------------------ po/ko.po | 48 ------------------------------------------ po/lt.po | 48 ------------------------------------------ po/ml.po | 48 ------------------------------------------ po/nb_NO.po | 48 ------------------------------------------ po/nl.po | 48 ------------------------------------------ po/or.po | 48 ------------------------------------------ po/pa.po | 48 ------------------------------------------ po/pl.po | 48 ------------------------------------------ po/pt_BR.po | 48 ------------------------------------------ po/pt_PT.po | 53 ----------------------------------------------- po/rm.po | 48 ------------------------------------------ po/ro.po | 48 ------------------------------------------ po/ru.po | 48 ------------------------------------------ po/sk.po | 48 ------------------------------------------ po/sl.po | 48 ------------------------------------------ po/sr_RS(a)cyrillic.po | 48 ------------------------------------------ po/sr_RS(a)latin.po | 53 ----------------------------------------------- po/sv.po | 48 ------------------------------------------ po/te.po | 48 ------------------------------------------ po/th.po | 48 ------------------------------------------ po/tr.po | 48 ------------------------------------------ po/uk.po | 48 ------------------------------------------ po/wa.po | 48 ------------------------------------------ po/wine.pot | 48 ------------------------------------------ po/zh_CN.po | 48 ------------------------------------------ po/zh_TW.po | 48 ------------------------------------------ 46 files changed, 12 insertions(+), 2197 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=7ae341e2ce0908a4a2e8b…
1
0
0
0
Francois Gouget : hhctrl.ocx: Convert an unneeded popup menu label to a comment.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: d7746d7fc818f9b5bbbb749e1ebf2498c45a1557 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d7746d7fc818f9b5bbbb749e1…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:37:09 2011 +0200 hhctrl.ocx: Convert an unneeded popup menu label to a comment. --- dlls/hhctrl.ocx/hhctrl.rc | 2 +- po/ar.po | 8 ++++---- po/bg.po | 8 ++++---- po/ca.po | 8 ++++---- po/cs.po | 8 ++++---- po/da.po | 18 +++++++++--------- po/de.po | 8 ++++---- po/el.po | 8 ++++---- po/en.po | 8 ++++---- po/en_US.po | 8 ++++---- po/eo.po | 8 ++++---- po/es.po | 8 ++++---- po/fa.po | 8 ++++---- po/fi.po | 8 ++++---- po/fr.po | 8 ++++---- po/he.po | 8 ++++---- po/hi.po | 8 ++++---- po/hu.po | 8 ++++---- po/it.po | 8 ++++---- po/ja.po | 8 ++++---- po/ko.po | 8 ++++---- po/lt.po | 8 ++++---- po/ml.po | 8 ++++---- po/nb_NO.po | 18 +++++++++--------- po/nl.po | 8 ++++---- po/or.po | 8 ++++---- po/pa.po | 8 ++++---- po/pl.po | 8 ++++---- po/pt_BR.po | 8 ++++---- po/pt_PT.po | 8 ++++---- po/rm.po | 10 +++++----- po/ro.po | 8 ++++---- po/ru.po | 8 ++++---- po/sk.po | 8 ++++---- po/sl.po | 8 ++++---- po/sr_RS(a)cyrillic.po | 8 ++++---- po/sr_RS(a)latin.po | 8 ++++---- po/sv.po | 8 ++++---- po/te.po | 8 ++++---- po/th.po | 8 ++++---- po/tr.po | 8 ++++---- po/uk.po | 8 ++++---- po/wa.po | 8 ++++---- po/wine.pot | 8 ++++---- po/zh_CN.po | 8 ++++---- po/zh_TW.po | 8 ++++---- 46 files changed, 192 insertions(+), 192 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=d7746d7fc818f9b5bbbb7…
1
0
0
0
Francois Gouget : oleview: Replace the CLSCTX_XXX strings with proper English sentences.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: b1d171262ffd2456f5a490906932684ef1c437b5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b1d171262ffd2456f5a490906…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:33:45 2011 +0200 oleview: Replace the CLSCTX_XXX strings with proper English sentences. --- po/ar.po | 16 ++++++++-------- po/bg.po | 22 ++++++++++++---------- po/ca.po | 16 ++++++++-------- po/cs.po | 22 ++++++++++++---------- po/da.po | 34 +++++++++++++++++++--------------- po/de.po | 34 +++++++++++++++++++--------------- po/el.po | 19 ++++++++++--------- po/en.po | 20 ++++++++++---------- po/en_US.po | 32 ++++++++++++++++---------------- po/eo.po | 22 ++++++++++++---------- po/es.po | 22 ++++++++++++---------- po/fa.po | 16 ++++++++-------- po/fi.po | 22 ++++++++++++---------- po/fr.po | 34 +++++++++++++++++++--------------- po/he.po | 34 +++++++++++++++++++--------------- po/hi.po | 16 ++++++++-------- po/hu.po | 22 ++++++++++++---------- po/it.po | 34 +++++++++++++++++++--------------- po/ja.po | 34 +++++++++++++++++++--------------- po/ko.po | 34 +++++++++++++++++++--------------- po/lt.po | 34 +++++++++++++++++++--------------- po/ml.po | 16 ++++++++-------- po/nb_NO.po | 34 +++++++++++++++++++--------------- po/nl.po | 34 +++++++++++++++++++--------------- po/or.po | 16 ++++++++-------- po/pa.po | 16 ++++++++-------- po/pl.po | 34 +++++++++++++++++++--------------- po/pt_BR.po | 34 +++++++++++++++++++--------------- po/pt_PT.po | 34 +++++++++++++++++++--------------- po/rm.po | 19 ++++++++++--------- po/ro.po | 34 +++++++++++++++++++--------------- po/ru.po | 34 +++++++++++++++++++--------------- po/sk.po | 22 ++++++++++++---------- po/sl.po | 34 +++++++++++++++++++--------------- po/sr_RS(a)cyrillic.po | 22 ++++++++++++---------- po/sr_RS(a)latin.po | 22 ++++++++++++---------- po/sv.po | 34 +++++++++++++++++++--------------- po/te.po | 16 ++++++++-------- po/th.po | 19 ++++++++++--------- po/tr.po | 22 ++++++++++++---------- po/uk.po | 34 +++++++++++++++++++--------------- po/wa.po | 19 ++++++++++--------- po/wine.pot | 16 ++++++++-------- po/zh_CN.po | 34 +++++++++++++++++++--------------- po/zh_TW.po | 34 +++++++++++++++++++--------------- programs/oleview/oleview.rc | 16 ++++++++-------- 46 files changed, 646 insertions(+), 542 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=b1d171262ffd2456f5a49…
1
0
0
0
Francois Gouget : po: A few French translation fixes.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: 52d067e3e384cfd1a8c5007760dd0f6f5ea8e569 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=52d067e3e384cfd1a8c500776…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:19:32 2011 +0200 po: A few French translation fixes. --- po/fr.po | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/po/fr.po b/po/fr.po index fa666f9..83f2547 100644 --- a/po/fr.po +++ b/po/fr.po @@ -8746,7 +8746,7 @@ msgstr "%s %s %s Ressources ouvertes : %lu\n" #: net.rc:45 msgid "OK" -msgstr "" +msgstr "OK" #: net.rc:46 msgid "Paused" @@ -8754,15 +8754,15 @@ msgstr "En pause" #: net.rc:47 msgid "Disconnected" -msgstr "Déconnecté\n" +msgstr "Déconnecté" #: net.rc:48 msgid "A network error occurred" -msgstr "Une erreur réseau s'est produite." +msgstr "Une erreur réseau s'est produite" #: net.rc:49 msgid "Connection is being made" -msgstr "Connexion en cours\n" +msgstr "Connexion en cours" #: net.rc:50 msgid "Reconnecting" @@ -9059,11 +9059,11 @@ msgstr "OleView" #: oleview.rc:98 msgid "ITypeLib viewer" -msgstr "Visionneur d'ITypeLib" +msgstr "Visionneuse d'ITypeLib" #: oleview.rc:96 msgid "OleView - OLE/COM Object Viewer" -msgstr "OleView - Visionneur d'objets OLE/COM" +msgstr "OleView - Visionneuse d'objets OLE/COM" #: oleview.rc:97 msgid "version 1.0" @@ -9114,7 +9114,7 @@ msgstr "" #: oleview.rc:112 msgid "Display the viewer for the selected item" -msgstr "Afficher le visionneur pour l'élément sélectionné" +msgstr "Afficher la visionneuse pour l'élément sélectionné" #: oleview.rc:117 msgid "Toggle between expert and novice display mode"
1
0
0
0
Francois Gouget : wmc: Remove a stray reference to wrc in the man page.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: 97ef93ac33b078274d32933f3281ad80c41af567 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=97ef93ac33b078274d32933f3…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:26:36 2011 +0200 wmc: Remove a stray reference to wrc in the man page. --- tools/wmc/wmc.man.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/wmc/wmc.man.in b/tools/wmc/wmc.man.in index 74542a5..a135145 100644 --- a/tools/wmc/wmc.man.in +++ b/tools/wmc/wmc.man.in @@ -1,7 +1,7 @@ .\" -*- nroff -*- .TH WMC 1 "October 2005" "@PACKAGE_STRING@" "Wine Developers Manual" .SH NAME -wrc \- Wine Message Compiler +wmc \- Wine Message Compiler .SH SYNOPSIS .BI "wmc " "[options] " "[inputfile]" .SH DESCRIPTION
1
0
0
0
Francois Gouget : wineps.drv: Make PSDRV_WriteRGB() static.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: 3704821417337a9bc3a6378fbf32e91e79afebb5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3704821417337a9bc3a6378fb…
Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Aug 23 14:11:37 2011 +0200 wineps.drv: Make PSDRV_WriteRGB() static. --- dlls/wineps.drv/ps.c | 2 +- dlls/wineps.drv/psdrv.h | 1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/wineps.drv/ps.c b/dlls/wineps.drv/ps.c index ab9d570..09b02ef 100644 --- a/dlls/wineps.drv/ps.c +++ b/dlls/wineps.drv/ps.c @@ -655,7 +655,7 @@ BOOL PSDRV_WriteIndexColorSpaceEnd(PHYSDEV dev) return PSDRV_WriteSpool(dev, buf, sizeof(buf) - 1); } -BOOL PSDRV_WriteRGB(PHYSDEV dev, COLORREF *map, int number) +static BOOL PSDRV_WriteRGB(PHYSDEV dev, COLORREF *map, int number) { char *buf = HeapAlloc(PSDRV_Heap, 0, number * 7 + 1), *ptr; int i; diff --git a/dlls/wineps.drv/psdrv.h b/dlls/wineps.drv/psdrv.h index 7b8185f..f4bb17d 100644 --- a/dlls/wineps.drv/psdrv.h +++ b/dlls/wineps.drv/psdrv.h @@ -519,7 +519,6 @@ extern BOOL PSDRV_WriteHatch(PHYSDEV dev) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteRotate(PHYSDEV dev, float ang) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteIndexColorSpaceBegin(PHYSDEV dev, int size) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteIndexColorSpaceEnd(PHYSDEV dev) DECLSPEC_HIDDEN; -extern BOOL PSDRV_WriteRGB(PHYSDEV dev, COLORREF *map, int number) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteRGBQUAD(PHYSDEV dev, const RGBQUAD *rgb, int number) DECLSPEC_HIDDEN; extern BOOL PSDRV_WriteImage(PHYSDEV dev, WORD depth, INT xDst, INT yDst, INT widthDst, INT heightDst, INT widthSrc,
1
0
0
0
Hans Leidekker : msi/tests: Clean up local packages.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: fabfc5da78d27087abb75b21c544d78fdbdeb841 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fabfc5da78d27087abb75b21c…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Aug 23 14:42:38 2011 +0200 msi/tests: Clean up local packages. --- dlls/msi/tests/automation.c | 7 ++++++- dlls/msi/tests/install.c | 30 ++++++++++++++++++++++++------ 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/dlls/msi/tests/automation.c b/dlls/msi/tests/automation.c index fff068f..3bbc037 100644 --- a/dlls/msi/tests/automation.c +++ b/dlls/msi/tests/automation.c @@ -47,6 +47,7 @@ static const WCHAR szUpgradeCode[] = { '{','C','E','0','6','7','E','8','D','-',' static const WCHAR szProductInfoException[] = { 'P','r','o','d','u','c','t','I','n','f','o',',','P','r','o','d','u','c','t',',','A','t','t','r','i','b','u','t','e',0 }; static const WCHAR WINE_INSTALLPROPERTY_PACKAGENAMEW[] = {'P','a','c','k','a','g','e','N','a','m','e',0}; static const WCHAR WINE_INSTALLPROPERTY_PRODUCTNAMEW[] = {'P','r','o','d','u','c','t','N','a','m','e',0}; +static const WCHAR WINE_INSTALLPROPERTY_LOCALPACKAGEW[] = {'L','o','c','a','l','P','a','c','k','a','g','e',0}; static FILETIME systemtime; static CHAR CURR_DIR[MAX_PATH]; static EXCEPINFO excepinfo; @@ -2485,6 +2486,10 @@ static void test_Installer_InstallProduct(void) IDispatch_Release(pStringList); } + hr = Installer_ProductInfo(szProductCode, WINE_INSTALLPROPERTY_LOCALPACKAGEW, szString); + ok(hr == S_OK, "Installer_ProductInfo failed, hresult 0x%08x\n", hr); + DeleteFileW( szString ); + /* Check & clean up installed files & registry keys */ ok(delete_pf("msitest\\cabout\\new\\five.txt", TRUE), "File not installed\n"); ok(delete_pf("msitest\\cabout\\new", FALSE), "File not installed\n"); @@ -2563,7 +2568,7 @@ static void test_Installer_InstallProduct(void) RegCloseKey(hkey); - /* Delete installation files we installed */ + /* Delete installation files we created */ delete_test_files(); } diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index a870353..3417d9a 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -4754,7 +4754,7 @@ static void test_MsiConfigureProductEx(void) LONG res; DWORD type, size; HKEY props, source; - CHAR keypath[MAX_PATH * 2], localpack[MAX_PATH]; + CHAR keypath[MAX_PATH * 2], localpackage[MAX_PATH], packagename[MAX_PATH]; REGSAM access = KEY_ALL_ACCESS; if (is_process_limited()) @@ -4886,7 +4886,7 @@ static void test_MsiConfigureProductEx(void) DeleteFileA(msifile); - /* local msifile is removed */ + /* msifile is removed */ r = MsiConfigureProductExA("{7DF88A48-996F-4EC8-A022-BF956F9B2CBB}", INSTALLLEVEL_DEFAULT, INSTALLSTATE_ABSENT, "PROPVAR=42"); @@ -4915,6 +4915,12 @@ static void test_MsiConfigureProductEx(void) res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, keypath, 0, access, &props); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); + type = REG_SZ; + size = MAX_PATH; + res = RegQueryValueExA(props, "LocalPackage", NULL, &type, + (LPBYTE)localpackage, &size); + ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); + res = RegSetValueExA(props, "LocalPackage", 0, REG_SZ, (const BYTE *)"C:\\idontexist.msi", 18); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); @@ -4933,7 +4939,7 @@ static void test_MsiConfigureProductEx(void) RegCloseKey(props); create_database(msifile, mcp_tables, sizeof(mcp_tables) / sizeof(msi_table)); - /* LastUsedSource (local msi package) can be used as a last resort */ + /* LastUsedSource can be used as a last resort */ r = MsiConfigureProductExA("{7DF88A48-996F-4EC8-A022-BF956F9B2CBB}", INSTALLLEVEL_DEFAULT, INSTALLSTATE_ABSENT, "PROPVAR=42"); @@ -4942,6 +4948,7 @@ static void test_MsiConfigureProductEx(void) ok(!delete_pf("msitest\\helium", TRUE), "File not removed\n"); ok(!delete_pf("msitest\\lithium", TRUE), "File not removed\n"); ok(!delete_pf("msitest", FALSE), "Directory not removed\n"); + DeleteFileA( localpackage ); /* install the product, machine */ r = MsiInstallProductA(msifile, "ALLUSERS=1 INSTALLLEVEL=10 PROPVAR=42"); @@ -4958,6 +4965,12 @@ static void test_MsiConfigureProductEx(void) res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, keypath, 0, access, &props); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); + type = REG_SZ; + size = MAX_PATH; + res = RegQueryValueExA(props, "LocalPackage", NULL, &type, + (LPBYTE)localpackage, &size); + ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); + res = RegSetValueExA(props, "LocalPackage", 0, REG_SZ, (const BYTE *)"C:\\idontexist.msi", 18); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); @@ -4971,7 +4984,7 @@ static void test_MsiConfigureProductEx(void) type = REG_SZ; size = MAX_PATH; res = RegQueryValueExA(source, "PackageName", NULL, &type, - (LPBYTE)localpack, &size); + (LPBYTE)packagename, &size); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); res = RegSetValueExA(source, "PackageName", 0, REG_SZ, @@ -4989,9 +5002,14 @@ static void test_MsiConfigureProductEx(void) ok(pf_exists("msitest\\lithium"), "File not installed\n"); ok(pf_exists("msitest"), "File not installed\n"); - /* restore the SourceList */ + /* restore PackageName */ res = RegSetValueExA(source, "PackageName", 0, REG_SZ, - (const BYTE *)localpack, lstrlenA(localpack) + 1); + (const BYTE *)packagename, lstrlenA(packagename) + 1); + ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); + + /* restore LocalPackage */ + res = RegSetValueExA(props, "LocalPackage", 0, REG_SZ, + (const BYTE *)localpackage, lstrlenA(localpackage) + 1); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); /* finally remove the product */
1
0
0
0
Hans Leidekker : msi: Remove icons when the product is uninstalled.
by Alexandre Julliard
23 Aug '11
23 Aug '11
Module: wine Branch: master Commit: eb7ae99ddbbcb181248a5a3aa459fe064e8fe37d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=eb7ae99ddbbcb181248a5a3aa…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Aug 23 14:42:27 2011 +0200 msi: Remove icons when the product is uninstalled. --- dlls/msi/action.c | 41 +++++++++++++++++++++++++++++++++++++++++ dlls/msi/tests/install.c | 2 ++ 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 71f4f6a..d008777 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -4896,6 +4896,45 @@ static UINT ACTION_InstallExecute(MSIPACKAGE *package) return execute_script(package,INSTALL_SCRIPT); } +static UINT ITERATE_UnpublishIcon( MSIRECORD *row, LPVOID param ) +{ + MSIPACKAGE *package = param; + const WCHAR *icon = MSI_RecordGetString( row, 1 ); + WCHAR *p, *icon_path; + + if (!icon) return ERROR_SUCCESS; + if ((icon_path = msi_build_icon_path( package, icon ))) + { + TRACE("removing icon file %s\n", debugstr_w(icon_path)); + DeleteFileW( icon_path ); + if ((p = strrchrW( icon_path, '\\' ))) + { + *p = 0; + RemoveDirectoryW( icon_path ); + } + msi_free( icon_path ); + } + return ERROR_SUCCESS; +} + +static UINT msi_unpublish_icons( MSIPACKAGE *package ) +{ + static const WCHAR query[]= { + 'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ','`','I','c','o','n','`',0}; + MSIQUERY *view; + UINT r; + + r = MSI_DatabaseOpenViewW( package->db, query, &view ); + if (r == ERROR_SUCCESS) + { + r = MSI_IterateRecords( view, NULL, ITERATE_UnpublishIcon, package ); + msiobj_release( &view->hdr ); + if (r != ERROR_SUCCESS) + return r; + } + return ERROR_SUCCESS; +} + static UINT msi_unpublish_product( MSIPACKAGE *package, const WCHAR *remove ) { static const WCHAR szUpgradeCode[] = {'U','p','g','r','a','d','e','C','o','d','e',0}; @@ -4948,6 +4987,8 @@ static UINT msi_unpublish_product( MSIPACKAGE *package, const WCHAR *remove ) } TRACE("removing local package %s\n", debugstr_w(package->localfile)); package->delete_on_close = TRUE; + + msi_unpublish_icons( package ); return ERROR_SUCCESS; } diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c index 1c550ae..a870353 100644 --- a/dlls/msi/tests/install.c +++ b/dlls/msi/tests/install.c @@ -5980,6 +5980,7 @@ static void test_icon_table(void) res = MsiInstallProductA(msifile, "REMOVE=ALL"); ok(res == ERROR_SUCCESS, "Failed to uninstall per-user\n"); + ok(!file_exists(path), "Per-user icon file not removed (%s)\n", path); /* system-wide */ res = MsiInstallProductA(msifile, "PUBLISH_PRODUCT=1 ALLUSERS=1"); @@ -5994,6 +5995,7 @@ static void test_icon_table(void) res = MsiInstallProductA(msifile, "REMOVE=ALL"); ok(res == ERROR_SUCCESS, "Failed to uninstall system-wide\n"); + ok(!file_exists(path), "System-wide icon file not removed (%s)\n", path); delete_pfmsitest_files(); DeleteFile(msifile);
1
0
0
0
← Newer
1
...
33
34
35
36
37
38
39
...
77
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
Results per page:
10
25
50
100
200