wine-commits August 2011

wine-commits@winehq.org

2 participants
770 discussions

Jacek Caban : mshtml: Added IOmNavigator::get_*Language tests.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: cdd09ba1859fc204042306387dc645d4e80b6500 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdd09ba1859fc204042306387… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jul 31 16:45:45 2011 +0200 mshtml: Added IOmNavigator::get_*Language tests. --- dlls/mshtml/tests/dom.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 08be27d..bba222f 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -34,6 +34,8 @@ #include "mshtml_test.h" #include "objsafe.h" +static INT (WINAPI *pLCIDToLocaleName)(LCID,LPWSTR,INT,DWORD); + static const char doc_blank[] = "<html></html>"; static const char doc_str1[] = "<html><body>test</body></html>"; static const char range_test_str[] = @@ -3820,6 +3822,22 @@ static void test_mime_types_col(IOmNavigator *nav) ok(!ref, "ref=%d\n", ref); } +#define test_language_string(a,b) _test_language_string(__LINE__,a,b) +static void _test_language_string(unsigned line, const WCHAR *lang, LCID lcid) +{ + WCHAR buf[64]; + int res; + + if(pLCIDToLocaleName) { + res = pLCIDToLocaleName(lcid, buf, sizeof(buf)/sizeof(WCHAR), 0); + ok_(__FILE__,line)(res, "LCIDToLocaleName failed: %u\n", GetLastError()); + ok_(__FILE__,line)(!lstrcmpW(lang, buf), "lang = %s, expected %s\n", wine_dbgstr_w(lang), wine_dbgstr_w(buf)); + }else { + win_skip("LCIDToLocaleName not available, unable to test language string\n"); + ok_(__FILE__,line)(lang != NULL, "lang == NULL\n"); + } +} + static void test_navigator(IHTMLDocument2 *doc) { IHTMLWindow2 *window; @@ -3877,6 +3895,24 @@ static void test_navigator(IHTMLDocument2 *doc) ok(!memcmp(bstr, v40, sizeof(v40)), "appVersion is %s\n", wine_dbgstr_w(bstr)); SysFreeString(bstr); + bstr = NULL; + hres = IOmNavigator_get_systemLanguage(navigator, &bstr); + ok(hres == S_OK, "get_systemLanguage failed: %08x\n", hres); + test_language_string(bstr, LOCALE_SYSTEM_DEFAULT); + SysFreeString(bstr); + + bstr = NULL; + hres = IOmNavigator_get_browserLanguage(navigator, &bstr); + ok(hres == S_OK, "get_browserLanguage failed: %08x\n", hres); + test_language_string(bstr, GetUserDefaultUILanguage()); + SysFreeString(bstr); + + bstr = NULL; + hres = IOmNavigator_get_userLanguage(navigator, &bstr); + ok(hres == S_OK, "get_userLanguage failed: %08x\n", hres); + test_language_string(bstr, LOCALE_USER_DEFAULT); + SysFreeString(bstr); + hres = IOmNavigator_toString(navigator, NULL); ok(hres == E_INVALIDARG, "toString failed: %08x\n", hres); @@ -5868,6 +5904,8 @@ static void run_domtest(const char *str, domtest_t test) START_TEST(dom) { + pLCIDToLocaleName = (void*)GetProcAddress(GetModuleHandleA("kernel32.dll"), "LCIDToLocaleName"); + CoInitialize(NULL); run_domtest(doc_str1, test_doc_elem);

1 0

Jacek Caban : mshtml: Added IOmNavigator::get_*Language implementations.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: e36d0d2e1bc817934c4fb6eb457c64524b98342d URL: http://source.winehq.org/git/wine.git/?a=commit;h=e36d0d2e1bc817934c4fb6eb4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jul 31 16:45:26 2011 +0200 mshtml: Added IOmNavigator::get_*Language implementations. --- dlls/mshtml/omnavigator.c | 44 ++++++++++++++++++++++++++++++++++++++------ 1 files changed, 38 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c index b4b5c15..73e55dd 100644 --- a/dlls/mshtml/omnavigator.c +++ b/dlls/mshtml/omnavigator.c @@ -621,25 +621,57 @@ static HRESULT WINAPI OmNavigator_get_cpuClass(IOmNavigator *iface, BSTR *p) return *p ? S_OK : E_OUTOFMEMORY; } +static HRESULT get_language_string(LCID lcid, BSTR *p) +{ + BSTR ret; + int len; + + len = LCIDToLocaleName(lcid, NULL, 0, 0); + if(!len) { + WARN("LCIDToLocaleName failed: %u\n", GetLastError()); + return E_FAIL; + } + + ret = SysAllocStringLen(NULL, len-1); + if(!ret) + return E_OUTOFMEMORY; + + len = LCIDToLocaleName(lcid, ret, len, 0); + if(!len) { + WARN("LCIDToLocaleName failed: %u\n", GetLastError()); + SysFreeString(ret); + return E_FAIL; + } + + *p = ret; + return S_OK; +} + static HRESULT WINAPI OmNavigator_get_systemLanguage(IOmNavigator *iface, BSTR *p) { OmNavigator *This = impl_from_IOmNavigator(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_language_string(LOCALE_SYSTEM_DEFAULT, p); } static HRESULT WINAPI OmNavigator_get_browserLanguage(IOmNavigator *iface, BSTR *p) { OmNavigator *This = impl_from_IOmNavigator(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_language_string(GetUserDefaultUILanguage(), p); } static HRESULT WINAPI OmNavigator_get_userLanguage(IOmNavigator *iface, BSTR *p) { OmNavigator *This = impl_from_IOmNavigator(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + return get_language_string(LOCALE_USER_DEFAULT, p); } static HRESULT WINAPI OmNavigator_get_platform(IOmNavigator *iface, BSTR *p)

1 0

Jacek Caban : mshtml: Added IHTMLPluginsCollection:: get_length implementation.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: 7d4e9f77929dbb233db6e69e593e91ecb936494e URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d4e9f77929dbb233db6e69e5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jul 31 16:45:08 2011 +0200 mshtml: Added IHTMLPluginsCollection::get_length implementation. --- dlls/mshtml/omnavigator.c | 8 ++++++-- dlls/mshtml/tests/dom.c | 20 ++++++++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c index 79db598..b4b5c15 100644 --- a/dlls/mshtml/omnavigator.c +++ b/dlls/mshtml/omnavigator.c @@ -145,8 +145,12 @@ static HRESULT WINAPI HTMLPluginsCollection_Invoke(IHTMLPluginsCollection *iface static HRESULT WINAPI HTMLPluginsCollection_get_length(IHTMLPluginsCollection *iface, LONG *p) { HTMLPluginsCollection *This = impl_from_IHTMLPluginsCollection(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + /* IE always returns 0 here */ + *p = 0; + return S_OK; } static HRESULT WINAPI HTMLPluginsCollection_refresh(IHTMLPluginsCollection *iface, VARIANT_BOOL reload) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index adffac2..08be27d 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -3760,12 +3760,19 @@ static void test_location(IHTMLDocument2 *doc) ok(!ref, "location chould be destroyed here\n"); } -static void test_plugins_col(IOmNavigator *nav) +static void test_plugins_col(IHTMLDocument2 *doc) { IHTMLPluginsCollection *col, *col2; + IHTMLWindow2 *window; + IOmNavigator *nav; ULONG ref; + LONG len; HRESULT hres; + window = get_doc_window(doc); + hres = IHTMLWindow2_get_navigator(window, &nav); + IHTMLWindow2_Release(window); + hres = IOmNavigator_get_plugins(nav, &col); ok(hres == S_OK, "get_plugins failed: %08x\n", hres); @@ -3776,8 +3783,15 @@ static void test_plugins_col(IOmNavigator *nav) test_disp2((IUnknown*)col, &DIID_DispCPlugins, &IID_IHTMLPluginsCollection, "[object]"); + len = 0xdeadbeef; + hres = IHTMLPluginsCollection_get_length(col, &len); + ok(hres == S_OK, "get_length failed: %08x\n", hres); + ok(!len, "length = %d\n", len); + ref = IHTMLPluginsCollection_Release(col); ok(!ref, "ref=%d\n", ref); + + IOmNavigator_Release(nav); } static void test_mime_types_col(IOmNavigator *nav) @@ -3892,7 +3906,6 @@ static void test_navigator(IHTMLDocument2 *doc) skip("nonstandard user agent\n"); } - test_plugins_col(navigator); test_mime_types_col(navigator); ref = IOmNavigator_Release(navigator); @@ -4263,6 +4276,7 @@ static void test_defaults(IHTMLDocument2 *doc) test_compatmode(doc); test_location(doc); test_navigator(doc); + test_plugins_col(doc); elem2 = get_elem2_iface((IUnknown*)elem); hres = IHTMLElement2_get_currentStyle(elem2, &cstyle); @@ -4653,6 +4667,8 @@ static void test_elems(IHTMLDocument2 *doc) IHTMLElementCollection_Release(collection); } + test_plugins_col(doc); + elem = get_doc_elem(doc); test_elem_all((IUnknown*)elem, all_types+1, sizeof(all_types)/sizeof(all_types[0])-1); IHTMLElement_Release(elem);

1 0

Jacek Caban : mshtml: Added semi-stub implementation of IHTMLWindow2:: status property.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: b25d49c6c16bd20371a5ea77fda477051794d162 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b25d49c6c16bd20371a5ea77f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jul 31 16:44:43 2011 +0200 mshtml: Added semi-stub implementation of IHTMLWindow2::status property. --- dlls/mshtml/htmlwindow.c | 18 ++++++++++++++---- dlls/mshtml/tests/dom.c | 27 +++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index ba292ab..465db09 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -491,15 +491,25 @@ static HRESULT WINAPI HTMLWindow2_get_defaultStatus(IHTMLWindow2 *iface, BSTR *p static HRESULT WINAPI HTMLWindow2_put_status(IHTMLWindow2 *iface, BSTR v) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); - return E_NOTIMPL; + + WARN("(%p)->(%s)\n", This, debugstr_w(v)); + + /* + * FIXME: Since IE7, setting status is blocked, but still possible in certain circumstances. + * Ignoring the call should be enough for us. + */ + return S_OK; } static HRESULT WINAPI HTMLWindow2_get_status(IHTMLWindow2 *iface, BSTR *p) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, p); + + /* See put_status */ + *p = NULL; + return S_OK; } static HRESULT WINAPI HTMLWindow2_setTimeout(IHTMLWindow2 *iface, BSTR expression, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 00fdb14..adffac2 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -1058,6 +1058,31 @@ static void _set_window_name(unsigned line, IHTMLWindow2 *window, const char *na _test_window_name(line, window, name); } +#define test_window_status(d) _test_window_status(__LINE__,d) +static void _test_window_status(unsigned line, IHTMLWindow2 *window) +{ + BSTR status; + HRESULT hres; + + status = (void*)0xdeadbeef; + hres = IHTMLWindow2_get_status(window, &status); + ok_(__FILE__,line)(hres == S_OK, "get_status failed: %08x\n", hres); + ok_(__FILE__,line)(!status, "status = %s\n", wine_dbgstr_w(status)); + SysFreeString(status); +} + +#define set_window_status(w,n) _set_window_status(__LINE__,w,n) +static void _set_window_status(unsigned line, IHTMLWindow2 *window, const char *status) +{ + BSTR str; + HRESULT hres; + + str = a2bstr(status); + hres = IHTMLWindow2_put_status(window, str); + SysFreeString(str); + ok_(__FILE__,line)(hres == S_OK, "put_status failed: %08x\n", hres); +} + #define test_window_length(w,l) _test_window_length(__LINE__,w,l) static void _test_window_length(unsigned line, IHTMLWindow2 *window, LONG exlen) { @@ -4146,6 +4171,8 @@ static void test_window(IHTMLDocument2 *doc) set_window_name(window, "test"); test_window_length(window, 0); test_screen(window); + test_window_status(window); + set_window_status(window, "Test!"); IHTMLWindow2_Release(window); }

1 0

Michael Stefaniuc : dxdiagn: Implement IClassFactory::QueryInterface.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: a84870259f20cb14762139c28615c30feb1df63f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a84870259f20cb14762139c28… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Aug 1 10:41:56 2011 +0200 dxdiagn: Implement IClassFactory::QueryInterface. --- dlls/dxdiagn/dxdiag_main.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/dlls/dxdiagn/dxdiag_main.c b/dlls/dxdiagn/dxdiag_main.c index 9cfe2ab..9f10a60 100644 --- a/dlls/dxdiagn/dxdiag_main.c +++ b/dlls/dxdiagn/dxdiag_main.c @@ -60,11 +60,22 @@ typedef struct { static HRESULT WINAPI DXDiagCF_QueryInterface(IClassFactory *iface, REFIID riid, void **ppv) { - FIXME("- no interface\n\tIID:\t%s\n", debugstr_guid(riid)); + if (ppv == NULL) + return E_POINTER; + + if (IsEqualGUID(&IID_IUnknown, riid)) + TRACE("(%p)->(IID_IUnknown %p)\n", iface, ppv); + else if (IsEqualGUID(&IID_IClassFactory, riid)) + TRACE("(%p)->(IID_IClassFactory %p)\n", iface, ppv); + else { + FIXME("(%p)->(%s %p)\n", iface, debugstr_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; + } - if (ppv == NULL) return E_POINTER; - - return E_NOINTERFACE; + *ppv = iface; + IClassFactory_AddRef(iface); + return S_OK; } static ULONG WINAPI DXDiagCF_AddRef(IClassFactory *iface)

1 0

Michael Stefaniuc : dxdiagn: COM cleanup for the IClassFactory iface.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: 08031fdc209135bcde10af0b47dae3e9c5c2423d URL: http://source.winehq.org/git/wine.git/?a=commit;h=08031fdc209135bcde10af0b4… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Aug 1 10:39:18 2011 +0200 dxdiagn: COM cleanup for the IClassFactory iface. --- dlls/dxdiagn/dxdiag_main.c | 50 +++++++++++++++++++++---------------------- 1 files changed, 24 insertions(+), 26 deletions(-) diff --git a/dlls/dxdiagn/dxdiag_main.c b/dlls/dxdiagn/dxdiag_main.c index 2d8b0ea..9cfe2ab 100644 --- a/dlls/dxdiagn/dxdiag_main.c +++ b/dlls/dxdiagn/dxdiag_main.c @@ -19,6 +19,8 @@ * */ +#define COBJMACROS + #include "config.h" #include <stdarg.h> @@ -53,39 +55,42 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpvReserved) * DXDiag ClassFactory */ typedef struct { - const IClassFactoryVtbl *lpVtbl; - REFCLSID rclsid; - HRESULT (*pfnCreateInstanceFactory)(LPCLASSFACTORY iface, LPUNKNOWN punkOuter, REFIID riid, LPVOID *ppobj); + IClassFactory IClassFactory_iface; } IClassFactoryImpl; -static HRESULT WINAPI DXDiagCF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) { +static HRESULT WINAPI DXDiagCF_QueryInterface(IClassFactory *iface, REFIID riid, void **ppv) +{ FIXME("- no interface\n\tIID:\t%s\n", debugstr_guid(riid)); - if (ppobj == NULL) return E_POINTER; + if (ppv == NULL) return E_POINTER; return E_NOINTERFACE; } -static ULONG WINAPI DXDiagCF_AddRef(LPCLASSFACTORY iface) { +static ULONG WINAPI DXDiagCF_AddRef(IClassFactory *iface) +{ DXDIAGN_LockModule(); return 2; /* non-heap based object */ } -static ULONG WINAPI DXDiagCF_Release(LPCLASSFACTORY iface) { +static ULONG WINAPI DXDiagCF_Release(IClassFactory * iface) +{ DXDIAGN_UnlockModule(); return 1; /* non-heap based object */ } -static HRESULT WINAPI DXDiagCF_CreateInstance(LPCLASSFACTORY iface,LPUNKNOWN pOuter,REFIID riid,LPVOID *ppobj) { - IClassFactoryImpl *This = (IClassFactoryImpl *)iface; - TRACE("(%p)->(%p,%s,%p)\n",This,pOuter,debugstr_guid(riid),ppobj); - - return This->pfnCreateInstanceFactory(iface, pOuter, riid, ppobj); +static HRESULT WINAPI DXDiagCF_CreateInstance(IClassFactory *iface, IUnknown *pOuter, REFIID riid, + void **ppv) +{ + TRACE("(%p)->(%p,%s,%p)\n", iface, pOuter, debugstr_guid(riid), ppv); + + return DXDiag_CreateDXDiagProvider(iface, pOuter, riid, ppv); } -static HRESULT WINAPI DXDiagCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { +static HRESULT WINAPI DXDiagCF_LockServer(IClassFactory *iface, BOOL dolock) +{ TRACE("(%d)\n", dolock); if (dolock) @@ -104,10 +109,7 @@ static const IClassFactoryVtbl DXDiagCF_Vtbl = { DXDiagCF_LockServer }; -static IClassFactoryImpl DXDiag_CFS[] = { - { &DXDiagCF_Vtbl, &CLSID_DxDiagProvider, DXDiag_CreateDXDiagProvider }, - { NULL, NULL, NULL } -}; +static IClassFactoryImpl DXDiag_CF = { { &DXDiagCF_Vtbl } }; /*********************************************************************** * DllCanUnloadNow (DXDIAGN.@) @@ -122,16 +124,12 @@ HRESULT WINAPI DllCanUnloadNow(void) */ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) { - int i = 0; - TRACE("(%s,%s,%p)\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); - while (NULL != DXDiag_CFS[i].rclsid) { - if (IsEqualGUID(rclsid, DXDiag_CFS[i].rclsid)) { - DXDiagCF_AddRef((IClassFactory*) &DXDiag_CFS[i]); - *ppv = &DXDiag_CFS[i]; - return S_OK; - } - ++i; + + if (IsEqualGUID(rclsid, &CLSID_DxDiagProvider)) { + IClassFactory_AddRef(&DXDiag_CF.IClassFactory_iface); + *ppv = &DXDiag_CF.IClassFactory_iface; + return S_OK; } FIXME("(%s,%s,%p): no interface found.\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv);

1 0

Michael Stefaniuc : devenum: COM cleanup for the IClassFactory iface.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: aa591dcd9d45bc0a50066f493092de7cdd822cf8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa591dcd9d45bc0a50066f493… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Aug 1 10:34:09 2011 +0200 devenum: COM cleanup for the IClassFactory iface. --- dlls/devenum/devenum_main.c | 2 +- dlls/devenum/devenum_private.h | 2 +- dlls/devenum/factory.c | 23 ++++++++--------------- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/dlls/devenum/devenum_main.c b/dlls/devenum/devenum_main.c index 6867fea..e19e1e0 100644 --- a/dlls/devenum/devenum_main.c +++ b/dlls/devenum/devenum_main.c @@ -75,7 +75,7 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv) * Oh well - works just fine as it is */ if (IsEqualGUID(rclsid, &CLSID_SystemDeviceEnum) || IsEqualGUID(rclsid, &CLSID_CDeviceMoniker)) - return IClassFactory_QueryInterface((IClassFactory*)&DEVENUM_ClassFactory, iid, ppv); + return IClassFactory_QueryInterface(&DEVENUM_ClassFactory.IClassFactory_iface, iid, ppv); FIXME("CLSID: %s, IID: %s\n", debugstr_guid(rclsid), debugstr_guid(iid)); return CLASS_E_CLASSNOTAVAILABLE; diff --git a/dlls/devenum/devenum_private.h b/dlls/devenum/devenum_private.h index 1363e91..7515877 100644 --- a/dlls/devenum/devenum_private.h +++ b/dlls/devenum/devenum_private.h @@ -57,7 +57,7 @@ static inline void DEVENUM_UnlockModule(void) { InterlockedDecrement(&dll_refs); */ typedef struct { - const IClassFactoryVtbl *lpVtbl; + IClassFactory IClassFactory_iface; } ClassFactoryImpl; typedef struct diff --git a/dlls/devenum/factory.c b/dlls/devenum/factory.c index 09861fa..215eb3a 100644 --- a/dlls/devenum/factory.c +++ b/dlls/devenum/factory.c @@ -28,10 +28,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(devenum); /********************************************************************** * DEVENUM_IClassFactory_QueryInterface (also IUnknown) */ -static HRESULT WINAPI DEVENUM_IClassFactory_QueryInterface( - LPCLASSFACTORY iface, - REFIID riid, - LPVOID *ppvObj) +static HRESULT WINAPI DEVENUM_IClassFactory_QueryInterface(IClassFactory *iface, REFIID riid, + void **ppvObj) { TRACE("\n\tIID:\t%s\n",debugstr_guid(riid)); @@ -56,7 +54,7 @@ static HRESULT WINAPI DEVENUM_IClassFactory_QueryInterface( /********************************************************************** * DEVENUM_IClassFactory_AddRef (also IUnknown) */ -static ULONG WINAPI DEVENUM_IClassFactory_AddRef(LPCLASSFACTORY iface) +static ULONG WINAPI DEVENUM_IClassFactory_AddRef(IClassFactory *iface) { TRACE("\n"); @@ -68,7 +66,7 @@ static ULONG WINAPI DEVENUM_IClassFactory_AddRef(LPCLASSFACTORY iface) /********************************************************************** * DEVENUM_IClassFactory_Release (also IUnknown) */ -static ULONG WINAPI DEVENUM_IClassFactory_Release(LPCLASSFACTORY iface) +static ULONG WINAPI DEVENUM_IClassFactory_Release(IClassFactory *iface) { TRACE("\n"); @@ -80,11 +78,8 @@ static ULONG WINAPI DEVENUM_IClassFactory_Release(LPCLASSFACTORY iface) /********************************************************************** * DEVENUM_IClassFactory_CreateInstance */ -static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( - LPCLASSFACTORY iface, - LPUNKNOWN pUnkOuter, - REFIID riid, - LPVOID *ppvObj) +static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance(IClassFactory *iface, + IUnknown *pUnkOuter, REFIID riid, void **ppvObj) { TRACE("\n\tIID:\t%s\n",debugstr_guid(riid)); @@ -110,9 +105,7 @@ static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( /********************************************************************** * DEVENUM_IClassFactory_LockServer */ -static HRESULT WINAPI DEVENUM_IClassFactory_LockServer( - LPCLASSFACTORY iface, - BOOL fLock) +static HRESULT WINAPI DEVENUM_IClassFactory_LockServer(IClassFactory *iface, BOOL fLock) { TRACE("\n"); @@ -138,4 +131,4 @@ static const IClassFactoryVtbl IClassFactory_Vtbl = /********************************************************************** * static ClassFactory instance */ -ClassFactoryImpl DEVENUM_ClassFactory = { &IClassFactory_Vtbl }; +ClassFactoryImpl DEVENUM_ClassFactory = { { &IClassFactory_Vtbl } };

1 0

Michael Stefaniuc : dmband: Merge the IClassFactory implementations.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: 2cfc711a6827d194b029a1051cafe26c74ed8685 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2cfc711a6827d194b029a1051… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Aug 1 10:31:49 2011 +0200 dmband: Merge the IClassFactory implementations. --- dlls/dmband/dmband_main.c | 135 ++++++++++++++++++--------------------------- 1 files changed, 54 insertions(+), 81 deletions(-) diff --git a/dlls/dmband/dmband_main.c b/dlls/dmband/dmband_main.c index b4863a3..e727ea6 100644 --- a/dlls/dmband/dmband_main.c +++ b/dlls/dmband/dmband_main.c @@ -26,111 +26,84 @@ static HINSTANCE instance; LONG DMBAND_refCount = 0; typedef struct { - const IClassFactoryVtbl *lpVtbl; + IClassFactory IClassFactory_iface; + HRESULT WINAPI (*fnCreateInstance)(REFIID riid, void **ppv, IUnknown *pUnkOuter); } IClassFactoryImpl; /****************************************************************** - * DirectMusicBand ClassFactory + * IClassFactory implementation */ - -static HRESULT WINAPI BandCF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) { - FIXME("- no interface IID: %s\n", debugstr_guid(riid)); - - if (ppobj == NULL) return E_POINTER; - - return E_NOINTERFACE; -} - -static ULONG WINAPI BandCF_AddRef(LPCLASSFACTORY iface) { - DMBAND_LockModule(); - - return 2; /* non-heap based object */ -} - -static ULONG WINAPI BandCF_Release(LPCLASSFACTORY iface) { - DMBAND_UnlockModule(); - - return 1; /* non-heap based object */ +static inline IClassFactoryImpl *impl_from_IClassFactory(IClassFactory *iface) +{ + return CONTAINING_RECORD(iface, IClassFactoryImpl, IClassFactory_iface); } -static HRESULT WINAPI BandCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, REFIID riid, LPVOID *ppobj) { - TRACE ("(%p, %s, %p)\n", pOuter, debugstr_dmguid(riid), ppobj); - - return DMUSIC_CreateDirectMusicBandImpl (riid, ppobj, pOuter); +static HRESULT WINAPI ClassFactory_QueryInterface(IClassFactory *iface, REFIID riid, void **ppv) +{ + if (ppv == NULL) + return E_POINTER; + + if (IsEqualGUID(&IID_IUnknown, riid)) + TRACE("(%p)->(IID_IUnknown %p)\n", iface, ppv); + else if (IsEqualGUID(&IID_IClassFactory, riid)) + TRACE("(%p)->(IID_IClassFactory %p)\n", iface, ppv); + else { + FIXME("(%p)->(%s %p)\n", iface, debugstr_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; + } + + *ppv = iface; + IClassFactory_AddRef(iface); + return S_OK; } -static HRESULT WINAPI BandCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { - TRACE("(%d)\n", dolock); +static ULONG WINAPI ClassFactory_AddRef(IClassFactory *iface) +{ + DMBAND_LockModule(); - if (dolock) - DMBAND_LockModule(); - else - DMBAND_UnlockModule(); - - return S_OK; + return 2; /* non-heap based object */ } -static const IClassFactoryVtbl BandCF_Vtbl = { - BandCF_QueryInterface, - BandCF_AddRef, - BandCF_Release, - BandCF_CreateInstance, - BandCF_LockServer -}; - -static IClassFactoryImpl Band_CF = {&BandCF_Vtbl}; - - -/****************************************************************** - * DirectMusicBandTrack ClassFactory - */ - -static HRESULT WINAPI BandTrackCF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) { - FIXME("- no interface IID: %s\n", debugstr_guid(riid)); - - if (ppobj == NULL) return E_POINTER; +static ULONG WINAPI ClassFactory_Release(IClassFactory *iface) +{ + DMBAND_UnlockModule(); - return E_NOINTERFACE; + return 1; /* non-heap based object */ } -static ULONG WINAPI BandTrackCF_AddRef(LPCLASSFACTORY iface) { - DMBAND_LockModule(); - - return 2; /* non-heap based object */ -} +static HRESULT WINAPI ClassFactory_CreateInstance(IClassFactory *iface, IUnknown *pUnkOuter, + REFIID riid, void **ppv) +{ + IClassFactoryImpl *This = impl_from_IClassFactory(iface); -static ULONG WINAPI BandTrackCF_Release(LPCLASSFACTORY iface) { - DMBAND_UnlockModule(); + TRACE ("(%p, %s, %p)\n", pUnkOuter, debugstr_dmguid(riid), ppv); - return 1; /* non-heap based object */ + return This->fnCreateInstance(riid, ppv, pUnkOuter); } -static HRESULT WINAPI BandTrackCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, REFIID riid, LPVOID *ppobj) { - TRACE ("(%p, %s, %p)\n", pOuter, debugstr_dmguid(riid), ppobj); - - return DMUSIC_CreateDirectMusicBandTrack (riid, ppobj, pOuter); -} +static HRESULT WINAPI ClassFactory_LockServer(IClassFactory *iface, BOOL dolock) +{ + TRACE("(%d)\n", dolock); -static HRESULT WINAPI BandTrackCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { - TRACE("(%d)\n", dolock); + if (dolock) + DMBAND_LockModule(); + else + DMBAND_UnlockModule(); - if (dolock) - DMBAND_LockModule(); - else - DMBAND_UnlockModule(); - - return S_OK; + return S_OK; } -static const IClassFactoryVtbl BandTrackCF_Vtbl = { - BandTrackCF_QueryInterface, - BandTrackCF_AddRef, - BandTrackCF_Release, - BandTrackCF_CreateInstance, - BandTrackCF_LockServer +static const IClassFactoryVtbl classfactory_vtbl = { + ClassFactory_QueryInterface, + ClassFactory_AddRef, + ClassFactory_Release, + ClassFactory_CreateInstance, + ClassFactory_LockServer }; -static IClassFactoryImpl BandTrack_CF = {&BandTrackCF_Vtbl}; +static IClassFactoryImpl Band_CF = {{&classfactory_vtbl}, DMUSIC_CreateDirectMusicBandImpl}; +static IClassFactoryImpl BandTrack_CF = {{&classfactory_vtbl}, DMUSIC_CreateDirectMusicBandTrack}; /****************************************************************** * DllMain

1 0

Andrew Talbot : riched20: Declare some variables unsigned.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: faa05713ad4cb299b8d2c35337d5513a54a36d55 URL: http://source.winehq.org/git/wine.git/?a=commit;h=faa05713ad4cb299b8d2c3533… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sun Jul 31 21:13:13 2011 +0100 riched20: Declare some variables unsigned. --- dlls/riched20/run.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/riched20/run.c b/dlls/riched20/run.c index 3682d13..4a9ae7a 100644 --- a/dlls/riched20/run.c +++ b/dlls/riched20/run.c @@ -894,8 +894,8 @@ void ME_GetCharFormat(ME_TextEditor *editor, const ME_Cursor *from, do { /* FIXME add more style feature comparisons */ - int nAttribs = CFM_SIZE | CFM_FACE | CFM_COLOR | CFM_UNDERLINETYPE; - int nEffects = CFM_BOLD | CFM_ITALIC | CFM_UNDERLINE | CFM_STRIKEOUT | CFM_PROTECTED | CFM_LINK | CFM_SUPERSCRIPT; + DWORD dwAttribs = CFM_SIZE | CFM_FACE | CFM_COLOR | CFM_UNDERLINETYPE; + DWORD dwEffects = CFM_BOLD | CFM_ITALIC | CFM_UNDERLINE | CFM_STRIKEOUT | CFM_PROTECTED | CFM_LINK | CFM_SUPERSCRIPT; run = ME_FindItemFwd(run, diRun); @@ -903,7 +903,7 @@ void ME_GetCharFormat(ME_TextEditor *editor, const ME_Cursor *from, tmp.cbSize = sizeof(tmp); ME_GetRunCharFormat(editor, run, &tmp); - assert((tmp.dwMask & nAttribs) == nAttribs); + assert((tmp.dwMask & dwAttribs) == dwAttribs); /* reset flags that differ */ if (pFmt->yHeight != tmp.yHeight) @@ -929,7 +929,7 @@ void ME_GetCharFormat(ME_TextEditor *editor, const ME_Cursor *from, } } - pFmt->dwMask &= ~((pFmt->dwEffects ^ tmp.dwEffects) & nEffects); + pFmt->dwMask &= ~((pFmt->dwEffects ^ tmp.dwEffects) & dwEffects); pFmt->dwEffects = tmp.dwEffects; } while(run != run_end);

1 0

Andrew Talbot : mscms: Move a misplaced brace.
by Alexandre Julliard 01 Aug '11

01 Aug '11

Module: wine Branch: master Commit: 322f3037677198b66cc87e790beeceded246023f URL: http://source.winehq.org/git/wine.git/?a=commit;h=322f3037677198b66cc87e790… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sun Jul 31 21:13:08 2011 +0100 mscms: Move a misplaced brace. --- dlls/mscms/profile.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mscms/profile.c b/dlls/mscms/profile.c index c9a5b42..49fc24b 100644 --- a/dlls/mscms/profile.c +++ b/dlls/mscms/profile.c @@ -660,9 +660,9 @@ BOOL WINAPI GetStandardColorSpaceProfileW( PCWSTR machine, DWORD id, PWSTR profi GetColorDirectoryW( machine, rgbprofile, &len ); switch (id) + { case LCS_sRGB: case LCS_WINDOWS_COLOR_SPACE: /* FIXME */ - { lstrcatW( rgbprofile, rgbprofilefile ); len = lstrlenW( rgbprofile ) * sizeof(WCHAR);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2011