wine-commits February 2017

wine-commits@winehq.org

2 participants
838 discussions

Francois Gouget : browseui: Add __WINE_ALLOC_SIZE attributes to heap_xxx() functions.
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 9f0e5bf4b850aea53d50c27415e4c836771e8558 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9f0e5bf4b850aea53d50c2741… Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Feb 10 16:44:00 2017 +0100 browseui: Add __WINE_ALLOC_SIZE attributes to heap_xxx() functions. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/browseui/browseui.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/browseui/browseui.h b/dlls/browseui/browseui.h index e03f47f..27691a1 100644 --- a/dlls/browseui/browseui.h +++ b/dlls/browseui/browseui.h @@ -31,19 +31,20 @@ extern HRESULT ACLShellSource_Constructor(IUnknown *punkOuter, IUnknown **ppOut) extern const GUID CLSID_CompCatCacheDaemon; -static inline void *heap_alloc(size_t size) +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc(size_t size) { return HeapAlloc(GetProcessHeap(), 0, size); } -static inline void *heap_alloc_zero(size_t size) +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(size_t size) { return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); } -static inline void *heap_realloc(void *mem, size_t size) +static inline void* __WINE_ALLOC_SIZE(2) heap_realloc(void *mem, size_t size) { - return mem ? HeapReAlloc(GetProcessHeap(), 0, mem, size) : heap_alloc(size); + if (!mem) return heap_alloc(size); + return HeapReAlloc(GetProcessHeap(), 0, mem, size); } static inline BOOL heap_free(void *mem)

1 0

Francois Gouget : advpack: Add a __WINE_ALLOC_SIZE attribute to heap_alloc ().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 2ed059a46971db9fe097dab9db5584eb1b927350 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ed059a46971db9fe097dab9d… Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Feb 10 16:40:56 2017 +0100 advpack: Add a __WINE_ALLOC_SIZE attribute to heap_alloc(). And standardize its parameter name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advpack/advpack_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advpack/advpack_private.h b/dlls/advpack/advpack_private.h index 205cc60..252974f 100644 --- a/dlls/advpack/advpack_private.h +++ b/dlls/advpack/advpack_private.h @@ -27,9 +27,9 @@ void set_ldids(HINF hInf, LPCWSTR pszInstallSection, LPCWSTR pszWorkingDir) DECL HRESULT launch_exe(LPCWSTR cmd, LPCWSTR dir, HANDLE *phEXE) DECLSPEC_HIDDEN; -static inline void *heap_alloc(size_t len) +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc(size_t size) { - return HeapAlloc(GetProcessHeap(), 0, len); + return HeapAlloc(GetProcessHeap(), 0, size); } static inline BOOL heap_free(void *mem)

1 0

Francois Gouget : wininet/tests: A spelling fix in an ok() message.
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 8f669b63a6848cb348301577ea75edc3428e4877 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f669b63a6848cb348301577e… Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Feb 10 16:40:43 2017 +0100 wininet/tests: A spelling fix in an ok() message. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wininet/tests/internet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c index 5408af8..9b32117 100644 --- a/dlls/wininet/tests/internet.c +++ b/dlls/wininet/tests/internet.c @@ -1187,7 +1187,7 @@ static void test_end_browser_session(void) ok(len != 0, "len = 0\n"); ret = InternetSetOptionA(NULL, INTERNET_OPTION_END_BROWSER_SESSION, NULL, 0); - ok(ret, "InternetSetOptio(INTERNET_OPTION_END_BROWSER_SESSION) failed: %u\n", GetLastError()); + ok(ret, "InternetSetOption(INTERNET_OPTION_END_BROWSER_SESSION) failed: %u\n", GetLastError()); len = 1024; ret = InternetGetCookieA("http://www.example.com/test_end", NULL, NULL, &len);

1 0

Francois Gouget : winetest: Explain why the source filename is printed.
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 548b650e8a4c389ede63b28fd9d4875602439104 URL: http://source.winehq.org/git/wine.git/?a=commit;h=548b650e8a4c389ede63b28fd… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Feb 10 16:40:18 2017 +0100 winetest: Explain why the source filename is printed. It is used by analysis tools like test.winehq.org to link to the relevant test source file. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winetest/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 3b2342a..4d1fa28 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -773,6 +773,7 @@ get_subtests (const char *tempdir, struct wine_test *test, LPSTR res_name) static void run_test (struct wine_test* test, const char* subtest, HANDLE out_file, const char *tempdir) { + /* Build the source filename so analysis tools can link to it */ const char* file = get_test_source_file(test->name, subtest); if (test_filtered_out( test->name, subtest ))

1 0

Francois Gouget : winetest: There is no special directory anymore.
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 8e14f1f79a157028ccb332f1aea5b2b5f8885869 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8e14f1f79a157028ccb332f1a… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Feb 10 16:39:32 2017 +0100 winetest: There is no special directory anymore. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winetest/main.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 48b71c5..3b2342a 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -514,11 +514,8 @@ static void remove_dir (const char *dir) static const char* get_test_source_file(const char* test, const char* subtest) { - static const char* special_dirs[][2] = { - { 0, 0 } - }; static char buffer[MAX_PATH]; - int i, len = strlen(test); + int len = strlen(test); if (len > 4 && !strcmp( test + len - 4, ".exe" )) { @@ -527,14 +524,6 @@ static const char* get_test_source_file(const char* test, const char* subtest) } else len = sprintf(buffer, "dlls/%s", test); - for (i = 0; special_dirs[i][0]; i++) { - if (strcmp(test, special_dirs[i][0]) == 0) { - strcpy( buffer, special_dirs[i][1] ); - len = strlen(buffer); - break; - } - } - sprintf(buffer + len, "/tests/%s.c", subtest); return buffer; }

1 0

Henri Verbeet : wined3d: Disable sRGB decode in swapchain_blit().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 1401f91307b6cd70f77be7a8407574d0f541d11b URL: http://source.winehq.org/git/wine.git/?a=commit;h=1401f91307b6cd70f77be7a84… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Feb 10 13:58:59 2017 +0100 wined3d: Disable sRGB decode in swapchain_blit(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/swapchain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 56646e7..dfb62c8 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -387,6 +387,9 @@ static void swapchain_blit(const struct wined3d_swapchain *swapchain, device->blitter->set_shader(device->blit_priv, context2, back_buffer, NULL); gl_info->gl_ops.gl.p_glTexParameteri(back_buffer->texture_target, GL_TEXTURE_MIN_FILTER, gl_filter); gl_info->gl_ops.gl.p_glTexParameteri(back_buffer->texture_target, GL_TEXTURE_MAG_FILTER, gl_filter); + if (gl_info->supported[EXT_TEXTURE_SRGB_DECODE]) + gl_info->gl_ops.gl.p_glTexParameteri(back_buffer->texture_target, + GL_TEXTURE_SRGB_DECODE_EXT, GL_SKIP_DECODE_EXT); context_set_draw_buffer(context, GL_BACK);

1 0

Henri Verbeet : ddraw: Implement GetSurfaceFromDC().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: ebcf5196fc150b6ed4bf4891d3f5b0ebe08d625c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebcf5196fc150b6ed4bf4891d… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Feb 10 13:58:58 2017 +0100 ddraw: Implement GetSurfaceFromDC(). Many thanks to Dmitry Timoshkov for helping figure this out. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/ddraw.spec | 2 +- dlls/ddraw/main.c | 34 ++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | 39 ++++++++++++++++++++++++++++++++++++++- dlls/ddraw/tests/ddraw7.c | 41 +++++++++++++++++++++++++++++++++++++++-- 4 files changed, 112 insertions(+), 4 deletions(-) diff --git a/dlls/ddraw/ddraw.spec b/dlls/ddraw/ddraw.spec index 7575091..a6cf141 100644 --- a/dlls/ddraw/ddraw.spec +++ b/dlls/ddraw/ddraw.spec @@ -15,7 +15,7 @@ @ stdcall -private DllRegisterServer() @ stdcall -private DllUnregisterServer() @ stub GetNextMipMap -@ stub GetSurfaceFromDC +@ stdcall GetSurfaceFromDC(ptr ptr ptr) @ stub HeapVidMemAllocAligned @ stub InternalLock @ stub InternalUnlock diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c index 4c94dd1..4caa923 100644 --- a/dlls/ddraw/main.c +++ b/dlls/ddraw/main.c @@ -200,6 +200,40 @@ void *ddraw_get_object(struct ddraw_handle_table *t, DWORD handle, enum ddraw_ha return entry->object; } +HRESULT WINAPI GetSurfaceFromDC(HDC dc, IDirectDrawSurface4 **surface, HDC *device_dc) +{ + struct ddraw *ddraw; + + TRACE("dc %p, surface %p, device_dc %p.\n", dc, surface, device_dc); + + if (!surface) + return E_INVALIDARG; + + if (!device_dc) + { + *surface = NULL; + + return E_INVALIDARG; + } + + wined3d_mutex_lock(); + LIST_FOR_EACH_ENTRY(ddraw, &global_ddraw_list, struct ddraw, ddraw_list_entry) + { + if (FAILED(IDirectDraw4_GetSurfaceFromDC(&ddraw->IDirectDraw4_iface, dc, surface))) + continue; + + *device_dc = NULL; /* FIXME */ + wined3d_mutex_unlock(); + return DD_OK; + } + wined3d_mutex_unlock(); + + *surface = NULL; + *device_dc = NULL; + + return DDERR_NOTFOUND; +} + /*********************************************************************** * * Helper function for DirectDrawCreate and friends diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index d5b43f4..830da89 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -24,6 +24,8 @@ #include <math.h> #include "d3d.h" +HRESULT WINAPI GetSurfaceFromDC(HDC dc, struct IDirectDrawSurface **surface, HDC *device_dc); + static BOOL is_ddraw64 = sizeof(DWORD) != sizeof(DWORD *); static DEVMODEW registry_mode; @@ -12778,10 +12780,11 @@ static void test_get_surface_from_dc(void) IDirectDrawSurface4 *surface; DDSURFACEDESC2 surface_desc; IDirectDraw4 *ddraw; + HDC dc, device_dc; ULONG refcount; HWND window; HRESULT hr; - HDC dc; + DWORD ret; window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW, 0, 0, 640, 480, 0, 0, 0, 0); @@ -12810,6 +12813,33 @@ static void test_get_surface_from_dc(void) hr = IDirectDrawSurface4_GetDC(surface, &dc); ok(SUCCEEDED(hr), "Failed to get DC, hr %#x.\n", hr); + tmp = (void *)0xdeadbeef; + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(NULL, &tmp, &device_dc); + ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr); + ok(!tmp, "Got unexpected surface %p.\n", tmp); + ok(!device_dc, "Got unexpected device_dc %p.\n", device_dc); + + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, NULL, &device_dc); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(device_dc == (void *)0xdeadbeef, "Got unexpected device_dc %p.\n", device_dc); + + tmp = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, &tmp, NULL); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(!tmp, "Got unexpected surface %p.\n", tmp); + + hr = GetSurfaceFromDC(dc, &tmp, &device_dc); + ok(SUCCEEDED(hr), "GetSurfaceFromDC failed, hr %#x.\n", hr); + ok(tmp == surface1, "Got unexpected surface %p, expected %p.\n", tmp, surface1); + IDirectDrawSurface_Release(tmp); + + ret = GetObjectType(device_dc); + todo_wine ok(ret == OBJ_DC, "Got unexpected object type %#x.\n", ret); + ret = GetDeviceCaps(device_dc, TECHNOLOGY); + todo_wine ok(ret == DT_RASDISPLAY, "Got unexpected technology %#x.\n", ret); + hr = IDirectDraw4_GetSurfaceFromDC(ddraw, dc, NULL); ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); @@ -12831,6 +12861,13 @@ static void test_get_surface_from_dc(void) ok(!!dc, "CreateCompatibleDC failed.\n"); tmp = (void *)0xdeadbeef; + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, &tmp, &device_dc); + ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr); + ok(!tmp, "Got unexpected surface %p.\n", tmp); + ok(!device_dc, "Got unexpected device_dc %p.\n", device_dc); + + tmp = (void *)0xdeadbeef; hr = IDirectDraw4_GetSurfaceFromDC(ddraw, dc, (IDirectDrawSurface4 **)&tmp); ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr); ok(!tmp, "Got unexpected surface %p.\n", tmp); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 70aff8f..31e7640 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -24,6 +24,8 @@ #include <math.h> #include "d3d.h" +HRESULT WINAPI GetSurfaceFromDC(HDC dc, struct IDirectDrawSurface **surface, HDC *device_dc); + static HRESULT (WINAPI *pDirectDrawCreateEx)(GUID *guid, void **ddraw, REFIID iid, IUnknown *outer_unknown); static BOOL is_ddraw64 = sizeof(DWORD) != sizeof(DWORD *); static DEVMODEW registry_mode; @@ -12447,14 +12449,15 @@ static void test_surface_desc_size(void) static void test_get_surface_from_dc(void) { + IDirectDrawSurface *surface1, *tmp1; IDirectDrawSurface7 *surface, *tmp; - IDirectDrawSurface *surface1; DDSURFACEDESC2 surface_desc; IDirectDraw7 *ddraw; + HDC dc, device_dc; ULONG refcount; HWND window; HRESULT hr; - HDC dc; + DWORD ret; window = CreateWindowA("static", "ddraw_test", WS_OVERLAPPEDWINDOW, 0, 0, 640, 480, 0, 0, 0, 0); @@ -12483,6 +12486,33 @@ static void test_get_surface_from_dc(void) hr = IDirectDrawSurface7_GetDC(surface, &dc); ok(SUCCEEDED(hr), "Failed to get DC, hr %#x.\n", hr); + tmp1 = (void *)0xdeadbeef; + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(NULL, &tmp1, &device_dc); + ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr); + ok(!tmp1, "Got unexpected surface %p.\n", tmp1); + ok(!device_dc, "Got unexpected device_dc %p.\n", device_dc); + + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, NULL, &device_dc); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(device_dc == (void *)0xdeadbeef, "Got unexpected device_dc %p.\n", device_dc); + + tmp1 = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, &tmp1, NULL); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(!tmp1, "Got unexpected surface %p.\n", tmp1); + + hr = GetSurfaceFromDC(dc, &tmp1, &device_dc); + ok(SUCCEEDED(hr), "GetSurfaceFromDC failed, hr %#x.\n", hr); + ok(tmp1 == surface1, "Got unexpected surface %p, expected %p.\n", tmp1, surface1); + IDirectDrawSurface_Release(tmp1); + + ret = GetObjectType(device_dc); + todo_wine ok(ret == OBJ_DC, "Got unexpected object type %#x.\n", ret); + ret = GetDeviceCaps(device_dc, TECHNOLOGY); + todo_wine ok(ret == DT_RASDISPLAY, "Got unexpected technology %#x.\n", ret); + hr = IDirectDraw7_GetSurfaceFromDC(ddraw, dc, NULL); ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); @@ -12503,6 +12533,13 @@ static void test_get_surface_from_dc(void) dc = CreateCompatibleDC(NULL); ok(!!dc, "CreateCompatibleDC failed.\n"); + tmp1 = (void *)0xdeadbeef; + device_dc = (void *)0xdeadbeef; + hr = GetSurfaceFromDC(dc, &tmp1, &device_dc); + ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr); + ok(!tmp1, "Got unexpected surface %p.\n", tmp1); + ok(!device_dc, "Got unexpected device_dc %p.\n", device_dc); + tmp = (void *)0xdeadbeef; hr = IDirectDraw7_GetSurfaceFromDC(ddraw, dc, &tmp); ok(hr == DDERR_NOTFOUND, "Got unexpected hr %#x.\n", hr);

1 0

Henri Verbeet : ddraw/tests: Rewrite GetDCTest().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: e28a5fa393b57a87427b82df2a6c9fec494c1640 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e28a5fa393b57a87427b82df2… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Feb 10 13:58:57 2017 +0100 ddraw/tests: Rewrite GetDCTest(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/tests/ddraw4.c | 77 +++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 77 +++++++++++++++++++++++++++ dlls/ddraw/tests/dsurface.c | 124 -------------------------------------------- 3 files changed, 154 insertions(+), 124 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e28a5fa393b57a87427b8…

1 0

Henri Verbeet : d3d8: Do not modify the "surface" pointer for D3DFMT_UNKNOWN in d3d8_device_CreateDepthStencilSurface().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 04586f6328f6d8040b8ecf34fea50e1761d7cfac URL: http://source.winehq.org/git/wine.git/?a=commit;h=04586f6328f6d8040b8ecf34f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Feb 10 13:58:56 2017 +0100 d3d8: Do not modify the "surface" pointer for D3DFMT_UNKNOWN in d3d8_device_CreateDepthStencilSurface(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d8/device.c | 3 +++ dlls/d3d8/tests/device.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index f8eb7ee..9592342 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -1010,6 +1010,9 @@ static HRESULT WINAPI d3d8_device_CreateDepthStencilSurface(IDirect3DDevice8 *if TRACE("iface %p, width %u, height %u, format %#x, multisample_type %#x, surface %p.\n", iface, width, height, format, multisample_type, surface); + if (!format) + return D3DERR_INVALIDCALL; + *surface = NULL; /* TODO: Verify that Discard is false */ diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 2295300..45969fe 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -8218,7 +8218,7 @@ static void test_format_unknown(void) hr = IDirect3DDevice8_CreateDepthStencilSurface(device, 64, 64, D3DFMT_UNKNOWN, D3DMULTISAMPLE_NONE, (IDirect3DSurface8 **)&iface); ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); - todo_wine ok(iface == (void *)0xdeadbeef, "Got unexpected iface %p.\n", iface); + ok(iface == (void *)0xdeadbeef, "Got unexpected iface %p.\n", iface); iface = (void *)0xdeadbeef; hr = IDirect3DDevice8_CreateImageSurface(device, 64, 64,

1 0

Henri Verbeet : d3d8: Do not modify the "surface" pointer for D3DFMT_UNKNOWN in d3d8_device_CreateRenderTarget().
by Alexandre Julliard 10 Feb '17

10 Feb '17

Module: wine Branch: master Commit: 177b3fc7c1ff5e2e85f8928c33fa5a597548cbfb URL: http://source.winehq.org/git/wine.git/?a=commit;h=177b3fc7c1ff5e2e85f8928c3… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Feb 10 13:58:55 2017 +0100 d3d8: Do not modify the "surface" pointer for D3DFMT_UNKNOWN in d3d8_device_CreateRenderTarget(). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d8/device.c | 3 +++ dlls/d3d8/tests/device.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index fe2f54e..f8eb7ee 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -990,6 +990,9 @@ static HRESULT WINAPI d3d8_device_CreateRenderTarget(IDirect3DDevice8 *iface, UI TRACE("iface %p, width %u, height %u, format %#x, multisample_type %#x, lockable %#x, surface %p.\n", iface, width, height, format, multisample_type, lockable, surface); + if (!format) + return D3DERR_INVALIDCALL; + *surface = NULL; if (lockable) flags |= WINED3D_TEXTURE_CREATE_MAPPABLE; diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 9a9278b..2295300 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -8212,7 +8212,7 @@ static void test_format_unknown(void) hr = IDirect3DDevice8_CreateRenderTarget(device, 64, 64, D3DFMT_UNKNOWN, D3DMULTISAMPLE_NONE, FALSE, (IDirect3DSurface8 **)&iface); ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x.\n", hr); - todo_wine ok(iface == (void *)0xdeadbeef, "Got unexpected iface %p.\n", iface); + ok(iface == (void *)0xdeadbeef, "Got unexpected iface %p.\n", iface); iface = (void *)0xdeadbeef; hr = IDirect3DDevice8_CreateDepthStencilSurface(device, 64, 64,

1 0

← Newer
1
...
52
53
54
55
56
57
58
...
84
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2017