wine-commits January 2018

wine-commits@winehq.org

2 participants
638 discussions

Alex Henrie : msxml3/tests: Add missing return value checks to domdoc tests (Coverity).
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: b8711196b14b5240962a1191affc0700a464507e URL: https://source.winehq.org/git/wine.git/?a=commit;h=b8711196b14b5240962a1191… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Jan 8 21:19:47 2018 -0700 msxml3/tests: Add missing return value checks to domdoc tests (Coverity). Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/tests/domdoc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 87a885d..26555d2 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -6460,7 +6460,8 @@ static void test_save(void) hr = IXMLDOMDocument_loadXML(doc, _bstr_(win1252xml), &b); EXPECT_HR(hr, S_OK); - CreateStreamOnHGlobal(NULL, TRUE, &stream); + hr = CreateStreamOnHGlobal(NULL, TRUE, &stream); + ok(hr == S_OK, "got 0x%08x\n", hr); V_VT(&dest) = VT_UNKNOWN; V_UNKNOWN(&dest) = (IUnknown*)stream; hr = IXMLDOMDocument_save(doc, dest); @@ -10950,7 +10951,8 @@ static void test_dispex(void) /* IXMLDOMNodeList */ hr = IXMLDOMDocument_getElementsByTagName(doc, _bstr_("*"), &node_list); EXPECT_HR(hr, S_OK); - IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk); + hr = IXMLDOMNodeList_QueryInterface(node_list, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "got 0x%08x\n", hr); test_domobj_dispex(unk); IUnknown_Release(unk); IXMLDOMNodeList_Release(node_list);

1 0

Alex Henrie : kernel32/tests: Drop module test workarounds for Windows <= 2000.
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: 84a5c59604ba88d7768a4fd2f7e08eccbdd10259 URL: https://source.winehq.org/git/wine.git/?a=commit;h=84a5c59604ba88d7768a4fd2… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed Jan 10 10:19:03 2018 -0700 kernel32/tests: Drop module test workarounds for Windows <= 2000. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/module.c | 162 +++++++++++++++---------------------------- 1 file changed, 54 insertions(+), 108 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=84a5c59604ba88d7768a…

1 0

Piotr Caban : concrt140: Fix Concurrency:: is_current_task_group_canceling spec entry.
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: 5890c3d0506fba366935a8a1d19c6a7d0c0e64fe URL: https://source.winehq.org/git/wine.git/?a=commit;h=5890c3d0506fba366935a8a1… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Jan 10 18:09:00 2018 +0100 concrt140: Fix Concurrency::is_current_task_group_canceling spec entry. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/concrt140/concrt140.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/concrt140/concrt140.spec b/dlls/concrt140/concrt140.spec index 0f96d7e..3777533 100644 --- a/dlls/concrt140/concrt140.spec +++ b/dlls/concrt140/concrt140.spec @@ -477,7 +477,7 @@ @ stub ?from_numa_node@location@Concurrency@@SA?AV12@G@Z @ thiscall -arch=i386 ?get_error_code@scheduler_resource_allocation_error@Concurrency@@QBEJXZ(ptr) msvcr120.?get_error_code@scheduler_resource_allocation_error@Concurrency@@QBEJXZ @ cdecl -arch=win64 ?get_error_code@scheduler_resource_allocation_error@Concurrency@@QEBAJXZ(ptr) msvcr120.?get_error_code@scheduler_resource_allocation_error@Concurrency@@QEBAJXZ -@ cdecl ?is_current_task_group_canceling@Concurrency@@YA_NXZ(ptr) msvcp120.?is_current_task_group_canceling@Concurrency@@YA_NXZ +@ cdecl ?is_current_task_group_canceling@Concurrency@@YA_NXZ() msvcp120.?is_current_task_group_canceling@Concurrency@@YA_NXZ @ thiscall -arch=i386 ?lock@critical_section@Concurrency@@QAEXXZ(ptr) msvcr120.?lock@critical_section@Concurrency@@QAEXXZ @ cdecl -arch=win64 ?lock@critical_section@Concurrency@@QEAAXXZ(ptr) msvcr120.?lock@critical_section@Concurrency@@QEAAXXZ @ thiscall -arch=win32 ?lock@reader_writer_lock@Concurrency@@QAEXXZ(ptr) msvcr120.?lock@reader_writer_lock@Concurrency@@QAEXXZ

1 0

Józef Kucia : include: Add EnableMouseInPointer() declaration.
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: 45ea40a14a6584ec60333af14a0ed6aef31be85f URL: https://source.winehq.org/git/wine.git/?a=commit;h=45ea40a14a6584ec60333af1… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Jan 9 15:57:54 2018 +0100 include: Add EnableMouseInPointer() declaration. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winuser.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/winuser.h b/include/winuser.h index 75bfe2b..05bf590 100644 --- a/include/winuser.h +++ b/include/winuser.h @@ -3576,6 +3576,7 @@ WINUSERAPI INT WINAPI DrawTextExW(HDC,LPWSTR,INT,LPRECT,UINT,LPDRAWTEXTP #define DrawTextEx WINELIB_NAME_AW(DrawTextEx) WINUSERAPI BOOL WINAPI EmptyClipboard(void); WINUSERAPI BOOL WINAPI EnableMenuItem(HMENU,UINT,UINT); +WINUSERAPI BOOL WINAPI EnableMouseInPointer(BOOL); WINUSERAPI BOOL WINAPI EnableScrollBar(HWND,UINT,UINT); WINUSERAPI BOOL WINAPI EnableWindow(HWND,BOOL); WINUSERAPI BOOL WINAPI EndDeferWindowPos(HDWP);

1 0

Nikolay Sivov : comctl32/tests: Add some state image tests for ListView.
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: 24fa2e8954cd98eabda05c93e29da0d10ecfcaf9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=24fa2e8954cd98eabda05c93… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Jan 10 10:17:21 2018 +0300 comctl32/tests: Add some state image tests for ListView. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/tests/listview.c | 91 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+) diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index 1df8648..1dd0fe1 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -6135,6 +6135,95 @@ todo_wine DestroyWindow(hwnd); } +static void test_state_image(void) +{ + static const DWORD styles[] = + { + LVS_ICON, + LVS_REPORT, + LVS_SMALLICON, + LVS_LIST, + }; + int i; + + for (i = 0; i < sizeof(styles)/sizeof(styles[0]); i++) + { + static char text[] = "Item"; + static char subtext[] = "Subitem"; + char buff[16]; + LVITEMA item; + HWND hwnd; + int r; + + hwnd = create_listview_control(styles[i]); + + insert_column(hwnd, 0); + insert_column(hwnd, 1); + + item.mask = LVIF_TEXT; + item.iItem = 0; + item.iSubItem = 0; + item.pszText = text; + r = SendMessageA(hwnd, LVM_INSERTITEMA, 0, (LPARAM)&item); + ok(r == 0, "Failed to insert an item.\n"); + + item.mask = LVIF_STATE; + item.state = INDEXTOSTATEIMAGEMASK(1) | LVIS_SELECTED; + item.stateMask = LVIS_STATEIMAGEMASK | LVIS_SELECTED; + item.iItem = 0; + item.iSubItem = 0; + r = SendMessageA(hwnd, LVM_SETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to set item state.\n"); + + item.mask = LVIF_TEXT; + item.iItem = 0; + item.iSubItem = 1; + item.pszText = subtext; + r = SendMessageA(hwnd, LVM_SETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to set subitem text.\n"); + + item.mask = LVIF_STATE; + item.stateMask = LVIS_STATEIMAGEMASK | LVIS_SELECTED; + item.state = 0; + item.iItem = 0; + item.iSubItem = 0; + r = SendMessageA(hwnd, LVM_GETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to get item state.\n"); + ok(item.state == (INDEXTOSTATEIMAGEMASK(1) | LVIS_SELECTED), "Unexpected item state %#x.\n", item.state); + + item.mask = LVIF_STATE; + item.stateMask = LVIS_STATEIMAGEMASK | LVIS_SELECTED; + item.state = INDEXTOSTATEIMAGEMASK(2); + item.iItem = 0; + item.iSubItem = 1; + r = SendMessageA(hwnd, LVM_GETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to get subitem state.\n"); + todo_wine + ok(item.state == 0, "Unexpected state %#x.\n", item.state); + + item.mask = LVIF_STATE; + item.stateMask = LVIS_STATEIMAGEMASK | LVIS_SELECTED; + item.state = INDEXTOSTATEIMAGEMASK(2); + item.iItem = 0; + item.iSubItem = 2; + r = SendMessageA(hwnd, LVM_GETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to get subitem state.\n"); + todo_wine + ok(item.state == 0, "Unexpected state %#x.\n", item.state); + + item.mask = LVIF_TEXT; + item.iItem = 0; + item.iSubItem = 1; + item.pszText = buff; + item.cchTextMax = sizeof(buff); + r = SendMessageA(hwnd, LVM_GETITEMA, 0, (LPARAM)&item); + ok(r, "Failed to get subitem text %d.\n", r); + ok(!strcmp(buff, subtext), "Unexpected subitem text %s.\n", buff); + + DestroyWindow(hwnd); + } +} + START_TEST(listview) { HMODULE hComctl32; @@ -6207,6 +6296,7 @@ START_TEST(listview) test_header_proc(); test_oneclickactivate(); test_callback_mask(); + test_state_image(); if (!load_v6_module(&ctx_cookie, &hCtx)) { @@ -6244,6 +6334,7 @@ START_TEST(listview) test_LVM_SETITEMTEXT(); test_LVM_REDRAWITEMS(); test_oneclickactivate(); + test_state_image(); unload_v6_module(ctx_cookie, hCtx);

1 0

Nikolay Sivov : comctl32/tests: Enable more ListView tests on Comctl32 v6.
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: 07ea3acbda5173d243ffc59233a2febcaed4d731 URL: https://source.winehq.org/git/wine.git/?a=commit;h=07ea3acbda5173d243ffc592… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Jan 10 10:17:20 2018 +0300 comctl32/tests: Enable more ListView tests on Comctl32 v6. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/tests/listview.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index f291698..1df8648 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -6225,6 +6225,25 @@ START_TEST(listview) test_multiselect(); test_insertitem(); test_header_proc(); + test_images(); + test_checkboxes(); + test_items(); + test_color(); + test_columns(); + test_sorting(); + test_ownerdata(); + test_norecompute(); + test_nosortheader(); + test_columnscreation(); + test_indentation(); + test_finditem(); + test_hover(); + test_destroynotify(); + test_createdragimage(); + test_dispinfo(); + test_LVM_SETITEMTEXT(); + test_LVM_REDRAWITEMS(); + test_oneclickactivate(); unload_v6_module(ctx_cookie, hCtx);

1 0

Zebediah Figura : hlink: Implement IHlinkBrowseContext_GetObject().
by Alexandre Julliard 10 Jan '18

10 Jan '18

Module: wine Branch: master Commit: c2953ba45775cdaf4c2653cc6337ea93031e04b4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c2953ba45775cdaf4c2653cc… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Jan 9 20:59:39 2018 -0600 hlink: Implement IHlinkBrowseContext_GetObject(). Fixes a regression introduced by 00aca1476efd573cbf9d31a45c3d484f6fa6055b. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hlink/browse_ctx.c | 27 ++++++++++++++--- dlls/hlink/tests/browse_ctx.c | 70 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 93 insertions(+), 4 deletions(-) diff --git a/dlls/hlink/browse_ctx.c b/dlls/hlink/browse_ctx.c index ee8509d..2038768 100644 --- a/dlls/hlink/browse_ctx.c +++ b/dlls/hlink/browse_ctx.c @@ -98,10 +98,11 @@ static ULONG WINAPI IHlinkBC_fnRelease (IHlinkBrowseContext* iface) return ref; } +static const WCHAR szIdent[] = {'W','I','N','E','H','L','I','N','K',0}; + static HRESULT WINAPI IHlinkBC_Register(IHlinkBrowseContext* iface, DWORD dwReserved, IUnknown *piunk, IMoniker *pimk, DWORD *pdwRegister) { - static const WCHAR szIdent[] = {'W','I','N','E','H','L','I','N','K',0}; HlinkBCImpl *This = impl_from_IHlinkBrowseContext(iface); IMoniker *mon; IMoniker *composite; @@ -125,11 +126,29 @@ static HRESULT WINAPI IHlinkBC_Register(IHlinkBrowseContext* iface, return S_OK; } -static HRESULT WINAPI IHlinkBC_GetObject(IHlinkBrowseContext* face, +static HRESULT WINAPI IHlinkBC_GetObject(IHlinkBrowseContext* iface, IMoniker *pimk, BOOL fBindifRootRegistered, IUnknown **ppiunk) { - FIXME("\n"); - return E_NOTIMPL; + HlinkBCImpl *This = impl_from_IHlinkBrowseContext(iface); + IMoniker *mon; + IMoniker *composite; + IRunningObjectTable *ROT; + HRESULT hr; + + TRACE("(%p)->(%p, %d, %p)\n", This, pimk, fBindifRootRegistered, ppiunk); + + hr = CreateItemMoniker(NULL, szIdent, &mon); + if (FAILED(hr)) return hr; + CreateGenericComposite(mon, pimk, &composite); + + GetRunningObjectTable(0, &ROT); + hr = IRunningObjectTable_GetObject(ROT, composite, ppiunk); + + IRunningObjectTable_Release(ROT); + IMoniker_Release(composite); + IMoniker_Release(mon); + + return hr; } static HRESULT WINAPI IHlinkBC_Revoke(IHlinkBrowseContext* iface, diff --git a/dlls/hlink/tests/browse_ctx.c b/dlls/hlink/tests/browse_ctx.c index 40d132b..3193525 100644 --- a/dlls/hlink/tests/browse_ctx.c +++ b/dlls/hlink/tests/browse_ctx.c @@ -131,12 +131,82 @@ static void test_BrowseWindowInfo(void) IHlinkBrowseContext_Release(bc); } +static HRESULT WINAPI Unknown_QueryInterface(IUnknown *iface, REFIID riid, void **ppv) +{ + *ppv = NULL; + + if (IsEqualIID(riid, &IID_IUnknown)) + { + *ppv = iface; + return S_OK; + } + return E_NOINTERFACE; +} + +static ULONG WINAPI Unknown_AddRef(IUnknown *iface) +{ + return 2; +} + +static ULONG WINAPI Unknown_Release(IUnknown *iface) +{ + return 1; +} + +static IUnknownVtbl UnknownVtbl = { + Unknown_QueryInterface, + Unknown_AddRef, + Unknown_Release, +}; + +static IUnknown Unknown = { &UnknownVtbl }; + +static void test_GetObject(void) +{ + IHlinkBrowseContext *bc; + IMoniker *dummy; + IBindCtx *bindctx; + IUnknown *unk; + WCHAR one[] = {'1',0}; + WCHAR five[] = {'5',0}; + DWORD cookie; + HRESULT hres; + + hres = CreateBindCtx(0, &bindctx); + ok(hres == S_OK, "CreateBindCtx() failed: 0x%08x\n", hres); + + hres = CreateItemMoniker(one, five, &dummy); + ok(hres == S_OK, "CreateItemMoniker() failed: 0x%08x\n", hres); + + hres = HlinkCreateBrowseContext(NULL, &IID_IHlinkBrowseContext, (void **)&bc); + ok(hres == S_OK, "HlinkCreateBrowseContext() failed: 0x%08x\n", hres); + + hres = IHlinkBrowseContext_GetObject(bc, dummy, FALSE, &unk); + ok(hres == MK_E_UNAVAILABLE, "expected MK_E_UNAVAILABLE, got 0x%08x\n", hres); + + hres = IHlinkBrowseContext_Register(bc, 0, &Unknown, dummy, &cookie); + ok(hres == S_OK, "Register() failed: 0x%08x\n", hres); + + hres = IHlinkBrowseContext_GetObject(bc, dummy, FALSE, &unk); + ok(hres == S_OK, "GetObject() failed: 0x%08x\n", hres); + ok(unk == &Unknown, "wrong object returned\n"); + + hres = IHlinkBrowseContext_Revoke(bc, cookie); + ok(hres == S_OK, "Revoke() failed: 0x%08x\n", hres); + + hres = IHlinkBrowseContext_GetObject(bc, dummy, FALSE, &unk); + ok(hres == MK_E_UNAVAILABLE, "expected MK_E_UNAVAILABLE, got 0x%08x\n", hres); + + IHlinkBrowseContext_Release(bc); +} + START_TEST(browse_ctx) { CoInitialize(NULL); test_SetInitialHlink(); test_BrowseWindowInfo(); + test_GetObject(); CoUninitialize(); }

1 0

Julian Rüger : German translation for release 3.0-rc5
by Jeremy Newman 10 Jan '18

10 Jan '18

Module: website Branch: master Commit: 28f727ff3e9e22923d33e37eb8ee33e4f8a303d4 URL: https://source.winehq.org/git/website.git/?a=commit;h=28f727ff3e9e22923d33e… Author: Julian Rüger <jr98(a)gmx.net> Date: Wed Jan 10 10:28:48 2018 +0100 German translation for release 3.0-rc5 Signed-off-by: Julian Rüger <jr98(a)gmx.net> Signed-off-by: Jeremy Newman <jnewman(a)codeweavers.com> --- news/de/2018010501.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/news/de/2018010501.xml b/news/de/2018010501.xml new file mode 100644 index 0000000..9877bce --- /dev/null +++ b/news/de/2018010501.xml @@ -0,0 +1,12 @@ +<news> +<date>5. Januar 2018</date> +<title>Wine 3.0-rc5 freigegeben</title> +<body> + Die Entwicklungsversion 3.0-rc5 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/3.0-rc5">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Nur Fehlerkorrekturen, da wir uns im Code-freeze befinden.</li> +</ul> +Der Quelltext ist ab sofort <a href="//dl.winehq.org/wine/source/3.0/wine-3.0-rc5.tar.xz">verfügbar</a>. +Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. +</body></news>

1 0

Bob Ziuchkovski : dinput: Ignore vendor-specific usage pages for joystick elements on Mac.
by Alexandre Julliard 09 Jan '18

09 Jan '18

Module: wine Branch: master Commit: 221708d64ebf7b9c6bed3674e9363779a3ed1a4d URL: https://source.winehq.org/git/wine.git/?a=commit;h=221708d64ebf7b9c6bed3674… Author: Bob Ziuchkovski <bob.ziuchkovski(a)gmail.com> Date: Sun Jan 7 16:26:04 2018 -0700 dinput: Ignore vendor-specific usage pages for joystick elements on Mac. Signed-off-by: Bob Ziuchkovski <bob.ziuchkovski(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/joystick_osx.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c index 43fa20e..b0dcdd9 100644 --- a/dlls/dinput/joystick_osx.c +++ b/dlls/dinput/joystick_osx.c @@ -640,14 +640,20 @@ static void get_osx_device_elements(JoystickImpl *device, int axis_map[8]) { IOHIDElementRef element = ( IOHIDElementRef ) CFArrayGetValueAtIndex( elements, idx ); int type = IOHIDElementGetType( element ); + int usage_page = IOHIDElementGetUsagePage( element ); TRACE("element %s\n", debugstr_element(element)); + if (usage_page >= kHIDPage_VendorDefinedStart) + { + /* vendor pages can repurpose type ids, resulting in incorrect case matches below (e.g. ds4 controllers) */ + continue; + } + switch(type) { case kIOHIDElementTypeInput_Button: { - int usage_page = IOHIDElementGetUsagePage( element ); TRACE("kIOHIDElementTypeInput_Button usage_page %d\n", usage_page); if (usage_page != kHIDPage_Button) {

1 0

Andrew Eikum : hid: Pass a buffer to DeviceIoControl in HidD_SetNumInputBuffers.
by Alexandre Julliard 09 Jan '18

09 Jan '18

Module: wine Branch: master Commit: 2de3dc3dd6059a1297a698c72a92b23eda853483 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2de3dc3dd6059a1297a698c7… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Jan 9 10:28:18 2018 -0600 hid: Pass a buffer to DeviceIoControl in HidD_SetNumInputBuffers. DeviceIoControl expects a pointer, and this value gets dereferenced as a ULONG* in hidclass.sys. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hid/hidd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/hid/hidd.c b/dlls/hid/hidd.c index 1161f0c..614e7c4 100644 --- a/dlls/hid/hidd.c +++ b/dlls/hid/hidd.c @@ -102,7 +102,7 @@ BOOLEAN WINAPI HidD_SetFeature(HANDLE HidDeviceObject, PVOID ReportBuffer, ULONG BOOLEAN WINAPI HidD_SetNumInputBuffers(HANDLE HidDeviceObject, ULONG NumberBuffers) { TRACE("(%p %i)\n", HidDeviceObject, NumberBuffers); - return DeviceIoControl(HidDeviceObject, IOCTL_SET_NUM_DEVICE_INPUT_BUFFERS, UlongToPtr(NumberBuffers), sizeof(NumberBuffers), NULL, 0, NULL, NULL); + return DeviceIoControl(HidDeviceObject, IOCTL_SET_NUM_DEVICE_INPUT_BUFFERS, &NumberBuffers, sizeof(NumberBuffers), NULL, 0, NULL, NULL); } BOOLEAN WINAPI HidD_GetProductString(HANDLE HidDeviceObject, PVOID Buffer, ULONG BufferLength)

1 0

← Newer
1
...
35
36
37
38
39
40
41
...
64
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2018