wine-commits August 2019

wine-commits@winehq.org

2 participants
703 discussions

Zebediah Figura : widl: Don' t store the default pointer type in the type_t structure.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 60d668631f3efb0b88c7751aba807b21ef5b5c5b URL: https://source.winehq.org/git/wine.git/?a=commit;h=60d668631f3efb0b88c7751a… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 17 20:07:08 2019 -0500 widl: Don't store the default pointer type in the type_t structure. This fixes type format string generation for the following IDL: typedef int *intp; [pointer_default(ref)] interface IRef { void a(intp *a); } [pointer_default(unique)] interface IUnique { void b(intp *a); } Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/widl/expr.c | 6 +++--- tools/widl/parser.h | 6 ------ tools/widl/parser.y | 39 +++++++++++++++------------------------ tools/widl/typegen.c | 9 +++++---- tools/widl/typetree.c | 7 ++----- tools/widl/typetree.h | 19 ++----------------- tools/widl/widltypes.h | 2 -- 7 files changed, 27 insertions(+), 61 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=60d668631f3efb0b88c7…

1 0

Zebediah Figura : widl: Store the "inline" function specifier inside the decl_spec_t structure.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 5cc35482991222c3b62f6b7b8bfbef7952d60a7c URL: https://source.winehq.org/git/wine.git/?a=commit;h=5cc35482991222c3b62f6b7b… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 17 20:07:07 2019 -0500 widl: Store the "inline" function specifier inside the decl_spec_t structure. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/widl/header.c | 4 +++- tools/widl/parser.y | 43 ++++++++++++++++--------------------------- tools/widl/widltypes.h | 10 +++++++--- 3 files changed, 26 insertions(+), 31 deletions(-) diff --git a/tools/widl/header.c b/tools/widl/header.c index bd7ca7e..c20fe69 100644 --- a/tools/widl/header.c +++ b/tools/widl/header.c @@ -318,6 +318,9 @@ void write_type_left(FILE *h, const decl_spec_t *ds, enum name_type name_type, i name = type_get_name(t, name_type); + if (ds->func_specifier & FUNCTION_SPECIFIER_INLINE) + fprintf(h, "inline "); + if ((ds->qualifier & TYPE_QUALIFIER_CONST) && (type_is_alias(t) || !is_ptr(t))) fprintf(h, "const "); @@ -383,7 +386,6 @@ void write_type_left(FILE *h, const decl_spec_t *ds, enum name_type name_type, i break; case TYPE_FUNCTION: { - if (is_attr(t->attrs, ATTR_INLINE)) fprintf(h, "inline "); write_type_left(h, type_function_get_ret(t), name_type, declonly, TRUE); /* A pointer to a function has to write the calling convention inside diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 45782ba..f6d0886 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -60,7 +60,7 @@ static str_list_t *append_str(str_list_t *list, char *str); static attr_list_t *append_attr(attr_list_t *list, attr_t *attr); static attr_list_t *append_attr_list(attr_list_t *new_list, attr_list_t *old_list); static decl_spec_t *make_decl_spec(type_t *type, decl_spec_t *left, decl_spec_t *right, - attr_t *attr, enum storage_class stgclass, enum type_qualifier qual); + enum storage_class stgclass, enum type_qualifier qual, enum function_specifier func_specifier); static attr_t *make_attr(enum attr_type type); static attr_t *make_attrv(enum attr_type type, unsigned int val); static attr_t *make_attrp(enum attr_type type, void *val); @@ -160,6 +160,7 @@ static typelib_t *current_typelib; struct _decl_spec_t *declspec; enum storage_class stgclass; enum type_qualifier type_qualifier; + enum function_specifier function_specifier; } %token <str> aIDENTIFIER aPRAGMA @@ -261,7 +262,7 @@ static typelib_t *current_typelib; %token tWCHAR tWIREMARSHAL %token tAPARTMENT tNEUTRAL tSINGLE tFREE tBOTH -%type <attr> attribute function_specifier acf_attribute +%type <attr> attribute acf_attribute %type <attr_list> m_attributes attributes attrib_list %type <attr_list> acf_attributes acf_attribute_list %type <str_list> str_list @@ -270,6 +271,7 @@ static typelib_t *current_typelib; %type <ifinfo> interfacehdr %type <stgclass> storage_cls_spec %type <type_qualifier> type_qualifier m_type_qual_list +%type <function_specifier> function_specifier %type <declspec> decl_spec decl_spec_no_type m_decl_spec_no_type %type <type> inherit interface interfacedef interfacedec %type <type> dispinterface dispinterfacehdr dispinterfacedef @@ -950,7 +952,7 @@ storage_cls_spec: ; function_specifier: - tINLINE { $$ = make_attr(ATTR_INLINE); } + tINLINE { $$ = FUNCTION_SPECIFIER_INLINE; } ; type_qualifier: @@ -961,9 +963,9 @@ m_type_qual_list: { $$ = 0; } | m_type_qual_list type_qualifier { $$ = $1 | $2; } ; -decl_spec: type m_decl_spec_no_type { $$ = make_decl_spec($1, $2, NULL, NULL, STG_NONE, 0); } +decl_spec: type m_decl_spec_no_type { $$ = make_decl_spec($1, $2, NULL, STG_NONE, 0, 0); } | decl_spec_no_type type m_decl_spec_no_type - { $$ = make_decl_spec($2, $1, $3, NULL, STG_NONE, 0); } + { $$ = make_decl_spec($2, $1, $3, STG_NONE, 0, 0); } ; m_decl_spec_no_type: { $$ = NULL; } @@ -971,9 +973,9 @@ m_decl_spec_no_type: { $$ = NULL; } ; decl_spec_no_type: - type_qualifier m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, NULL, STG_NONE, $1); } - | function_specifier m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, $1, STG_NONE, 0); } - | storage_cls_spec m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, NULL, $1, 0); } + type_qualifier m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, STG_NONE, $1, 0); } + | function_specifier m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, STG_NONE, 0, $1); } + | storage_cls_spec m_decl_spec_no_type { $$ = make_decl_spec(NULL, $2, NULL, $1, 0, 0); } ; declarator: @@ -1285,57 +1287,47 @@ static attr_list_t *map_attrs(const attr_list_t *list, map_attrs_filter_t filter } static decl_spec_t *make_decl_spec(type_t *type, decl_spec_t *left, decl_spec_t *right, - attr_t *attr, enum storage_class stgclass, enum type_qualifier qual) + enum storage_class stgclass, enum type_qualifier qual, enum function_specifier func_specifier) { decl_spec_t *declspec = left ? left : right; if (!declspec) { declspec = xmalloc(sizeof(*declspec)); declspec->type = NULL; - declspec->attrs = NULL; declspec->stgclass = STG_NONE; declspec->qualifier = 0; + declspec->func_specifier = 0; } declspec->type = type; if (left && declspec != left) { - declspec->attrs = append_attr_list(declspec->attrs, left->attrs); if (declspec->stgclass == STG_NONE) declspec->stgclass = left->stgclass; else if (left->stgclass != STG_NONE) error_loc("only one storage class can be specified\n"); declspec->qualifier |= left->qualifier; + declspec->func_specifier |= left->func_specifier; assert(!left->type); free(left); } if (right && declspec != right) { - declspec->attrs = append_attr_list(declspec->attrs, right->attrs); if (declspec->stgclass == STG_NONE) declspec->stgclass = right->stgclass; else if (right->stgclass != STG_NONE) error_loc("only one storage class can be specified\n"); declspec->qualifier |= right->qualifier; + declspec->func_specifier |= right->func_specifier; assert(!right->type); free(right); } - declspec->attrs = append_attr(declspec->attrs, attr); if (declspec->stgclass == STG_NONE) declspec->stgclass = stgclass; else if (stgclass != STG_NONE) error_loc("only one storage class can be specified\n"); declspec->qualifier |= qual; - - /* apply attributes to type */ - if (type && declspec->attrs) - { - attr_list_t *attrs; - declspec->type = duptype(type, 1); - attrs = map_attrs(type->attrs, NULL); - declspec->type->attrs = append_attr_list(attrs, declspec->attrs); - declspec->attrs = NULL; - } + declspec->func_specifier |= func_specifier; return declspec; } @@ -1550,12 +1542,10 @@ static var_t *declare_var(attr_list_t *attrs, decl_spec_t *decl_spec, declarator type_t **ptype; type_t *type = decl_spec->type; - if (is_attr(type->attrs, ATTR_INLINE)) + if (decl_spec->func_specifier & FUNCTION_SPECIFIER_INLINE) { if (!decl || !is_func(decl->type)) error_loc("inline attribute applied to non-function type\n"); - else - decl->type->attrs = move_attr(decl->type->attrs, type->attrs, ATTR_INLINE); } /* add type onto the end of the pointers in pident->type */ @@ -2182,7 +2172,6 @@ struct allowed_attr allowed_attr[] = /* ATTR_IMMEDIATEBIND */ { 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "immediatebind" }, /* ATTR_IMPLICIT_HANDLE */ { 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "implicit_handle" }, /* ATTR_IN */ { 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, "in" }, - /* ATTR_INLINE */ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "inline" }, /* ATTR_INPUTSYNC */ { 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "inputsync" }, /* ATTR_LENGTHIS */ { 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, "length_is" }, /* ATTR_LIBLCID */ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, "lcid" }, diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h index 6e88019..c217c59 100644 --- a/tools/widl/widltypes.h +++ b/tools/widl/widltypes.h @@ -115,7 +115,6 @@ enum attr_type ATTR_IMMEDIATEBIND, ATTR_IMPLICIT_HANDLE, ATTR_IN, - ATTR_INLINE, ATTR_INPUTSYNC, ATTR_LENGTHIS, ATTR_LIBLCID, @@ -239,6 +238,11 @@ enum type_qualifier TYPE_QUALIFIER_CONST = 1, }; +enum function_specifier +{ + FUNCTION_SPECIFIER_INLINE = 1, +}; + enum statement_type { STMT_LIBRARY, @@ -301,9 +305,9 @@ struct str_list_entry_t struct _decl_spec_t { type_t *type; - attr_list_t *attrs; enum storage_class stgclass; enum type_qualifier qualifier; + enum function_specifier func_specifier; }; struct _attr_t { @@ -630,9 +634,9 @@ static inline int is_global_namespace(const struct namespace *namespace) static inline decl_spec_t *init_declspec(decl_spec_t *declspec, type_t *type) { declspec->type = type; - declspec->attrs = NULL; declspec->stgclass = STG_NONE; declspec->qualifier = 0; + declspec->func_specifier = 0; return declspec; }

1 0

Richard Pospesel : widl: Store the "const" type qualifier inside the decl_spec_t structure.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 7e4da76689ecdb9ae49eae91e3759dae03c50644 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7e4da76689ecdb9ae49eae91… Author: Richard Pospesel <richard(a)torproject.org> Date: Sat Aug 17 20:07:06 2019 -0500 widl: Store the "const" type qualifier inside the decl_spec_t structure. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/widl/expr.c | 6 +-- tools/widl/header.c | 15 ++++--- tools/widl/parser.y | 111 +++++++++++++++++++++++++++++-------------------- tools/widl/typetree.c | 3 +- tools/widl/typetree.h | 2 +- tools/widl/widltypes.h | 9 +++- 6 files changed, 86 insertions(+), 60 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=7e4da76689ecdb9ae49e…

1 0

Zebediah Figura : widl: Fix nesting of functions, pointers, and arrays.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: df948ccc05d17df07f9fc70898af463610cf621a URL: https://source.winehq.org/git/wine.git/?a=commit;h=df948ccc05d17df07f9fc708… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Sat Aug 17 20:07:05 2019 -0500 widl: Fix nesting of functions, pointers, and arrays. This is actually broken in MIDL, even as recent as the version shipped with the Windows 10 SDK, but it makes our code simpler, so there's no reason not to do it right. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/widl/header.c | 109 +++++++++++++++++++++++++++--------------------- tools/widl/header.h | 7 +++- tools/widl/parser.y | 111 ++++++++++++++++++++----------------------------- tools/widl/typegen.c | 6 +-- tools/widl/typetree.c | 1 + tools/widl/widltypes.h | 1 - 6 files changed, 117 insertions(+), 118 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=df948ccc05d17df07f9f…

1 0

Sven Baars : setupapi: Fix an uninitialized variable warning (Valgrind).
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: ecbd2dd34b4239318162242caaa197ae4f0911f5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ecbd2dd34b4239318162242c… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sun Aug 18 00:09:05 2019 +0200 setupapi: Fix an uninitialized variable warning (Valgrind). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/setupapi/queue.c b/dlls/setupapi/queue.c index e049bbe..e9b48ed 100644 --- a/dlls/setupapi/queue.c +++ b/dlls/setupapi/queue.c @@ -196,6 +196,7 @@ UINT CALLBACK QUEUE_callback_WtoA( void *context, UINT notification, switch(notification) { case SPFILENOTIFY_COPYERROR: + buffer[0] = 0; param2 = (UINT_PTR)buffer; /* fall through */ case SPFILENOTIFY_STARTDELETE:

1 0

Sven Baars : setupapi: Fix a path leak (Valgrind).
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 5f0d53e20903b009ee47a238a642f2e95f27d712 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5f0d53e20903b009ee47a238… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sun Aug 18 00:09:04 2019 +0200 setupapi: Fix a path leak (Valgrind). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/queue.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/dlls/setupapi/queue.c b/dlls/setupapi/queue.c index ba750b0..e049bbe 100644 --- a/dlls/setupapi/queue.c +++ b/dlls/setupapi/queue.c @@ -1408,13 +1408,20 @@ BOOL WINAPI SetupCommitFileQueueW( HWND owner, HSPFILEQ handle, PSP_FILE_CALLBAC * actually isn't in a subdirectory, but keep track of what it * was, and then later strip it from the root path that we * ultimately resolve the source disk to. */ - WCHAR *src_path = op->src_path; + WCHAR src_path[MAX_PATH]; + size_t path_len = 0; - op->src_path = NULL; - if (src_path) + src_path[0] = 0; + if (op->src_path) { + lstrcpyW(src_path, op->src_path); + path_len = lstrlenW(src_path); + lstrcatW(op->media->root, backslashW); - lstrcatW(op->media->root, src_path); + lstrcatW(op->media->root, op->src_path); + + heap_free(op->src_path); + op->src_path = NULL; } for (;;) @@ -1450,12 +1457,11 @@ BOOL WINAPI SetupCommitFileQueueW( HWND owner, HSPFILEQ handle, PSP_FILE_CALLBAC if (queue_copy_file( paths.Source, paths.Target, op, handler, context )) { - if (src_path && !op->media->cabinet) + if (path_len > 0 && !op->media->cabinet) { - size_t root_len = lstrlenW(op->media->root), path_len = lstrlenW(src_path); + size_t root_len = lstrlenW(op->media->root); if (path_len <= root_len && !wcsnicmp(op->media->root + root_len - path_len, src_path, path_len)) op->media->root[root_len - path_len - 1] = 0; - heap_free( src_path ); } op->media->resolved = TRUE; handler( context, SPFILENOTIFY_ENDCOPY, (UINT_PTR)&paths, 0 );

1 0

Sven Baars : setupapi/tests: Fix a crash in the need_media tests.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 448f4cc9a25c6f994395978df0dfd7c7487b5dbb URL: https://source.winehq.org/git/wine.git/?a=commit;h=448f4cc9a25c6f994395978d… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sun Aug 18 00:09:03 2019 +0200 setupapi/tests: Fix a crash in the need_media tests. Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/install.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/setupapi/tests/install.c b/dlls/setupapi/tests/install.c index f9e5592..d761f89 100644 --- a/dlls/setupapi/tests/install.c +++ b/dlls/setupapi/tests/install.c @@ -1903,6 +1903,7 @@ static void test_need_media(void) queue = SetupOpenFileQueue(); ok(queue != INVALID_HANDLE_VALUE, "Failed to open queue, error %#x.\n", GetLastError()); copy_params.LayoutInf = hinf; + copy_params.QueueHandle = queue; /* In fact this fails with ERROR_INVALID_PARAMETER on 8+. */ if (SetupQueueCopyIndirectA(&copy_params)) {

1 0

Sven Baars : wmp: Fix a playlist leak (Valgrind).
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 2eb50028e3c3a69bdcef1c98f13ff237a9777daf URL: https://source.winehq.org/git/wine.git/?a=commit;h=2eb50028e3c3a69bdcef1c98… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sat Aug 17 18:50:18 2019 +0200 wmp: Fix a playlist leak (Valgrind). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/player.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wmp/player.c b/dlls/wmp/player.c index 9ba6684..f9df561 100644 --- a/dlls/wmp/player.c +++ b/dlls/wmp/player.c @@ -2258,6 +2258,8 @@ void destroy_player(WindowsMediaPlayer *wmp) IWMPControls_stop(&wmp->IWMPControls_iface); if (wmp->media) IWMPMedia_Release(&wmp->media->IWMPMedia_iface); + if (wmp->playlist) + IWMPPlaylist_Release(&wmp->playlist->IWMPPlaylist_iface); DestroyWindow(wmp->msg_window); }

1 0

Sven Baars : wmp: Fix some memory leaks on error path (Coverity).
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 2a88c53a9f5ae8c54aa1039b645696e23e193702 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2a88c53a9f5ae8c54aa1039b… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sat Aug 17 18:50:17 2019 +0200 wmp: Fix some memory leaks on error path (Coverity). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/player.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/wmp/player.c b/dlls/wmp/player.c index c547dad..9ba6684 100644 --- a/dlls/wmp/player.c +++ b/dlls/wmp/player.c @@ -2300,6 +2300,7 @@ HRESULT create_media_from_url(BSTR url, double duration, IWMPMedia **ppMedia) if (FAILED(hr)) { heap_free(name_dup); + IWMPMedia_Release(&media->IWMPMedia_iface); return hr; } hr = IUri_GetPath(uri, &path); @@ -2307,6 +2308,7 @@ HRESULT create_media_from_url(BSTR url, double duration, IWMPMedia **ppMedia) { heap_free(name_dup); IUri_Release(uri); + IWMPMedia_Release(&media->IWMPMedia_iface); return hr; }

1 0

Sven Baars : wmp: Fix a crash in put_volume when basic_audio is NULL.
by Alexandre Julliard 19 Aug '19

19 Aug '19

Module: wine Branch: master Commit: 9e8cf8082c3523957f6b19f49e820d910c16faa7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9e8cf8082c3523957f6b19f4… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sat Aug 17 18:50:16 2019 +0200 wmp: Fix a crash in put_volume when basic_audio is NULL. Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/player.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/wmp/player.c b/dlls/wmp/player.c index 729cc81..c547dad 100644 --- a/dlls/wmp/player.c +++ b/dlls/wmp/player.c @@ -985,18 +985,18 @@ static HRESULT WINAPI WMPSettings_get_volume(IWMPSettings *iface, LONG *p) static HRESULT WINAPI WMPSettings_put_volume(IWMPSettings *iface, LONG v) { - HRESULT hres; WindowsMediaPlayer *This = impl_from_IWMPSettings(iface); TRACE("(%p)->(%d)\n", This, v); This->volume = v; - if (!This->filter_graph) { - hres = S_OK; - } else { - /* IBasicAudio - [-10000, 0], wmp - [0, 100] */ - v = 10000 * v / 100 - 10000; - hres = IBasicAudio_put_Volume(This->basic_audio, v); - } - return hres; + if (!This->filter_graph) + return S_OK; + + /* IBasicAudio - [-10000, 0], wmp - [0, 100] */ + v = 10000 * v / 100 - 10000; + if (!This->basic_audio) + return S_FALSE; + + return IBasicAudio_put_Volume(This->basic_audio, v); } static HRESULT WINAPI WMPSettings_getMode(IWMPSettings *iface, BSTR mode, VARIANT_BOOL *p)

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2019