wine-commits March 2020

wine-commits@winehq.org

1 participants
996 discussions

Zebediah Figura : strmbase: Move window.c to quartz.
by Alexandre Julliard 12 Mar '20

12 Mar '20

Module: wine Branch: master Commit: bb8911928fac413530007a7f1f01cb5abdd35b97 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bb8911928fac413530007a7f… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Mar 11 21:10:11 2020 -0500 strmbase: Move window.c to quartz. The only filters that expose IVideoWindow live in quartz. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/Makefile.in | 3 +- dlls/quartz/quartz_private.h | 91 ++++++++++++++++++++++++++++++++++++ dlls/quartz/videorenderer.c | 2 +- dlls/quartz/vmr9.c | 2 +- dlls/{strmbase => quartz}/window.c | 16 +++---- dlls/strmbase/Makefile.in | 3 +- include/wine/strmbase.h | 94 -------------------------------------- 7 files changed, 104 insertions(+), 107 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=bb8911928fac41353000…

1 0

Zebediah Figura : quartz: Pass an IUnknown pointer to the object creation functions.
by Alexandre Julliard 12 Mar '20

12 Mar '20

Module: wine Branch: master Commit: 56a6bc87acbbbee74fb6cd8e77ae61828e274c2d URL: https://source.winehq.org/git/wine.git/?a=commit;h=56a6bc87acbbbee74fb6cd8e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Mar 11 21:10:10 2020 -0500 quartz: Pass an IUnknown pointer to the object creation functions. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/acmwrapper.c | 2 +- dlls/quartz/avidec.c | 2 +- dlls/quartz/dsoundrender.c | 5 ++--- dlls/quartz/filesource.c | 2 +- dlls/quartz/filtergraph.c | 10 +++------- dlls/quartz/filtermapper.c | 26 +++----------------------- dlls/quartz/main.c | 42 +++++++++++++++++++++--------------------- dlls/quartz/memallocator.c | 6 ++---- dlls/quartz/quartz_private.h | 27 +++++++++++++-------------- dlls/quartz/systemclock.c | 2 +- dlls/quartz/videorenderer.c | 6 +++--- dlls/quartz/vmr9.c | 10 +++++----- 12 files changed, 56 insertions(+), 84 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=56a6bc87acbbbee74fb6…

1 0

Zebediah Figura : qedit: Pass an IUnknown pointer to the object creation functions.
by Alexandre Julliard 12 Mar '20

12 Mar '20

Module: wine Branch: master Commit: 98143898dbab4694cc968b4dd3ebc5eadd5186de URL: https://source.winehq.org/git/wine.git/?a=commit;h=98143898dbab4694cc968b4d… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Mar 11 21:10:09 2020 -0500 qedit: Pass an IUnknown pointer to the object creation functions. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qedit/main.c | 16 ++++++++-------- dlls/qedit/mediadet.c | 3 ++- dlls/qedit/nullrenderer.c | 2 +- dlls/qedit/qedit_private.h | 8 ++++---- dlls/qedit/samplegrabber.c | 2 +- dlls/qedit/timeline.c | 2 +- 6 files changed, 17 insertions(+), 16 deletions(-) diff --git a/dlls/qedit/main.c b/dlls/qedit/main.c index 3797d96dcf..f4d1bbb061 100644 --- a/dlls/qedit/main.c +++ b/dlls/qedit/main.c @@ -42,7 +42,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) typedef struct { IClassFactory IClassFactory_iface; LONG ref; - HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); + HRESULT (*create_instance)(IUnknown *outer, IUnknown **out); } IClassFactoryImpl; static inline IClassFactoryImpl *impl_from_IClassFactory(IClassFactory *iface) @@ -53,15 +53,15 @@ static inline IClassFactoryImpl *impl_from_IClassFactory(IClassFactory *iface) struct object_creation_info { const CLSID *clsid; - HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); + HRESULT (*create_instance)(IUnknown *outer, IUnknown **out); }; static const struct object_creation_info object_creation[] = { - { &CLSID_AMTimeline, AMTimeline_create }, - { &CLSID_MediaDet, MediaDet_create }, - { &CLSID_NullRenderer, NullRenderer_create }, - { &CLSID_SampleGrabber, SampleGrabber_create }, + {&CLSID_AMTimeline, timeline_create}, + {&CLSID_MediaDet, media_detector_create}, + {&CLSID_NullRenderer, null_renderer_create}, + {&CLSID_SampleGrabber, sample_grabber_create}, }; static HRESULT WINAPI DSCF_QueryInterface(IClassFactory *iface, REFIID riid, void **ppobj) @@ -109,7 +109,7 @@ static HRESULT WINAPI DSCF_CreateInstance(IClassFactory *iface, IUnknown *pOuter if (pOuter && !IsEqualGUID(&IID_IUnknown, riid)) return E_NOINTERFACE; - hres = This->pfnCreateInstance(pOuter, (LPVOID *) &punk); + hres = This->create_instance(pOuter, &punk); if (SUCCEEDED(hres)) { hres = IUnknown_QueryInterface(punk, riid, ppobj); IUnknown_Release(punk); @@ -186,7 +186,7 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) factory->IClassFactory_iface.lpVtbl = &DSCF_Vtbl; factory->ref = 1; - factory->pfnCreateInstance = object_creation[i].pfnCreateInstance; + factory->create_instance = object_creation[i].create_instance; *ppv = &factory->IClassFactory_iface; return S_OK; diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c index d5c01aff6b..ecfafc44cb 100644 --- a/dlls/qedit/mediadet.c +++ b/dlls/qedit/mediadet.c @@ -637,7 +637,8 @@ static const IMediaDetVtbl IMediaDet_VTable = MediaDet_EnterBitmapGrabMode, }; -HRESULT MediaDet_create(IUnknown * pUnkOuter, LPVOID * ppv) { +HRESULT media_detector_create(IUnknown *pUnkOuter, IUnknown **ppv) +{ MediaDetImpl* obj = NULL; TRACE("(%p,%p)\n", pUnkOuter, ppv); diff --git a/dlls/qedit/nullrenderer.c b/dlls/qedit/nullrenderer.c index 575ecea89b..cbebadfd18 100644 --- a/dlls/qedit/nullrenderer.c +++ b/dlls/qedit/nullrenderer.c @@ -62,7 +62,7 @@ static const struct strmbase_renderer_ops renderer_ops = .renderer_destroy = null_renderer_destroy, }; -HRESULT NullRenderer_create(IUnknown *outer, void **out) +HRESULT null_renderer_create(IUnknown *outer, IUnknown **out) { HRESULT hr; NullRendererImpl *pNullRenderer; diff --git a/dlls/qedit/qedit_private.h b/dlls/qedit/qedit_private.h index 96f21bcb3b..7011c9f70d 100644 --- a/dlls/qedit/qedit_private.h +++ b/dlls/qedit/qedit_private.h @@ -33,9 +33,9 @@ #include "dshow.h" #include "qedit.h" -HRESULT AMTimeline_create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN; -HRESULT MediaDet_create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN; -HRESULT NullRenderer_create(IUnknown *outer, void **out) DECLSPEC_HIDDEN; -HRESULT SampleGrabber_create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HIDDEN; +HRESULT timeline_create(IUnknown *outer, IUnknown **out) DECLSPEC_HIDDEN; +HRESULT media_detector_create(IUnknown *outer, IUnknown **out) DECLSPEC_HIDDEN; +HRESULT null_renderer_create(IUnknown *outer, IUnknown **out) DECLSPEC_HIDDEN; +HRESULT sample_grabber_create(IUnknown *outer, IUnknown **out) DECLSPEC_HIDDEN; #endif /* __QEDIT_PRIVATE_INCLUDED__ */ diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c index 9492620d04..7e29154762 100644 --- a/dlls/qedit/samplegrabber.c +++ b/dlls/qedit/samplegrabber.c @@ -634,7 +634,7 @@ static const struct strmbase_source_ops source_ops = .pfnDecideAllocator = sample_grabber_source_DecideAllocator, }; -HRESULT SampleGrabber_create(IUnknown *outer, void **out) +HRESULT sample_grabber_create(IUnknown *outer, IUnknown **out) { SG_Impl* obj = NULL; ISeekingPassThru *passthru; diff --git a/dlls/qedit/timeline.c b/dlls/qedit/timeline.c index 5d3fb461ff..a00ccdbefb 100644 --- a/dlls/qedit/timeline.c +++ b/dlls/qedit/timeline.c @@ -421,7 +421,7 @@ static const IAMTimelineVtbl IAMTimeline_VTable = Timeline_IAMTimeline_GetDefaultEffectB, }; -HRESULT AMTimeline_create(IUnknown *pUnkOuter, LPVOID *ppv) +HRESULT timeline_create(IUnknown *pUnkOuter, IUnknown **ppv) { TimelineImpl* obj = NULL;

1 0

Zebediah Figura : wine.inf: Manually register qedit.
by Alexandre Julliard 12 Mar '20

12 Mar '20

Module: wine Branch: master Commit: ed0f2909ff10a55abeced50f9c3130b12daf320f URL: https://source.winehq.org/git/wine.git/?a=commit;h=ed0f2909ff10a55abeced50f… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Mar 11 21:10:08 2020 -0500 wine.inf: Manually register qedit. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/wine.inf.in | 1 + 1 file changed, 1 insertion(+) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index bca478e6d7..8267ef34dc 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -2636,6 +2636,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" 11,,mshtml.dll,1 11,,msisip.dll,1 11,,qcap.dll,1 +11,,qedit.dll,1 11,,urlmon.dll,1 11,,windowscodecs.dll,1 11,,winegstreamer.dll,1

1 0

Francois Gouget : kernel32/tests: Remove a 100 ms sleep in 'process exit' children.
by Alexandre Julliard 12 Mar '20

12 Mar '20

Module: wine Branch: master Commit: 496100b9a734268599d3989de81174ac6feac8c5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=496100b9a734268599d3989d… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Mar 12 00:34:43 2020 +0100 kernel32/tests: Remove a 100 ms sleep in 'process exit' children. Such a short pause cannot serve any purpose and this shaves off 1 to 2 seconds of run time. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/process.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 1d426dd017..c5ff473d30 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -4060,7 +4060,6 @@ START_TEST(process) } else if (!strcmp(myARGV[2], "exit")) { - Sleep(100); return; } else if (!strcmp(myARGV[2], "nested") && myARGC >= 4)

1 0

Jefferson Carpenter : services: Initialize OVERLAPPED Offset and OffsetHigh.
by Alexandre Julliard 11 Mar '20

11 Mar '20

Module: wine Branch: master Commit: 4dfd5f22f4032efdc283adf861d82e43c3b08d42 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4dfd5f22f4032efdc283adf8… Author: Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> Date: Wed Mar 11 21:06:56 2020 +0000 services: Initialize OVERLAPPED Offset and OffsetHigh. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48735 Signed-off-by: Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/services/rpc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/programs/services/rpc.c b/programs/services/rpc.c index a657492a5f..0f2c1440c2 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -19,6 +19,7 @@ */ #define WIN32_LEAN_AND_MEAN +#define NONAMELESSSTRUCT #define NONAMELESSUNION #include <stdarg.h> @@ -1133,6 +1134,8 @@ static BOOL process_send_command(struct process_entry *process, const void *data DWORD count, ret; BOOL r; + overlapped.u.s.Offset = 0; + overlapped.u.s.OffsetHigh = 0; overlapped.hEvent = process->overlapped_event; r = WriteFile(process->control_pipe, data, size, &count, &overlapped); if (!r && GetLastError() == ERROR_IO_PENDING)

1 0

Ken Thomases : winemac: Only call -[NSOpenGLContext update] from the main thread.
by Alexandre Julliard 11 Mar '20

11 Mar '20

Module: wine Branch: master Commit: 3deae92a6fe1c2634410fb34a552b7f39fd1adb9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3deae92a6fe1c2634410fb34… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed Mar 11 14:55:53 2020 -0500 winemac: Only call -[NSOpenGLContext update] from the main thread. Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/cocoa_opengl.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/winemac.drv/cocoa_opengl.m b/dlls/winemac.drv/cocoa_opengl.m index e60b0b388b..80a766cbda 100644 --- a/dlls/winemac.drv/cocoa_opengl.m +++ b/dlls/winemac.drv/cocoa_opengl.m @@ -359,8 +359,9 @@ void macdrv_update_opengl_context(macdrv_opengl_context c) [context clearDrawableLeavingSurfaceOnScreen]; context.view = view; } - else + else OnMainThread(^{ [context update]; + }); [context resetSurfaceIfBackingSizeChanged]; } }

1 0

Piotr Caban : winemac: Handle dummy_surface in get_mac_surface.
by Alexandre Julliard 11 Mar '20

11 Mar '20

Module: wine Branch: master Commit: da1e666f57c61f68c77debd6b9ba9aebe0545b85 URL: https://source.winehq.org/git/wine.git/?a=commit;h=da1e666f57c61f68c77debd6… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Mar 11 14:45:54 2020 -0500 winemac: Handle dummy_surface in get_mac_surface. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Ken Thomases <ken(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winemac.drv/surface.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/winemac.drv/surface.c b/dlls/winemac.drv/surface.c index 9850c92aaa..85ff56c957 100644 --- a/dlls/winemac.drv/surface.c +++ b/dlls/winemac.drv/surface.c @@ -70,10 +70,7 @@ struct macdrv_window_surface BITMAPINFO info; /* variable size, must be last */ }; -static struct macdrv_window_surface *get_mac_surface(struct window_surface *surface) -{ - return (struct macdrv_window_surface *)surface; -} +static struct macdrv_window_surface *get_mac_surface(struct window_surface *surface); /*********************************************************************** * update_blit_data @@ -227,6 +224,12 @@ static const struct window_surface_funcs macdrv_surface_funcs = macdrv_surface_destroy, }; +static struct macdrv_window_surface *get_mac_surface(struct window_surface *surface) +{ + if (!surface || surface->funcs != &macdrv_surface_funcs) return NULL; + return (struct macdrv_window_surface *)surface; +} + /*********************************************************************** * create_surface */ @@ -311,7 +314,7 @@ failed: void set_surface_use_alpha(struct window_surface *window_surface, BOOL use_alpha) { struct macdrv_window_surface *surface = get_mac_surface(window_surface); - surface->use_alpha = use_alpha; + if (surface) surface->use_alpha = use_alpha; } /*********************************************************************** @@ -424,6 +427,7 @@ void surface_clip_to_visible_rect(struct window_surface *window_surface, const R { struct macdrv_window_surface *surface = get_mac_surface(window_surface); + if (!surface) return; window_surface->funcs->lock(window_surface); if (surface->drawn)

1 0

Paul Gofman : ntdll: Add semi-stub for RtlGetNativeSystemInformation().
by Alexandre Julliard 11 Mar '20

11 Mar '20

Module: wine Branch: master Commit: c6b501acdcabe7d3ebcf5ce13729fd9f4d9176e9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c6b501acdcabe7d3ebcf5ce1… Author: Paul Gofman <gofmanp(a)gmail.com> Date: Mon Mar 9 14:59:20 2020 +0300 ntdll: Add semi-stub for RtlGetNativeSystemInformation(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40334 Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/nt.c | 20 ++++++++++++++++++++ dlls/ntdll/ntdll.spec | 2 +- dlls/ntdll/tests/info.c | 36 +++++++++++++++++++++++++++++++++++- 3 files changed, 56 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c index f88ded34c1..660d5faf54 100644 --- a/dlls/ntdll/nt.c +++ b/dlls/ntdll/nt.c @@ -3076,6 +3076,26 @@ NTSTATUS WINAPI NtQuerySystemInformation( return ret; } + +/****************************************************************************** + * RtlGetNativeSystemInformation [NTDLL.@] + */ +NTSTATUS WINAPI /* DECLSPEC_HOTPATCH */ RtlGetNativeSystemInformation( + IN SYSTEM_INFORMATION_CLASS SystemInformationClass, + OUT PVOID SystemInformation, + IN ULONG Length, + OUT PULONG ResultLength) +{ + FIXME( "semi-stub, SystemInformationClass %#x, SystemInformation %p, Length %#x, ResultLength %p.\n", + SystemInformationClass, SystemInformation, Length, ResultLength ); + + /* RtlGetNativeSystemInformation function is the same as NtQuerySystemInformation on some Win7 + * versions but there are differences for earlier and newer versions, at least: + * - HighestUserAddress field for SystemBasicInformation; + * - Some information classes are not supported by RtlGetNativeSystemInformation. */ + return NtQuerySystemInformation( SystemInformationClass, SystemInformation, Length, ResultLength ); +} + /****************************************************************************** * NtQuerySystemInformationEx [NTDLL.@] * ZwQuerySystemInformationEx [NTDLL.@] diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index f1f495837d..0ea72e3aef 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -700,7 +700,7 @@ # Yes, Microsoft really misspelled this one! # @ stub RtlGetLengthWithoutTrailingPathSeperators @ stdcall RtlGetLongestNtPathLength() -# @ stub RtlGetNativeSystemInformation +@ stdcall RtlGetNativeSystemInformation(long ptr long ptr) # @ stub RtlGetNextRange @ stdcall RtlGetNtGlobalFlags() @ stdcall RtlGetNtProductType(ptr) diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c index 76de56810c..8dc8bad645 100644 --- a/dlls/ntdll/tests/info.c +++ b/dlls/ntdll/tests/info.c @@ -23,6 +23,7 @@ #include <stdio.h> static NTSTATUS (WINAPI * pNtQuerySystemInformation)(SYSTEM_INFORMATION_CLASS, PVOID, ULONG, PULONG); +static NTSTATUS (WINAPI * pRtlGetNativeSystemInformation)(SYSTEM_INFORMATION_CLASS, PVOID, ULONG, PULONG); static NTSTATUS (WINAPI * pNtQuerySystemInformationEx)(SYSTEM_INFORMATION_CLASS, void*, ULONG, void*, ULONG, ULONG*); static NTSTATUS (WINAPI * pNtPowerInformation)(POWER_INFORMATION_LEVEL, PVOID, ULONG, PVOID, ULONG); static NTSTATUS (WINAPI * pNtQueryInformationProcess)(HANDLE, PROCESSINFOCLASS, PVOID, ULONG, PULONG); @@ -75,6 +76,7 @@ static BOOL InitFunctionPtrs(void) } NTDLL_GET_PROC(NtQuerySystemInformation); + NTDLL_GET_PROC(RtlGetNativeSystemInformation); NTDLL_GET_PROC(NtPowerInformation); NTDLL_GET_PROC(NtQueryInformationProcess); NTDLL_GET_PROC(NtQueryInformationThread); @@ -111,7 +113,7 @@ static void test_query_basic(void) { NTSTATUS status; ULONG ReturnLength; - SYSTEM_BASIC_INFORMATION sbi; + SYSTEM_BASIC_INFORMATION sbi, sbi2; /* This test also covers some basic parameter testing that should be the same for * every information class @@ -153,6 +155,38 @@ static void test_query_basic(void) /* Check if we have some return values */ trace("Number of Processors : %d\n", sbi.NumberOfProcessors); ok( sbi.NumberOfProcessors > 0, "Expected more than 0 processors, got %d\n", sbi.NumberOfProcessors); + + memset(&sbi2, 0, sizeof(sbi2)); + status = pRtlGetNativeSystemInformation(SystemBasicInformation, &sbi2, sizeof(sbi2), &ReturnLength); + ok( status == STATUS_SUCCESS, "Expected STATUS_SUCCESS, got %08x.\n", status); + ok( sizeof(sbi2) == ReturnLength, "Unexpected length %u.\n", ReturnLength); + + ok( sbi.unknown == sbi2.unknown, "Expected unknown %#x, got %#x.\n", sbi.unknown, sbi2.unknown); + ok( sbi.KeMaximumIncrement == sbi2.KeMaximumIncrement, "Expected KeMaximumIncrement %u, got %u.\n", + sbi.KeMaximumIncrement, sbi2.KeMaximumIncrement); + ok( sbi.PageSize == sbi2.PageSize, "Expected PageSize field %u, %u.\n", sbi.PageSize, sbi2.PageSize); + ok( sbi.MmNumberOfPhysicalPages == sbi2.MmNumberOfPhysicalPages, + "Expected MmNumberOfPhysicalPages %u, got %u.\n", + sbi.MmNumberOfPhysicalPages, sbi2.MmNumberOfPhysicalPages); + ok( sbi.MmLowestPhysicalPage == sbi2.MmLowestPhysicalPage, "Expected MmLowestPhysicalPage %u, got %u.\n", + sbi.MmLowestPhysicalPage, sbi2.MmLowestPhysicalPage); + ok( sbi.MmHighestPhysicalPage == sbi2.MmHighestPhysicalPage, "Expected MmHighestPhysicalPage %u, got %u.\n", + sbi.MmHighestPhysicalPage, sbi2.MmHighestPhysicalPage); + /* Higher 32 bits of AllocationGranularity is sometimes garbage on Windows. */ + ok( (ULONG)sbi.AllocationGranularity == (ULONG)sbi2.AllocationGranularity, + "Expected AllocationGranularity %#lx, got %#lx.\n", + sbi.AllocationGranularity, sbi2.AllocationGranularity); + ok( sbi.LowestUserAddress == sbi2.LowestUserAddress, "Expected LowestUserAddress %p, got %p.\n", + (void *)sbi.LowestUserAddress, (void *)sbi2.LowestUserAddress); + /* Not testing HighestUserAddress. The field is different from NtQuerySystemInformation result + * on 32 bit Windows (some of Win8 versions are the exception). Whenever it is different, + * NtQuerySystemInformation returns user space limit (0x0x7ffeffff) and RtlGetNativeSystemInformation + * returns address space limit (0xfffeffff). */ + ok( sbi.ActiveProcessorsAffinityMask == sbi2.ActiveProcessorsAffinityMask, + "Expected ActiveProcessorsAffinityMask %#lx, got %#lx.\n", + sbi.ActiveProcessorsAffinityMask, sbi2.ActiveProcessorsAffinityMask); + ok( sbi.NumberOfProcessors == sbi2.NumberOfProcessors, "Expected NumberOfProcessors %u, got %u.\n", + sbi.NumberOfProcessors, sbi2.NumberOfProcessors); } static void test_query_cpu(void)

1 0

Dmitry Timoshkov : adsldp: Implement IParseDisplayName::ParseDisplayName.
by Alexandre Julliard 11 Mar '20

11 Mar '20

Module: wine Branch: master Commit: 631813bf1a8bf431c3f00c4e8363896631f1ce1c URL: https://source.winehq.org/git/wine.git/?a=commit;h=631813bf1a8bf431c3f00c4e… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Mar 10 15:42:55 2020 +0800 adsldp: Implement IParseDisplayName::ParseDisplayName. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/adsldp/adsldp.c | 24 ++++++++++++++++++++++-- dlls/adsldp/tests/ldap.c | 3 +-- 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/dlls/adsldp/adsldp.c b/dlls/adsldp/adsldp.c index 536932c966..acebf717aa 100644 --- a/dlls/adsldp/adsldp.c +++ b/dlls/adsldp/adsldp.c @@ -101,8 +101,28 @@ static ULONG WINAPI ldap_Release(IParseDisplayName *iface) static HRESULT WINAPI ldap_ParseDisplayName(IParseDisplayName *iface, IBindCtx *bc, LPOLESTR name, ULONG *eaten, IMoniker **mk) { - FIXME("%p,%p,%s,%p,%p: stub\n", iface, bc, debugstr_w(name), eaten, mk); - return E_NOTIMPL; + HRESULT hr; + IADsOpenDSObject *ads_open; + IDispatch *disp; + + TRACE("%p,%p,%s,%p,%p\n", iface, bc, debugstr_w(name), eaten, mk); + + hr = LDAPNamespace_create(&IID_IADsOpenDSObject, (void **)&ads_open); + if (hr != S_OK) return hr; + + hr = IADsOpenDSObject_OpenDSObject(ads_open, name, NULL, NULL, ADS_SECURE_AUTHENTICATION, &disp); + if (hr == S_OK) + { + hr = CreatePointerMoniker((IUnknown *)disp, mk); + if (hr == S_OK) + *eaten = wcslen(name); + + IDispatch_Release(disp); + } + + IADsOpenDSObject_Release(ads_open); + + return hr; } static const IParseDisplayNameVtbl LDAP_PARSE_vtbl = diff --git a/dlls/adsldp/tests/ldap.c b/dlls/adsldp/tests/ldap.c index c5d97b55df..0ecba26817 100644 --- a/dlls/adsldp/tests/ldap.c +++ b/dlls/adsldp/tests/ldap.c @@ -122,7 +122,6 @@ static void test_ParseDisplayName(void) count = 0xdeadbeef; hr = IParseDisplayName_ParseDisplayName(parse, bc, path, &count, &mk); -todo_wine ok(hr == test[i].hr || hr == test[i].hr_ads_open, "%d: got %#x, expected %#x\n", i, hr, test[i].hr); if (hr == S_OK) { @@ -139,7 +138,7 @@ todo_wine count = 0xdeadbeef; hr = MkParseDisplayName(bc, test[i].path, &count, &mk); -todo_wine +todo_wine_if(i == 0 || i == 1 || i == 11 || i == 12) ok(hr == test[i].hr, "%d: got %#x, expected %#x\n", i, hr, test[i].hr); if (hr == S_OK) {

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2020