winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2021
----- 2025 -----
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1163 discussions
Start a n
N
ew thread
Jacek Caban : jscript: Print source location in backtraces.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 2986821b933c239b1b16def8eb87bc0df3ed1d91 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=2986821b933c239b1b16def8…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:57 2021 +0100 jscript: Print source location in backtraces. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/compile.c | 14 ++++++++++++++ dlls/jscript/engine.c | 5 +++-- dlls/jscript/engine.h | 2 ++ dlls/jscript/jscript.c | 14 ++++---------- 4 files changed, 23 insertions(+), 12 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index a1d1171e2ec..dea8db1f37e 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -2236,6 +2236,20 @@ static void resolve_labels(compiler_ctx_t *ctx, unsigned off) ctx->labels_cnt = 0; } +unsigned get_location_line(bytecode_t *code, unsigned loc, unsigned *char_pos) +{ + unsigned line = code->start_line; + const WCHAR *nl, *p; + + for(nl = p = code->source; p < code->source + loc; p++) { + if(*p != '\n') continue; + line++; + nl = p + 1; + } + *char_pos = loc - (nl - code->source); + return line; +} + void release_bytecode(bytecode_t *code) { unsigned i; diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 0fdcb13f142..e1c3783196f 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -2703,7 +2703,7 @@ static void pop_call_frame(script_ctx_t *ctx) static void print_backtrace(script_ctx_t *ctx) { - unsigned depth = 0, i; + unsigned depth = 0, i, line, char_pos; call_frame_t *frame; for(frame = ctx->call_ctx; frame; frame = frame->prev_frame) { @@ -2724,7 +2724,8 @@ static void print_backtrace(script_ctx_t *ctx) }else { WARN("[detached frame]"); } - WARN(")\n"); + line = get_location_line(frame->bytecode, frame->bytecode->instrs[frame->ip].loc, &char_pos); + WARN(") context %s line %u char %u\n", wine_dbgstr_longlong(frame->bytecode->source_context), line, char_pos); if(!(frame->flags & EXEC_RETURN_TO_INTERP)) { WARN("%u\t[native code]\n", depth); diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index 2a8e405a28f..eca27cb1460 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -201,6 +201,8 @@ struct _bytecode_t { HRESULT compile_script(script_ctx_t*,const WCHAR*,UINT64,unsigned,const WCHAR*,const WCHAR*,BOOL,BOOL,named_item_t*,bytecode_t**) DECLSPEC_HIDDEN; void release_bytecode(bytecode_t*) DECLSPEC_HIDDEN; +unsigned get_location_line(bytecode_t *code, unsigned loc, unsigned *char_pos) DECLSPEC_HIDDEN; + static inline bytecode_t *bytecode_addref(bytecode_t *code) { code->ref++; diff --git a/dlls/jscript/jscript.c b/dlls/jscript/jscript.c index 8e729a04324..c5c23889f04 100644 --- a/dlls/jscript/jscript.c +++ b/dlls/jscript/jscript.c @@ -257,8 +257,7 @@ static HRESULT WINAPI JScriptError_GetSourcePosition(IActiveScriptError *iface, { JScriptError *This = impl_from_IActiveScriptError(iface); bytecode_t *code = This->ei.code; - const WCHAR *nl, *p; - unsigned l; + unsigned line_pos, char_pos; TRACE("(%p)->(%p %p %p)\n", This, source_context, line, character); @@ -272,16 +271,11 @@ static HRESULT WINAPI JScriptError_GetSourcePosition(IActiveScriptError *iface, if(!line && !character) return S_OK; - l = code->start_line; - for(nl = p = code->source; p < code->source + This->ei.loc; p++) { - if(*p != '\n') continue; - l++; - nl = p + 1; - } + line_pos = get_location_line(code, This->ei.loc, &char_pos); if(line) - *line = l; + *line = line_pos; if(character) - *character = code->source + This->ei.loc - nl; + *character = char_pos; return S_OK; }
1
0
0
0
Jacek Caban : mshtml: Add animationstart and animationend event support.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: cdb264e871c273abb70022a40dbf890de45bc483 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=cdb264e871c273abb70022a4…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:20 2021 +0100 mshtml: Add animationstart and animationend event support. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 6 ++++++ dlls/mshtml/htmlevent.h | 2 ++ dlls/mshtml/tests/dom.js | 14 ++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 1befd94c742..da2d59bc894 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -109,6 +109,10 @@ typedef struct { static const event_info_t event_info[] = { {L"abort", EVENT_TYPE_EVENT, DISPID_EVMETH_ONABORT, EVENT_BIND_TO_TARGET}, + {L"animationend", EVENT_TYPE_EVENT, DISPID_EVPROP_ONANIMATIONEND, + EVENT_DEFAULTLISTENER | EVENT_BUBBLES}, + {L"animationstart", EVENT_TYPE_EVENT, DISPID_EVPROP_ONANIMATIONSTART, + EVENT_DEFAULTLISTENER | EVENT_BUBBLES}, {L"beforeactivate", EVENT_TYPE_EVENT, DISPID_EVMETH_ONBEFOREACTIVATE, EVENT_FIXME | EVENT_BUBBLES | EVENT_CANCELABLE}, {L"beforeunload", EVENT_TYPE_EVENT, DISPID_EVMETH_ONBEFOREUNLOAD, @@ -185,6 +189,8 @@ static const event_info_t event_info[] = { EVENT_FIXME} }; +C_ASSERT(ARRAY_SIZE(event_info) == EVENTID_LAST); + static eventid_t str_to_eid(const WCHAR *str) { int i; diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index c5d9753722a..69655d2a4ee 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -18,6 +18,8 @@ typedef enum { EVENTID_ABORT, + EVENTID_ANIMATIONEND, + EVENTID_ANIMATIONSTART, EVENTID_BEFOREACTIVATE, EVENTID_BEFOREUNLOAD, EVENTID_BLUR, diff --git a/dlls/mshtml/tests/dom.js b/dlls/mshtml/tests/dom.js index 0064690ee36..7fc6b87882c 100644 --- a/dlls/mshtml/tests/dom.js +++ b/dlls/mshtml/tests/dom.js @@ -401,3 +401,17 @@ sync_test("storage", function() { ok(typeof(window.localStorage) === "object", "typeof(window.localStorage) = " + typeof(window.localStorage)); }); + +async_test("animation", function() { + document.body.innerHTML = + "<style>" + + " @keyframes testAnimation {0% { opacity: 0; } 100% { opacity: 1; }}" + + " .testAnimation { animation-name: testAnimation; animation-duration: 0.01s; }" + + "</style>"; + var div = document.createElement("div"); + div.addEventListener("animationstart", function() { + div.addEventListener("animationend", next_test); + }); + document.body.appendChild(div); + div.className = "testAnimation"; +});
1
0
0
0
Jacek Caban : mshtml/tests: Use more winetest.js helpers in more places.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: e06c541cb6ccaf9140c9b7637170194d1f8041c6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e06c541cb6ccaf9140c9b763…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:59:02 2021 +0100 mshtml/tests: Use more winetest.js helpers in more places. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/dom.js | 113 +++++++++++------------------------ dlls/mshtml/tests/events.js | 142 ++++++++++++++------------------------------ 2 files changed, 80 insertions(+), 175 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=e06c541cb6ccaf9140c9…
1
0
0
0
Jacek Caban : mshtml: Add IHTMLElement7::spellcheck property implementation.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 44dbb88ce417deb8515991aa0a82bc7b344185e2 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=44dbb88ce417deb8515991aa…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:29 2021 +0100 mshtml: Add IHTMLElement7::spellcheck property implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 35 +++++++++++++++++++++++++++++++---- dlls/mshtml/tests/dom.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 74 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index b7aca01c3c1..f93e015f559 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -5414,15 +5414,42 @@ static HRESULT WINAPI HTMLElement7_get_xmsAcceleratorKey(IHTMLElement7 *iface, B static HRESULT WINAPI HTMLElement7_put_spellcheck(IHTMLElement7 *iface, VARIANT v) { HTMLElement *This = impl_from_IHTMLElement7(iface); - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); - return E_NOTIMPL; + + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); + + if(!This->html_element) { + FIXME("non-HTML element\n"); + return E_NOTIMPL; + } + + if(V_VT(&v) != VT_BOOL) { + FIXME("unsupported argument %s\n", debugstr_variant(&v)); + return E_NOTIMPL; + } + + return map_nsresult(nsIDOMHTMLElement_SetSpellcheck(This->html_element, !!V_BOOL(&v))); } static HRESULT WINAPI HTMLElement7_get_spellcheck(IHTMLElement7 *iface, VARIANT *p) { HTMLElement *This = impl_from_IHTMLElement7(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + cpp_bool spellcheck; + nsresult nsres; + + TRACE("(%p)->(%p)\n", This, p); + + if(!This->html_element) { + FIXME("non-HTML element\n"); + return E_NOTIMPL; + } + + nsres = nsIDOMHTMLElement_GetSpellcheck(This->html_element, &spellcheck); + if(NS_FAILED(nsres)) + return map_nsresult(nsres); + + V_VT(p) = VT_BOOL; + V_BOOL(p) = spellcheck ? VARIANT_TRUE : VARIANT_FALSE; + return S_OK; } static HRESULT WINAPI HTMLElement7_put_onmsmanipulationstatechanged(IHTMLElement7 *iface, VARIANT v) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 94923d83add..ebed27b48e8 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -8369,6 +8369,48 @@ static void test_iframe_elem(IHTMLElement *elem) IHTMLDocument2_Release(content_doc); } +static void test_elem_spellcheck(IHTMLElement *iface) +{ + IHTMLElement7 *elem; + VARIANT v; + HRESULT hres; + + hres = IUnknown_QueryInterface(iface, &IID_IHTMLElement7, (void**)&elem); + if(hres == E_NOINTERFACE) { + win_skip("IHTMLElement7 not supported\n"); + return; + } + ok(hres == S_OK, "Could not get IHTMLElement7 interface: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && !V_BOOL(&v), "spellcheck = %s\n", wine_dbgstr_variant(&v)); + + V_VT(&v) = VT_BOOL; + V_BOOL(&v) = VARIANT_TRUE; + hres = IHTMLElement7_put_spellcheck(elem, v); + ok(hres == S_OK, "put_spellcheck failed: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && V_BOOL(&v) == VARIANT_TRUE, "spellcheck = %s\n", + wine_dbgstr_variant(&v)); + + V_VT(&v) = VT_BOOL; + V_BOOL(&v) = VARIANT_FALSE; + hres = IHTMLElement7_put_spellcheck(elem, v); + ok(hres == S_OK, "put_spellcheck failed: %08x\n", hres); + + V_VT(&v) = VT_ERROR; + hres = IHTMLElement7_get_spellcheck(elem, &v); + ok(hres == S_OK, "get_spellcheck failed: %08x\n", hres); + ok(V_VT(&v) == VT_BOOL && !V_BOOL(&v), "spellcheck = %s\n", wine_dbgstr_variant(&v)); + + IHTMLElement7_Release(elem); +} + #define test_stylesheet_csstext(a,b,c) _test_stylesheet_csstext(__LINE__,a,b,c) static void _test_stylesheet_csstext(unsigned line, IHTMLStyleSheet *stylesheet, const WCHAR *exstr, BOOL is_todo) { @@ -8981,6 +9023,7 @@ static void test_elems(IHTMLDocument2 *doc) test_elem_client_size((IUnknown*)elem); test_input_type(input, L"text"); test_elem_istextedit(elem, VARIANT_TRUE); + test_elem_spellcheck(elem); test_node_get_value_str((IUnknown*)elem, NULL); test_node_put_value_str((IUnknown*)elem, L"test");
1
0
0
0
Jacek Caban : mshtml: Expose IHTMLElement7 to scripts.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 926d662e3607bfb7b7cc59fb98460f36466f6858 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=926d662e3607bfb7b7cc59fb…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:17 2021 +0100 mshtml: Expose IHTMLElement7 to scripts. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 3 +++ dlls/mshtml/tests/documentmode.js | 2 ++ 2 files changed, 5 insertions(+) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 2d4a8e8113f..b7aca01c3c1 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -6273,6 +6273,9 @@ void HTMLElement_init_dispex_info(dispex_data_t *info, compat_mode_t mode) dispex_info_add_interface(info, IHTMLElement6_tid, NULL); dispex_info_add_interface(info, IElementTraversal_tid, NULL); } + + if(mode >= COMPAT_MODE_IE10) + dispex_info_add_interface(info, IHTMLElement7_tid, NULL); } static const tid_t HTMLElement_iface_tids[] = { diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js index 75ebe082ce0..d61d3658151 100644 --- a/dlls/mshtml/tests/documentmode.js +++ b/dlls/mshtml/tests/documentmode.js @@ -42,6 +42,8 @@ sync_test("elem_props", function() { test_exposed("addEventListener", v >= 9); test_exposed("removeEventListener", v >= 9); test_exposed("dispatchEvent", v >= 9); + test_exposed("msSetPointerCapture", v >= 10); + if (v >= 9) test_exposed("spellcheck", v >= 10); }); sync_test("doc_props", function() {
1
0
0
0
Jacek Caban : mshtml: Add IHTMLElement7 stub implementation.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 097ca893357b393c4eeb270ace86cad8779c3658 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=097ca893357b393c4eeb270a…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:58:05 2021 +0100 mshtml: Add IHTMLElement7 stub implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlelem.c | 499 +++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/mshtml_private.h | 2 + 2 files changed, 501 insertions(+) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=097ca893357b393c4eeb…
1
0
0
0
Jacek Caban : include: Add IHTMLElement7 declaration.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 48e65244e0cabce8194b738eb93dddca664ac568 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=48e65244e0cabce8194b738e…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 10 14:57:52 2021 +0100 include: Add IHTMLElement7 declaration. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/mshtmdid.h | 35 ++++++ include/mshtml.idl | 353 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 382 insertions(+), 6 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=48e65244e0cabce8194b…
1
0
0
0
Owen Rudge : winspool: Filter invalid characters when creating the PPD filename.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 6b906e82371513e9f5b94fa2d67ad8e0ee865335 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=6b906e82371513e9f5b94fa2…
Author: Owen Rudge <orudge(a)codeweavers.com> Date: Wed Mar 10 12:26:50 2021 +0000 winspool: Filter invalid characters when creating the PPD filename. Fixes potential crash when trying to print if a CUPS printer name contains an asterisk. Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winspool.drv/info.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index fb9c1599d38..4d0542d20e3 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -721,13 +721,18 @@ fail: static WCHAR *get_ppd_filename( const WCHAR *dir, const WCHAR *file_name ) { static const WCHAR dot_ppd[] = {'.','p','p','d',0}; - int len = (strlenW( dir ) + strlenW( file_name )) * sizeof(WCHAR) + sizeof(dot_ppd); - WCHAR *ppd = HeapAlloc( GetProcessHeap(), 0, len ); + static const WCHAR invalid_chars[] = {'*','?','<','>','|','"','/','\\',0}; + int dir_len = strlenW( dir ), file_len = strlenW( file_name ); + int len = (dir_len + file_len + ARRAY_SIZE( dot_ppd )) * sizeof(WCHAR); + WCHAR *ppd = HeapAlloc( GetProcessHeap(), 0, len ), *p; if (!ppd) return NULL; - strcpyW( ppd, dir ); - strcatW( ppd, file_name ); - strcatW( ppd, dot_ppd ); + memcpy( ppd, dir, dir_len * sizeof(WCHAR) ); + memcpy( ppd + dir_len, file_name, file_len * sizeof(WCHAR) ); + memcpy( ppd + dir_len + file_len, dot_ppd, sizeof(dot_ppd) ); + + p = ppd + dir_len; + while ((p = strpbrkW( p, invalid_chars ))) *p++ = '_'; return ppd; }
1
0
0
0
Jactry Zeng : ole32: Handle CF_HDROP format.
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 1a82fbf4333a5f04f2b2a82344eb3279e4b33ad8 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=1a82fbf4333a5f04f2b2a823…
Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Wed Mar 10 10:41:30 2021 +0000 ole32: Handle CF_HDROP format. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ole32/clipboard.c | 1 + dlls/ole32/tests/clipboard.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index a28dcef9eee..e61b3076883 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -1138,6 +1138,7 @@ static DWORD get_tymed_from_nonole_cf(UINT cf) case CF_TEXT: case CF_OEMTEXT: case CF_UNICODETEXT: + case CF_HDROP: return TYMED_ISTREAM | TYMED_HGLOBAL; case CF_ENHMETAFILE: return TYMED_ENHMF; diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c index 0a087aff840..fd8f287680b 100644 --- a/dlls/ole32/tests/clipboard.c +++ b/dlls/ole32/tests/clipboard.c @@ -28,6 +28,8 @@ #include "windef.h" #include "winbase.h" #include "objbase.h" +#include "shellapi.h" +#include "shlobj.h" #include "wine/test.h" @@ -1513,6 +1515,24 @@ static HENHMETAFILE create_emf(void) return CloseEnhMetaFile(hdc); } +static HDROP create_dropped_file(void) +{ + WCHAR path[] = L"C:\\testfile1\0"; + DROPFILES *dropfiles; + DWORD offset; + HDROP hdrop; + + offset = sizeof(DROPFILES); + hdrop = GlobalAlloc(GHND, offset + sizeof(path)); + dropfiles = GlobalLock(hdrop); + dropfiles->pFiles = offset; + dropfiles->fWide = TRUE; + memcpy((char *)dropfiles + offset, path, sizeof(path)); + GlobalUnlock(hdrop); + + return hdrop; +} + static void test_nonole_clipboard(void) { HRESULT hr; @@ -1524,6 +1544,7 @@ static void test_nonole_clipboard(void) HENHMETAFILE emf; STGMEDIUM med; DWORD obj_type; + HDROP hdrop; r = OpenClipboard(NULL); ok(r, "gle %d\n", GetLastError()); @@ -1552,6 +1573,7 @@ static void test_nonole_clipboard(void) hblob = GlobalAlloc(GMEM_DDESHARE|GMEM_MOVEABLE|GMEM_ZEROINIT, 10); emf = create_emf(); hstorage = create_storage(); + hdrop = create_dropped_file(); r = OpenClipboard(NULL); ok(r, "gle %d\n", GetLastError()); @@ -1563,6 +1585,8 @@ static void test_nonole_clipboard(void) ok(h == emf, "got %p\n", h); h = SetClipboardData(cf_storage, hstorage); ok(h == hstorage, "got %p\n", h); + h = SetClipboardData(CF_HDROP, hdrop); + ok(h == hdrop, "got %p\n", h); r = CloseClipboard(); ok(r, "gle %d\n", GetLastError()); @@ -1608,6 +1632,14 @@ static void test_nonole_clipboard(void) ok(fmt.lindex == -1, "lindex %d\n", fmt.lindex); ok(fmt.tymed == (TYMED_ISTREAM | TYMED_HGLOBAL), "tymed %x\n", fmt.tymed); + hr = IEnumFORMATETC_Next(enum_fmt, 1, &fmt, NULL); + ok(hr == S_OK, "got %08x\n", hr); + ok(fmt.cfFormat == CF_HDROP, "cf %04x\n", fmt.cfFormat); + ok(fmt.ptd == NULL, "ptd %p\n", fmt.ptd); + ok(fmt.dwAspect == DVASPECT_CONTENT, "aspect %x\n", fmt.dwAspect); + ok(fmt.lindex == -1, "lindex %d\n", fmt.lindex); + ok(fmt.tymed == (TYMED_ISTREAM | TYMED_HGLOBAL), "tymed %x\n", fmt.tymed); + hr = IEnumFORMATETC_Next(enum_fmt, 1, &fmt, NULL); ok(hr == S_OK, "got %08x\n", hr); /* User32 adds some synthesised formats */
1
0
0
0
Zebediah Figura : d3d11: Use wined3d_device_context_set_blend_state().
by Alexandre Julliard
10 Mar '21
10 Mar '21
Module: wine Branch: master Commit: 6cc5f9a6ff661d4c055d26be25dba95bfd4c8ac1 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=6cc5f9a6ff661d4c055d26be…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Mar 9 20:09:01 2021 -0600 d3d11: Use wined3d_device_context_set_blend_state(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c index 6a6744d22af..6f98227bef3 100644 --- a/dlls/d3d11/device.c +++ b/dlls/d3d11/device.c @@ -1000,7 +1000,7 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetRenderTargetsAndUnord static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetBlendState(ID3D11DeviceContext1 *iface, ID3D11BlendState *blend_state, const float blend_factor[4], UINT sample_mask) { - struct d3d_device *device = device_from_immediate_ID3D11DeviceContext1(iface); + struct d3d11_immediate_context *context = impl_from_ID3D11DeviceContext1(iface); static const float default_blend_factor[] = {1.0f, 1.0f, 1.0f, 1.0f}; struct d3d_blend_state *blend_state_impl; @@ -1012,10 +1012,10 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_OMSetBlendState(ID3D11Devi wined3d_mutex_lock(); if (!(blend_state_impl = unsafe_impl_from_ID3D11BlendState(blend_state))) - wined3d_device_set_blend_state(device->wined3d_device, NULL, + wined3d_device_context_set_blend_state(context->wined3d_context, NULL, (const struct wined3d_color *)blend_factor, sample_mask); else - wined3d_device_set_blend_state(device->wined3d_device, blend_state_impl->wined3d_state, + wined3d_device_context_set_blend_state(context->wined3d_context, blend_state_impl->wined3d_state, (const struct wined3d_color *)blend_factor, sample_mask); wined3d_mutex_unlock(); }
1
0
0
0
← Newer
1
...
82
83
84
85
86
87
88
...
117
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
Results per page:
10
25
50
100
200