wine-commits February 2022

wine-commits@winehq.org

2 participants
1495 discussions

Zebediah Figura : quartz/filtergraph: Clean up CheckCircularConnection().
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: e41b3529e394d53ffac0e8ac1e88749d8d942329 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e41b3529e394d53ffac0e8ac… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:58:09 2022 -0600 quartz/filtergraph: Clean up CheckCircularConnection(). Use clearer variable names, and simplify the error handling. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 91 ++++++++++++++++++++++++----------------------- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index 74f1adcb665..0dccf2b7fb4 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -771,65 +771,66 @@ static HRESULT WINAPI FilterGraph2_FindFilterByName(IFilterGraph2 *iface, return VFW_E_NOT_FOUND; } -/* Don't allow a circular connection to form, return VFW_E_CIRCULAR_GRAPH if this would be the case. - * A circular connection will be formed if from the filter of the output pin, the input pin can be reached - */ -static HRESULT CheckCircularConnection(struct filter_graph *This, IPin *out, IPin *in) +static HRESULT check_cyclic_connection(IPin *source, IPin *sink) { + IPin *upstream_source, *upstream_sink; + PIN_INFO source_info, sink_info; + IEnumPins *enumpins; HRESULT hr; - PIN_INFO info_out, info_in; - hr = IPin_QueryPinInfo(out, &info_out); + hr = IPin_QueryPinInfo(sink, &sink_info); if (FAILED(hr)) + { + ERR("Failed to query pin, hr %#x.\n", hr); return hr; + } + IBaseFilter_Release(sink_info.pFilter); - hr = IPin_QueryPinInfo(in, &info_in); - if (SUCCEEDED(hr)) - IBaseFilter_Release(info_in.pFilter); + hr = IPin_QueryPinInfo(source, &source_info); if (FAILED(hr)) - goto out; + { + ERR("Failed to query pin, hr %#x.\n", hr); + return hr; + } - if (info_out.pFilter == info_in.pFilter) - hr = VFW_E_CIRCULAR_GRAPH; - else + if (sink_info.pFilter == source_info.pFilter) { - IEnumPins *enumpins; - IPin *test; + WARN("Cyclic connection detected; returning VFW_E_CIRCULAR_GRAPH.\n"); + IBaseFilter_Release(source_info.pFilter); + return VFW_E_CIRCULAR_GRAPH; + } - hr = IBaseFilter_EnumPins(info_out.pFilter, &enumpins); - if (FAILED(hr)) - goto out; + hr = IBaseFilter_EnumPins(source_info.pFilter, &enumpins); + if (FAILED(hr)) + { + ERR("Failed to enumerate pins, hr %#x.\n", hr); + IBaseFilter_Release(source_info.pFilter); + return hr; + } + + while ((hr = IEnumPins_Next(enumpins, 1, &upstream_sink, NULL)) == S_OK) + { + PIN_DIRECTION dir = PINDIR_OUTPUT; - IEnumPins_Reset(enumpins); - while ((hr = IEnumPins_Next(enumpins, 1, &test, NULL)) == S_OK) + IPin_QueryDirection(upstream_sink, &dir); + if (dir == PINDIR_INPUT && IPin_ConnectedTo(upstream_sink, &upstream_source) == S_OK) { - PIN_DIRECTION dir = PINDIR_OUTPUT; - IPin_QueryDirection(test, &dir); - if (dir == PINDIR_INPUT) + hr = check_cyclic_connection(upstream_source, sink); + IPin_Release(upstream_source); + if (FAILED(hr)) { - IPin *victim = NULL; - IPin_ConnectedTo(test, &victim); - if (victim) - { - hr = CheckCircularConnection(This, victim, in); - IPin_Release(victim); - if (FAILED(hr)) - { - IPin_Release(test); - break; - } - } + IPin_Release(upstream_sink); + IEnumPins_Release(enumpins); + IBaseFilter_Release(source_info.pFilter); + return hr; } - IPin_Release(test); } - IEnumPins_Release(enumpins); + IPin_Release(upstream_sink); } + IEnumPins_Release(enumpins); -out: - IBaseFilter_Release(info_out.pFilter); - if (FAILED(hr)) - ERR("Checking filtergraph returned %08x, something's not right!\n", hr); - return hr; + IBaseFilter_Release(source_info.pFilter); + return S_OK; } static struct filter *find_sorted_filter(struct filter_graph *graph, IBaseFilter *iface) @@ -855,7 +856,7 @@ static void sort_filter_recurse(struct filter_graph *graph, struct filter *filte TRACE("Sorting filter %p.\n", filter->filter); - /* Cyclic connections should be caught by CheckCircularConnection(). */ + /* Cyclic connections should be caught by check_cyclic_connection(). */ assert(!filter->sorting); filter->sorting = TRUE; @@ -935,13 +936,13 @@ static HRESULT WINAPI FilterGraph2_ConnectDirect(IFilterGraph2 *iface, IPin *ppi { if (dir == PINDIR_INPUT) { - hr = CheckCircularConnection(This, ppinOut, ppinIn); + hr = check_cyclic_connection(ppinOut, ppinIn); if (SUCCEEDED(hr)) hr = IPin_Connect(ppinOut, ppinIn, pmt); } else { - hr = CheckCircularConnection(This, ppinIn, ppinOut); + hr = check_cyclic_connection(ppinIn, ppinOut); if (SUCCEEDED(hr)) hr = IPin_Connect(ppinIn, ppinOut, pmt); }

1 0

Zebediah Figura : quartz/filtergraph: Remove redundant checks for pin direction from CheckCircularConnection().
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: ae9d64ed4cf1f1d80c5faee1b5a90a6d5739bc97 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ae9d64ed4cf1f1d80c5faee1… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:58:08 2022 -0600 quartz/filtergraph: Remove redundant checks for pin direction from CheckCircularConnection(). These are already checked in the callers. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index aa646615428..74f1adcb665 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -782,22 +782,12 @@ static HRESULT CheckCircularConnection(struct filter_graph *This, IPin *out, IPi hr = IPin_QueryPinInfo(out, &info_out); if (FAILED(hr)) return hr; - if (info_out.dir != PINDIR_OUTPUT) - { - IBaseFilter_Release(info_out.pFilter); - return VFW_E_CANNOT_CONNECT; - } hr = IPin_QueryPinInfo(in, &info_in); if (SUCCEEDED(hr)) IBaseFilter_Release(info_in.pFilter); if (FAILED(hr)) goto out; - if (info_in.dir != PINDIR_INPUT) - { - hr = VFW_E_CANNOT_CONNECT; - goto out; - } if (info_out.pFilter == info_in.pFilter) hr = VFW_E_CIRCULAR_GRAPH;

1 0

Zebediah Figura : quartz/filtergraph: Remove "#if 1" from CheckCircularConnection().
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 9942693a8552b7b83ccb67fccec68755bb5451c5 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9942693a8552b7b83ccb67fc… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:58:07 2022 -0600 quartz/filtergraph: Remove "#if 1" from CheckCircularConnection(). Cycle detection is done by native quartz. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index 4132ffa5b2f..aa646615428 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -776,7 +776,6 @@ static HRESULT WINAPI FilterGraph2_FindFilterByName(IFilterGraph2 *iface, */ static HRESULT CheckCircularConnection(struct filter_graph *This, IPin *out, IPin *in) { -#if 1 HRESULT hr; PIN_INFO info_out, info_in; @@ -841,10 +840,6 @@ out: if (FAILED(hr)) ERR("Checking filtergraph returned %08x, something's not right!\n", hr); return hr; -#else - /* Debugging filtergraphs not enabled */ - return S_OK; -#endif } static struct filter *find_sorted_filter(struct filter_graph *graph, IBaseFilter *iface)

1 0

Zebediah Figura : quartz/tests: Test more interfaces exposed by the filter graph.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 09cf9b8a13594bd9f344a5c1771536017b939c63 URL: https://source.winehq.org/git/wine.git/?a=commit;h=09cf9b8a13594bd9f344a5c1… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Feb 2 22:58:06 2022 -0600 quartz/tests: Test more interfaces exposed by the filter graph. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/filtergraph.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index bd086445a3b..98f7b30717d 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -98,23 +98,30 @@ static void test_interfaces(void) IFilterGraph2 *graph = create_graph(); check_interface(graph, &IID_IBasicAudio, TRUE); + check_interface(graph, &IID_IBasicVideo, TRUE); check_interface(graph, &IID_IBasicVideo2, TRUE); + check_interface(graph, &IID_IFilterGraph, TRUE); check_interface(graph, &IID_IFilterGraph2, TRUE); check_interface(graph, &IID_IFilterMapper, TRUE); + check_interface(graph, &IID_IFilterMapper2, TRUE); check_interface(graph, &IID_IFilterMapper3, TRUE); + check_interface(graph, &IID_IGraphBuilder, TRUE); check_interface(graph, &IID_IGraphConfig, TRUE); check_interface(graph, &IID_IGraphVersion, TRUE); check_interface(graph, &IID_IMediaControl, TRUE); check_interface(graph, &IID_IMediaEvent, TRUE); - check_interface(graph, &IID_IMediaFilter, TRUE); + check_interface(graph, &IID_IMediaEventEx, TRUE); check_interface(graph, &IID_IMediaEventSink, TRUE); + check_interface(graph, &IID_IMediaFilter, TRUE); check_interface(graph, &IID_IMediaPosition, TRUE); check_interface(graph, &IID_IMediaSeeking, TRUE); check_interface(graph, &IID_IObjectWithSite, TRUE); check_interface(graph, &IID_IVideoFrameStep, TRUE); check_interface(graph, &IID_IVideoWindow, TRUE); + check_interface(graph, &IID_IUnknown, TRUE); check_interface(graph, &IID_IBaseFilter, FALSE); + check_interface(graph, &IID_IDispatch, FALSE); IFilterGraph2_Release(graph); }

1 0

Zebediah Figura : shell32: Move StrRetToStrN*() helpers to shell32_main.h.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 2d6a314ecf6d4bba3f266a8ef0c8c5813837059b URL: https://source.winehq.org/git/wine.git/?a=commit;h=2d6a314ecf6d4bba3f266a8e… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:56:41 2022 -0600 shell32: Move StrRetToStrN*() helpers to shell32_main.h. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32_main.h | 3 +++ dlls/shell32/undocshell.h | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h index ea8019a85e2..14011489e86 100644 --- a/dlls/shell32/shell32_main.h +++ b/dlls/shell32/shell32_main.h @@ -290,4 +290,7 @@ typedef struct ITEMIDLIST idl; } CWTESTPATHSTRUCT; +BOOL WINAPI StrRetToStrNA(char *, DWORD, STRRET *, const ITEMIDLIST *); +BOOL WINAPI StrRetToStrNW(WCHAR *, DWORD, STRRET *, const ITEMIDLIST *); + #endif diff --git a/dlls/shell32/undocshell.h b/dlls/shell32/undocshell.h index 881832c5185..61c2ff4069f 100644 --- a/dlls/shell32/undocshell.h +++ b/dlls/shell32/undocshell.h @@ -31,12 +31,6 @@ extern "C" { #endif /* defined(__cplusplus) */ -/* - string functions -*/ -BOOL WINAPI StrRetToStrNA(LPSTR,DWORD,LPSTRRET,const ITEMIDLIST*); -BOOL WINAPI StrRetToStrNW(LPWSTR,DWORD,LPSTRRET,const ITEMIDLIST*); - /**************************************************************************** * Memory Routines */

1 0

Zebediah Figura : shell32: Move explorer window messages definitions to shell32_main.h.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 295285620aa2557115ea020009da5315a9190ad2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=295285620aa2557115ea0200… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:56:40 2022 -0600 shell32: Move explorer window messages definitions to shell32_main.h. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shell32_main.h | 22 ++++++++++++++++++++++ dlls/shell32/undocshell.h | 25 ------------------------- 2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h index b98629298aa..ea8019a85e2 100644 --- a/dlls/shell32/shell32_main.h +++ b/dlls/shell32/shell32_main.h @@ -268,4 +268,26 @@ static inline WCHAR *strdupAtoW(const char *str) return ret; } +/* explorer ("cabinet") window messages */ +#define CWM_SETPATH (WM_USER + 2) +#define CWM_WANTIDLE (WM_USER + 3) +#define CWM_GETSETCURRENTINFO (WM_USER + 4) +#define CWM_SELECTITEM (WM_USER + 5) +#define CWM_SELECTITEMSTR (WM_USER + 6) +#define CWM_GETISHELLBROWSER (WM_USER + 7) +#define CWM_TESTPATH (WM_USER + 9) +#define CWM_STATECHANGE (WM_USER + 10) +#define CWM_GETPATH (WM_USER + 12) + +/* CWM_TESTPATH types */ +#define CWTP_ISEQUAL 0 +#define CWTP_ISCHILD 1 + +/* CWM_TESTPATH structure */ +typedef struct +{ + DWORD dwType; + ITEMIDLIST idl; +} CWTESTPATHSTRUCT; + #endif diff --git a/dlls/shell32/undocshell.h b/dlls/shell32/undocshell.h index e4ed7c3630a..881832c5185 100644 --- a/dlls/shell32/undocshell.h +++ b/dlls/shell32/undocshell.h @@ -61,31 +61,6 @@ LPVOID WINAPI SHLockShared( BOOL WINAPI SHUnlockShared(LPVOID pv); -/**************************************************************************** - * Cabinet Window Messages - */ - -#define CWM_SETPATH (WM_USER + 2) -#define CWM_WANTIDLE (WM_USER + 3) -#define CWM_GETSETCURRENTINFO (WM_USER + 4) -#define CWM_SELECTITEM (WM_USER + 5) -#define CWM_SELECTITEMSTR (WM_USER + 6) -#define CWM_GETISHELLBROWSER (WM_USER + 7) -#define CWM_TESTPATH (WM_USER + 9) -#define CWM_STATECHANGE (WM_USER + 10) -#define CWM_GETPATH (WM_USER + 12) - -/* CWM_TESTPATH types */ -#define CWTP_ISEQUAL 0 -#define CWTP_ISCHILD 1 - -/* CWM_TESTPATH structure */ -typedef struct -{ - DWORD dwType; - ITEMIDLIST idl; -} CWTESTPATHSTRUCT,* LPCWTESTPATHSTRUCT; - /**************************************************************************** * System Imagelist Routines */

1 0

Zebediah Figura : shell32: Move SHCreateLinks() flags to shlfolder.c.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: c2f25d25b648b19481ea102530e4b245dce85104 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c2f25d25b648b19481ea1025… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:56:39 2022 -0600 shell32: Move SHCreateLinks() flags to shlfolder.c. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shlfolder.c | 4 ++++ dlls/shell32/undocshell.h | 11 ----------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/dlls/shell32/shlfolder.c b/dlls/shell32/shlfolder.c index 10aafc160c0..2ea6af11271 100644 --- a/dlls/shell32/shlfolder.c +++ b/dlls/shell32/shlfolder.c @@ -48,6 +48,10 @@ WINE_DEFAULT_DEBUG_CHANNEL (shell); +/* SHCreateLinks flags */ +#define SHCLF_PREFIXNAME 0x01 +#define SHCLF_CREATEONDESKTOP 0x02 + /*************************************************************************** * SHELL32_GetCustomFolderAttribute (internal function) * diff --git a/dlls/shell32/undocshell.h b/dlls/shell32/undocshell.h index dd20090d7bd..e4ed7c3630a 100644 --- a/dlls/shell32/undocshell.h +++ b/dlls/shell32/undocshell.h @@ -226,17 +226,6 @@ HRESULT WINAPI SHCreateDefClassObject( void WINAPI SHFreeUnusedLibraries(void); -/* SHCreateLinks flags */ -#define SHCLF_PREFIXNAME 0x01 -#define SHCLF_CREATEONDESKTOP 0x02 - -HRESULT WINAPI SHCreateLinks( - HWND hWnd, - LPCSTR lpszDir, - LPDATAOBJECT lpDataObject, - UINT uFlags, - LPITEMIDLIST *lppidlLinks); - DWORD WINAPI CheckEscapesA(LPSTR string, DWORD len); DWORD WINAPI CheckEscapesW(LPWSTR string, DWORD len);

1 0

Zebediah Figura : shell32: Move RegisterShellHook() definitions to shellord.c.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 6abfd74a8bb17bb27944fc796622e07f82560ebb URL: https://source.winehq.org/git/wine.git/?a=commit;h=6abfd74a8bb17bb27944fc79… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:56:38 2022 -0600 shell32: Move RegisterShellHook() definitions to shellord.c. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellord.c | 6 ++++++ dlls/shell32/undocshell.h | 10 ---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c index a138f381a92..57308e1c988 100644 --- a/dlls/shell32/shellord.c +++ b/dlls/shell32/shellord.c @@ -55,6 +55,12 @@ WINE_DECLARE_DEBUG_CHANNEL(pidl); #define SHWFF_REMOVE 0x02 #define SHWFF_WAIT 0x04 +/* RegisterShellHook types */ +#define RSH_DEREGISTER 0 +#define RSH_REGISTER 1 +#define RSH_REGISTER_PROGMAN 2 +#define RSH_REGISTER_TASKMAN 3 + /* FIXME: !!! move CREATEMRULIST and flags to header file !!! */ /* !!! it is in both here and comctl32undoc.c !!! */ typedef struct tagCREATEMRULIST diff --git a/dlls/shell32/undocshell.h b/dlls/shell32/undocshell.h index 459c51c8454..dd20090d7bd 100644 --- a/dlls/shell32/undocshell.h +++ b/dlls/shell32/undocshell.h @@ -211,16 +211,6 @@ BOOL WINAPI PathFindOnPathAW(LPVOID sFile, LPCVOID *sOtherDirs); WORD WINAPI ArrangeWindows(HWND hwndParent, DWORD dwReserved, const RECT *lpRect, WORD cKids, const HWND *lpKids); -/* RegisterShellHook types */ -#define RSH_DEREGISTER 0 -#define RSH_REGISTER 1 -#define RSH_REGISTER_PROGMAN 2 -#define RSH_REGISTER_TASKMAN 3 - -BOOL WINAPI RegisterShellHook( - HWND hWnd, - DWORD dwType); - /* SHCreateDefClassObject callback function */ typedef HRESULT (CALLBACK *LPFNCDCOCALLBACK)( LPUNKNOWN pUnkOuter,

1 0

Zebediah Figura : shell32: Move SHWaitForFileToOpen() flags to shellord.c.
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: e1aa67132721247050f39a126e9cdfda99dbdcb1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e1aa67132721247050f39a12… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Feb 2 22:56:37 2022 -0600 shell32: Move SHWaitForFileToOpen() flags to shellord.c. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellord.c | 5 +++++ dlls/shell32/undocshell.h | 10 ---------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c index 2c73ce18940..a138f381a92 100644 --- a/dlls/shell32/shellord.c +++ b/dlls/shell32/shellord.c @@ -50,6 +50,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(shell); WINE_DECLARE_DEBUG_CHANNEL(pidl); +/* SHWaitForFileToOpen flags */ +#define SHWFF_ADD 0x01 +#define SHWFF_REMOVE 0x02 +#define SHWFF_WAIT 0x04 + /* FIXME: !!! move CREATEMRULIST and flags to header file !!! */ /* !!! it is in both here and comctl32undoc.c !!! */ typedef struct tagCREATEMRULIST diff --git a/dlls/shell32/undocshell.h b/dlls/shell32/undocshell.h index 5ed8d25f234..459c51c8454 100644 --- a/dlls/shell32/undocshell.h +++ b/dlls/shell32/undocshell.h @@ -208,16 +208,6 @@ BOOL WINAPI PathFindOnPathAW(LPVOID sFile, LPCVOID *sOtherDirs); * Misc Stuff */ -/* SHWaitForFileToOpen flags */ -#define SHWFF_ADD 0x01 -#define SHWFF_REMOVE 0x02 -#define SHWFF_WAIT 0x04 - -BOOL WINAPI SHWaitForFileToOpen( - LPCITEMIDLIST pidl, - DWORD dwFlags, - DWORD dwTimeout); - WORD WINAPI ArrangeWindows(HWND hwndParent, DWORD dwReserved, const RECT *lpRect, WORD cKids, const HWND *lpKids);

1 0

Alex Henrie : winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity).
by Alexandre Julliard 03 Feb '22

03 Feb '22

Module: wine Branch: master Commit: 5a12c6a481c157a299821cb85874819c181081a4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5a12c6a481c157a299821cb8… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Wed Feb 2 21:35:01 2022 -0700 winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity). Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winspool.drv/info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 971eb654e6a..52edd362622 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -1775,7 +1775,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap, WCHAR *outputW; ret = DeviceCapabilitiesW(device_name, port, cap, NULL, devmode); - if (ret == -1) return ret; + if (ret == -1) goto cleanup; switch (cap) { case DC_BINNAMES: @@ -1795,6 +1795,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap, } else { ret = DeviceCapabilitiesW(device_name, port, cap, (WCHAR *)output, devmode); } +cleanup: HeapFree(GetProcessHeap(), 0, device_name); HeapFree(GetProcessHeap(), 0, devmode); HeapFree(GetProcessHeap(), 0, port);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2022