wine-commits June 2022

wine-commits@winehq.org

2 participants
791 discussions

Alexandre Julliard : makefiles: Add separate variables for Unix flags and libraries.
by Alexandre Julliard 29 Jun '22

29 Jun '22

Module: wine Branch: master Commit: 194e09baeca42b369b391d87c9605338b8fbc978 URL: https://source.winehq.org/git/wine.git/?a=commit;h=194e09baeca42b369b391d87… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 29 11:06:16 2022 +0200 makefiles: Add separate variables for Unix flags and libraries. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/bcrypt/Makefile.in | 2 +- dlls/capi2032/Makefile.in | 4 ++-- dlls/crypt32/Makefile.in | 4 ++-- dlls/dnsapi/Makefile.in | 2 +- dlls/dwrite/Makefile.in | 2 +- dlls/gphoto2.ds/Makefile.in | 5 +++-- dlls/kerberos/Makefile.in | 2 +- dlls/mountmgr.sys/Makefile.in | 4 ++-- dlls/nsiproxy.sys/Makefile.in | 2 +- dlls/ntdll/Makefile.in | 4 ++-- dlls/openal32/Makefile.in | 2 +- dlls/opencl/Makefile.in | 2 +- dlls/sane.ds/Makefile.in | 4 ++-- dlls/secur32/Makefile.in | 2 +- dlls/win32u/Makefile.in | 4 ++-- dlls/winealsa.drv/Makefile.in | 2 +- dlls/wineandroid.drv/Makefile.in | 2 +- dlls/winebus.sys/Makefile.in | 4 ++-- dlls/winecoreaudio.drv/Makefile.in | 2 +- dlls/winegstreamer/Makefile.in | 4 ++-- dlls/winemac.drv/Makefile.in | 2 +- dlls/wineoss.drv/Makefile.in | 4 ++-- dlls/winepulse.drv/Makefile.in | 4 ++-- dlls/wineusb.sys/Makefile.in | 4 ++-- dlls/winevulkan/Makefile.in | 2 +- dlls/winex11.drv/Makefile.in | 4 ++-- dlls/winspool.drv/Makefile.in | 4 ++-- dlls/wldap32/Makefile.in | 4 ++-- dlls/wpcap/Makefile.in | 2 +- libs/wine/Makefile.in | 2 +- server/Makefile.in | 2 +- tools/makedep.c | 20 +++++++++++++------- tools/sfnt2fon/Makefile.in | 5 ++--- tools/wmc/Makefile.in | 3 +-- tools/wrc/Makefile.in | 2 +- 35 files changed, 64 insertions(+), 59 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=194e09baeca42b369b39…

1 0

Alexandre Julliard : makefiles: Use the defined external lib variables also when building the libs themselves.
by Alexandre Julliard 29 Jun '22

29 Jun '22

Module: wine Branch: master Commit: e2d96342df3c4f7ae9d13a550a8a95ea94736cb6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e2d96342df3c4f7ae9d13a55… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Jun 29 09:33:15 2022 +0200 makefiles: Use the defined external lib variables also when building the libs themselves. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/Makefile.in | 1 + libs/faudio/Makefile.in | 2 +- libs/gsm/Makefile.in | 2 +- libs/jxr/Makefile.in | 3 ++- libs/lcms2/Makefile.in | 2 +- libs/mpg123/Makefile.in | 2 +- libs/tiff/Makefile.in | 2 +- libs/vkd3d/Makefile.in | 2 +- tools/makedep.c | 12 +++++++++++- 9 files changed, 20 insertions(+), 8 deletions(-) diff --git a/include/Makefile.in b/include/Makefile.in index d03c6d9412a..d5f389b506a 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -429,6 +429,7 @@ SOURCES = \ mimeole.idl \ minidumpapiset.h \ minmax.h \ + minschannel.h \ mlang.idl \ mmc.idl \ mmddk.h \ diff --git a/libs/faudio/Makefile.in b/libs/faudio/Makefile.in index 3a9bb591227..639cd2cbff0 100644 --- a/libs/faudio/Makefile.in +++ b/libs/faudio/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = libfaudio.a -EXTRAINCL = -I$(srcdir)/include +EXTRAINCL = $(FAUDIO_PE_CFLAGS) EXTRADEFS = -DFAUDIO_WIN32_PLATFORM -DHAVE_WMADEC -DNDEBUG C_SRCS = \ diff --git a/libs/gsm/Makefile.in b/libs/gsm/Makefile.in index 36c749aa60f..d2aefc937f9 100644 --- a/libs/gsm/Makefile.in +++ b/libs/gsm/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = libgsm.a -EXTRAINCL = -I$(srcdir)/inc +EXTRAINCL = $(GSM_PE_CFLAGS) EXTRADEFS = -DWAV49 C_SRCS = \ diff --git a/libs/jxr/Makefile.in b/libs/jxr/Makefile.in index 5203dc970aa..3162cfca263 100644 --- a/libs/jxr/Makefile.in +++ b/libs/jxr/Makefile.in @@ -1,5 +1,6 @@ EXTLIB = libjxr.a -EXTRAINCL = -I$(srcdir)/jxrgluelib -I$(srcdir)/image/sys -DDISABLE_PERF_MEASUREMENT +EXTRAINCL = $(JXR_PE_CFLAGS) +EXTRADEFS = -DDISABLE_PERF_MEASUREMENT C_SRCS = \ image/decode/JXRTranscode.c \ diff --git a/libs/lcms2/Makefile.in b/libs/lcms2/Makefile.in index 6549d5718b5..c2aafa9c70a 100644 --- a/libs/lcms2/Makefile.in +++ b/libs/lcms2/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = liblcms2.a -EXTRAINCL = -I$(srcdir)/include +EXTRAINCL = $(LCMS2_PE_CFLAGS) C_SRCS = \ src/cmsalpha.c \ diff --git a/libs/mpg123/Makefile.in b/libs/mpg123/Makefile.in index 6859f66f68a..7974c34ed91 100644 --- a/libs/mpg123/Makefile.in +++ b/libs/mpg123/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = libmpg123.a -EXTRAINCL = -I$(srcdir)/src -I$(srcdir)/src/compat -I$(srcdir)/src/libmpg123 +EXTRAINCL = -I$(srcdir)/src -I$(srcdir)/src/compat $(MPG123_PE_CFLAGS) EXTRADEFS = -DOPT_GENERIC_DITHER -DREAL_IS_FLOAT -DNO_CATCHSIGNAL -DMPG123_NO_LARGENAME C_SRCS = \ diff --git a/libs/tiff/Makefile.in b/libs/tiff/Makefile.in index f8ceb5006d4..7c793f3e2f9 100644 --- a/libs/tiff/Makefile.in +++ b/libs/tiff/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = libtiff.a -EXTRAINCL = -I$(srcdir)/libtiff $(JPEG_PE_CFLAGS) $(ZLIB_PE_CFLAGS) +EXTRAINCL = $(TIFF_PE_CFLAGS) $(JPEG_PE_CFLAGS) $(ZLIB_PE_CFLAGS) C_SRCS = \ libtiff/tif_aux.c \ diff --git a/libs/vkd3d/Makefile.in b/libs/vkd3d/Makefile.in index c912f97165e..0ed4e27ad83 100644 --- a/libs/vkd3d/Makefile.in +++ b/libs/vkd3d/Makefile.in @@ -1,5 +1,5 @@ EXTLIB = libvkd3d.a -EXTRAINCL = -I$(srcdir)/include -I$(srcdir)/include/private -I$(srcdir)/libs/vkd3d -I$(srcdir)/libs/vkd3d-shader +EXTRAINCL = $(VKD3D_PE_CFLAGS) -I$(srcdir)/include/private -I$(srcdir)/libs/vkd3d -I$(srcdir)/libs/vkd3d-shader EXTRADEFS = \ -DWINE_NO_NAMELESS_EXTENSION \ -DCONST_VTABLE \ diff --git a/tools/makedep.c b/tools/makedep.c index 81e9c20fd4f..fb09e6acc8a 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -4152,10 +4152,20 @@ static void load_sources( struct makefile *make ) value = get_expanded_make_var_array( make, "EXTRAINCL" ); for (i = 0; i < value.count; i++) + { if (!strncmp( value.str[i], "-I", 2 )) - strarray_add_uniq( &make->include_paths, value.str[i] + 2 ); + { + const char *dir = value.str[i] + 2; + if (!strncmp( dir, "./", 2 )) + { + dir += 2; + while (*dir == '/') dir++; + } + strarray_add_uniq( &make->include_paths, dir ); + } else if (!strncmp( value.str[i], "-D", 2 ) || !strncmp( value.str[i], "-U", 2 )) strarray_add_uniq( &make->define_args, value.str[i] ); + } strarray_addall( &make->define_args, get_expanded_make_var_array( make, "EXTRADEFS" )); strarray_add( &make->include_args, strmake( "-I%s", obj_dir_path( make, "" )));

1 0

Zhiyi Zhang : uxtheme: Avoid calling application dialog procedures repeatedly.
by Alexandre Julliard 29 Jun '22

29 Jun '22

Module: wine Branch: master Commit: d461cca19a4a2883e5e3000afe79bc4e15626b5f URL: https://source.winehq.org/git/wine.git/?a=commit;h=d461cca19a4a2883e5e3000a… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Jun 27 17:13:56 2022 +0800 uxtheme: Avoid calling application dialog procedures repeatedly. Application dialog procedures are called in UXTHEME_DefDlgProc(), then may be called again in USER_DefDlgProcA/W(). Lotus Approach doesn't expect this and run into infinite recursion. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52586 Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/uxtheme/dialog.c | 21 +++++++++++++++++---- dlls/uxtheme/tests/system.c | 2 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/dlls/uxtheme/dialog.c b/dlls/uxtheme/dialog.c index 13943d753bb..a27382af784 100644 --- a/dlls/uxtheme/dialog.c +++ b/dlls/uxtheme/dialog.c @@ -131,12 +131,25 @@ LRESULT WINAPI UXTHEME_DefDlgProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp, BOO dlgproc = (WNDPROC)GetWindowLongPtrW(hwnd, DWLP_DLGPROC); SetWindowLongPtrW(hwnd, DWLP_MSGRESULT, 0); lr = LOWORD(CallWindowProcW(dlgproc, hwnd, msg, wp, lp)); - if (lr) + if (lr || !IsWindow(hwnd)) return GetWindowLongPtrW(hwnd, DWLP_MSGRESULT); brush = get_dialog_background_brush(hwnd, TRUE); if (!brush) - break; + { + /* Copied from DEFDLG_Proc() */ + brush = (HBRUSH)SendMessageW(hwnd, WM_CTLCOLORDLG, wp, (LPARAM)hwnd); + if (!brush) + brush = (HBRUSH)DefWindowProcW(hwnd, WM_CTLCOLORDLG, wp, (LPARAM)hwnd); + if (brush) + { + hdc = (HDC)wp; + GetClientRect(hwnd, &rect); + DPtoLP(hdc, (LPPOINT)&rect, 2); + FillRect(hdc, &rect, brush); + } + return TRUE; + } /* Using FillRect() to draw background could introduce a tiling effect if the destination * rectangle is larger than the pattern brush size, which is usually 10x600. This bug is @@ -157,12 +170,12 @@ LRESULT WINAPI UXTHEME_DefDlgProc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp, BOO { dlgproc = (WNDPROC)GetWindowLongPtrW(hwnd, DWLP_DLGPROC); lr = CallWindowProcW(dlgproc, hwnd, msg, wp, lp); - if (lr) + if (lr || !IsWindow(hwnd)) return lr; brush = get_dialog_background_brush(hwnd, FALSE); if (!brush) - break; + return DefWindowProcW(hwnd, msg, wp, lp); hdc = (HDC)wp; SetBkColor(hdc, GetSysColor(COLOR_BTNFACE)); diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c index 4301a0f76f2..29fe5ec047d 100644 --- a/dlls/uxtheme/tests/system.c +++ b/dlls/uxtheme/tests/system.c @@ -2319,7 +2319,7 @@ static void test_EnableThemeDialogTexture(void) sprintf(buffer, "message %#x\n", message_tests[i].msg); flush_sequences(sequences, NUM_MSG_SEQUENCES); SendMessageW(dialog, message_tests[i].msg, (WPARAM)child_hdc, (LPARAM)child); - ok_sequence(sequences, PARENT_SEQ_INDEX, message_tests[i].msg_seq, buffer, TRUE); + ok_sequence(sequences, PARENT_SEQ_INDEX, message_tests[i].msg_seq, buffer, FALSE); } ReleaseDC(child, child_hdc); EndDialog(dialog, 0);

1 0

Zhiyi Zhang : uxtheme/tests: Add dialog procedure message tests.
by Alexandre Julliard 29 Jun '22

29 Jun '22

Module: wine Branch: master Commit: 2a6a2b04fe153e9327b588022b5d1c9334d6a0bb URL: https://source.winehq.org/git/wine.git/?a=commit;h=2a6a2b04fe153e9327b58802… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Jun 27 17:55:45 2022 +0800 uxtheme/tests: Add dialog procedure message tests. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/uxtheme/tests/system.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c index aa566f554ff..4301a0f76f2 100644 --- a/dlls/uxtheme/tests/system.c +++ b/dlls/uxtheme/tests/system.c @@ -1614,6 +1614,37 @@ static const struct message empty_seq[] = {0} }; +static const struct message wm_erasebkgnd_seq[] = +{ + {WM_ERASEBKGND, sent}, + {WM_CTLCOLORDLG, sent}, + {0} +}; + +static const struct message wm_ctlcolormsgbox_seq[] = +{ + {WM_CTLCOLORMSGBOX, sent}, + {0} +}; + +static const struct message wm_ctlcolorbtn_seq[] = +{ + {WM_CTLCOLORBTN, sent}, + {0} +}; + +static const struct message wm_ctlcolordlg_seq[] = +{ + {WM_CTLCOLORDLG, sent}, + {0} +}; + +static const struct message wm_ctlcolorstatic_seq[] = +{ + {WM_CTLCOLORSTATIC, sent}, + {0} +}; + static HWND dialog_child; static DWORD dialog_init_flag; static BOOL handle_WM_ERASEBKGND; @@ -1673,6 +1704,7 @@ static void test_EnableThemeDialogTexture(void) HBRUSH brush, brush2; HDC child_hdc, hdc; LOGBRUSH log_brush; + char buffer[32]; ULONG_PTR proc; WNDCLASSA cls; HTHEME theme; @@ -1779,6 +1811,20 @@ static void test_EnableThemeDialogTexture(void) {{WC_SCROLLBARA}}, }; + static const struct message_test + { + UINT msg; + const struct message *msg_seq; + } + message_tests[] = + { + {WM_ERASEBKGND, wm_erasebkgnd_seq}, + {WM_CTLCOLORMSGBOX, wm_ctlcolormsgbox_seq}, + {WM_CTLCOLORBTN, wm_ctlcolorbtn_seq}, + {WM_CTLCOLORDLG, wm_ctlcolordlg_seq}, + {WM_CTLCOLORSTATIC, wm_ctlcolorstatic_seq}, + }; + if (!IsThemeActive()) { skip("Theming is inactive.\n"); @@ -2260,6 +2306,24 @@ static void test_EnableThemeDialogTexture(void) DestroyWindow(hwnd2); DestroyWindow(hwnd); + /* Test that application dialog procedures should be called only once for each message */ + dialog = CreateDialogIndirectParamA(NULL, &temp.template, GetDesktopWindow(), + test_EnableThemeDialogTexture_proc, + (LPARAM)&param); + ok(dialog != NULL, "CreateDialogIndirectParamA failed, error %ld.\n", GetLastError()); + child = dialog_child; + ok(child != NULL, "Failed to get child control, error %ld.\n", GetLastError()); + child_hdc = GetDC(child); + for (i = 0; i < ARRAY_SIZE(message_tests); ++i) + { + sprintf(buffer, "message %#x\n", message_tests[i].msg); + flush_sequences(sequences, NUM_MSG_SEQUENCES); + SendMessageW(dialog, message_tests[i].msg, (WPARAM)child_hdc, (LPARAM)child); + ok_sequence(sequences, PARENT_SEQ_INDEX, message_tests[i].msg_seq, buffer, TRUE); + } + ReleaseDC(child, child_hdc); + EndDialog(dialog, 0); + UnregisterClassA(cls.lpszClassName, GetModuleHandleA(NULL)); }

1 0

Jinoh Kang : windowscodecs: Fix non-zero alpha detection in ImagingFactory_CreateBitmapFromHICON.
by Alexandre Julliard 29 Jun '22

29 Jun '22

Module: wine Branch: master Commit: e6155827e8b72be53fc0fa031347121ed8e73b26 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e6155827e8b72be53fc0fa03… Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Tue Jun 28 22:41:38 2022 +0900 windowscodecs: Fix non-zero alpha detection in ImagingFactory_CreateBitmapFromHICON. Increment pixel pointer for every *pixel*, not every *stride*. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- dlls/windowscodecs/imgfactory.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/dlls/windowscodecs/imgfactory.c b/dlls/windowscodecs/imgfactory.c index c7e101e3d62..07f5b53fefd 100644 --- a/dlls/windowscodecs/imgfactory.c +++ b/dlls/windowscodecs/imgfactory.c @@ -901,16 +901,14 @@ static HRESULT WINAPI ImagingFactory_CreateBitmapFromHICON(IWICImagingFactory2 * if (bm.bmBitsPixel == 32) { /* If any pixel has a non-zero alpha, ignore hbmMask */ - bits = (DWORD *)buffer; - for (x = 0; x < width && !has_alpha; x++, bits++) + DWORD *ptr = (DWORD *)buffer; + DWORD *end = ptr + width * height; + while (ptr != end) { - for (y = 0; y < height; y++) + if (*ptr++ & 0xff000000) { - if (*bits & 0xff000000) - { - has_alpha = TRUE; - break; - } + has_alpha = TRUE; + break; } } }

1 0

Eric Pouech : dbghelp: Use remap table from PDB hash stream.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 29dd84443976005a8ec713dd1c75458e27346591 URL: https://source.winehq.org/git/wine.git/?a=commit;h=29dd84443976005a8ec713dd… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Jun 22 16:28:09 2022 +0200 dbghelp: Use remap table from PDB hash stream. The PDB hash stream from TPI header contains information to force a remap to a given type record (whatever the order in the bucket hash list). This is generated by the incremental linker in some occasions. Use that information to remap the corresponding types. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/msc.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index 2e7336163bb..1c58b0e9cf6 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -3201,6 +3201,12 @@ static void pdb_dispose_type_parse(struct codeview_type_parse* ctp) free((DWORD*)ctp->alloc_hash); } +static BOOL pdb_bitfield_is_bit_set(const unsigned* dw, unsigned len, unsigned i) +{ + if (i >= len * sizeof(unsigned) * 8) return FALSE; + return (dw[i >> 5] & (1u << (i & 31u))) != 0; +} + static BOOL pdb_init_type_parse(const struct msc_debug_info* msc_dbg, const struct pdb_file_info* pdb_file, struct codeview_type_parse* ctp, @@ -3268,6 +3274,42 @@ static BOOL pdb_init_type_parse(const struct msc_debug_info* msc_dbg, ctp->alloc_hash[i - ctp->header.first_index].next = ctp->hash[hash_i]; ctp->hash[hash_i] = &ctp->alloc_hash[i - ctp->header.first_index]; } + /* parse the remap table + * => move listed type_id at first position of their hash buckets so that we force remap to them + */ + if (ctp->header.type_remap_len) + { + const unsigned* remap = (const unsigned*)((const BYTE*)ctp->hash_stream + ctp->header.type_remap_offset); + unsigned i, capa, count_present; + const unsigned* present_bitset; + remap++; /* no need of num */ + capa = *remap++; + count_present = *remap++; + present_bitset = remap; + remap += count_present; + remap += *remap + 1; /* skip deleted bit set */ + for (i = 0; i < capa; ++i) + { + if (pdb_bitfield_is_bit_set(present_bitset, count_present, i)) + { + unsigned hash_i; + struct hash_link** phl; + /* remap[0] is an offset for a string in /string stream, followed by type_id to force */ + hash_i = pdb_read_hash_value(ctp, remap[1]); + for (phl = &ctp->hash[hash_i]; *phl; phl = &(*phl)->next) + if ((*phl)->id == remap[1]) + { + struct hash_link* hl = *phl; + /* move hl node at first position of its hash bucket */ + *phl = hl->next; + hl->next = ctp->hash[hash_i]; + ctp->hash[hash_i] = hl; + break; + } + remap += 2; + } + } + } return TRUE; oom: pdb_dispose_type_parse(ctp);

1 0

Eric Pouech : dbghelp: Preserve PDB's partial order for types of same name.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: d12d5c7245635c9df26505c8b1aa3080404ca616 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d12d5c7245635c9df26505c8… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Jun 22 16:28:09 2022 +0200 dbghelp: Preserve PDB's partial order for types of same name. The PDB types can contain several times a type definition with an identical name. It seems to appear when modifying a type in source (like adding new fields to a struct): - as the PDB file (generated from first compilation) is updated (and not fully rewritten), the debug information for the old type is not flushed; a new record (for the same struct name) is emitted, and inserted before the old one in the hash table (bucket list). Even if dbghelp's hash table is different from PDB's internal one (ie number of buckets & bucket lists are different), we must maintain the order of records of identical names (they end up in the same bucket) as a lookup by name *must* return the first record in PDB's order. Lookup by name is used: - when resolving a forward definition (to get the full UDT definition including for example a struct/class fields's list) - when searching by type name from dbghelp APIs, like SymGetTypeFromName() This patch implements the preservation of that order. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/msc.c | 373 ++++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 284 insertions(+), 89 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=d12d5c7245635c9df265…

1 0

Eric Pouech : dbghelp: Clearly separate the type loading into two passes.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: ddbd341bd0baa663338326246e2b05d8651743ff URL: https://source.winehq.org/git/wine.git/?a=commit;h=ddbd341bd0baa66333832624… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Jun 22 16:28:09 2022 +0200 dbghelp: Clearly separate the type loading into two passes. - create (contentless) UDT & enum in first pass - fill UDT&enum content and load the rest of types in second pass. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/msc.c | 491 +++++++++++++++++++++++++++-------------------------- 1 file changed, 246 insertions(+), 245 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=ddbd341bd0baa6633383…

1 0

Eric Pouech : mscvpdb.h: Redefine property with bitfields.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: eb14fad72afe7d507f439c10ef42998dbb733858 URL: https://source.winehq.org/git/wine.git/?a=commit;h=eb14fad72afe7d507f439c10… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Jun 22 16:28:09 2022 +0200 mscvpdb.h: Redefine property with bitfields. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/msc.c | 10 +++++----- include/wine/mscvpdb.h | 37 ++++++++++++++++++++++++++++--------- tools/winedump/msc.c | 38 +++++++++++++++++++------------------- 3 files changed, 52 insertions(+), 33 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=eb14fad72afe7d507f43…

1 0

Eric Pouech : dbghelp: Rely on first/last type index from type header.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: b7c231c78f84402b47c79ba744884c32ca2a8323 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b7c231c78f84402b47c79ba7… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Jun 22 16:28:08 2022 +0200 dbghelp: Rely on first/last type index from type header. Code now follows these guidelines: - define PDB & Codeview internals in cvconst.h and mscvinfo.h (instead of having definitions in .c files, some of them being duplicate of .h content, and their "duplicate" values eventually diverged over time) - index of first type comes from PDB type header (instead of always being hardcoded as FIRST_DEFINABLE_TYPE) - use index of last typex from type header (instead of guessing the right value while parsing types, which also allows a single allocation instead of enlarging buffer while parsing). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> --- dlls/dbghelp/msc.c | 108 ++++++++++++++++++++++--------------------------- include/wine/mscvpdb.h | 3 +- 2 files changed, 50 insertions(+), 61 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=b7c231c78f84402b47c7…

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
80
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2022