wine-commits June 2022

wine-commits@winehq.org

2 participants
791 discussions

Nikolay Sivov : ntdll: Implement NtRenameKey().
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 1fb6f271447bd827148521a913c9aea99b02abc4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=1fb6f271447bd827148521a9… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 9 22:41:56 2022 +0300 ntdll: Implement NtRenameKey(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/ntdll/tests/reg.c | 10 +++--- dlls/ntdll/unix/registry.c | 19 +++++++++-- include/wine/server_protocol.h | 18 +++++++++- server/protocol.def | 7 ++++ server/registry.c | 74 ++++++++++++++++++++++++++++++++++++++++++ server/request.h | 4 +++ server/trace.c | 9 +++++ 7 files changed, 131 insertions(+), 10 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=1fb6f271447bd8271485…

1 0

Nikolay Sivov : advapi32/tests: Add some tests for RegRenameKey().
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 440d37172d7c4ee299f4df54448322e57a19ff76 URL: https://source.winehq.org/git/wine.git/?a=commit;h=440d37172d7c4ee299f4df54… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 9 20:31:08 2022 +0300 advapi32/tests: Add some tests for RegRenameKey(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/advapi32/tests/registry.c | 73 ++++++++++++++++++++++++++++++++++++++++++ include/winreg.h | 1 + 2 files changed, 74 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 6152a313803..c2e78192f2e 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -4475,6 +4475,78 @@ static void test_EnumDynamicTimeZoneInformation(void) RegCloseKey(key); } +static void test_RegRenameKey(void) +{ + HKEY key, key2; + LSTATUS ret; + + ret = RegRenameKey(NULL, NULL, NULL); + todo_wine + ok(ret == ERROR_INVALID_PARAMETER, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(NULL, NULL, L"newname"); + todo_wine + ok(ret == ERROR_INVALID_HANDLE, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(NULL, L"oldname", NULL); + todo_wine + ok(ret == ERROR_INVALID_HANDLE, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(NULL, L"oldname", L"newname"); + todo_wine + ok(ret == ERROR_INVALID_HANDLE, "Unexpected return value %ld.\n", ret); + + ret = RegCreateKeyExA(hkey_main, "TestRenameKey", 0, NULL, 0, KEY_READ, NULL, &key, NULL); + ok(!ret, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(key, NULL, L"TestNewRenameKey"); + todo_wine + ok(ret == ERROR_ACCESS_DENIED, "Unexpected return value %ld.\n", ret); + RegCloseKey(key); + + /* Rename itself. */ + ret = RegCreateKeyExA(hkey_main, "TestRenameKey", 0, NULL, 0, KEY_WRITE, NULL, &key, NULL); + ok(!ret, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(key, NULL, NULL); + todo_wine + ok(ret == ERROR_INVALID_PARAMETER, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(key, NULL, L"TestNewRenameKey"); + todo_wine + ok(!ret, "Unexpected return value %ld.\n", ret); + RegCloseKey(key); + + ret = RegDeleteKeyA(hkey_main, "TestNewRenameKey"); + todo_wine + ok(!ret, "Unexpected return value %ld.\n", ret); + ret = RegDeleteKeyA(hkey_main, "TestRenameKey"); + todo_wine + ok(ret, "Unexpected return value %ld.\n", ret); + + /* Subkey does not exist. */ + ret = RegCreateKeyExA(hkey_main, "TestRenameKey", 0, NULL, 0, KEY_WRITE, NULL, &key, NULL); + ok(!ret, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(key, L"unknown_subkey", NULL); + todo_wine + ok(ret == ERROR_FILE_NOT_FOUND, "Unexpected return value %ld.\n", ret); + ret = RegRenameKey(key, L"unknown_subkey", L"known_subkey"); + todo_wine + ok(ret == ERROR_FILE_NOT_FOUND, "Unexpected return value %ld.\n", ret); + + /* Rename existing subkey. */ + ret = RegCreateKeyExA(key, "known_subkey", 0, NULL, 0, KEY_WRITE, NULL, &key2, NULL); + ok(!ret, "Unexpected return value %ld.\n", ret); + RegCloseKey(key2); + + ret = RegRenameKey(key, L"known_subkey", L"renamed_subkey"); + todo_wine + ok(!ret, "Unexpected return value %ld.\n", ret); + + ret = RegDeleteKeyA(key, "renamed_subkey"); + todo_wine + ok(!ret, "Unexpected return value %ld.\n", ret); + ret = RegDeleteKeyA(key, "known_subkey"); + todo_wine + ok(ret, "Unexpected return value %ld.\n", ret); + + RegCloseKey(key); +} + START_TEST(registry) { /* Load pointers for functions that are not available in all Windows versions */ @@ -4514,6 +4586,7 @@ START_TEST(registry) test_RegLoadMUIString(); test_EnumDynamicTimeZoneInformation(); test_perflib_key(); + test_RegRenameKey(); /* cleanup */ delete_key( hkey_main ); diff --git a/include/winreg.h b/include/winreg.h index 00bc8c02dc8..da92fb11f94 100644 --- a/include/winreg.h +++ b/include/winreg.h @@ -178,6 +178,7 @@ WINADVAPI LSTATUS WINAPI RegQueryValueW(HKEY,LPCWSTR,LPWSTR,LPLONG); WINADVAPI LSTATUS WINAPI RegQueryValueExA(HKEY,LPCSTR,LPDWORD,LPDWORD,LPBYTE,LPDWORD); WINADVAPI LSTATUS WINAPI RegQueryValueExW(HKEY,LPCWSTR,LPDWORD,LPDWORD,LPBYTE,LPDWORD); #define RegQueryValueEx WINELIB_NAME_AW(RegQueryValueEx) +WINADVAPI LSTATUS WINAPI RegRenameKey(HKEY,LPCWSTR,LPCWSTR); WINADVAPI LSTATUS WINAPI RegReplaceKeyA(HKEY,LPCSTR,LPCSTR,LPCSTR); WINADVAPI LSTATUS WINAPI RegReplaceKeyW(HKEY,LPCWSTR,LPCWSTR,LPCWSTR); #define RegReplaceKey WINELIB_NAME_AW(RegReplaceKey)

1 0

Nikolay Sivov : ntdll/tests: Add some tests for NtRenameKey().
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 4bd160da5e7ce759ef25a6581f167ec10a4f0fb9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4bd160da5e7ce759ef25a658… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 9 19:54:32 2022 +0300 ntdll/tests: Add some tests for NtRenameKey(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> --- dlls/ntdll/tests/reg.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 2c158be17b4..b0cbf137086 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -2115,6 +2115,74 @@ static void test_RtlCreateRegistryKey(void) pRtlFreeUnicodeString(&str); } +static void test_NtRenameKey(void) +{ + KEY_NAME_INFORMATION *info = NULL; + UNICODE_STRING str, str2; + OBJECT_ATTRIBUTES attr; + HANDLE key, subkey; + char buffer[200]; + NTSTATUS status; + DWORD size; + + status = NtRenameKey(NULL, NULL); + todo_wine + ok(status == STATUS_ACCESS_VIOLATION, "Unexpected status %#lx.\n", status); + + InitializeObjectAttributes(&attr, &winetestpath, 0, 0, 0); + status = pNtCreateKey(&key, KEY_READ|DELETE, &attr, 0, 0, 0, 0); + ok(!status, "Unexpected status %#lx.\n", status); + + attr.RootDirectory = key; + attr.ObjectName = &str; + + pRtlCreateUnicodeStringFromAsciiz(&str, "rename_subkey"); + status = pNtCreateKey(&subkey, KEY_READ|DELETE, &attr, 0, 0, 0, 0); + ok(!status, "Unexpected status %#lx.\n", status); + + pRtlCreateUnicodeStringFromAsciiz(&str2, "renamed_subkey"); + + status = NtRenameKey(subkey, NULL); + todo_wine + ok(status == STATUS_ACCESS_VIOLATION, "Unexpected status %#lx.\n", status); + status = NtRenameKey(NULL, &str); + todo_wine + ok(status == STATUS_INVALID_HANDLE, "Unexpected status %#lx.\n", status); + + status = NtRenameKey(subkey, &str2); + todo_wine + ok(status == STATUS_ACCESS_DENIED, "Unexpected status %#lx.\n", status); + pNtClose(subkey); + + status = pNtCreateKey(&subkey, KEY_WRITE|DELETE, &attr, 0, 0, 0, 0); + ok(!status, "Unexpected status %#lx.\n", status); + /* Rename to itself. */ + status = NtRenameKey(subkey, &str); + todo_wine + ok(status == STATUS_CANNOT_DELETE, "Unexpected status %#lx.\n", status); + status = NtRenameKey(subkey, &str2); + todo_wine + ok(!status, "Unexpected status %#lx.\n", status); + + pRtlFreeUnicodeString(&str2); + pRtlFreeUnicodeString(&str); + + info = (KEY_NAME_INFORMATION *)buffer; + status = pNtQueryKey(subkey, KeyNameInformation, info, sizeof(buffer), &size); + todo_wine + ok(!status, "Unexpected status %#lx.\n", status); + if (status == STATUS_SUCCESS) + { + info->Name[info->NameLength/sizeof(WCHAR)] = 0; + ok(!!wcsstr(info->Name, L"renamed_subkey"), "Unexpected subkey name %s.\n", wine_dbgstr_w(info->Name)); + } + + pNtDeleteKey(subkey); + pNtDeleteKey(key); + pNtClose(subkey); + pNtClose(key); +} + START_TEST(reg) { static const WCHAR winetest[] = {'\\','W','i','n','e','T','e','s','t',0}; @@ -2144,6 +2212,7 @@ START_TEST(reg) test_NtDeleteKey(); test_symlinks(); test_redirection(); + test_NtRenameKey(); pRtlFreeUnicodeString(&winetestpath);

1 0

Zhiyi Zhang : light.msstyles: Add Vista+ spin parts.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 8e12b359f71249acca006780f72e70d021cb9b33 URL: https://source.winehq.org/git/wine.git/?a=commit;h=8e12b359f71249acca006780… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Jun 13 20:49:47 2022 +0800 light.msstyles: Add Vista+ spin parts. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 33 +++- dlls/light.msstyles/blue_spin_background.bmp | Bin 446 -> 0 bytes dlls/light.msstyles/blue_spin_background.svg | 16 -- dlls/light.msstyles/blue_spin_glyph_down.bmp | Bin 810 -> 0 bytes dlls/light.msstyles/blue_spin_glyph_down.svg | 24 --- dlls/light.msstyles/blue_spin_glyph_down_11px.bmp | Bin 0 -> 1722 bytes dlls/light.msstyles/blue_spin_glyph_down_11px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_down_14px.bmp | Bin 0 -> 2826 bytes dlls/light.msstyles/blue_spin_glyph_down_14px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_down_18px.bmp | Bin 0 -> 4458 bytes dlls/light.msstyles/blue_spin_glyph_down_18px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_down_21px.bmp | Bin 0 -> 6186 bytes dlls/light.msstyles/blue_spin_glyph_down_21px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_down_28px.bmp | Bin 0 -> 10890 bytes dlls/light.msstyles/blue_spin_glyph_down_28px.svg | 23 +++ .../light.msstyles/blue_spin_glyph_down_7x16px.bmp | Bin 0 -> 586 bytes .../light.msstyles/blue_spin_glyph_down_7x16px.svg | 21 +++ .../light.msstyles/blue_spin_glyph_down_7x24px.bmp | Bin 0 -> 810 bytes .../light.msstyles/blue_spin_glyph_down_7x24px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left.bmp | Bin 810 -> 0 bytes dlls/light.msstyles/blue_spin_glyph_left.svg | 24 --- dlls/light.msstyles/blue_spin_glyph_left_12px.bmp | Bin 0 -> 2826 bytes dlls/light.msstyles/blue_spin_glyph_left_12px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_15px.bmp | Bin 0 -> 3978 bytes dlls/light.msstyles/blue_spin_glyph_left_15px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_18px.bmp | Bin 0 -> 6186 bytes dlls/light.msstyles/blue_spin_glyph_left_18px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_24px.bmp | Bin 0 -> 10890 bytes dlls/light.msstyles/blue_spin_glyph_left_24px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_4px.bmp | Bin 0 -> 586 bytes dlls/light.msstyles/blue_spin_glyph_left_4px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_6px.bmp | Bin 0 -> 810 bytes dlls/light.msstyles/blue_spin_glyph_left_6px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_left_9px.bmp | Bin 0 -> 1722 bytes dlls/light.msstyles/blue_spin_glyph_left_9px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right.bmp | Bin 810 -> 0 bytes dlls/light.msstyles/blue_spin_glyph_right.svg | 24 --- dlls/light.msstyles/blue_spin_glyph_right_12px.bmp | Bin 0 -> 2826 bytes dlls/light.msstyles/blue_spin_glyph_right_12px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_15px.bmp | Bin 0 -> 3978 bytes dlls/light.msstyles/blue_spin_glyph_right_15px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_18px.bmp | Bin 0 -> 6186 bytes dlls/light.msstyles/blue_spin_glyph_right_18px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_24px.bmp | Bin 0 -> 10890 bytes dlls/light.msstyles/blue_spin_glyph_right_24px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_4px.bmp | Bin 0 -> 586 bytes dlls/light.msstyles/blue_spin_glyph_right_4px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_6px.bmp | Bin 0 -> 810 bytes dlls/light.msstyles/blue_spin_glyph_right_6px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_right_9px.bmp | Bin 0 -> 1722 bytes dlls/light.msstyles/blue_spin_glyph_right_9px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up.bmp | Bin 810 -> 0 bytes dlls/light.msstyles/blue_spin_glyph_up.svg | 24 --- dlls/light.msstyles/blue_spin_glyph_up_11px.bmp | Bin 0 -> 1722 bytes dlls/light.msstyles/blue_spin_glyph_up_11px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_14px.bmp | Bin 0 -> 2826 bytes dlls/light.msstyles/blue_spin_glyph_up_14px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_18px.bmp | Bin 0 -> 4458 bytes dlls/light.msstyles/blue_spin_glyph_up_18px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_21px.bmp | Bin 0 -> 6186 bytes dlls/light.msstyles/blue_spin_glyph_up_21px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_28px.bmp | Bin 0 -> 10890 bytes dlls/light.msstyles/blue_spin_glyph_up_28px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_7x20px.bmp | Bin 0 -> 698 bytes dlls/light.msstyles/blue_spin_glyph_up_7x20px.svg | 21 +++ dlls/light.msstyles/blue_spin_glyph_up_7x24px.bmp | Bin 0 -> 810 bytes dlls/light.msstyles/blue_spin_glyph_up_7x24px.svg | 21 +++ dlls/light.msstyles/light.rc | 179 ++++++++++++++++++--- 68 files changed, 772 insertions(+), 142 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=8e12b359f71249acca00…

1 0

Zhiyi Zhang : light.msstyles: Add Vista+ scrollbar parts.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 4cb229a97c1cf6d430a99f3b976064aa10ff3d96 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4cb229a97c1cf6d430a99f3b… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Jun 1 17:22:09 2022 +0800 light.msstyles: Add Vista+ scrollbar parts. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 32 ++- .../blue_scrollbar_arrow_glyphs_13px.bmp | Bin 0 -> 13658 bytes .../blue_scrollbar_arrow_glyphs_13px.svg | 67 ++++++ .../blue_scrollbar_arrow_glyphs_16px.bmp | Bin 0 -> 20618 bytes .../blue_scrollbar_arrow_glyphs_16px.svg | 71 +++++++ .../blue_scrollbar_arrow_glyphs_20px.bmp | Bin 0 -> 32138 bytes .../blue_scrollbar_arrow_glyphs_20px.svg | 85 ++++++++ .../blue_scrollbar_arrow_glyphs_26px.bmp | Bin 0 -> 54218 bytes .../blue_scrollbar_arrow_glyphs_26px.svg | 67 ++++++ .../blue_scrollbar_arrow_glyphs_32px.bmp | Bin 0 -> 82058 bytes .../blue_scrollbar_arrow_glyphs_32px.svg | 75 +++++++ .../blue_scrollbar_arrow_glyphs_39px.bmp | Bin 0 -> 121818 bytes .../blue_scrollbar_arrow_glyphs_39px.svg | 67 ++++++ .../blue_scrollbar_arrow_glyphs_52px.bmp | Bin 0 -> 216458 bytes .../blue_scrollbar_arrow_glyphs_52px.svg | 69 ++++++ .../blue_scrollbar_arrow_glyphs_7px.bmp | Bin 3274 -> 0 bytes .../blue_scrollbar_arrow_glyphs_7px.svg | 54 ----- .../blue_scrollbar_arrow_glyphs_9px.bmp | Bin 5322 -> 0 bytes .../blue_scrollbar_arrow_glyphs_9px.svg | 54 ----- dlls/light.msstyles/blue_scrollbar_arrows.bmp | Bin 14282 -> 17818 bytes dlls/light.msstyles/blue_scrollbar_arrows.svg | 17 +- .../blue_scrollbar_gripper_horizontal_10px.bmp | Bin 0 -> 1938 bytes .../blue_scrollbar_gripper_horizontal_10px.svg | 2 + .../blue_scrollbar_gripper_horizontal_12px.bmp | Bin 0 -> 2778 bytes .../blue_scrollbar_gripper_horizontal_12px.svg | 2 + ... => blue_scrollbar_gripper_horizontal_16px.bmp} | Bin 6410 -> 4618 bytes .../blue_scrollbar_gripper_horizontal_16px.svg | 2 + .../blue_scrollbar_gripper_horizontal_20px.bmp | Bin 0 -> 7338 bytes .../blue_scrollbar_gripper_horizontal_20px.svg | 2 + .../blue_scrollbar_gripper_horizontal_25px.bmp | Bin 0 -> 11338 bytes .../blue_scrollbar_gripper_horizontal_25px.svg | 2 + .../blue_scrollbar_gripper_horizontal_30px.bmp | Bin 0 -> 16338 bytes .../blue_scrollbar_gripper_horizontal_30px.svg | 2 + .../blue_scrollbar_gripper_horizontal_40px.bmp | Bin 0 -> 28938 bytes .../blue_scrollbar_gripper_horizontal_40px.svg | 2 + .../blue_scrollbar_gripper_vertical_11px.bmp | Bin 0 -> 2778 bytes .../blue_scrollbar_gripper_vertical_11px.svg | 2 + .../blue_scrollbar_gripper_vertical_14px.bmp | Bin 0 -> 4618 bytes .../blue_scrollbar_gripper_vertical_14px.svg | 2 + ...mp => blue_scrollbar_gripper_vertical_22px.bmp} | Bin 10506 -> 11138 bytes .../blue_scrollbar_gripper_vertical_22px.svg | 2 + .../blue_scrollbar_gripper_vertical_27px.bmp | Bin 0 -> 16338 bytes .../blue_scrollbar_gripper_vertical_27px.svg | 2 + .../blue_scrollbar_gripper_vertical_36px.bmp | Bin 0 -> 28938 bytes .../blue_scrollbar_gripper_vertical_36px.svg | 2 + .../blue_scrollbar_gripper_vertical_9px.bmp | Bin 0 -> 1938 bytes .../blue_scrollbar_gripper_vertical_9px.svg | 2 + .../blue_scrollbar_lower_track_horizontal.bmp | Bin 0 -> 298 bytes ...g => blue_scrollbar_lower_track_horizontal.svg} | 5 +- ...bmp => blue_scrollbar_lower_track_vertical.bmp} | Bin 490 -> 358 bytes ...svg => blue_scrollbar_lower_track_vertical.svg} | 5 +- .../blue_scrollbar_resizebox_grip_16px.bmp | Bin 2186 -> 8330 bytes .../blue_scrollbar_resizebox_grip_16px.svg | 63 ++++-- .../blue_scrollbar_resizebox_grip_20px.bmp | Bin 3338 -> 12938 bytes .../blue_scrollbar_resizebox_grip_20px.svg | 63 ++++-- .../blue_scrollbar_resizebox_grip_24px.bmp | Bin 4746 -> 18570 bytes .../blue_scrollbar_resizebox_grip_24px.svg | 61 ++++-- .../blue_scrollbar_resizebox_grip_28px.svg | 26 --- .../blue_scrollbar_resizebox_grip_32px.bmp | Bin 8330 -> 32906 bytes .../blue_scrollbar_resizebox_grip_32px.svg | 63 ++++-- .../blue_scrollbar_resizebox_grip_36px.svg | 26 --- .../blue_scrollbar_resizebox_grip_40px.bmp | Bin 12938 -> 51338 bytes .../blue_scrollbar_resizebox_grip_40px.svg | 63 ++++-- .../blue_scrollbar_resizebox_grip_48px.bmp | Bin 0 -> 73866 bytes .../blue_scrollbar_resizebox_grip_48px.svg | 69 ++++++ .../blue_scrollbar_resizebox_grip_64px.bmp | Bin 0 -> 131210 bytes .../blue_scrollbar_resizebox_grip_64px.svg | 61 ++++++ .../blue_scrollbar_shaft_horizontal.bmp | Bin 394 -> 0 bytes .../blue_scrollbar_thumb_horizontal.bmp | Bin 4762 -> 5238 bytes .../blue_scrollbar_thumb_horizontal.svg | 18 +- .../blue_scrollbar_thumb_vertical.bmp | Bin 4714 -> 2998 bytes .../blue_scrollbar_thumb_vertical.svg | 14 +- .../blue_scrollbar_upper_track_horizontal.bmp | Bin 0 -> 298 bytes .../blue_scrollbar_upper_track_horizontal.svg | 12 ++ .../blue_scrollbar_upper_track_vertical.bmp | Bin 0 -> 358 bytes .../blue_scrollbar_upper_track_vertical.svg | 12 ++ dlls/light.msstyles/light.rc | 234 +++++++++++++++------ 77 files changed, 1157 insertions(+), 322 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=4cb229a97c1cf6d430a9…

1 0

Zhiyi Zhang : light.msstyles: Add Vista+ rebar parts.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 7110384741a232d4c794d58e9d1a5acb13643734 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7110384741a232d4c794d58e… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Thu Jun 9 11:54:17 2022 +0800 light.msstyles: Add Vista+ rebar parts. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 15 +++- dlls/light.msstyles/blue_rebar_chevron.bmp | Bin 2298 -> 0 bytes dlls/light.msstyles/blue_rebar_chevron.svg | 28 ------ .../blue_rebar_chevron_background.bmp | Bin 0 -> 5382 bytes .../blue_rebar_chevron_background.svg | 15 ++++ .../blue_rebar_chevron_glyph_10px.bmp | Bin 0 -> 1218 bytes .../blue_rebar_chevron_glyph_10px.svg | 29 ++++++ .../blue_rebar_chevron_glyph_13px.bmp | Bin 0 -> 1854 bytes .../blue_rebar_chevron_glyph_13px.svg | 31 +++++++ .../blue_rebar_chevron_glyph_15px.bmp | Bin 0 -> 2658 bytes .../blue_rebar_chevron_glyph_15px.svg | 29 ++++++ .../blue_rebar_chevron_glyph_20px.bmp | Bin 0 -> 4458 bytes .../blue_rebar_chevron_glyph_20px.svg | 29 ++++++ .../blue_rebar_chevron_glyph_25px.bmp | Bin 0 -> 6738 bytes .../blue_rebar_chevron_glyph_25px.svg | 29 ++++++ .../blue_rebar_chevron_glyph_30px.bmp | Bin 0 -> 9858 bytes .../blue_rebar_chevron_glyph_30px.svg | 29 ++++++ .../blue_rebar_chevron_glyph_40px.bmp | Bin 0 -> 17418 bytes .../blue_rebar_chevron_glyph_40px.svg | 29 ++++++ .../blue_rebar_chevron_vertical_background.bmp | Bin 0 -> 5382 bytes .../blue_rebar_chevron_vertical_background.svg | 15 ++++ .../blue_rebar_chevron_vertical_glyph_10px.bmp | Bin 0 -> 1218 bytes .../blue_rebar_chevron_vertical_glyph_10px.svg | 29 ++++++ .../blue_rebar_chevron_vertical_glyph_13px.bmp | Bin 0 -> 1854 bytes .../blue_rebar_chevron_vertical_glyph_13px.svg | 31 +++++++ .../blue_rebar_chevron_vertical_glyph_15px.bmp | Bin 0 -> 2658 bytes .../blue_rebar_chevron_vertical_glyph_15px.svg | 29 ++++++ dlls/light.msstyles/blue_rebar_splitter.bmp | Bin 0 -> 246 bytes dlls/light.msstyles/blue_rebar_splitter.svg | 15 ++++ .../blue_rebar_splitter_vertical.bmp | Bin 0 -> 246 bytes .../blue_rebar_splitter_vertical.svg | 15 ++++ dlls/light.msstyles/light.rc | 97 ++++++++++++++++++--- 32 files changed, 453 insertions(+), 41 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=7110384741a232d4c794…

1 0

Zhiyi Zhang : light.msstyles: Add navigation class.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 9b3b64de8570f577f489a8d55b7019ef268c010b URL: https://source.winehq.org/git/wine.git/?a=commit;h=9b3b64de8570f577f489a8d5… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Jun 21 23:27:20 2022 +0800 light.msstyles: Add navigation class. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 21 ++++ .../blue_navigation_back_button_120px.bmp | Bin 0 -> 230538 bytes .../blue_navigation_back_button_120px.svg | 17 +++ .../blue_navigation_back_button_30px.bmp | Bin 0 -> 14538 bytes .../blue_navigation_back_button_30px.svg | 17 +++ .../blue_navigation_back_button_38px.bmp | Bin 0 -> 23242 bytes .../blue_navigation_back_button_38px.svg | 17 +++ .../blue_navigation_back_button_45px.bmp | Bin 0 -> 32538 bytes .../blue_navigation_back_button_45px.svg | 17 +++ .../blue_navigation_back_button_60px.bmp | Bin 0 -> 57738 bytes .../blue_navigation_back_button_60px.svg | 17 +++ .../blue_navigation_back_button_74px.bmp | Bin 0 -> 87754 bytes .../blue_navigation_back_button_74px.svg | 17 +++ .../blue_navigation_back_button_90px.bmp | Bin 0 -> 129738 bytes .../blue_navigation_back_button_90px.svg | 17 +++ .../blue_navigation_forward_button_120px.bmp | Bin 0 -> 230538 bytes .../blue_navigation_forward_button_120px.svg | 17 +++ .../blue_navigation_forward_button_30px.bmp | Bin 0 -> 14538 bytes .../blue_navigation_forward_button_30px.svg | 17 +++ .../blue_navigation_forward_button_38px.bmp | Bin 0 -> 23242 bytes .../blue_navigation_forward_button_38px.svg | 17 +++ .../blue_navigation_forward_button_45px.bmp | Bin 0 -> 32538 bytes .../blue_navigation_forward_button_45px.svg | 17 +++ .../blue_navigation_forward_button_60px.bmp | Bin 0 -> 57738 bytes .../blue_navigation_forward_button_60px.svg | 17 +++ .../blue_navigation_forward_button_74px.bmp | Bin 0 -> 87754 bytes .../blue_navigation_forward_button_74px.svg | 17 +++ .../blue_navigation_forward_button_90px.bmp | Bin 0 -> 129738 bytes .../blue_navigation_forward_button_90px.svg | 17 +++ .../blue_navigation_menu_button_13px.bmp | Bin 0 -> 5754 bytes .../blue_navigation_menu_button_13px.svg | 25 ++++ .../blue_navigation_menu_button_17px.bmp | Bin 0 -> 9386 bytes .../blue_navigation_menu_button_17px.svg | 23 ++++ .../blue_navigation_menu_button_19px.bmp | Bin 0 -> 12298 bytes .../blue_navigation_menu_button_19px.svg | 23 ++++ .../blue_navigation_menu_button_26px.bmp | Bin 0 -> 22602 bytes .../blue_navigation_menu_button_26px.svg | 23 ++++ .../blue_navigation_menu_button_32px.bmp | Bin 0 -> 34442 bytes .../blue_navigation_menu_button_32px.svg | 23 ++++ .../blue_navigation_menu_button_39px.bmp | Bin 0 -> 50682 bytes .../blue_navigation_menu_button_39px.svg | 23 ++++ .../blue_navigation_menu_button_52px.bmp | Bin 0 -> 89994 bytes .../blue_navigation_menu_button_52px.svg | 23 ++++ dlls/light.msstyles/light.rc | 138 +++++++++++++++++++++ 44 files changed, 560 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=9b3b64de8570f577f489…

1 0

Zhiyi Zhang : light.msstyles: Add Vista+ menu parts.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 51f488919dd331197501ed377fc22cd6ea152877 URL: https://source.winehq.org/git/wine.git/?a=commit;h=51f488919dd331197501ed37… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Jun 20 16:29:48 2022 +0800 light.msstyles: Add Vista+ menu parts. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 52 +++- dlls/light.msstyles/blue_menu_bar_background.bmp | Bin 0 -> 738 bytes dlls/light.msstyles/blue_menu_bar_background.svg | 9 + dlls/light.msstyles/blue_menu_bar_item.bmp | Bin 0 -> 2082 bytes dlls/light.msstyles/blue_menu_bar_item.svg | 15 + dlls/light.msstyles/blue_menu_popup_background.bmp | Bin 0 -> 142 bytes dlls/light.msstyles/blue_menu_popup_background.svg | 6 + dlls/light.msstyles/blue_menu_popup_borders.bmp | Bin 0 -> 174 bytes dlls/light.msstyles/blue_menu_popup_borders.svg | 14 + dlls/light.msstyles/blue_menu_popup_check_16px.bmp | Bin 4234 -> 4234 bytes dlls/light.msstyles/blue_menu_popup_check_16px.svg | 8 +- dlls/light.msstyles/blue_menu_popup_check_18px.bmp | Bin 5322 -> 5322 bytes dlls/light.msstyles/blue_menu_popup_check_18px.svg | 10 +- dlls/light.msstyles/blue_menu_popup_check_25px.bmp | Bin 0 -> 10138 bytes dlls/light.msstyles/blue_menu_popup_check_25px.svg | 9 + dlls/light.msstyles/blue_menu_popup_check_32px.bmp | Bin 0 -> 16522 bytes dlls/light.msstyles/blue_menu_popup_check_32px.svg | 9 + dlls/light.msstyles/blue_menu_popup_check_40px.bmp | Bin 0 -> 25738 bytes dlls/light.msstyles/blue_menu_popup_check_40px.svg | 9 + dlls/light.msstyles/blue_menu_popup_check_48px.bmp | Bin 0 -> 37002 bytes dlls/light.msstyles/blue_menu_popup_check_48px.svg | 9 + dlls/light.msstyles/blue_menu_popup_check_64px.bmp | Bin 0 -> 65674 bytes dlls/light.msstyles/blue_menu_popup_check_64px.svg | 7 + .../blue_menu_popup_check_background.bmp | Bin 0 -> 726 bytes .../blue_menu_popup_check_background.svg | 5 + dlls/light.msstyles/blue_menu_popup_gutter.bmp | Bin 0 -> 150 bytes dlls/light.msstyles/blue_menu_popup_gutter.svg | 4 + dlls/light.msstyles/blue_menu_popup_item.bmp | Bin 0 -> 922 bytes dlls/light.msstyles/blue_menu_popup_item.svg | 5 + dlls/light.msstyles/blue_menu_popup_separator.bmp | Bin 162 -> 158 bytes dlls/light.msstyles/blue_menu_popup_separator.svg | 5 +- .../blue_menu_popup_submenu_11px.bmp | Bin 0 -> 1106 bytes .../blue_menu_popup_submenu_11px.svg | 9 + .../blue_menu_popup_submenu_14px.bmp | Bin 0 -> 1650 bytes .../blue_menu_popup_submenu_14px.svg | 9 + .../blue_menu_popup_submenu_18px.bmp | Bin 0 -> 2730 bytes .../blue_menu_popup_submenu_18px.svg | 9 + .../blue_menu_popup_submenu_23px.bmp | Bin 0 -> 4370 bytes .../blue_menu_popup_submenu_23px.svg | 7 + .../blue_menu_popup_submenu_27px.bmp | Bin 0 -> 5970 bytes .../blue_menu_popup_submenu_27px.svg | 9 + .../blue_menu_popup_submenu_36px.bmp | Bin 0 -> 10506 bytes .../blue_menu_popup_submenu_36px.svg | 9 + ...submenu.bmp => blue_menu_popup_submenu_9px.bmp} | Bin 786 -> 786 bytes ...submenu.svg => blue_menu_popup_submenu_9px.svg} | 4 +- dlls/light.msstyles/blue_menu_system_close.bmp | Bin 1018 -> 0 bytes dlls/light.msstyles/blue_menu_system_close.svg | 5 - .../light.msstyles/blue_menu_system_close_11px.bmp | Bin 0 -> 1018 bytes .../light.msstyles/blue_menu_system_close_11px.svg | 5 + .../light.msstyles/blue_menu_system_close_14px.bmp | Bin 0 -> 1594 bytes .../light.msstyles/blue_menu_system_close_14px.svg | 5 + .../light.msstyles/blue_menu_system_close_17px.bmp | Bin 0 -> 2178 bytes .../light.msstyles/blue_menu_system_close_17px.svg | 5 + .../light.msstyles/blue_menu_system_close_22px.bmp | Bin 0 -> 3658 bytes .../light.msstyles/blue_menu_system_close_22px.svg | 5 + .../light.msstyles/blue_menu_system_close_28px.bmp | Bin 0 -> 5962 bytes .../light.msstyles/blue_menu_system_close_28px.svg | 5 + .../light.msstyles/blue_menu_system_close_34px.bmp | Bin 0 -> 8298 bytes .../light.msstyles/blue_menu_system_close_34px.svg | 5 + .../light.msstyles/blue_menu_system_close_44px.bmp | Bin 0 -> 14218 bytes .../light.msstyles/blue_menu_system_close_44px.svg | 5 + ...mize.bmp => blue_menu_system_maximize_11px.bmp} | Bin 1018 -> 1018 bytes ...mize.svg => blue_menu_system_maximize_11px.svg} | 4 +- .../blue_menu_system_maximize_14px.bmp | Bin 0 -> 1594 bytes .../blue_menu_system_maximize_14px.svg | 5 + .../blue_menu_system_maximize_17px.bmp | Bin 0 -> 2178 bytes .../blue_menu_system_maximize_17px.svg | 5 + .../blue_menu_system_maximize_22px.bmp | Bin 0 -> 3658 bytes .../blue_menu_system_maximize_22px.svg | 5 + .../blue_menu_system_maximize_28px.bmp | Bin 0 -> 5962 bytes .../blue_menu_system_maximize_28px.svg | 5 + .../blue_menu_system_maximize_34px.bmp | Bin 0 -> 8298 bytes .../blue_menu_system_maximize_34px.svg | 5 + .../blue_menu_system_maximize_44px.bmp | Bin 0 -> 14218 bytes .../blue_menu_system_maximize_44px.svg | 5 + ...mize.bmp => blue_menu_system_minimize_11px.bmp} | Bin ...mize.svg => blue_menu_system_minimize_11px.svg} | 0 .../blue_menu_system_minimize_14px.bmp | Bin 0 -> 1594 bytes .../blue_menu_system_minimize_14px.svg | 5 + .../blue_menu_system_minimize_17px.bmp | Bin 0 -> 2178 bytes .../blue_menu_system_minimize_17px.svg | 5 + .../blue_menu_system_minimize_22px.bmp | Bin 0 -> 3658 bytes .../blue_menu_system_minimize_22px.svg | 5 + .../blue_menu_system_minimize_28px.bmp | Bin 0 -> 5962 bytes .../blue_menu_system_minimize_28px.svg | 5 + .../blue_menu_system_minimize_34px.bmp | Bin 0 -> 8298 bytes .../blue_menu_system_minimize_34px.svg | 5 + .../blue_menu_system_minimize_44px.bmp | Bin 0 -> 14218 bytes .../blue_menu_system_minimize_44px.svg | 5 + ...store.bmp => blue_menu_system_restore_11px.bmp} | Bin 1018 -> 1018 bytes ...store.svg => blue_menu_system_restore_11px.svg} | 8 +- .../blue_menu_system_restore_14px.bmp | Bin 0 -> 1594 bytes .../blue_menu_system_restore_14px.svg | 13 + .../blue_menu_system_restore_17px.bmp | Bin 0 -> 2178 bytes .../blue_menu_system_restore_17px.svg | 11 + .../blue_menu_system_restore_22px.bmp | Bin 0 -> 3658 bytes .../blue_menu_system_restore_22px.svg | 11 + .../blue_menu_system_restore_28px.bmp | Bin 0 -> 5962 bytes .../blue_menu_system_restore_28px.svg | 11 + .../blue_menu_system_restore_34px.bmp | Bin 0 -> 8298 bytes .../blue_menu_system_restore_34px.svg | 11 + .../blue_menu_system_restore_44px.bmp | Bin 0 -> 14218 bytes .../blue_menu_system_restore_44px.svg | 11 + dlls/light.msstyles/light.rc | 325 +++++++++++++++++---- 104 files changed, 650 insertions(+), 87 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=51f488919dd331197501…

1 0

Zhiyi Zhang : light.msstyles: Add Vista+ listview parts.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 5b563c21a9173bea0946a499b999e3c5c11592d8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5b563c21a9173bea0946a499… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Wed Jun 8 19:14:48 2022 +0800 light.msstyles: Add Vista+ listview parts. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> --- dlls/light.msstyles/Makefile.in | 27 +++ .../blue_listview_collapse_button_15px.bmp | Bin 0 -> 2838 bytes .../blue_listview_collapse_button_15px.svg | 17 ++ .../blue_listview_collapse_button_19px.bmp | Bin 0 -> 4470 bytes .../blue_listview_collapse_button_19px.svg | 13 ++ .../blue_listview_collapse_button_23px.bmp | Bin 0 -> 6486 bytes .../blue_listview_collapse_button_23px.svg | 11 + .../blue_listview_collapse_button_30px.bmp | Bin 0 -> 10938 bytes .../blue_listview_collapse_button_30px.svg | 17 ++ .../blue_listview_collapse_button_37px.bmp | Bin 0 -> 16566 bytes .../blue_listview_collapse_button_37px.svg | 13 ++ .../blue_listview_collapse_button_45px.bmp | Bin 0 -> 24438 bytes .../blue_listview_collapse_button_45px.svg | 11 + .../blue_listview_collapse_button_60px.bmp | Bin 0 -> 43338 bytes .../blue_listview_collapse_button_60px.svg | 17 ++ .../light.msstyles/blue_listview_column_detail.bmp | Bin 0 -> 146 bytes .../light.msstyles/blue_listview_column_detail.svg | 5 + .../blue_listview_expand_button_15px.bmp | Bin 0 -> 2838 bytes .../blue_listview_expand_button_15px.svg | 17 ++ .../blue_listview_expand_button_19px.bmp | Bin 0 -> 4470 bytes .../blue_listview_expand_button_19px.svg | 13 ++ .../blue_listview_expand_button_23px.bmp | Bin 0 -> 6486 bytes .../blue_listview_expand_button_23px.svg | 11 + .../blue_listview_expand_button_30px.bmp | Bin 0 -> 10938 bytes .../blue_listview_expand_button_30px.svg | 17 ++ .../blue_listview_expand_button_37px.bmp | Bin 0 -> 16566 bytes .../blue_listview_expand_button_37px.svg | 13 ++ .../blue_listview_expand_button_45px.bmp | Bin 0 -> 24438 bytes .../blue_listview_expand_button_45px.svg | 11 + .../blue_listview_expand_button_60px.bmp | Bin 0 -> 43338 bytes .../blue_listview_expand_button_60px.svg | 17 ++ .../blue_listview_group_header_close_hot.bmp | Bin 0 -> 334 bytes .../blue_listview_group_header_close_hot.svg | 4 + ...listview_group_header_close_mixed_selection.bmp | Bin 0 -> 334 bytes ...listview_group_header_close_mixed_selection.svg | 4 + ...view_group_header_close_mixed_selection_hot.bmp | Bin 0 -> 334 bytes ...view_group_header_close_mixed_selection_hot.svg | 4 + .../blue_listview_group_header_close_selected.bmp | Bin 0 -> 334 bytes .../blue_listview_group_header_close_selected.svg | 4 + ...ue_listview_group_header_close_selected_hot.bmp | Bin 0 -> 334 bytes ...ue_listview_group_header_close_selected_hot.svg | 5 + ...iew_group_header_close_selected_not_focused.bmp | Bin 0 -> 334 bytes ...iew_group_header_close_selected_not_focused.svg | 4 + ...group_header_close_selected_not_focused_hot.bmp | Bin 0 -> 334 bytes ...group_header_close_selected_not_focused_hot.svg | 5 + .../blue_listview_group_header_line.bmp | Bin 0 -> 202 bytes .../blue_listview_group_header_line.svg | 9 + .../blue_listview_group_header_open_hot.bmp | Bin 0 -> 334 bytes .../blue_listview_group_header_open_hot.svg | 4 + ...tview_group_header_open_mixed_selection_hot.bmp | Bin 0 -> 334 bytes ...tview_group_header_open_mixed_selection_hot.svg | 4 + ...lue_listview_group_header_open_selected_hot.bmp | Bin 0 -> 334 bytes ...lue_listview_group_header_open_selected_hot.svg | 4 + ..._group_header_open_selected_not_focused_hot.bmp | Bin 0 -> 334 bytes ..._group_header_open_selected_not_focused_hot.svg | 4 + dlls/light.msstyles/light.rc | 242 +++++++++++++++++++++ 56 files changed, 527 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=5b563c21a9173bea0946…

1 0

Alexandre Julliard : ntdll: Fix returned status code for paths with a trailing slash.
by Alexandre Julliard 28 Jun '22

28 Jun '22

Module: wine Branch: master Commit: 3af025879583dff92540e29a92031a1078296484 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3af025879583dff92540e29a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jun 28 13:16:51 2022 +0200 ntdll: Fix returned status code for paths with a trailing slash. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/file.c | 25 ++++--------------------- dlls/ntdll/tests/file.c | 5 +---- dlls/ntdll/tests/path.c | 11 +++++------ dlls/ntdll/unix/file.c | 7 +++++-- dlls/ucrtbase/tests/misc.c | 2 +- server/fd.c | 6 +++++- 6 files changed, 21 insertions(+), 35 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index bd8d8c91b2f..b29e2c3dc4e 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -432,27 +432,10 @@ static void test__lcreat( void ) ok( ret, "DeleteFile failed (%ld)\n", GetLastError( ) ); filehandle=_lcreat (slashname, 0); /* illegal name */ - if (HFILE_ERROR==filehandle) { - err=GetLastError (); - ok (err==ERROR_INVALID_NAME || err==ERROR_PATH_NOT_FOUND, - "creating file \"%s\" failed with error %d\n", slashname, err); - } else { /* only NT succeeds */ - _lclose(filehandle); - find=FindFirstFileA (slashname, &search_results); - if (INVALID_HANDLE_VALUE!=find) - { - ret = FindClose (find); - ok (0 != ret, "FindClose complains (%ld)\n", GetLastError ()); - slashname[strlen(slashname)-1]=0; - ok (!strcmp (slashname, search_results.cFileName), - "found unexpected name \"%s\"\n", search_results.cFileName); - ok (FILE_ATTRIBUTE_ARCHIVE==search_results.dwFileAttributes, - "attributes of file \"%s\" are 0x%04lx\n", search_results.cFileName, - search_results.dwFileAttributes); - } - ret = DeleteFileA( slashname ); - ok( ret, "DeleteFile failed (%ld)\n", GetLastError( ) ); - } + ok( filehandle == HFILE_ERROR, "succeeded\n" ); + err=GetLastError (); + ok (err==ERROR_INVALID_NAME || err==ERROR_PATH_NOT_FOUND, + "creating file \"%s\" failed with error %d\n", slashname, err); filehandle=_lcreat (filename, 8); /* illegal attribute */ if (HFILE_ERROR==filehandle) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index f8ef38f38c2..065a9251c2a 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -4255,15 +4255,12 @@ static void test_NtCreateFile(void) status = pNtCreateFile( &handle, GENERIC_READ, &attr, &io, NULL, 0, FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_CREATE, 0, NULL, 0); - todo_wine ok( status == STATUS_OBJECT_NAME_INVALID, "failed %s %lx\n", debugstr_w(nameW.Buffer), status ); - if (!status) DeleteFileW( path ); status = pNtCreateFile( &handle, GENERIC_READ, &attr, &io, NULL, 0, FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_CREATE, FILE_DIRECTORY_FILE, NULL, 0); - todo_wine ok( !status, "failed %s %lx\n", debugstr_w(nameW.Buffer), status ); - if (!status) RemoveDirectoryW( path ); + RemoveDirectoryW( path ); } static void test_read_write(void) diff --git a/dlls/ntdll/tests/path.c b/dlls/ntdll/tests/path.c index d5d6e9c217a..4732f6a6aa8 100644 --- a/dlls/ntdll/tests/path.c +++ b/dlls/ntdll/tests/path.c @@ -627,7 +627,7 @@ static void test_RtlDosPathNameToNtPathName_U(void) static void test_nt_names(void) { - static const struct { const WCHAR *root, *name; NTSTATUS expect, broken; BOOL todo; } tests[] = + static const struct { const WCHAR *root, *name; NTSTATUS expect, broken; } tests[] = { { NULL, L"\\??\\C:\\windows\\system32\\kernel32.dll", STATUS_SUCCESS }, { NULL, L"\\??\\C:\\\\windows\\system32\\kernel32.dll", STATUS_SUCCESS, STATUS_OBJECT_NAME_INVALID }, @@ -652,9 +652,9 @@ static void test_nt_names(void) { NULL, L"\\??\\C:\\windows\\SyStEm32\\", STATUS_FILE_IS_A_DIRECTORY }, { NULL, L"\\??\\C:\\windows\\system32\\\\", STATUS_OBJECT_NAME_INVALID }, { NULL, L"\\??\\C:\\windows\\system32\\foobar\\", STATUS_OBJECT_NAME_NOT_FOUND }, - { NULL, L"\\??\\C:\\windows\\system32\\kernel32.dll\\", STATUS_OBJECT_NAME_INVALID, 0, TRUE }, + { NULL, L"\\??\\C:\\windows\\system32\\kernel32.dll\\", STATUS_OBJECT_NAME_INVALID }, { NULL, L"\\??\\C:\\windows\\system32\\kernel32.dll\\foo", STATUS_OBJECT_PATH_NOT_FOUND }, - { NULL, L"\\??\\C:\\windows\\system32\\Kernel32.Dll\\", STATUS_OBJECT_NAME_INVALID, 0, TRUE }, + { NULL, L"\\??\\C:\\windows\\system32\\Kernel32.Dll\\", STATUS_OBJECT_NAME_INVALID }, { NULL, L"\\??\\C:\\windows\\system32\\Kernel32.Dll\\foo", STATUS_OBJECT_PATH_NOT_FOUND }, { NULL, L"\\??\\C:\\windows\\sys\001", STATUS_OBJECT_NAME_INVALID }, { L"\\??\\", NULL, STATUS_OBJECT_NAME_INVALID }, @@ -678,9 +678,9 @@ static void test_nt_names(void) { L"\\??\\C:\\windows\\", L"SyStEm32\\", STATUS_FILE_IS_A_DIRECTORY }, { L"\\??\\C:\\windows\\", L"system32\\\\", STATUS_OBJECT_NAME_INVALID }, { L"\\??\\C:\\windows\\", L"system32\\foobar\\", STATUS_OBJECT_NAME_NOT_FOUND }, - { L"\\??\\C:\\windows\\", L"system32\\kernel32.dll\\", STATUS_OBJECT_NAME_INVALID, 0, TRUE }, + { L"\\??\\C:\\windows\\", L"system32\\kernel32.dll\\", STATUS_OBJECT_NAME_INVALID }, { L"\\??\\C:\\windows\\", L"system32\\kernel32.dll\\foo", STATUS_OBJECT_PATH_NOT_FOUND }, - { L"\\??\\C:\\windows\\", L"system32\\Kernel32.Dll\\", STATUS_OBJECT_NAME_INVALID, 0, TRUE }, + { L"\\??\\C:\\windows\\", L"system32\\Kernel32.Dll\\", STATUS_OBJECT_NAME_INVALID }, { L"\\??\\C:\\windows\\", L"system32\\Kernel32.Dll\\foo", STATUS_OBJECT_PATH_NOT_FOUND }, { L"\\??\\C:\\windows\\", L"\\system32\\kernel32.dll", STATUS_INVALID_PARAMETER }, { L"\\??\\C:\\windows\\", L"/system32\\kernel32.dll", STATUS_OBJECT_NAME_INVALID }, @@ -720,7 +720,6 @@ static void test_nt_names(void) } if (attr.RootDirectory) NtClose( attr.RootDirectory ); if (handle) NtClose( handle ); - todo_wine_if( tests[i].todo ) ok( status == tests[i].expect || broken( tests[i].broken && status == tests[i].broken ), "%u: got %lx / %lx for %s + %s\n", i, status, tests[i].expect, debugstr_w( tests[i].root ), debugstr_w( tests[i].name )); diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index 4873f7f093c..e09e8cafc82 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -3187,7 +3187,7 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer /* grow the buffer if needed */ - if (unix_len - pos < MAX_DIR_ENTRY_LEN + 2) + if (unix_len - pos < MAX_DIR_ENTRY_LEN + 3) { char *new_name; unix_len += 2 * MAX_DIR_ENTRY_LEN; @@ -3208,7 +3208,9 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer if (ret > 0 && ret <= MAX_DIR_ENTRY_LEN) { unix_name[pos] = '/'; - unix_name[pos + 1 + ret] = 0; + pos += ret + 1; + if (end < next) unix_name[pos++] = '/'; + unix_name[pos] = 0; status = STATUS_NO_SUCH_FILE; break; } @@ -3218,6 +3220,7 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer { status = STATUS_OBJECT_NAME_COLLISION; } + if (end < next) strcat( unix_name, "/" ); } else if (status == STATUS_OBJECT_NAME_NOT_FOUND) status = STATUS_OBJECT_PATH_NOT_FOUND; diff --git a/dlls/ucrtbase/tests/misc.c b/dlls/ucrtbase/tests/misc.c index 9cc50d85d78..069de0787b7 100644 --- a/dlls/ucrtbase/tests/misc.c +++ b/dlls/ucrtbase/tests/misc.c @@ -1309,7 +1309,7 @@ static void test__stat32(void) ok(!ret, "_stat32('%s') returned %d\n", path, ret); strcat(path, "\\"); ret = _stat32(path, &buf); - todo_wine ok(ret, "_stat32('%s') returned %d\n", path, ret); + ok(ret, "_stat32('%s') returned %d\n", path, ret); close(fd); remove(path); } diff --git a/server/fd.c b/server/fd.c index 1b4b98b0e76..eaebe044f37 100644 --- a/server/fd.c +++ b/server/fd.c @@ -1959,7 +1959,11 @@ struct fd *open_fd( struct fd *root, const char *name, struct unicode_str nt_nam if (fd->unix_fd == -1) { - file_set_error(); + /* check for trailing slash on file path */ + if ((errno == ENOENT || errno == ENOTDIR) && name[strlen(name) - 1] == '/') + set_error( STATUS_OBJECT_NAME_INVALID ); + else + file_set_error(); goto error; } }

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
80
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2022