wine-commits October 2023

wine-commits@winehq.org

1 participants
702 discussions

Gabriel Ivăncescu : ieframe: Implement DocObjectService_IsErrorUrl.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: c737b283d0c9716f5ea7e93afac93b8c34e8fc16 URL: https://gitlab.winehq.org/wine/wine/-/commit/c737b283d0c9716f5ea7e93afac93b… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Implement DocObjectService_IsErrorUrl. Needed to prevent an infinite loop when the error page itself fails to load (mshtml bails out early). Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/shellbrowser.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/ieframe/shellbrowser.c b/dlls/ieframe/shellbrowser.c index ca229c0ac8b..e2c4c451741 100644 --- a/dlls/ieframe/shellbrowser.c +++ b/dlls/ieframe/shellbrowser.c @@ -930,9 +930,10 @@ static HRESULT WINAPI DocObjectService_IsErrorUrl( BOOL *pfIsError) { ShellBrowser *This = impl_from_IDocObjectService(iface); - FIXME("%p %s %p\n", This, debugstr_w(lpszUrl), pfIsError); - *pfIsError = FALSE; + TRACE("(%p)->(%s %p)\n", This, debugstr_w(lpszUrl), pfIsError); + + *pfIsError = !!error_url_frag(lpszUrl); return S_OK; }

1 0

Gabriel Ivăncescu : ieframe: Send the original URL for error pages in FireDocumentComplete notification.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 5d17e7e4a877d75c024e016b1cc888b31f3fad10 URL: https://gitlab.winehq.org/wine/wine/-/commit/5d17e7e4a877d75c024e016b1cc888… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Send the original URL for error pages in FireDocumentComplete notification. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/shellbrowser.c | 8 ++++++++ dlls/ieframe/tests/ie.c | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/dlls/ieframe/shellbrowser.c b/dlls/ieframe/shellbrowser.c index 58ff851fb0b..ca229c0ac8b 100644 --- a/dlls/ieframe/shellbrowser.c +++ b/dlls/ieframe/shellbrowser.c @@ -839,6 +839,7 @@ static HRESULT WINAPI DocObjectService_FireDocumentComplete( { ShellBrowser *This = impl_from_IDocObjectService(iface); IHTMLPrivateWindow *priv_window; + const WCHAR *orig_url; VARIANTARG params[2]; DISPPARAMS dp = {params, NULL, 2, 0}; VARIANT url_var; @@ -858,6 +859,13 @@ static HRESULT WINAPI DocObjectService_FireDocumentComplete( TRACE("got URL %s\n", debugstr_w(url)); + orig_url = error_url_frag(url); + if(orig_url) { + BSTR tmp = SysAllocString(orig_url); + SysFreeString(url); + url = tmp; + } + V_VT(params) = (VT_BYREF|VT_VARIANT); V_VARIANTREF(params) = &url_var; diff --git a/dlls/ieframe/tests/ie.c b/dlls/ieframe/tests/ie.c index 8a91efb3af5..d6e1f643952 100644 --- a/dlls/ieframe/tests/ie.c +++ b/dlls/ieframe/tests/ie.c @@ -215,7 +215,6 @@ static HRESULT WINAPI Dispatch_Invoke(IDispatch *iface, DISPID dispIdMember, REF arg = pDispParams->rgvarg; ok(V_VT(arg) == (VT_BYREF | VT_VARIANT), "VT = %d\n", V_VT(arg)); ok(V_VT(V_VARIANTREF(arg)) == VT_BSTR, "VT = %d\n", V_VT(V_VARIANTREF(arg))); - todo_wine_if(called_Invoke_NAVIGATEERROR) ok(!wcscmp(V_BSTR(V_VARIANTREF(arg)), navigate_url), "url = %s\n", wine_dbgstr_w(V_BSTR(V_VARIANTREF(arg)))); arg = pDispParams->rgvarg + 1;

1 0

Gabriel Ivăncescu : ieframe: Send the original URL for error pages in FireNavigationComplete2 notification.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 82c03141d871d8bf651132817bfa6bc117ed0d8b URL: https://gitlab.winehq.org/wine/wine/-/commit/82c03141d871d8bf651132817bfa6b… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Send the original URL for error pages in FireNavigationComplete2 notification. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/shellbrowser.c | 8 ++++++++ dlls/ieframe/tests/ie.c | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/dlls/ieframe/shellbrowser.c b/dlls/ieframe/shellbrowser.c index d3f8c6f8ddb..58ff851fb0b 100644 --- a/dlls/ieframe/shellbrowser.c +++ b/dlls/ieframe/shellbrowser.c @@ -758,6 +758,7 @@ static HRESULT WINAPI DocObjectService_FireNavigateComplete2( ShellBrowser *This = impl_from_IDocObjectService(iface); DocHost *doc_host = This->doc_host; IHTMLPrivateWindow *priv_window; + const WCHAR *orig_url; VARIANTARG params[2]; DISPPARAMS dp = {params, NULL, 2, 0}; VARIANT url_var; @@ -786,6 +787,13 @@ static HRESULT WINAPI DocObjectService_FireNavigateComplete2( TRACE("got URL %s\n", debugstr_w(url)); set_dochost_url(This->doc_host, url); + orig_url = error_url_frag(url); + if(orig_url) { + BSTR tmp = SysAllocString(orig_url); + SysFreeString(url); + url = tmp; + } + V_VT(params) = (VT_BYREF|VT_VARIANT); V_VARIANTREF(params) = &url_var; diff --git a/dlls/ieframe/tests/ie.c b/dlls/ieframe/tests/ie.c index 5e52baedb68..8a91efb3af5 100644 --- a/dlls/ieframe/tests/ie.c +++ b/dlls/ieframe/tests/ie.c @@ -186,7 +186,6 @@ static HRESULT WINAPI Dispatch_Invoke(IDispatch *iface, DISPID dispIdMember, REF arg = pDispParams->rgvarg; ok(V_VT(arg) == (VT_BYREF | VT_VARIANT), "VT = %d\n", V_VT(arg)); ok(V_VT(V_VARIANTREF(arg)) == VT_BSTR, "VT = %d\n", V_VT(V_VARIANTREF(arg))); - todo_wine_if(called_Invoke_NAVIGATEERROR) ok(!wcscmp(V_BSTR(V_VARIANTREF(arg)), navigate_url), "url = %s\n", wine_dbgstr_w(V_BSTR(V_VARIANTREF(arg)))); arg = pDispParams->rgvarg + 1;

1 0

Gabriel Ivăncescu : ieframe: Use the original URL for error pages' address bar.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 76b198000f3df8e32c63174dc728d88f625e85f7 URL: https://gitlab.winehq.org/wine/wine/-/commit/76b198000f3df8e32c63174dc728d8… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Use the original URL for error pages' address bar. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/ieframe.h | 1 + dlls/ieframe/iexplore.c | 4 ++++ dlls/ieframe/shellbrowser.c | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+) diff --git a/dlls/ieframe/ieframe.h b/dlls/ieframe/ieframe.h index b03fe6e8e83..602bb1c5d36 100644 --- a/dlls/ieframe/ieframe.h +++ b/dlls/ieframe/ieframe.h @@ -281,6 +281,7 @@ HRESULT get_window(DocHost*,IHTMLWindow2**); HRESULT get_location_url(DocHost*,BSTR*); HRESULT set_dochost_url(DocHost*,const WCHAR*); void handle_navigation_error(DocHost*,HRESULT,BSTR,IHTMLWindow2*); +const WCHAR *error_url_frag(const WCHAR*); HRESULT dochost_object_available(DocHost*,IUnknown*); void set_doc_state(DocHost*,READYSTATE); void activate_document(DocHost*); diff --git a/dlls/ieframe/iexplore.c b/dlls/ieframe/iexplore.c index acf7a18e3f3..43ecf5ee3f1 100644 --- a/dlls/ieframe/iexplore.c +++ b/dlls/ieframe/iexplore.c @@ -783,6 +783,10 @@ static void DocHostContainer_on_command_state_change(DocHost *iface, LONG comman static void DocHostContainer_set_url(DocHost* iface, const WCHAR *url) { InternetExplorer *This = impl_from_DocHost(iface); + const WCHAR *orig_url = error_url_frag(url); + + if(orig_url) + url = orig_url; This->nohome = FALSE; SendMessageW(This->frame_hwnd, WM_UPDATEADDRBAR, 0, (LPARAM)url); diff --git a/dlls/ieframe/shellbrowser.c b/dlls/ieframe/shellbrowser.c index a5666fd761b..d3f8c6f8ddb 100644 --- a/dlls/ieframe/shellbrowser.c +++ b/dlls/ieframe/shellbrowser.c @@ -29,6 +29,24 @@ WINE_DEFAULT_DEBUG_CHANNEL(ieframe); +const WCHAR *error_url_frag(const WCHAR *url) +{ + if(!wcsncmp(url, L"res://", ARRAY_SIZE(L"res://")-1)) { + WCHAR buf[MAX_PATH]; + UINT len = GetSystemDirectoryW(buf, ARRAY_SIZE(buf)); + + if(len && !wcsncmp(url + ARRAY_SIZE(L"res://")-1, buf, len)) { + len += ARRAY_SIZE(L"res://")-1; + if(!wcsncmp(url + len, L"\\shdoclc.dll/ERROR.HTM", ARRAY_SIZE(L"\\shdoclc.dll/ERROR.HTM")-1)) { + len += ARRAY_SIZE(L"\\shdoclc.dll/ERROR.HTM")-1; + url = wcschr(url + len, '#'); + return url ? url + 1 : NULL; + } + } + } + return NULL; +} + static inline ShellBrowser *impl_from_IShellBrowser(IShellBrowser *iface) { return CONTAINING_RECORD(iface, ShellBrowser, IShellBrowser_iface);

1 0

Gabriel Ivăncescu : ieframe: Navigate to a basic error page on failed navigation.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 8a67308f7466fed8f8f3b4968b7022ec8bc12459 URL: https://gitlab.winehq.org/wine/wine/-/commit/8a67308f7466fed8f8f3b4968b7022… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Navigate to a basic error page on failed navigation. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/ieframe.h | 1 + dlls/ieframe/navigate.c | 49 +++++++++++++-- dlls/ieframe/tests/ie.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 198 insertions(+), 8 deletions(-)

1 0

Gabriel Ivăncescu : ieframe: Implement IEHTMLWindow2_get_document.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 125c390f61e09bcc2e988ecf39aed92b8b54951b URL: https://gitlab.winehq.org/wine/wine/-/commit/125c390f61e09bcc2e988ecf39aed9… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 ieframe: Implement IEHTMLWindow2_get_document. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/ieframe/iehtmlwnd.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/dlls/ieframe/iehtmlwnd.c b/dlls/ieframe/iehtmlwnd.c index 44e58a2cdff..de211fc784f 100644 --- a/dlls/ieframe/iehtmlwnd.c +++ b/dlls/ieframe/iehtmlwnd.c @@ -22,6 +22,25 @@ WINE_DEFAULT_DEBUG_CHANNEL(ieframe); +HRESULT get_window(DocHost *doc_host, IHTMLWindow2 **ret) +{ + IHTMLDocument2 *doc_obj; + HRESULT hres; + + if(!doc_host->document) { + *ret = NULL; + return S_OK; + } + + hres = IUnknown_QueryInterface(doc_host->document, &IID_IHTMLDocument2, (void**)&doc_obj); + if(FAILED(hres)) + return hres; + + hres = IHTMLDocument2_get_parentWindow(doc_obj, ret); + IHTMLDocument2_Release(doc_obj); + return hres; +} + static inline IEHTMLWindow *impl_from_IHTMLWindow2(IHTMLWindow2 *iface) { return CONTAINING_RECORD(iface, IEHTMLWindow, IHTMLWindow2_iface); @@ -432,8 +451,22 @@ static HRESULT WINAPI IEHTMLWindow2_get_onscroll(IHTMLWindow2 *iface, VARIANT *p static HRESULT WINAPI IEHTMLWindow2_get_document(IHTMLWindow2 *iface, IHTMLDocument2 **p) { IEHTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + IHTMLWindow2 *window; + HRESULT hres; + + TRACE("(%p)->(%p)\n", This, p); + + hres = get_window(This->doc_host, &window); + if(FAILED(hres)) + return hres; + + if(!window) + *p = NULL; + else { + hres = IHTMLWindow2_get_document(window, p); + IHTMLWindow2_Release(window); + } + return hres; } static HRESULT WINAPI IEHTMLWindow2_get_event(IHTMLWindow2 *iface, IHTMLEventObj **p)

1 0

Gabriel Ivăncescu : shdoclc: Add a basic generic html page for navigation errors.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: e3c768ab551b4751937a14d55ae470e5618ff272 URL: https://gitlab.winehq.org/wine/wine/-/commit/e3c768ab551b4751937a14d55ae470… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 shdoclc: Add a basic generic html page for navigation errors. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/shdoclc/ERROR.HTM | 13 +++++++++++++ dlls/shdoclc/shdoclc.rc | 3 +++ 2 files changed, 16 insertions(+) diff --git a/dlls/shdoclc/ERROR.HTM b/dlls/shdoclc/ERROR.HTM new file mode 100644 index 00000000000..e74efa15608 --- /dev/null +++ b/dlls/shdoclc/ERROR.HTM @@ -0,0 +1,13 @@ +<!DOCTYPE HTML> +<html> +<head> + <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> + <title>Page Load Error</title> +</head> +<body onload="javascript: if(window.location.search) document.getElementById('err').innerHTML = unescape(window.location.search.substr(1))"> +<div style="margin-left:45px; width:720px;"> + <h2>The page cannot be loaded because of an error</h2> + <p>Error code: <b id="err">Unknown</b></p> +</div> +</body> +</html> diff --git a/dlls/shdoclc/shdoclc.rc b/dlls/shdoclc/shdoclc.rc index 57b03e152d4..a350438e0fb 100644 --- a/dlls/shdoclc/shdoclc.rc +++ b/dlls/shdoclc/shdoclc.rc @@ -241,3 +241,6 @@ IDR_BROWSE_CONTEXT_MENU MENU MENUITEM "Scroll Right", IDM_SCROLL_RIGHT } } + +/* @makedep: ERROR.HTM */ +ERROR.HTM HTML "ERROR.HTM"

1 0

Gabriel Ivăncescu : mshtml: Implement SuperNavigate undocumented flag 2.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: b38fcaf36a3cf7b8eed153a539377d82bb4d6291 URL: https://gitlab.winehq.org/wine/wine/-/commit/b38fcaf36a3cf7b8eed153a539377d… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Oct 5 18:57:46 2023 +0300 mshtml: Implement SuperNavigate undocumented flag 2. Seems to be doing a replace and skipping updating travel log/history. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/htmlwindow.c | 9 +- dlls/mshtml/tests/htmldoc.c | 206 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 212 insertions(+), 3 deletions(-)

1 0

Helix Graziani : nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 5a7d75cd347369ed14dcccc84e796dda20d77580 URL: https://gitlab.winehq.org/wine/wine/-/commit/5a7d75cd347369ed14dcccc84e796d… Author: Helix Graziani <helix.graziani(a)hotmail.com> Date: Sat Sep 9 17:37:48 2023 -0400 nsiproxy.sys: Implement ipv6_forward_enumerate_all. --- dlls/nsiproxy.sys/ip.c | 136 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 134 insertions(+), 2 deletions(-) diff --git a/dlls/nsiproxy.sys/ip.c b/dlls/nsiproxy.sys/ip.c index dbe3a0b46b7..c904f9158fe 100644 --- a/dlls/nsiproxy.sys/ip.c +++ b/dlls/nsiproxy.sys/ip.c @@ -1482,13 +1482,145 @@ static NTSTATUS ipv4_forward_enumerate_all( void *key_data, UINT key_size, void return status; } +struct ipv6_route_data +{ + NET_LUID luid; + UINT if_index; + struct in6_addr prefix; + UINT prefix_len; + struct in6_addr next_hop; + UINT metric; + UINT protocol; + BYTE loopback; +}; + +static void ipv6_forward_fill_entry( struct ipv6_route_data *entry, struct nsi_ipv6_forward_key *key, + struct nsi_ip_forward_rw *rw, struct nsi_ipv6_forward_dynamic *dyn, + struct nsi_ip_forward_static *stat ) +{ + if (key) + { + key->unk = 0; + memcpy( key->prefix.u.Byte, entry->prefix.s6_addr, sizeof(entry->prefix.s6_addr) ); + key->prefix_len = entry->prefix_len; + memset( key->unk2, 0, sizeof(key->unk2) ); + memset( key->unk3, 0, sizeof(key->unk3) ); + key->luid = entry->luid; + key->luid2 = entry->luid; + memcpy( key->next_hop.u.Byte, entry->next_hop.s6_addr, sizeof(entry->next_hop.s6_addr) ); + key->pad = 0; + } + + if (rw) + { + rw->site_prefix_len = 0; + rw->valid_lifetime = ~0u; + rw->preferred_lifetime = ~0u; + rw->metric = entry->metric; + rw->protocol = entry->protocol; + rw->loopback = entry->loopback; + rw->autoconf = 1; + rw->publish = 0; + rw->immortal = 1; + memset( rw->unk, 0, sizeof(rw->unk) ); + rw->unk2 = 0; + } + + if (dyn) + { + memset( dyn, 0, sizeof(*dyn) ); + } + + if (stat) + { + stat->origin = NlroManual; + stat->if_index = entry->if_index; + } +} + +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) +{ + struct in6_addr ret; + + for (int i = 0; i < sizeof(ret); i++) + { + if (!isxdigit( *nptr ) || !isxdigit( *nptr + 1 )) + { + /* invalid hex string */ + if (endptr) *endptr = nptr; + return ret; + } + + sscanf( nptr, "%2hhx", &ret.s6_addr[i] ); + nptr += 2; + } + + if (endptr) *endptr = nptr; + + return ret; +} + static NTSTATUS ipv6_forward_enumerate_all( void *key_data, UINT key_size, void *rw_data, UINT rw_size, void *dynamic_data, UINT dynamic_size, void *static_data, UINT static_size, UINT_PTR *count ) { + UINT num = 0; + NTSTATUS status = STATUS_SUCCESS; + BOOL want_data = key_size || rw_size || dynamic_size || static_size; + struct ipv6_route_data entry; + + TRACE( "%p %d %p %d %p %d %p %d %p" , key_data, key_size, rw_data, rw_size, + dynamic_data, dynamic_size, static_data, static_size, count ); + +#ifdef __linux__ + { + char buf[512], *ptr; + UINT rtf_flags; + FILE *fp; + + if (!(fp = fopen( "/proc/net/ipv6_route", "r" ))) return STATUS_NOT_SUPPORTED; + + while ((ptr = fgets( buf, sizeof(buf), fp ))) + { + while (!isspace( *ptr )) ptr++; + *ptr++ = '\0'; + + entry.prefix = str_to_in6_addr( ptr, &ptr ); + entry.prefix_len = strtoul( ptr + 1, &ptr, 16 ); + str_to_in6_addr( ptr + 1, &ptr ); /* source network, skip */ + strtoul( ptr + 1, &ptr, 16 ); /* source prefix length, skip */ + entry.next_hop = str_to_in6_addr( ptr + 1, &ptr ); + entry.metric = strtoul( ptr + 1, &ptr, 16 ); + strtoul( ptr + 1, &ptr, 16 ); /* refcount, skip */ + strtoul( ptr + 1, &ptr, 16 ); /* use, skip */ + rtf_flags = strtoul( ptr + 1, &ptr, 16); + entry.protocol = (rtf_flags & RTF_GATEWAY) ? MIB_IPPROTO_NETMGMT : MIB_IPPROTO_LOCAL; + entry.loopback = entry.protocol == MIB_IPPROTO_LOCAL && entry.prefix_len == 32; + + if (!convert_unix_name_to_luid( ptr, &entry.luid )) continue; + if (!convert_luid_to_index( &entry.luid, &entry.if_index )) continue; + + if (num < *count) + { + ipv6_forward_fill_entry( &entry, key_data, rw_data, dynamic_data, static_data ); + key_data = (BYTE *)key_data + key_size; + rw_data = (BYTE *)rw_data + rw_size; + dynamic_data = (BYTE *)dynamic_data + dynamic_size; + static_data = (BYTE *)static_data + static_size; + } + num++; + } + fclose(fp); + } +#else FIXME( "not implemented\n" ); - *count = 0; - return STATUS_SUCCESS; + return STATUS_NOT_IMPLEMENTED; +#endif + + if (!want_data || num <= *count) *count = num; + else status = STATUS_BUFFER_OVERFLOW; + + return status; } static struct module_table ipv4_tables[] =

1 0

Zebediah Figura : objsel: Do not create an object from IClassFactory::QueryInterface().
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 512f8b17aee3fe25d1ec062667ef9e1eb24a485a URL: https://gitlab.winehq.org/wine/wine/-/commit/512f8b17aee3fe25d1ec062667ef9e… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 17:46:54 2023 -0500 objsel: Do not create an object from IClassFactory::QueryInterface(). --- dlls/objsel/objsel.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/dlls/objsel/objsel.c b/dlls/objsel/objsel.c index 41f548bbc75..fce397cf557 100644 --- a/dlls/objsel/objsel.c +++ b/dlls/objsel/objsel.c @@ -189,10 +189,6 @@ static HRESULT WINAPI class_factory_QueryInterface(IClassFactory *iface, REFIID IClassFactory_AddRef(iface); return S_OK; } - else if (IsEqualGUID(iid, &IID_IDsObjectPicker)) - { - return IClassFactory_CreateInstance(iface, NULL, iid, out); - } WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(iid)); return E_NOINTERFACE;

1 0

← Newer
1
...
54
55
56
57
58
59
60
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2023