wine-commits October 2023

wine-commits@winehq.org

1 participants
702 discussions

Zebediah Figura : objsel: Do not check for a NULL interface in COM methods.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 2ac66e33fd89bbae31367ebda94415424d812a56 URL: https://gitlab.winehq.org/wine/wine/-/commit/2ac66e33fd89bbae31367ebda94415… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 17:45:49 2023 -0500 objsel: Do not check for a NULL interface in COM methods. --- dlls/objsel/objsel.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/dlls/objsel/objsel.c b/dlls/objsel/objsel.c index 0c809673c44..41f548bbc75 100644 --- a/dlls/objsel/objsel.c +++ b/dlls/objsel/objsel.c @@ -59,8 +59,6 @@ static ULONG WINAPI OBJSEL_IDsObjectPicker_AddRef(IDsObjectPicker * iface) TRACE("\n"); - if (This == NULL) return E_POINTER; - return InterlockedIncrement(&This->ref); } @@ -75,8 +73,6 @@ static ULONG WINAPI OBJSEL_IDsObjectPicker_Release(IDsObjectPicker * iface) TRACE("\n"); - if (This == NULL) return E_POINTER; - ref = InterlockedDecrement(&This->ref); if (ref == 0) @@ -209,9 +205,6 @@ static ULONG WINAPI class_factory_AddRef(IClassFactory *iface) TRACE("\n"); - if (!factory) - return E_POINTER; - return InterlockedIncrement(&factory->ref); } @@ -222,9 +215,6 @@ static ULONG WINAPI class_factory_Release(IClassFactory *iface) TRACE("\n"); - if (!factory) - return E_POINTER; - return InterlockedDecrement(&factory->ref); }

1 0

Zebediah Figura : objsel: Merge factory.c into objsel.c.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 026c7fc6b52f26b75de920f57766c807a329610d URL: https://gitlab.winehq.org/wine/wine/-/commit/026c7fc6b52f26b75de920f57766c8… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 17:41:14 2023 -0500 objsel: Merge factory.c into objsel.c. A separate file for the class factory is not justified. --- dlls/objsel/Makefile.in | 1 - dlls/objsel/factory.c | 152 ------------------------------------------- dlls/objsel/objsel.c | 151 ++++++++++++++++++++++++++++++++++++------ dlls/objsel/objsel_private.h | 43 ------------ 4 files changed, 131 insertions(+), 216 deletions(-)

1 0

Zebediah Figura : objsel: Remove DLL refcount tracking.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 39ccd7199160bd0e9ed3ed4a040328f930369706 URL: https://gitlab.winehq.org/wine/wine/-/commit/39ccd7199160bd0e9ed3ed4a040328… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 13:05:14 2023 -0500 objsel: Remove DLL refcount tracking. Recent consensus seems to be that this isn't worth the effort. --- dlls/objsel/factory.c | 20 ++------------------ dlls/objsel/objsel.c | 24 +----------------------- dlls/objsel/objsel_private.h | 6 ------ 3 files changed, 3 insertions(+), 47 deletions(-) diff --git a/dlls/objsel/factory.c b/dlls/objsel/factory.c index cb0fb491cb4..c3e64f0568a 100644 --- a/dlls/objsel/factory.c +++ b/dlls/objsel/factory.c @@ -66,20 +66,12 @@ static HRESULT WINAPI OBJSEL_IClassFactory_QueryInterface( static ULONG WINAPI OBJSEL_IClassFactory_AddRef(LPCLASSFACTORY iface) { ClassFactoryImpl *This = impl_from_IClassFactory(iface); - ULONG ref; TRACE("\n"); if (This == NULL) return E_POINTER; - ref = InterlockedIncrement(&This->ref); - - if (ref == 1) - { - InterlockedIncrement(&dll_refs); - } - - return ref; + return InterlockedIncrement(&This->ref); } @@ -89,20 +81,12 @@ static ULONG WINAPI OBJSEL_IClassFactory_AddRef(LPCLASSFACTORY iface) static ULONG WINAPI OBJSEL_IClassFactory_Release(LPCLASSFACTORY iface) { ClassFactoryImpl *This = impl_from_IClassFactory(iface); - ULONG ref; TRACE("\n"); if (This == NULL) return E_POINTER; - ref = InterlockedDecrement(&This->ref); - - if (ref == 0) - { - InterlockedDecrement(&dll_refs); - } - - return ref; + return InterlockedDecrement(&This->ref); } diff --git a/dlls/objsel/objsel.c b/dlls/objsel/objsel.c index 90873191691..026a6d594af 100644 --- a/dlls/objsel/objsel.c +++ b/dlls/objsel/objsel.c @@ -24,8 +24,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(objsel); -LONG dll_refs = 0; - /*********************************************************************** * DllGetClassObject (OBJSEL.@) */ @@ -43,15 +41,6 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv) } -/*********************************************************************** - * DllCanUnloadNow (OBJSEL.@) - */ -HRESULT WINAPI DllCanUnloadNow(void) -{ - return dll_refs != 0 ? S_FALSE : S_OK; -} - - /********************************************************************** * OBJSEL_IDsObjectPicker_Destroy (also IUnknown) */ @@ -74,20 +63,12 @@ static inline IDsObjectPickerImpl *impl_from_IDsObjectPicker(IDsObjectPicker *if static ULONG WINAPI OBJSEL_IDsObjectPicker_AddRef(IDsObjectPicker * iface) { IDsObjectPickerImpl *This = impl_from_IDsObjectPicker(iface); - ULONG ref; TRACE("\n"); if (This == NULL) return E_POINTER; - ref = InterlockedIncrement(&This->ref); - - if (ref == 1) - { - InterlockedIncrement(&dll_refs); - } - - return ref; + return InterlockedIncrement(&This->ref); } @@ -106,10 +87,7 @@ static ULONG WINAPI OBJSEL_IDsObjectPicker_Release(IDsObjectPicker * iface) ref = InterlockedDecrement(&This->ref); if (ref == 0) - { - InterlockedDecrement(&dll_refs); OBJSEL_IDsObjectPicker_Destroy(This); - } return ref; } diff --git a/dlls/objsel/objsel_private.h b/dlls/objsel/objsel_private.h index b0a2e956733..86ea129089b 100644 --- a/dlls/objsel/objsel_private.h +++ b/dlls/objsel/objsel_private.h @@ -23,12 +23,6 @@ #include "objidl.h" #include "objsel.h" -/********************************************************************** - * Dll lifetime tracking declaration for objsel.dll - */ - -extern LONG dll_refs DECLSPEC_HIDDEN; - /********************************************************************** * ClassFactory declaration for objsel.dll */

1 0

Zebediah Figura : objsel: Remove unnecessary includes.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 528fdc783bf8fe84cf232b90b5d19acc258c0a32 URL: https://gitlab.winehq.org/wine/wine/-/commit/528fdc783bf8fe84cf232b90b5d19a… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Wed Sep 6 13:01:43 2023 -0500 objsel: Remove unnecessary includes. --- dlls/objsel/objsel.c | 1 - dlls/objsel/objsel_private.h | 16 +--------------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/dlls/objsel/objsel.c b/dlls/objsel/objsel.c index e42ac5ab898..90873191691 100644 --- a/dlls/objsel/objsel.c +++ b/dlls/objsel/objsel.c @@ -19,7 +19,6 @@ */ #include "objsel_private.h" -#include "rpcproxy.h" #include "wine/debug.h" diff --git a/dlls/objsel/objsel_private.h b/dlls/objsel/objsel_private.h index 9289c00d8c9..b0a2e956733 100644 --- a/dlls/objsel/objsel_private.h +++ b/dlls/objsel/objsel_private.h @@ -18,24 +18,10 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include <string.h> -#include <stdarg.h> -#include <stdio.h> -#include "winerror.h" -#include "windef.h" -#include "winbase.h" -#include "winreg.h" -#include "wingdi.h" -#include "winuser.h" - #define COBJMACROS -#include "ole2.h" -#include "strmif.h" -#include "olectl.h" -#include "unknwn.h" +#include "objidl.h" #include "objsel.h" -#include "uuids.h" /********************************************************************** * Dll lifetime tracking declaration for objsel.dll

1 0

Alex Henrie : riched20: Use CRT allocation functions.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 42579f1dcd2f14e765e2f53ceb5b46fff5623f10 URL: https://gitlab.winehq.org/wine/wine/-/commit/42579f1dcd2f14e765e2f53ceb5b46… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Sep 24 11:36:20 2023 -0600 riched20: Use CRT allocation functions. --- dlls/riched20/caret.c | 2 +- dlls/riched20/clipboard.c | 8 +++--- dlls/riched20/editor.c | 36 ++++++++++++------------ dlls/riched20/editstr.h | 1 - dlls/riched20/list.c | 8 +++--- dlls/riched20/reader.c | 72 +++++++++++++++++------------------------------ dlls/riched20/richole.c | 22 +++++++-------- dlls/riched20/string.c | 24 ++++++++-------- dlls/riched20/style.c | 4 +-- dlls/riched20/table.c | 2 +- dlls/riched20/txthost.c | 12 ++++---- dlls/riched20/txtsrv.c | 4 +-- dlls/riched20/undo.c | 8 +++--- dlls/riched20/wrap.c | 18 ++++++------ dlls/riched20/writer.c | 12 ++++---- 15 files changed, 106 insertions(+), 127 deletions(-)

1 0

Alexandre Julliard : ntdll: Only create the main module on the 32-bit side for wow64.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: de81e2ea41b27a14f88177639c5b5d35a210b5bd URL: https://gitlab.winehq.org/wine/wine/-/commit/de81e2ea41b27a14f88177639c5b5d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 6 15:08:02 2023 +0200 ntdll: Only create the main module on the 32-bit side for wow64. --- dlls/ntdll/loader.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index cfb1e833cc6..2bf1437623f 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -4219,16 +4219,13 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR init_user_process_params(); load_global_options(); version_init(); + build_ntdll_module( meminfo.AllocationBase ); - get_env_var( L"WINESYSTEMDLLPATH", 0, &system_dll_path ); + if (NtCurrentTeb()->WowTebOffset) init_wow64( context ); wm = build_main_module(); wm->ldr.LoadCount = -1; - build_ntdll_module( meminfo.AllocationBase ); - - if (NtCurrentTeb()->WowTebOffset) init_wow64( context ); - if ((status = load_dll( NULL, L"kernel32.dll", 0, &kernel32, FALSE )) != STATUS_SUCCESS) { MESSAGE( "wine: could not load kernel32.dll, status %lx\n", status ); @@ -4245,6 +4242,7 @@ void WINAPI LdrInitializeThunk( CONTEXT *context, ULONG_PTR unknown2, ULONG_PTR actctx_init(); locale_init(); + get_env_var( L"WINESYSTEMDLLPATH", 0, &system_dll_path ); if (wm->ldr.Flags & LDR_COR_ILONLY) status = fixup_imports_ilonly( wm, NULL, entry ); else

1 0

Alexandre Julliard : server: Remove some leftover code from a failed rebase.
by Alexandre Julliard 07 Oct '23

07 Oct '23

Module: wine Branch: master Commit: 93a5dce013a0b992e18ff6b923dcbb6535577ab3 URL: https://gitlab.winehq.org/wine/wine/-/commit/93a5dce013a0b992e18ff6b923dcbb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 6 11:23:46 2023 +0200 server: Remove some leftover code from a failed rebase. --- server/mapping.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/server/mapping.c b/server/mapping.c index c570bcf8f94..a795dc4b38b 100644 --- a/server/mapping.c +++ b/server/mapping.c @@ -833,11 +833,6 @@ static unsigned int get_image_params( struct mapping *mapping, file_pos_t file_s !(nt.FileHeader.Characteristics & IMAGE_FILE_RELOCS_STRIPPED)); if (nt.opt.hdr64.SectionAlignment & page_mask) mapping->image.image_flags |= IMAGE_FLAGS_ImageMappedFlat; - else if (nt.opt.hdr64.NumberOfRvaAndSizes > IMAGE_DIRECTORY_ENTRY_BASERELOC && - nt.opt.hdr64.DataDirectory[IMAGE_DIRECTORY_ENTRY_BASERELOC].VirtualAddress && - nt.opt.hdr64.DataDirectory[IMAGE_DIRECTORY_ENTRY_BASERELOC].Size && - !(nt.FileHeader.Characteristics & IMAGE_FILE_RELOCS_STRIPPED)) - mapping->image.image_flags |= IMAGE_FLAGS_ImageDynamicallyRelocated; else if ((nt.opt.hdr64.DllCharacteristics & IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE) && (has_relocs || mapping->image.contains_code) && !(clr_va && clr_size)) mapping->image.image_flags |= IMAGE_FLAGS_ImageDynamicallyRelocated;

1 0

Nikolay Sivov : d3d10/effect: Add support for shift instructions.
by Alexandre Julliard 05 Oct '23

05 Oct '23

Module: wine Branch: master Commit: 41ab207c71cfaa82ef95c83b291654aba023a45c URL: https://gitlab.winehq.org/wine/wine/-/commit/41ab207c71cfaa82ef95c83b291654… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Oct 5 00:20:47 2023 +0200 d3d10/effect: Add support for shift instructions. --- dlls/d3d10/effect.c | 43 ++++++++++ dlls/d3d10/tests/effect.c | 215 ++++++++++++++++++++++++++++++---------------- 2 files changed, 183 insertions(+), 75 deletions(-)

1 0

Joel Holdsworth : ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE.
by Alexandre Julliard 05 Oct '23

05 Oct '23

Module: wine Branch: master Commit: e916255216e708e7646f87ebc5a860039660a87f URL: https://gitlab.winehq.org/wine/wine/-/commit/e916255216e708e7646f87ebc5a860… Author: Joel Holdsworth <joel(a)airwebreathe.org.uk> Date: Mon Aug 7 11:32:44 2023 +0100 ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- dlls/ntdll/tests/file.c | 14 +++++++------- dlls/ntdll/unix/file.c | 4 ++-- server/fd.c | 3 ++- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index a00a425582c..4e1750a4751 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -2259,10 +2259,10 @@ static void test_file_rename_information_ex(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fri, sizeof(FILE_RENAME_INFORMATION) + fri->FileNameLength, FileRenameInformationEx ); - todo_wine ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); - todo_wine ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); + ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); + ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; - todo_wine ok( fileDeleted, "file should not exist\n" ); + ok( fileDeleted, "file should not exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -3076,8 +3076,8 @@ static void test_file_link_information_ex(void) return; } - ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); - todo_wine ok( res == STATUS_ACCESS_DENIED, "res expected STATUS_ACCESS_DENIED, got %lx\n", res ); + todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( res == STATUS_ACCESS_DENIED, "res expected STATUS_ACCESS_DENIED, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; @@ -3110,8 +3110,8 @@ static void test_file_link_information_ex(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformationEx ); - todo_wine ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); - todo_wine ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); + ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); + ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index aa2ec9bae59..c6533710365 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -4797,7 +4797,7 @@ NTSTATUS WINAPI NtSetInformationFile( HANDLE handle, IO_STATUS_BLOCK *io, else flags = info->Flags; - if (flags & ~FILE_RENAME_REPLACE_IF_EXISTS) + if (flags & ~(FILE_RENAME_REPLACE_IF_EXISTS | FILE_RENAME_IGNORE_READONLY_ATTRIBUTE)) FIXME( "unsupported flags: %#x\n", flags ); name_str.Buffer = info->FileName; @@ -4844,7 +4844,7 @@ NTSTATUS WINAPI NtSetInformationFile( HANDLE handle, IO_STATUS_BLOCK *io, else flags = info->Flags; - if (flags & ~FILE_LINK_REPLACE_IF_EXISTS) + if (flags & ~(FILE_LINK_REPLACE_IF_EXISTS | FILE_LINK_IGNORE_READONLY_ATTRIBUTE)) FIXME( "unsupported flags: %#x\n", flags ); name_str.Buffer = info->FileName; diff --git a/server/fd.c b/server/fd.c index 00c0e4ac847..8576882aaa9 100644 --- a/server/fd.c +++ b/server/fd.c @@ -2601,7 +2601,8 @@ static void set_fd_name( struct fd *fd, struct fd *root, const char *nameptr, da } /* read-only files cannot be replaced */ - if (!(st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH))) + if (!(st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)) && + !(flags & FILE_RENAME_IGNORE_READONLY_ATTRIBUTE)) { set_error( STATUS_ACCESS_DENIED ); goto failed;

1 0

Joel Holdsworth : server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}.
by Alexandre Julliard 05 Oct '23

05 Oct '23

Module: wine Branch: master Commit: a8489d12eb8161cd0434ec57774e87ea70a44716 URL: https://gitlab.winehq.org/wine/wine/-/commit/a8489d12eb8161cd0434ec57774e87… Author: Joel Holdsworth <joel(a)airwebreathe.org.uk> Date: Mon Aug 7 11:30:31 2023 +0100 server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}. Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> --- dlls/ntdll/tests/file.c | 16 ++++++++-------- server/fd.c | 7 +++++++ 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index ae8956dedf4..a00a425582c 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -2226,9 +2226,9 @@ static void test_file_rename_information_ex(void) } todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); - todo_wine ok( res == STATUS_ACCESS_DENIED, "res expected STATUS_ACCESS_DENIED, got %lx\n", res ); + ok( res == STATUS_ACCESS_DENIED, "res expected STATUS_ACCESS_DENIED, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; - todo_wine ok( !fileDeleted, "file should exist\n" ); + ok( !fileDeleted, "file should exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -2259,10 +2259,10 @@ static void test_file_rename_information_ex(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fri, sizeof(FILE_RENAME_INFORMATION) + fri->FileNameLength, FileRenameInformationEx ); - ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); - ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); + todo_wine ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); + todo_wine ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; - ok( fileDeleted, "file should not exist\n" ); + todo_wine ok( fileDeleted, "file should not exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -3076,7 +3076,7 @@ static void test_file_link_information_ex(void) return; } - todo_wine ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); + ok( io.Status == 0xdeadbeef, "io.Status expected 0xdeadbeef, got %lx\n", io.Status ); todo_wine ok( res == STATUS_ACCESS_DENIED, "res expected STATUS_ACCESS_DENIED, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); @@ -3110,8 +3110,8 @@ static void test_file_link_information_ex(void) io.Status = 0xdeadbeef; res = pNtSetInformationFile( handle, &io, fli, sizeof(FILE_LINK_INFORMATION) + fli->FileNameLength, FileLinkInformationEx ); - ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); - ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); + todo_wine ok( io.Status == STATUS_SUCCESS, "io.Status expected STATUS_SUCCESS, got %lx\n", io.Status ); + todo_wine ok( res == STATUS_SUCCESS, "res expected STATUS_SUCCESS, got %lx\n", res ); fileDeleted = GetFileAttributesW( oldpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; ok( !fileDeleted, "file should exist\n" ); fileDeleted = GetFileAttributesW( newpath ) == INVALID_FILE_ATTRIBUTES && GetLastError() == ERROR_FILE_NOT_FOUND; diff --git a/server/fd.c b/server/fd.c index 2785bd54d63..00c0e4ac847 100644 --- a/server/fd.c +++ b/server/fd.c @@ -2600,6 +2600,13 @@ static void set_fd_name( struct fd *fd, struct fd *root, const char *nameptr, da goto failed; } + /* read-only files cannot be replaced */ + if (!(st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH))) + { + set_error( STATUS_ACCESS_DENIED ); + goto failed; + } + /* can't replace an opened file */ if ((inode = get_inode( st.st_dev, st.st_ino, -1 ))) {

1 0

← Newer
1
...
55
56
57
58
59
60
61
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2023