winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2024
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
590 discussions
Start a n
N
ew thread
Jinoh Kang : kernel32/tests: Test module refcounting with forwarded exports.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 4baada41a03ad577db3932334f48eda881a96f56 URL:
https://gitlab.winehq.org/wine/wine/-/commit/4baada41a03ad577db3932334f48ed…
Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Date: Mon Apr 15 23:50:22 2024 +0900 kernel32/tests: Test module refcounting with forwarded exports. --- dlls/kernel32/tests/loader.c | 433 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 433 insertions(+)
1
0
0
0
Rémi Bernon : win32u: Add all display device source modes at once.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 320442a48b3de75470bb545831ebc9e80adaaab3 URL:
https://gitlab.winehq.org/wine/wine/-/commit/320442a48b3de75470bb545831ebc9…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Apr 11 14:29:59 2024 +0200 win32u: Add all display device source modes at once. --- dlls/win32u/sysparams.c | 84 +++++++++++++++++------------------ dlls/wineandroid.drv/init.c | 8 +++- dlls/winemac.drv/display.c | 39 +--------------- dlls/winewayland.drv/display.c | 22 +++++---- dlls/winewayland.drv/wayland_output.c | 4 ++ dlls/winewayland.drv/waylanddrv.h | 1 + dlls/winex11.drv/display.c | 41 ++--------------- include/wine/gdi_driver.h | 2 +- 8 files changed, 71 insertions(+), 130 deletions(-)
1
0
0
0
Rémi Bernon : win32u: Keep the primary current mode in the device manager context.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: ee0aad5cf63e9827226637ea99064e895782a221 URL:
https://gitlab.winehq.org/wine/wine/-/commit/ee0aad5cf63e9827226637ea99064e…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Apr 11 15:06:47 2024 +0200 win32u: Keep the primary current mode in the device manager context. --- dlls/win32u/sysparams.c | 35 +++++++++++++---------------------- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 58ef0f2e9ac..01c3c4f13c6 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -924,9 +924,7 @@ struct device_manager_ctx HKEY source_key; /* for the virtual desktop settings */ BOOL is_primary; - UINT primary_bpp; - UINT primary_width; - UINT primary_height; + DEVMODEW primary; }; static void link_device( const char *instance, const char *class ) @@ -1828,13 +1826,7 @@ static void desktop_add_monitor( const struct gdi_monitor *monitor, void *param static void desktop_add_mode( const DEVMODEW *mode, BOOL current, void *param ) { struct device_manager_ctx *ctx = param; - - if (ctx->is_primary && current) - { - ctx->primary_bpp = mode->dmBitsPerPel; - ctx->primary_width = mode->dmPelsWidth; - ctx->primary_height = mode->dmPelsHeight; - } + if (ctx->is_primary && current) ctx->primary = *mode; } static const struct gdi_device_manager desktop_device_manager = @@ -1891,20 +1883,16 @@ static BOOL desktop_update_display_devices( BOOL force, struct device_manager_ct struct device_manager_ctx desktop_ctx = {0}; UINT screen_width, screen_height, max_width, max_height; unsigned int depths[] = {8, 16, 0}; - DEVMODEW current, mode = - { - .dmFields = DM_DISPLAYORIENTATION | DM_BITSPERPEL | DM_PELSWIDTH | DM_PELSHEIGHT | DM_DISPLAYFLAGS | DM_DISPLAYFREQUENCY, - .dmDisplayFrequency = 60, - }; + DEVMODEW current; UINT i, j; if (!force) return TRUE; /* in virtual desktop mode, read the device list from the user driver but expose virtual devices */ if (!update_display_devices( &desktop_device_manager, TRUE, &desktop_ctx )) return FALSE; - max_width = desktop_ctx.primary_width; - max_height = desktop_ctx.primary_height; - depths[ARRAY_SIZE(depths) - 1] = desktop_ctx.primary_bpp; + max_width = desktop_ctx.primary.dmPelsWidth; + max_height = desktop_ctx.primary.dmPelsHeight; + depths[ARRAY_SIZE(depths) - 1] = desktop_ctx.primary.dmBitsPerPel; if (!get_default_desktop_size( &screen_width, &screen_height )) { @@ -1916,9 +1904,7 @@ static BOOL desktop_update_display_devices( BOOL force, struct device_manager_ct add_source( "Default", source_flags, ctx ); if (!read_source_mode( ctx->source_key, ENUM_CURRENT_SETTINGS, ¤t )) { - current = mode; - current.dmFields |= DM_POSITION; - current.dmBitsPerPel = desktop_ctx.primary_bpp; + current = desktop_ctx.primary; current.dmPelsWidth = screen_width; current.dmPelsHeight = screen_height; } @@ -1931,7 +1917,12 @@ static BOOL desktop_update_display_devices( BOOL force, struct device_manager_ct for (i = 0; i < ARRAY_SIZE(depths); ++i) { - mode.dmBitsPerPel = depths[i]; + DEVMODEW mode = + { + .dmFields = DM_DISPLAYORIENTATION | DM_BITSPERPEL | DM_PELSWIDTH | DM_PELSHEIGHT | DM_DISPLAYFLAGS | DM_DISPLAYFREQUENCY, + .dmDisplayFrequency = 60, + .dmBitsPerPel = depths[i], + }; for (j = 0; j < ARRAY_SIZE(screen_sizes); ++j) {
1
0
0
0
Rémi Bernon : win32u: Remove fake source creation when adding display mode.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 72e429629355fea6118857ab27e15623f6a2708c URL:
https://gitlab.winehq.org/wine/wine/-/commit/72e429629355fea6118857ab27e156…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Apr 11 14:33:09 2024 +0200 win32u: Remove fake source creation when adding display mode. --- dlls/win32u/sysparams.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 916b84abbba..58ef0f2e9ac 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -1439,13 +1439,6 @@ static void add_mode( const DEVMODEW *mode, BOOL current, void *param ) struct device_manager_ctx *ctx = param; DEVMODEW nopos_mode; - if (!ctx->gpu.source_count) - { - static const DWORD source_flags = DISPLAY_DEVICE_ATTACHED_TO_DESKTOP | DISPLAY_DEVICE_PRIMARY_DEVICE | DISPLAY_DEVICE_VGA_COMPATIBLE; - TRACE( "adding default fake source\n" ); - add_source( "Default", source_flags, ctx ); - } - nopos_mode = *mode; nopos_mode.dmPosition.x = 0; nopos_mode.dmPosition.y = 0;
1
0
0
0
Rémi Bernon : win32u: Close device manager source key in write_source_to_registry.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: df1c70ee35de94b95bfe509bf8b89a9425238bef URL:
https://gitlab.winehq.org/wine/wine/-/commit/df1c70ee35de94b95bfe509bf8b89a…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Thu Apr 11 14:04:58 2024 +0200 win32u: Close device manager source key in write_source_to_registry. --- dlls/win32u/sysparams.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index b0b9a5cc907..916b84abbba 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -1280,6 +1280,7 @@ static BOOL write_source_to_registry( const struct source *source, HKEY *source_ NtClose( hkey ); /* Following information is Wine specific, it doesn't really exist on Windows. */ + if (*source_key) NtClose( *source_key ); *source_key = reg_create_ascii_key( NULL, source->path, REG_OPTION_VOLATILE, NULL ); set_reg_ascii_value( *source_key, "GPUID", gpu->path ); set_reg_value( *source_key, state_flagsW, REG_DWORD, &source->state_flags, @@ -1302,12 +1303,6 @@ static void add_source( const char *name, UINT state_flags, void *param ) TRACE( "name %s, state_flags %#x\n", name, state_flags ); - if (ctx->source_key) - { - NtClose( ctx->source_key ); - ctx->source_key = NULL; - } - memset( &ctx->source, 0, sizeof(ctx->source) ); ctx->source.gpu = &ctx->gpu; ctx->source.id = ctx->source_count;
1
0
0
0
Alexandre Julliard : widl: Don't use a structure for NdrClientCall2 parameters on ARM.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 2f532567ffa5d400809450543828481b885fcab3 URL:
https://gitlab.winehq.org/wine/wine/-/commit/2f532567ffa5d40080945054382848…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 15 12:57:20 2024 +0200 widl: Don't use a structure for NdrClientCall2 parameters on ARM. --- tools/widl/typegen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 7284e0531bc..063080bd9de 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -5063,7 +5063,7 @@ void write_client_call_routine( FILE *file, const type_t *iface, const var_t *fu int len, needs_params = 0; /* we need a param structure if we have more than one arg */ - if (pointer_size == 4 && args) needs_params = is_object( iface ) || list_count( args ) > 1; + if (target.cpu == CPU_i386 && args) needs_params = is_object( iface ) || list_count( args ) > 1; print_file( file, 0, "{\n"); if (needs_params) @@ -5086,7 +5086,7 @@ void write_client_call_routine( FILE *file, const type_t *iface, const var_t *fu { fprintf( file, ",\n%*s&__params", len, "" ); } - else if (pointer_size == 8) + else if (target.cpu != CPU_i386) { if (is_object( iface )) fprintf( file, ",\n%*sThis", len, "" ); if (args) @@ -5107,7 +5107,7 @@ void write_client_call_routine( FILE *file, const type_t *iface, const var_t *fu { print_file( file, 1, "return (" ); write_type_decl_left(file, rettype); - fprintf( file, ")%s;\n", pointer_size == 8 ? "_RetVal.Simple" : "*(LONG_PTR *)&_RetVal" ); + fprintf( file, ")%s;\n", target.cpu != CPU_i386 ? "_RetVal.Simple" : "*(LONG_PTR *)&_RetVal" ); } print_file( file, 0, "}\n\n"); }
1
0
0
0
Alexandre Julliard : widl: Correctly align stack parameters on ARM.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 84509acb166387e5877066a39a56d4be54cdd9e0 URL:
https://gitlab.winehq.org/wine/wine/-/commit/84509acb166387e5877066a39a56d4…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 15 16:15:08 2024 +0200 widl: Correctly align stack parameters on ARM. --- tools/widl/typegen.c | 61 ++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 45 insertions(+), 16 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 86d4354573e..7284e0531bc 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -417,20 +417,35 @@ static int get_padding(const var_list_t *fields) return ROUNDING(offset, salign); } -static unsigned int get_stack_size( const var_t *var, int *by_value ) +static unsigned int get_stack_size( const var_t *var, unsigned int *stack_align, int *by_value ) { - unsigned int stack_size; + unsigned int stack_size, align = 0; int by_val; switch (typegen_detect_type( var->declspec.type, var->attrs, TDT_ALL_TYPES )) { case TGT_BASIC: + if (target.cpu == CPU_ARM) + { + switch (type_basic_get_type( var->declspec.type )) + { + case TYPE_BASIC_FLOAT: + case TYPE_BASIC_DOUBLE: + case TYPE_BASIC_INT64: + case TYPE_BASIC_HYPER: + align = 8; + break; + default: + break; + } + } + /* fall through */ case TGT_ENUM: case TGT_RANGE: case TGT_STRUCT: case TGT_UNION: case TGT_USER_TYPE: - stack_size = type_memsize( var->declspec.type ); + stack_size = type_memsize_and_alignment( var->declspec.type, &align ); switch (target.cpu) { case CPU_x86_64: @@ -439,7 +454,11 @@ static unsigned int get_stack_size( const var_t *var, int *by_value ) case CPU_ARM64: by_val = (stack_size <= 2 * pointer_size); break; + case CPU_ARM: + by_val = 1; + break; default: + align = pointer_size; by_val = 1; break; } @@ -448,9 +467,12 @@ static unsigned int get_stack_size( const var_t *var, int *by_value ) by_val = 0; break; } - if (!by_val) stack_size = pointer_size; + if (align < pointer_size) align = pointer_size; + if (!by_val) stack_size = align = pointer_size; + if (by_value) *by_value = by_val; - return ROUND_SIZE( stack_size, pointer_size ); + if (stack_align) *stack_align = align; + return ROUND_SIZE( stack_size, align ); } static unsigned char get_contexthandle_flags( const type_t *iface, const attr_list_t *attrs, @@ -1035,7 +1057,8 @@ int decl_indirect(const type_t *t) } static unsigned char get_parameter_fc( const var_t *var, int is_return, unsigned short *flags, - unsigned int *stack_size, unsigned int *typestring_offset ) + unsigned int *stack_size, unsigned int *stack_align, + unsigned int *typestring_offset ) { unsigned int alignment, server_size = 0, buffer_size = 0; unsigned char fc = 0; @@ -1047,7 +1070,7 @@ static unsigned char get_parameter_fc( const var_t *var, int is_return, unsigned else if (!is_in && !is_out) is_in = TRUE; *flags = 0; - *stack_size = get_stack_size( var, &is_byval ); + *stack_size = get_stack_size( var, stack_align, &is_byval ); *typestring_offset = var->typestring_offset; if (is_in) *flags |= IsIn; @@ -1203,11 +1226,11 @@ static unsigned char get_func_oi2_flags( const var_t *func ) var_t *retval = type_function_get_retval( func->declspec.type ); unsigned char oi2_flags = 0x40; /* HasExtensions */ unsigned short flags; - unsigned int stack_size, typestring_offset; + unsigned int stack_size, stack_align, typestring_offset; if (args) LIST_FOR_EACH_ENTRY( var, args, const var_t, entry ) { - get_parameter_fc( var, 0, &flags, &stack_size, &typestring_offset ); + get_parameter_fc( var, 0, &flags, &stack_size, &stack_align, &typestring_offset ); if (flags & MustSize) { if (flags & IsIn) oi2_flags |= 0x02; /* ClientMustSize */ @@ -1218,7 +1241,7 @@ static unsigned char get_func_oi2_flags( const var_t *func ) if (!is_void( retval->declspec.type )) { oi2_flags |= 0x04; /* HasRet */ - get_parameter_fc( retval, 1, &flags, &stack_size, &typestring_offset ); + get_parameter_fc( retval, 1, &flags, &stack_size, &stack_align, &typestring_offset ); if (flags & MustSize) oi2_flags |= 0x01; /* ServerMustSize */ } return oi2_flags; @@ -1228,10 +1251,11 @@ static unsigned int write_new_procformatstring_type(FILE *file, int indent, cons int is_return, unsigned int *stack_offset) { char buffer[128]; - unsigned int stack_size, typestring_offset; + unsigned int stack_size, stack_align, typestring_offset; unsigned short flags; - unsigned char fc = get_parameter_fc( var, is_return, &flags, &stack_size, &typestring_offset ); + unsigned char fc = get_parameter_fc( var, is_return, &flags, &stack_size, &stack_align, &typestring_offset ); + *stack_offset = ROUND_SIZE( *stack_offset, stack_align ); strcpy( buffer, "/* flags:" ); if (flags & MustSize) strcat( buffer, " must size," ); if (flags & MustFree) strcat( buffer, " must free," ); @@ -1255,7 +1279,7 @@ static unsigned int write_new_procformatstring_type(FILE *file, int indent, cons else print_file( file, indent, "NdrFcShort(0x%x), /* type offset = %u */\n", typestring_offset, typestring_offset ); - *stack_offset += max( stack_size, pointer_size ); + *stack_offset += stack_size; return 6; } @@ -1313,7 +1337,7 @@ static unsigned int write_old_procformatstring_type(FILE *file, int indent, cons else print_file(file, indent, "0x4d, /* FC_IN_PARAM */\n"); - size = get_stack_size( var, NULL ); + size = get_stack_size( var, NULL, NULL ); print_file(file, indent, "0x%02x,\n", size / pointer_size ); print_file(file, indent, "NdrFcShort(0x%x), /* type offset = %u */\n", offset, offset); size = 4; /* includes param type prefix */ @@ -1365,6 +1389,7 @@ static void write_proc_func_interp( FILE *file, int indent, const type_t *iface, unsigned int nb_args = 0; unsigned int stack_size = 0; unsigned int stack_offset = 0; + unsigned int stack_align; unsigned short param_num = 0; unsigned short handle_stack_offset = 0; unsigned short handle_param_num = 0; @@ -1385,7 +1410,9 @@ static void write_proc_func_interp( FILE *file, int indent, const type_t *iface, handle_stack_offset = stack_size; handle_param_num = param_num; } - stack_size += get_stack_size( var, NULL ); + size = get_stack_size( var, &stack_align, NULL ); + stack_size = ROUND_SIZE( stack_size, stack_align ); + stack_size += size; param_num++; nb_args++; } @@ -1773,13 +1800,15 @@ static unsigned int write_conf_or_var_desc(FILE *file, const type_t *cont_type, if (is_object( iface )) offset += pointer_size; if (args) LIST_FOR_EACH_ENTRY( var, args, const var_t, entry ) { + unsigned int align, size = get_stack_size( var, &align, NULL ); + offset = ROUND_SIZE( offset, align ); if (var->name && !strcmp(var->name, subexpr->u.sval)) { expr_loc.v = var; correlation_variable = var->declspec.type; break; } - offset += get_stack_size( var, NULL ); + offset += size; if (var == current_arg) robust_flags &= ~RobustEarly; } }
1
0
0
0
Alexandre Julliard : widl: Only pass power of 2 structures by value on x86-64.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 377f9f8de923cc79144bcd2d02ad3959ce0c7ee4 URL:
https://gitlab.winehq.org/wine/wine/-/commit/377f9f8de923cc79144bcd2d02ad39…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 15 16:15:33 2024 +0200 widl: Only pass power of 2 structures by value on x86-64. --- tools/widl/typegen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 52874b717fe..86d4354573e 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -434,7 +434,7 @@ static unsigned int get_stack_size( const var_t *var, int *by_value ) switch (target.cpu) { case CPU_x86_64: - by_val = (stack_size <= pointer_size); + by_val = (stack_size == 1 || stack_size == 2 || stack_size == 4 || stack_size == 8); break; case CPU_ARM64: by_val = (stack_size <= 2 * pointer_size);
1
0
0
0
Alexandre Julliard : widl: Pass 16-byte structures by value on ARM64.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: 9cda4233df1e970251d0f5595f77b1bc95d6763f URL:
https://gitlab.winehq.org/wine/wine/-/commit/9cda4233df1e970251d0f5595f77b1…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Apr 15 12:04:56 2024 +0200 widl: Pass 16-byte structures by value on ARM64. --- tools/widl/typegen.c | 13 ++++++++++++- tools/widl/widl.c | 2 +- tools/widl/widl.h | 1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 917f4b40a21..52874b717fe 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -431,7 +431,18 @@ static unsigned int get_stack_size( const var_t *var, int *by_value ) case TGT_UNION: case TGT_USER_TYPE: stack_size = type_memsize( var->declspec.type ); - by_val = (pointer_size < 8 || stack_size <= pointer_size); /* FIXME: should be platform-specific */ + switch (target.cpu) + { + case CPU_x86_64: + by_val = (stack_size <= pointer_size); + break; + case CPU_ARM64: + by_val = (stack_size <= 2 * pointer_size); + break; + default: + by_val = 1; + break; + } break; default: by_val = 0; diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 6d7dd46c33e..30907eca69b 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -89,7 +89,7 @@ static const char usage[] = static const char version_string[] = "Wine IDL Compiler version " PACKAGE_VERSION "\n" "Copyright 2002 Ove Kaaven\n"; -static struct target target; +struct target target = { 0 }; int debuglevel = DEBUGLEVEL_NONE; int parser_debug, yy_flex_debug; diff --git a/tools/widl/widl.h b/tools/widl/widl.h index c5ccc140b36..31bb2c83694 100644 --- a/tools/widl/widl.h +++ b/tools/widl/widl.h @@ -71,6 +71,7 @@ extern const char *prefix_client; extern const char *prefix_server; extern unsigned int packing; extern unsigned int pointer_size; +extern struct target target; extern time_t now; extern int open_typelib( const char *name );
1
0
0
0
Alexandre Julliard : winhttp/tests: Fix some compiler warnings with non-PE build.
by Alexandre Julliard
15 Apr '24
15 Apr '24
Module: wine Branch: master Commit: cc88d9175b9df619053facb017b19306175402dc URL:
https://gitlab.winehq.org/wine/wine/-/commit/cc88d9175b9df619053facb017b193…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Apr 13 15:50:24 2024 +0200 winhttp/tests: Fix some compiler warnings with non-PE build. --- dlls/winhttp/tests/winhttp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index ee01fd5ec72..5810a516c68 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -5944,7 +5944,7 @@ static void test_connection_cache(int port) req = WinHttpOpenRequest(con, L"GET", L"/cached", NULL, NULL, NULL, 0); ok(req != NULL, "failed to open a request %lu\n", GetLastError()); - ret = WinHttpSendRequest(req, L"Connection: close", ~0ul, NULL, 0, 0, 0); + ret = WinHttpSendRequest(req, L"Connection: close", ~0u, NULL, 0, 0, 0); ok(ret, "failed to send request %lu\n", GetLastError()); ret = WinHttpReceiveResponse(req, NULL); ok(ret, "failed to receive response %lu\n", GetLastError()); @@ -5959,7 +5959,7 @@ static void test_connection_cache(int port) req = WinHttpOpenRequest(con, L"GET", L"/notcached", NULL, NULL, NULL, 0); ok(req != NULL, "failed to open a request %lu\n", GetLastError()); - ret = WinHttpSendRequest(req, L"Connection: close", ~0ul, NULL, 0, 0, 0); + ret = WinHttpSendRequest(req, L"Connection: close", ~0u, NULL, 0, 0, 0); ok(ret, "failed to send request %lu\n", GetLastError()); ret = WinHttpReceiveResponse(req, NULL); ok(ret, "failed to receive response %lu\n", GetLastError());
1
0
0
0
← Newer
1
...
33
34
35
36
37
38
39
...
59
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
Results per page:
10
25
50
100
200