wine-commits May 2024

wine-commits@winehq.org

1 participants
705 discussions

Eric Pouech : winedump: Dump Memory64List streams in minidumps.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 95e6302e82eefab31355a6d2f2febf6ecdde9e96 URL: https://gitlab.winehq.org/wine/wine/-/commit/95e6302e82eefab31355a6d2f2febf… Author: Eric Pouech <epouech(a)codeweavers.com> Date: Fri May 10 16:18:04 2024 +0200 winedump: Dump Memory64List streams in minidumps. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- tools/winedump/minidump.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/tools/winedump/minidump.c b/tools/winedump/minidump.c index df7885bc86b..80057a21829 100644 --- a/tools/winedump/minidump.c +++ b/tools/winedump/minidump.c @@ -232,6 +232,25 @@ void mdmp_dump(void) } } break; + case Memory64ListStream: + if (globals_dump_sect("memory")) + { + const MINIDUMP_MEMORY64_LIST *mml = stream; + const MINIDUMP_MEMORY_DESCRIPTOR64 *mmd = mml->MemoryRanges; + ULONG64 i64, base_rva; + printf("Stream [%u]: Memory64 Ranges:\n", idx); + printf(" NumberOfMemoryRanges: %s\n", get_uint64_str(mml->NumberOfMemoryRanges)); + base_rva = mml->BaseRva; + for (i64 = 0; i64 < mml->NumberOfMemoryRanges; i64++, mmd++) + { + printf(" Memory Range #%s:\n", get_uint64_str(i64)); + printf(" Range: %s +%s\n", get_hexint64_str(mmd->StartOfMemoryRange), get_hexint64_str(mmd->DataSize)); + if (globals_dump_sect("content")) + dump_data(PRD(base_rva, mmd->DataSize), mmd->DataSize, " "); + base_rva += mmd->DataSize; + } + } + break; case SystemInfoStream: if (globals_dump_sect("info")) {

1 0

Eric Pouech : winedump: Don't dump twice.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: ec61ad8b154b9d9970cdfb428dafb3e0cb6c192c URL: https://gitlab.winehq.org/wine/wine/-/commit/ec61ad8b154b9d9970cdfb428dafb3… Author: Eric Pouech <epouech(a)codeweavers.com> Date: Tue Apr 16 09:23:08 2024 +0200 winedump: Don't dump twice. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- tools/winedump/minidump.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/winedump/minidump.c b/tools/winedump/minidump.c index 0a5ee15412b..df7885bc86b 100644 --- a/tools/winedump/minidump.c +++ b/tools/winedump/minidump.c @@ -226,7 +226,6 @@ void mdmp_dump(void) for (i = 0; i < mml->NumberOfMemoryRanges; i++, mmd++) { printf(" Memory Range #%d:\n", i); - dump_mdmp_data(&mmd->Memory, " "); printf(" Range: %s +%#x\n", get_hexint64_str(mmd->StartOfMemoryRange), mmd->Memory.DataSize); if (globals_dump_sect("content")) dump_mdmp_data(&mmd->Memory, " ");

1 0

Eric Pouech : winedump: Dump correct handle information for minidump.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 0327b00d10f966da0a659cc57380d326a9ff576c URL: https://gitlab.winehq.org/wine/wine/-/commit/0327b00d10f966da0a659cc57380d3… Author: Eric Pouech <epouech(a)codeweavers.com> Date: Sun Apr 14 09:44:15 2024 +0200 winedump: Dump correct handle information for minidump. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- include/minidumpapiset.h | 7 +++++++ tools/winedump/minidump.c | 20 +++++++++++++++++++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/include/minidumpapiset.h b/include/minidumpapiset.h index 2d13c6f6a67..c3cd43310ae 100644 --- a/include/minidumpapiset.h +++ b/include/minidumpapiset.h @@ -392,6 +392,13 @@ typedef struct _MINIDUMP_HANDLE_DESCRIPTOR ULONG32 PointerCount; } MINIDUMP_HANDLE_DESCRIPTOR, *PMINIDUMP_HANDLE_DESCRIPTOR; +typedef struct _MINIDUMP_HANDLE_OBJECT_INFORMATION +{ + RVA NextInfoRva; + ULONG32 InfoType; + ULONG32 SizeOfInfo; +} MINIDUMP_HANDLE_OBJECT_INFORMATION; + typedef struct _MINIDUMP_HANDLE_DESCRIPTOR_2 { ULONG64 Handle; diff --git a/tools/winedump/minidump.c b/tools/winedump/minidump.c index 80900e3eb33..0a5ee15412b 100644 --- a/tools/winedump/minidump.c +++ b/tools/winedump/minidump.c @@ -499,8 +499,26 @@ void mdmp_dump(void) if (mhd->SizeOfDescriptor >= sizeof(MINIDUMP_HANDLE_DESCRIPTOR_2)) { - printf(" ObjectInfo: %s\n", get_mdmp_str(hd->ObjectInfoRva)); + MINIDUMP_HANDLE_OBJECT_INFORMATION *obj_info; + unsigned link_count = 0; + + printf(" ObjectInfo: %#x\n", (UINT)hd->ObjectInfoRva); printf(" Reserved0: %#x\n", hd->Reserved0); + + if (hd->ObjectInfoRva) + { + for (obj_info = (void*)PRD(hd->ObjectInfoRva, sizeof(*obj_info)); + obj_info; + obj_info = obj_info->NextInfoRva ? (void*)PRD(obj_info->NextInfoRva, sizeof(*obj_info)) : NULL) + { + printf(" Information[%u]\n", link_count++); + printf(" NextInfoRva: %#x\n", (UINT)obj_info->NextInfoRva); + printf(" InfoType: %u\n", obj_info->InfoType); + printf(" SizeOfInfo: %u\n", obj_info->SizeOfInfo); + if (globals_dump_sect("content")) + dump_data((const BYTE*)(obj_info + 1), obj_info->SizeOfInfo, " "); + } + } } ptr += mhd->SizeOfDescriptor;

1 0

Jacek Caban : mshtml: Move IDispatchEx forwarding implementation to outer window object.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 5ef4bb1d48e7313466135946ec8399bcd4fec995 URL: https://gitlab.winehq.org/wine/wine/-/commit/5ef4bb1d48e7313466135946ec8399… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 30 02:33:18 2024 +0200 mshtml: Move IDispatchEx forwarding implementation to outer window object. --- dlls/mshtml/htmldoc.c | 2 +- dlls/mshtml/htmlframe.c | 4 +-- dlls/mshtml/htmlwindow.c | 80 +++++++++++++++++++++----------------------- dlls/mshtml/mshtml_private.h | 2 +- 4 files changed, 42 insertions(+), 46 deletions(-)

1 0

Jacek Caban : mshtml: Use macro for window object IDispatch functions implementation.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: ec9ecc51eba7591586c11c74b4bc1a0cfba18dc9 URL: https://gitlab.winehq.org/wine/wine/-/commit/ec9ecc51eba7591586c11c74b4bc1a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 30 02:19:39 2024 +0200 mshtml: Use macro for window object IDispatch functions implementation. --- dlls/mshtml/htmlwindow.c | 392 +++---------------------------------------- dlls/mshtml/mshtml_private.h | 29 ++-- 2 files changed, 36 insertions(+), 385 deletions(-)

1 0

Jacek Caban : mshtml: Use DispatchEx vtbl for all window properties.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: b133812b63db6e39978d232e29ec81b64521bd2a URL: https://gitlab.winehq.org/wine/wine/-/commit/b133812b63db6e39978d232e29ec81… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu May 30 00:08:34 2024 +0200 mshtml: Use DispatchEx vtbl for all window properties. --- dlls/mshtml/dispex.c | 12 ++++++++++-- dlls/mshtml/htmlwindow.c | 18 +++++++++--------- dlls/mshtml/mshtml_private.h | 3 +++ 3 files changed, 22 insertions(+), 11 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 8517ccac554..152d2d4cb66 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -994,6 +994,13 @@ static HRESULT get_builtin_func(dispex_data_t *data, DISPID id, func_info_t **re static HRESULT get_builtin_id(DispatchEx *This, BSTR name, DWORD grfdex, DISPID *ret) { int min, max, n, c; + HRESULT hres; + + if(This->info->desc->vtbl->lookup_dispid) { + hres = This->info->desc->vtbl->lookup_dispid(This, name, grfdex, ret); + if(hres != DISP_E_UNKNOWNNAME) + return hres; + } min = 0; max = This->info->func_cnt-1; @@ -1017,8 +1024,6 @@ static HRESULT get_builtin_id(DispatchEx *This, BSTR name, DWORD grfdex, DISPID } if(This->info->desc->vtbl->get_dispid) { - HRESULT hres; - hres = This->info->desc->vtbl->get_dispid(This, name, grfdex, ret); if(hres != DISP_E_UNKNOWNNAME) return hres; @@ -1800,6 +1805,9 @@ static HRESULT WINAPI DispatchEx_DeleteMemberByName(IDispatchEx *iface, BSTR nam TRACE("%s (%p)->(%s %lx)\n", This->info->desc->name, This, debugstr_w(name), grfdex); + if(dispex_compat_mode(This) < COMPAT_MODE_IE8 && !This->info->desc->vtbl->delete) + return E_NOTIMPL; + hres = IDispatchEx_GetDispID(&This->IDispatchEx_iface, name, grfdex & ~fdexNameEnsure, &id); if(FAILED(hres)) { compat_mode_t compat_mode = dispex_compat_mode(This); diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index be07072600c..0230cca86e5 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -3699,16 +3699,8 @@ HRESULT search_window_props(HTMLInnerWindow *This, BSTR bstrName, DWORD grfdex, static HRESULT WINAPI WindowDispEx_GetDispID(IDispatchEx *iface, BSTR bstrName, DWORD grfdex, DISPID *pid) { HTMLWindow *This = impl_from_IDispatchEx(iface); - HTMLInnerWindow *window = This->inner_window; - HRESULT hres; - - TRACE("(%p)->(%s %lx %p)\n", This, debugstr_w(bstrName), grfdex, pid); - - hres = search_window_props(window, bstrName, grfdex, pid); - if(hres != DISP_E_UNKNOWNNAME) - return hres; - return IDispatchEx_GetDispID(&window->base.inner_window->event_target.dispex.IDispatchEx_iface, bstrName, grfdex, pid); + return IDispatchEx_GetDispID(&This->inner_window->event_target.dispex.IDispatchEx_iface, bstrName, grfdex, pid); } static HRESULT WINAPI WindowDispEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lcid, WORD wFlags, DISPPARAMS *pdp, @@ -4069,6 +4061,13 @@ static HRESULT HTMLWindow_get_name(DispatchEx *dispex, DISPID id, BSTR *name) return (*name = SysAllocString(This->global_props[idx].name)) ? S_OK : E_OUTOFMEMORY; } +static HRESULT HTMLWindow_lookup_dispid(DispatchEx *dispex, BSTR name, DWORD grfdex, DISPID *dispid) +{ + HTMLInnerWindow *This = impl_from_DispatchEx(dispex); + + return search_window_props(This, name, grfdex, dispid); +} + static HRESULT HTMLWindow_find_dispid(DispatchEx *dispex, BSTR name, DWORD grfdex, DISPID *dispid) { HTMLInnerWindow *This = impl_from_DispatchEx(dispex); @@ -4401,6 +4400,7 @@ static const event_target_vtbl_t HTMLWindow_event_target_vtbl = { .unlink = HTMLWindow_unlink, .last_release = HTMLWindow_last_release, .get_name = HTMLWindow_get_name, + .lookup_dispid = HTMLWindow_lookup_dispid, .find_dispid = HTMLWindow_find_dispid, .invoke = HTMLWindow_invoke, .next_dispid = HTMLWindow_next_dispid, diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 52d53ca9e00..98a417726f2 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -374,6 +374,9 @@ typedef struct { /* Similar to get_dispid, but called only when a dynamic property can't be found */ HRESULT (*find_dispid)(DispatchEx*,BSTR,DWORD,DISPID*); + /* Similar to get_dispid, but called before any other lookup */ + HRESULT (*lookup_dispid)(DispatchEx*,BSTR,DWORD,DISPID*); + /* These are called when the object implements GetMemberName, InvokeEx, DeleteMemberByDispID and GetNextDispID for custom props */ HRESULT (*get_name)(DispatchEx*,DISPID,BSTR*); HRESULT (*invoke)(DispatchEx*,DISPID,LCID,WORD,DISPPARAMS*,VARIANT*,EXCEPINFO*,IServiceProvider*);

1 0

Jacek Caban : mshtml: Use DispatchEx vtbl for elements as window property lookups.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 3108a405e3d0e7c88ce6552ae7552ae1c91eb959 URL: https://gitlab.winehq.org/wine/wine/-/commit/3108a405e3d0e7c88ce6552ae7552a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 29 23:45:53 2024 +0200 mshtml: Use DispatchEx vtbl for elements as window property lookups. --- dlls/mshtml/dispex.c | 5 ++++ dlls/mshtml/htmlwindow.c | 66 +++++++++++++++++++++++--------------------- dlls/mshtml/mshtml_private.h | 3 ++ 3 files changed, 43 insertions(+), 31 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 3c5f00e35b7..8517ccac554 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -1691,6 +1691,11 @@ static HRESULT WINAPI DispatchEx_GetDispID(IDispatchEx *iface, BSTR bstrName, DW hres = get_dynamic_prop(This, bstrName, grfdex & ~fdexNameEnsure, &dprop); if(FAILED(hres)) { + if(This->info->desc->vtbl->find_dispid) { + hres = This->info->desc->vtbl->find_dispid(This, bstrName, grfdex, pid); + if(SUCCEEDED(hres)) + return hres; + } if(grfdex & fdexNameEnsure) hres = alloc_dynamic_prop(This, bstrName, dprop, &dprop); if(FAILED(hres)) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 59a0f6d023d..be07072600c 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -3700,9 +3700,6 @@ static HRESULT WINAPI WindowDispEx_GetDispID(IDispatchEx *iface, BSTR bstrName, { HTMLWindow *This = impl_from_IDispatchEx(iface); HTMLInnerWindow *window = This->inner_window; - HTMLOuterWindow *frame; - global_prop_t *prop; - IHTMLElement *elem; HRESULT hres; TRACE("(%p)->(%s %lx %p)\n", This, debugstr_w(bstrName), grfdex, pid); @@ -3711,34 +3708,7 @@ static HRESULT WINAPI WindowDispEx_GetDispID(IDispatchEx *iface, BSTR bstrName, if(hres != DISP_E_UNKNOWNNAME) return hres; - hres = IDispatchEx_GetDispID(&window->base.inner_window->event_target.dispex.IDispatchEx_iface, bstrName, grfdex, pid); - if(hres != DISP_E_UNKNOWNNAME) - return hres; - - hres = get_frame_by_name(This->outer_window, bstrName, FALSE, &frame); - if(SUCCEEDED(hres) && frame) { - prop = alloc_global_prop(window, GLOBAL_FRAMEVAR, bstrName); - if(!prop) - return E_OUTOFMEMORY; - - *pid = prop_to_dispid(window, prop); - return S_OK; - } - - hres = IHTMLDocument3_getElementById(&window->base.inner_window->doc->IHTMLDocument3_iface, - bstrName, &elem); - if(SUCCEEDED(hres) && elem) { - IHTMLElement_Release(elem); - - prop = alloc_global_prop(window, GLOBAL_ELEMENTVAR, bstrName); - if(!prop) - return E_OUTOFMEMORY; - - *pid = prop_to_dispid(window, prop); - return S_OK; - } - - return DISP_E_UNKNOWNNAME; + return IDispatchEx_GetDispID(&window->base.inner_window->event_target.dispex.IDispatchEx_iface, bstrName, grfdex, pid); } static HRESULT WINAPI WindowDispEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lcid, WORD wFlags, DISPPARAMS *pdp, @@ -4099,6 +4069,39 @@ static HRESULT HTMLWindow_get_name(DispatchEx *dispex, DISPID id, BSTR *name) return (*name = SysAllocString(This->global_props[idx].name)) ? S_OK : E_OUTOFMEMORY; } +static HRESULT HTMLWindow_find_dispid(DispatchEx *dispex, BSTR name, DWORD grfdex, DISPID *dispid) +{ + HTMLInnerWindow *This = impl_from_DispatchEx(dispex); + HTMLOuterWindow *frame; + global_prop_t *prop; + IHTMLElement *elem; + HRESULT hres; + + hres = get_frame_by_name(This->base.outer_window, name, FALSE, &frame); + if(SUCCEEDED(hres) && frame) { + prop = alloc_global_prop(This, GLOBAL_FRAMEVAR, name); + if(!prop) + return E_OUTOFMEMORY; + + *dispid = prop_to_dispid(This, prop); + return S_OK; + } + + hres = IHTMLDocument3_getElementById(&This->doc->IHTMLDocument3_iface, name, &elem); + if(SUCCEEDED(hres) && elem) { + IHTMLElement_Release(elem); + + prop = alloc_global_prop(This, GLOBAL_ELEMENTVAR, name); + if(!prop) + return E_OUTOFMEMORY; + + *dispid = prop_to_dispid(This, prop); + return S_OK; + } + + return DISP_E_UNKNOWNNAME; +} + static HRESULT HTMLWindow_invoke(DispatchEx *dispex, DISPID id, LCID lcid, WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) { @@ -4398,6 +4401,7 @@ static const event_target_vtbl_t HTMLWindow_event_target_vtbl = { .unlink = HTMLWindow_unlink, .last_release = HTMLWindow_last_release, .get_name = HTMLWindow_get_name, + .find_dispid = HTMLWindow_find_dispid, .invoke = HTMLWindow_invoke, .next_dispid = HTMLWindow_next_dispid, .get_compat_mode = HTMLWindow_get_compat_mode, diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 1d4f005ba11..52d53ca9e00 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -371,6 +371,9 @@ typedef struct { /* Used when the object has custom props, and this returns DISPIDs for them */ HRESULT (*get_dispid)(DispatchEx*,BSTR,DWORD,DISPID*); + /* Similar to get_dispid, but called only when a dynamic property can't be found */ + HRESULT (*find_dispid)(DispatchEx*,BSTR,DWORD,DISPID*); + /* These are called when the object implements GetMemberName, InvokeEx, DeleteMemberByDispID and GetNextDispID for custom props */ HRESULT (*get_name)(DispatchEx*,DISPID,BSTR*); HRESULT (*invoke)(DispatchEx*,DISPID,LCID,WORD,DISPPARAMS*,VARIANT*,EXCEPINFO*,IServiceProvider*);

1 0

Jacek Caban : mshtml: Factor out alloc_dynamic_prop.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 16271ac208ea82cde1777a72d412fad407906309 URL: https://gitlab.winehq.org/wine/wine/-/commit/16271ac208ea82cde1777a72d412fa… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 29 23:33:24 2024 +0200 mshtml: Factor out alloc_dynamic_prop. --- dlls/mshtml/dispex.c | 70 ++++++++++++++++++++++++++++++++-------------------- 1 file changed, 43 insertions(+), 27 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 07c26e2e762..3c5f00e35b7 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -646,33 +646,16 @@ static inline dispex_dynamic_data_t *get_dynamic_data(DispatchEx *This) return This->dynamic_data; } -static HRESULT get_dynamic_prop(DispatchEx *This, const WCHAR *name, DWORD flags, dynamic_prop_t **ret) +static HRESULT alloc_dynamic_prop(DispatchEx *This, const WCHAR *name, dynamic_prop_t *prop, dynamic_prop_t **ret) { - const BOOL alloc = flags & fdexNameEnsure; - dispex_dynamic_data_t *data; - dynamic_prop_t *prop; - - data = get_dynamic_data(This); - if(!data) - return E_OUTOFMEMORY; + dispex_dynamic_data_t *data = This->dynamic_data; - for(prop = data->props; prop < data->props+data->prop_cnt; prop++) { - if(flags & fdexNameCaseInsensitive ? !wcsicmp(prop->name, name) : !wcscmp(prop->name, name)) { - if(prop->flags & DYNPROP_DELETED) { - if(!alloc) - return DISP_E_UNKNOWNNAME; - prop->flags &= ~DYNPROP_DELETED; - } - *ret = prop; - return S_OK; - } + if(prop) { + prop->flags &= ~DYNPROP_DELETED; + *ret = prop; + return S_OK; } - if(!alloc) - return DISP_E_UNKNOWNNAME; - - TRACE("creating dynamic prop %s\n", debugstr_w(name)); - if(!data->buf_size) { data->props = malloc(sizeof(dynamic_prop_t) * 4); if(!data->props) @@ -702,6 +685,35 @@ static HRESULT get_dynamic_prop(DispatchEx *This, const WCHAR *name, DWORD flags return S_OK; } +static HRESULT get_dynamic_prop(DispatchEx *This, const WCHAR *name, DWORD flags, dynamic_prop_t **ret) +{ + const BOOL alloc = flags & fdexNameEnsure; + dispex_dynamic_data_t *data; + dynamic_prop_t *prop; + + data = get_dynamic_data(This); + if(!data) + return E_OUTOFMEMORY; + + for(prop = data->props; prop < data->props+data->prop_cnt; prop++) { + if(flags & fdexNameCaseInsensitive ? !wcsicmp(prop->name, name) : !wcscmp(prop->name, name)) { + *ret = prop; + if(prop->flags & DYNPROP_DELETED) { + if(!alloc) + return DISP_E_UNKNOWNNAME; + prop->flags &= ~DYNPROP_DELETED; + } + return S_OK; + } + } + + if(!alloc) + return DISP_E_UNKNOWNNAME; + + TRACE("creating dynamic prop %s\n", debugstr_w(name)); + return alloc_dynamic_prop(This, name, NULL, ret); +} + HRESULT dispex_get_dprop_ref(DispatchEx *This, const WCHAR *name, BOOL alloc, VARIANT **ret) { dynamic_prop_t *prop; @@ -1662,7 +1674,7 @@ static HRESULT WINAPI DispatchEx_Invoke(IDispatchEx *iface, DISPID dispIdMember, static HRESULT WINAPI DispatchEx_GetDispID(IDispatchEx *iface, BSTR bstrName, DWORD grfdex, DISPID *pid) { DispatchEx *This = impl_from_IDispatchEx(iface); - dynamic_prop_t *dprop; + dynamic_prop_t *dprop = NULL; HRESULT hres; TRACE("%s (%p)->(%s %lx %p)\n", This->info->desc->name, This, debugstr_w(bstrName), grfdex, pid); @@ -1677,9 +1689,13 @@ static HRESULT WINAPI DispatchEx_GetDispID(IDispatchEx *iface, BSTR bstrName, DW if(hres != DISP_E_UNKNOWNNAME) return hres; - hres = get_dynamic_prop(This, bstrName, grfdex, &dprop); - if(FAILED(hres)) - return hres; + hres = get_dynamic_prop(This, bstrName, grfdex & ~fdexNameEnsure, &dprop); + if(FAILED(hres)) { + if(grfdex & fdexNameEnsure) + hres = alloc_dynamic_prop(This, bstrName, dprop, &dprop); + if(FAILED(hres)) + return hres; + } *pid = DISPID_DYNPROP_0 + (dprop - This->dynamic_data->props); return S_OK;

1 0

Jacek Caban : mshtml/tests: Add more custom properties tests.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 984178cdb0ad9275520f21ead1756d98fc69ec04 URL: https://gitlab.winehq.org/wine/wine/-/commit/984178cdb0ad9275520f21ead1756d… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 29 22:41:22 2024 +0200 mshtml/tests: Add more custom properties tests. --- dlls/mshtml/tests/documentmode.js | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/dlls/mshtml/tests/documentmode.js b/dlls/mshtml/tests/documentmode.js index 5249e042182..2eed3bb1aff 100644 --- a/dlls/mshtml/tests/documentmode.js +++ b/dlls/mshtml/tests/documentmode.js @@ -950,6 +950,30 @@ sync_test("elem_by_id", function() { ok(v < 9 && e.number === 0xa01b6 - 0x80000000, "Setting document.testid threw = " + e.number); } + window.testid2 = 1; + document.testid2 = 2; + document.body.innerHTML = '<form id="testid2" name="testname"></form>'; + ok(window.testid2 == 1, "window.testid2 = " + window.testid2); + id_elem = document.body.firstChild; + todo_wine_if(v < 9). + ok(document.testid2 == (v < 9 ? id_elem : 2), "document.testid2 = " + document.testid2); + document.body.innerHTML = ''; + ok(window.testid2 == 1, "window.testid2 = " + window.testid2); + ok(document.testid2 == 2, "document.testid2 = " + document.testid2 + " expected 2"); + + ok(document.title === "", "document.title = " + document.title); + document.body.innerHTML = '<form id="title" name="testname"></form>'; + id_elem = document.body.firstChild; + todo_wine_if(v < 9). + ok(document.title === (v < 9 ? id_elem : ""), "document.title = " + document.title); + document.body.innerHTML = ''; + ok(document.title === "", "document.title = " + document.title); + + ok(window.closed === false, "window.closed = " + window.closed); + document.body.innerHTML = '<form id="closed" name="testname"></form>'; + id_elem = document.body.firstChild; + ok(window.closed === false, "window.closed = " + window.closed); + // these tags expose name as props, and id only if they have a name var tags = [ "embed", "form", "iframe", "img" ]; for(i in tags) { @@ -3011,3 +3035,17 @@ async_test("postMessage", function() { ok(onmessage_called == (v < 9 ? true : false), "onmessage not called"); if(v < 9) next_test(); }); + +sync_test("form", function() { + document.body.innerHTML = ""; + var form = document.createElement("form"); + document.body.appendChild(form); + + form[0] = "test"; + form.innerHTML = "<input type=\"text\" id = \"i1\" /><input type=\"text\" id = \"i2\" />"; + ok(form.length === 2, "form.length = " + form.length); + ok(typeof(form[0]) === "object", "form[0] = " + form[0]); + ok(typeof(form[1]) === "object", "form[1] = " + form[1]); + form.innerHTML = ""; + ok(form[0] === "test", "form[0] = " + form[0]); +});

1 0

Jacek Caban : mshtml: Return success in IHTMLWindow2::get_closed stub.
by Alexandre Julliard 31 May '24

31 May '24

Module: wine Branch: master Commit: 0fb56a84b75bcb1bb8000a0d6570f08195fee5ed URL: https://gitlab.winehq.org/wine/wine/-/commit/0fb56a84b75bcb1bb8000a0d6570f0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 29 22:40:43 2024 +0200 mshtml: Return success in IHTMLWindow2::get_closed stub. --- dlls/mshtml/htmlwindow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 5a4707153e5..59a0f6d023d 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -1321,8 +1321,11 @@ static HRESULT WINAPI HTMLWindow2_focus(IHTMLWindow2 *iface) static HRESULT WINAPI HTMLWindow2_get_closed(IHTMLWindow2 *iface, VARIANT_BOOL *p) { HTMLWindow *This = impl_from_IHTMLWindow2(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + + TRACE("(%p)->(%p) semi-stub\n", This, p); + + *p = VARIANT_FALSE; + return S_OK; } static HRESULT WINAPI HTMLWindow2_blur(IHTMLWindow2 *iface)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits May 2024