Alexandre Julliard pushed to branch master at wine / wine
Commits:
203f2df0 by Elizabeth Figura at 2025-08-03T11:18:52+09:00
Revert "wined3d/glsl: Transpose the bump environment matrix.".
This reverts commit ed62b8bf30ac926ae100eee42fee3f6ceb8541e2.
GL_TRUE here signifies that the matrix is in row-major storage, and we do indeed
pass it in row-major order here (like other d3d matrices).
The problem is that this matrix, like other d3d matrices, is not only row-major
in storage, it also uses what Sean Middleditch [1] calls "row-major notation".
Contrary to GL, Vulkan, and almost the entire world of mathematics, Direct3D
matrices have the *column* in their first component.
A matrix which is row-major in both storage and notation is effectively
identical, at least in storage order, to one which is column-major in both
storage and notation, as here. That is, it should *not* be transposed.
Adding to the confusion is the fact that, as mentioned by the commit being
reverted (as well as texbem_test() in d3d9:visual), some drivers get this wrong
too, and transpose the matrix. I originally thought that NVidia was broken, but
it turns out that AMD is the one in the wrong here, at least for the BEM and
TEXBEM(L) shader instructions. Incidentally, WARP incorrectly transposes the
matrix for TEXBEM(L) but not for BEM.
This fixes test failures in texbem_test() and fixed_function_bumpmap_test().
[1] https://web.archive.org/web/20180419095941/http://seanmiddleditch.com/matri…
- - - - -
1 changed file:
- dlls/wined3d/glsl_shader.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/203f2df08e438ab41a373d86198f82…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/203f2df08e438ab41a373d86198f82…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
36826182 by Vibhav Pant at 2025-08-03T11:18:39+09:00
cfgmgr32: Add stubs for DevGetObjectProperties(Ex).
- - - - -
ba790ceb by Vibhav Pant at 2025-08-03T11:18:42+09:00
cfgmgr32: Implement DevFreeObjectProperties.
- - - - -
be87abcb by Vibhav Pant at 2025-08-03T11:18:42+09:00
cfgmgr32: Implement DevGetObjectProperties for device interfaces.
- - - - -
b3998eb2 by Vibhav Pant at 2025-08-03T11:18:42+09:00
ntoskrnl.exe/tests: Add tests for device updates in DevCreateObjectQuery.
- - - - -
bf09ac35 by Vibhav Pant at 2025-08-03T11:18:44+09:00
cfgmgr32: Implement device updates for DevCreateObjectQuery.
- - - - -
5 changed files:
- dlls/cfgmgr32/cfgmgr32.spec
- dlls/cfgmgr32/main.c
- dlls/cfgmgr32/tests/cfgmgr32.c
- dlls/ntoskrnl.exe/tests/Makefile.in
- dlls/ntoskrnl.exe/tests/ntoskrnl.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/a1767edc51c863e8e433b4ec9738e…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/a1767edc51c863e8e433b4ec9738e…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
a1767edc by Yuxuan Shui at 2025-08-01T21:43:02+09:00
rpcrt4: Don't read past the end of params in client_do_args.
During the INITOUT phrase, client_do_args will go through the parameter list,
and for out parameters that are returned via pointers, it will reads those
pointers and initialize the memories they point to.
The problem is, for *_Proxy functions, the TypeFormatString generated by widl
includes an extra return value parameter, that does not have a stack location,
therefore client_do_args should not try to read it. Since the return value is
not returned via pointer, we can fix this by reordering the checks.
- - - - -
1 changed file:
- dlls/rpcrt4/ndr_stubless.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/a1767edc51c863e8e433b4ec9738e9…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/a1767edc51c863e8e433b4ec9738e9…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
219662ea by Jacek Caban at 2025-08-01T20:58:56+09:00
include: Add IHTMLAttributeCollection4 declaration.
- - - - -
736490d2 by Jacek Caban at 2025-08-01T20:58:57+09:00
mshtml: Add IHTMLAttributeCollection4 stub implementation.
- - - - -
5 changed files:
- dlls/mshtml/htmlelem.c
- dlls/mshtml/mshtml_private.h
- dlls/mshtml/tests/dom.c
- include/mshtmdid.h
- include/mshtml.idl
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/37fc8477416b5785b1a97e6774225…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/37fc8477416b5785b1a97e6774225…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
81f8da01 by Vibhav Pant at 2025-08-01T20:57:23+09:00
windows.devices.enumeration: Implement DeviceInformationStatics::FindAllAsync using DevGetObjects.
- - - - -
cb86c9a0 by Vibhav Pant at 2025-08-01T20:57:26+09:00
windows.devices.enumeration/tests: Add weak reference tests for DeviceWatcher.
- - - - -
7c735f97 by Vibhav Pant at 2025-08-01T20:57:27+09:00
windows.devices.enumeration: Implement IWeakReferenceSource for DeviceWatcher.
- - - - -
2f185aa9 by Vibhav Pant at 2025-08-01T20:57:29+09:00
windows.devices.enumeration: Implement DeviceInformationStatics::DeviceWatcher using DevCreateObjectQuery.
- - - - -
6 changed files:
- dlls/windows.devices.enumeration/Makefile.in
- dlls/windows.devices.enumeration/main.c
- dlls/windows.devices.enumeration/private.h
- dlls/windows.devices.enumeration/tests/devices.c
- + dlls/windows.devices.enumeration/weakref.c
- + dlls/windows.devices.enumeration/weakref.h
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/42a63687cd6991de03402d81bf79b…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/42a63687cd6991de03402d81bf79b…
You're receiving this email because of your account on gitlab.winehq.org.