wine-devel November 2003

wine-devel@winehq.org

121 participants
276 discussions

RFH: *ReAlloc* mess
by Dimitrie O. Paun 25 Nov '03

25 Nov '03

Hi folks, I need some help to figure out how the following realloc functions behave: GlobalReAlloc LocalReAlloc Local32ReAlloc16 NetApiBufferReallocate SysReAllocStringLen So, I need to know: -- do they allocate memory when a NULL is passed in? -- do they free memory when the size is passed in as 0? Help with this matter is much appreciated! -- Dimi.

1 0

Re: Update comctl spec
by Alexandre Julliard 24 Nov '03

24 Nov '03

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog: > - Export more functions by name. This will break the import libraries. Why do you want to do that? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: Compile Bug: dlls/wininet/cookie.c .. and its cause
by Alexandre Julliard 24 Nov '03

24 Nov '03

Ivan Gyurdiev <ivg2(a)cornell.edu> writes: > I have no clue what the FAR macro does, but wouldn't it be better to > just rename the wine FAR macro to something different if you dont want > it to conflict w/ the other FAR macro? It's a Windows thing, we can't change it. -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: heap: fix RtlHeapReAllocate()
by Dimitrie O. Paun 24 Nov '03

24 Nov '03

On November 21, 2003 03:21 pm, Eric Pouech wrote: > this will not compile on Win9x. You have to take care of: Good point, sorry about that, I was being lazy. To force people to do the dyn load, we shouldn't import ntdll, no? ChangeLog RtlHeapReAllocate() should not allocate memory. Add small test to make sure it doesn't return. Don't import ntdll for tests, we need to load it dynamically. Index: dlls/ntdll/heap.c =================================================================== RCS file: /var/cvs/wine/dlls/ntdll/heap.c,v retrieving revision 1.25 diff -u -r1.25 heap.c --- dlls/ntdll/heap.c 10 Oct 2003 00:12:17 -0000 1.25 +++ dlls/ntdll/heap.c 20 Nov 2003 21:00:39 -0000 @@ -1231,11 +1231,11 @@ HEAP *heapPtr; SUBHEAP *subheap; - if (!ptr) return RtlAllocateHeap( heap, flags, size ); /* FIXME: correct? */ + if (!ptr) return NULL; if (!(heapPtr = HEAP_GetPtr( heap ))) { set_status( STATUS_INVALID_HANDLE ); - return FALSE; + return NULL; } /* Validate the parameters */ Index: dlls/ntdll/tests/Makefile.in =================================================================== RCS file: /var/cvs/wine/dlls/ntdll/tests/Makefile.in,v retrieving revision 1.9 diff -u -r1.9 Makefile.in --- dlls/ntdll/tests/Makefile.in 8 May 2003 03:47:24 -0000 1.9 +++ dlls/ntdll/tests/Makefile.in 24 Nov 2003 07:19:04 -0000 @@ -3,12 +3,12 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = ntdll.dll -IMPORTS = ntdll CTESTS = \ env.c \ error.c \ generated.c \ + heap.c \ large_int.c \ path.c \ rtl.c \ --- /dev/null 2003-01-30 05:24:37.000000000 -0500 +++ dlls/ntdll/tests/heap.c 2003-11-24 02:17:07.000000000 -0500 @@ -0,0 +1,49 @@ +/* + * Unit test suite for heap functions + * + * Copyright 2003 Dimitrie O. Paun + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <stdarg.h> +#include <stdlib.h> + +#include "ntstatus.h" +#include "windef.h" +#include "winbase.h" +#include "wine/test.h" +#include "winnt.h" +#include "winnls.h" +#include "winreg.h" +#include "winternl.h" + +PVOID (WINAPI *pRtlReAllocateHeap)(HANDLE,ULONG,PVOID,ULONG); + +static void test_realloc( void ) +{ + void *mem = NULL; + + mem = pRtlReAllocateHeap(GetProcessHeap(), 0, mem, 10); + ok(mem == NULL, "memory allocated"); +} + +START_TEST(heap) +{ + HMODULE mod = GetModuleHandle("ntdll.dll"); + if (!mod) return; + pRtlReAllocateHeap = (void *)GetProcAddress(mod, "RtlReAllocateHeap"); + if (pRtlReAllocateHeap) test_realloc(); +} -- Dimi.

3 3

Compile Bug: dlls/wininet/cookie.c .. and its cause
by Ivan Gyurdiev 24 Nov '03

24 Nov '03

Macro __WINESRC__ is defined for dlls/wininet/cookie.c in the Makefile. The file cookie.c includes wine/debug.h. wine/debug.h includes windef.h. windef.h defines the macro FAR to __ONLY_IN_WINELIB() __ONLY_IN_WINELIB() defines to do_not_use_this_in_wine if __WINESRC__ The file dlls/wininet/cookie.c also includes dlls/wininet/internet.h dlls/wininet/internet.h includes openssl/ssl.h for my machine openssl/ssl.h includes openssl/kssl.h openssl/kssl.h has the following code using the FAR macro: #ifdef KRB5_HEIMDAL typedef unsigned char krb5_octet; #endif #ifndef FAR #define FAR #endif ... Line 136: krb5_octet FAR *key; This is on a Fedora core system, which applies a patch to openssl that changes the original openssl-devel regarding this, but I think the issue's with wine, and is still there. The original openssl-devel looks like this: #ifdef KRB5_HEIMDAL typedef unsigned char krb5_octet; define FAR #endif Either way, the point is the FAR macro is being used in kssl.h, and it's defined in windef.h, as do_not_use_this_in_wine, resulting in this: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_WINX32_ -D_REENTRANT -fPIC -Wall -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o cookie.o cookie.c In file included from /usr/include/openssl/ssl.h:179, from internet.h:36, from cookie.c:39: /usr/include/openssl/kssl.h:136: error: syntax error before '*' token /usr/include/openssl/kssl.h:149: error: syntax error before '*' token /usr/include/openssl/kssl.h:150: error: syntax error before '*' token /usr/include/openssl/kssl.h:151: error: syntax error before '*' token /usr/include/openssl/kssl.h:151: error: syntax error before '*' token /usr/include/openssl/kssl.h:152: error: syntax error before '*' token /usr/include/openssl/kssl.h:153: error: syntax error before '*' token /usr/include/openssl/kssl.h:155: error: syntax error before '*' token /usr/include/openssl/kssl.h:157: error: syntax error before '*' token /usr/include/openssl/kssl.h:159: error: syntax error before '*' token /usr/include/openssl/kssl.h:167: error: syntax error before '*' token In file included from internet.h:36, from cookie.c:39: /usr/include/openssl/ssl.h:909: error: syntax error before "KSSL_CTX" /usr/include/openssl/ssl.h:931: error: syntax error before '}' token make[2]: *** [cookie.o] Error 1 make[2]: Leaving directory `/home/phantom/tmp/firebird-downloads/wine-20031118/dlls/wininet' make[1]: *** [wininet] Error 2 make[1]: Leaving directory `/home/phantom/tmp/firebird-downloads/wine-20031118/dlls' make: *** [dlls] Error 2 ===================================================================== I am not subscribed to this list. If you'd like to email back write to ivg2(a)cornell.edu. Also, some unrelated questions: does anyone know what causes this: err:module:NE_LoadBuiltinModule loaded .so but dll winealsa.drv still not found (the file is there... oss is there too, and works great) ....or why keyboard focus is always lost (characters appear in the console, kb doesn't work in application) when playing most games under a window manager like gnome or kde, but not under twm? This bug has been there forever and is really annoying.

3 2

Re: winmm: move MCI settings from system.ini to the registry
by Andreas Mohr 24 Nov '03

24 Nov '03

Hi, On Mon, Nov 24, 2003 at 12:10:20PM -0500, Dimitrie O. Paun wrote: > On November 22, 2003 03:02 am, Eric Pouech wrote: > > I won't have too much time to look at this in details right now, so if > > someone wants to jump in, I'll be happy to give him (her ?) a hand. > > To be honest, > My interest in doing this work is to get rid of system.ini from the > Wine tree. While I agree that there's more to do, it's just not up > my alley :) So, this version of the patch still maintains support > for system.ini, just like the old code does, but it also adds support > for registry, which should allow us to move stuff there. To be honest, I'm not sure why one would want that. After all the system.ini settings are an essential part of a Windows environment, and removing the whole file will break many (admittedly older) programs, if I'm not mistaken... (nevermind the duplication of the parameters, which does exist) Andreas Mohr

1 0

Re: documentation/samples/generic.ppd
by Marcus Meissner 24 Nov '03

24 Nov '03

On Mon, Nov 24, 2003 at 02:32:49AM -0500, Dimitrie O. Paun wrote: > > I can't help but feel that this file does not belong in the > Wine tree, but in the print system packages (cups, etc.). > > cvs rm -f documentation/samples/generic.ppd > > ChangeLog > Remove generic.ppd, it does not belong in the Wine tree. This is the generic fallback PPD file which can be used LPR style printing, where we do not get access to a PPD easily. Ciao, Marcus

2 1

IS_STRING_ITEM( lpitem->fType ) but no lpitem->text
by Uwe Bonnes 24 Nov '03

24 Nov '03

Hallo, Peter Heckert <ph_newsalias(a)arcor.de> posted on c.e.m.w a problem with Sigma Photo Pro 2. Sigma Photo Pro 2 can be downloaded at http://www.sigma-photo.co.jp/english/downloads/downloads.html It seems that IS_STRING_ITEM( lpitem->fType ) is set while there is no lpitem->text. Appended hack lets Sigma Photo Pro 2 run until exit, where it crashes again. Can anybody look at that problem? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/controls/menu.c =================================================================== RCS file: /home/wine/wine/controls/menu.c,v retrieving revision 1.169 diff -u -r1.169 menu.c --- wine/controls/menu.c 18 Nov 2003 19:42:31 -0000 1.169 +++ wine/controls/menu.c 23 Nov 2003 21:52:38 -0000 @@ -936,7 +936,7 @@ /* it must be a text item - unless it's the system menu */ - if (!(lpitem->fType & MF_SYSMENU) && IS_STRING_ITEM( lpitem->fType )) + if (!(lpitem->fType & MF_SYSMENU) && IS_STRING_ITEM( lpitem->fType )&& lpitem->text) { SIZE size; GetTextExtentPoint32W(hdc, lpitem->text, strlenW(lpitem->text), &size); @@ -1361,7 +1361,7 @@ } /* No bitmap - process text if present */ - else if (IS_STRING_ITEM(lpitem->fType)) + else if (IS_STRING_ITEM(lpitem->fType) && lpitem->text) { register int i; HFONT hfontOld = 0;

2 2

Re: wine/dlls/kernel process.c
by Marcelo Duarte 24 Nov '03

24 Nov '03

Em Seg 17 Nov 2003 17:18, Alexandre Julliard escreveu: > ChangeSet ID: 10093 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2003/11/17 14:18:19 > > Modified files: > dlls/kernel : process.c > > Log message: > Fixed regression in loading of builtin apps from the system dir when > the native doesn't exist. > > Patch: http://cvs.winehq.com/patch.py?id=10093 > > Old revision New revision Changes Path > 1.34 1.35 +1 -1 wine/dlls/kernel/process.c This patch do not work for me. I run: wine --debugmsg +file -- c:\\windows\\system\\vfp300.esl c:\\modullus.300\\modullus.exe See, the file is searched in all directories of the PATH, and not found: trace:file:CreateFileW L"C:\\windows\\system\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\windows\\system\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L".\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L".\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"C:\\WINDOWS\\SYSTEM\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\WINDOWS\\SYSTEM\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"C:\\WINDOWS\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\WINDOWS\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"c:\\windows\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"c:\\windows\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"c:\\windows\\system\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"c:\\windows\\system\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"e:\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"e:\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"e:\\test\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"e:\\test\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"f:\\msvcrt.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"f:\\msvcrt.dll" (GLE 2) trace:file:CreateFileW L"C:\\windows\\system\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\windows\\system\\kernel32.dll" (GLE 2) trace:file:CreateFileW L".\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L".\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"C:\\WINDOWS\\SYSTEM\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\WINDOWS\\SYSTEM\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"C:\\WINDOWS\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\WINDOWS\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"c:\\windows\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"c:\\windows\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"c:\\windows\\system\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"c:\\windows\\system\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"e:\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"e:\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"e:\\test\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"e:\\test\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"f:\\kernel32.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"f:\\kernel32.dll" (GLE 2) trace:file:CreateFileW L"C:\\windows\\system\\ntdll.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L"C:\\windows\\system\\ntdll.dll" (GLE 2) trace:file:CreateFileW L".\\ntdll.dll" QUERY_ACCESS FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING attributes 0x0 warn:file:CreateFileW Unable to get full filename from L".\\ntdll.dll" (GLE 2) -- Marcelo Duarte

1 0

Re: Compiler problems
by Ivan Leo Murray-Smith 24 Nov '03

24 Nov '03

Current code builds on my system.

2 1

← Newer
1
...
6
7
8
9
10
11
12
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel November 2003