wine-devel May 2006

wine-devel@winehq.org

151 participants
288 discussions

Re: [PATCH 2/4] advapi32: Test GetTokenInformation() as it can fail.
by Saulius Krasuckas 21 May '06

21 May '06

* On Sun, 21 May 2006, Saulius Krasuckas wrote: > > ret = GetTokenInformation(Token, TokenGroups, NULL, 0, &Size); > + ok(ret, "GetTokenInformation(TokenGroups) failed with error %ld\n", GetLastError()); > Groups = HeapAlloc(GetProcessHeap(), 0, Size); Sorry, this fails at make test. I'll try investigate. Skip now.

2 1

Re: cabinet: Add initial tests for Extract [try 2]
by Saulius Krasuckas 21 May '06

21 May '06

* On Tue, 10 Jan 2006, James Hawkins wrote: > This version marks the failing tests as todo_wine, and only uses > DeleteFile instead of file_exists so that a file is removed when it's > not suppsosed to exist. ... > +++ b/dlls/cabinet/tests/extract.c ... > +static INT_PTR fci_open(char *pszFile, int oflag, int pmode, int *err, void *pv) > +{ > + HANDLE handle; > + DWORD dwAccess = 0; > + DWORD dwShareMode = 0; > + DWORD dwCreateDisposition = OPEN_EXISTING; > + > + dwAccess = GENERIC_READ | GENERIC_WRITE; > + dwShareMode = FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE; > + > + if (GetFileAttributesA(pszFile) != INVALID_FILE_ATTRIBUTES) > + dwCreateDisposition = OPEN_EXISTING; > + else > + dwCreateDisposition = CREATE_NEW; > + > + handle = CreateFileA(pszFile, dwAccess, dwShareMode, NULL, > + dwCreateDisposition, 0, NULL); On win9x the flag FILE_SHARE_DELETE isn't supported and makes all the following tests to fail. Can the flag be removed? Tests work nice on XP without it.

1 0

Re: [WINEALSA] close after free bug?
by Robert Reif 21 May '06

21 May '06

Robert Reif wrote: > I can't test this patch but it looks wrong to free a device handle and > then close the device with the freed handle. > >------------------------------------------------------------------------ > >Index: dlls/winmm/winealsa/audio.c >=================================================================== >RCS file: /home/wine/wine/dlls/winmm/winealsa/audio.c,v >retrieving revision 1.104 >diff -p -u -r1.104 audio.c >--- dlls/winmm/winealsa/audio.c 10 May 2006 10:24:16 -0000 1.104 >+++ dlls/winmm/winealsa/audio.c 21 May 2006 12:21:23 -0000 >@@ -2692,8 +2692,8 @@ static DWORD wodClose(WORD wDevID) > > if (wwo->hctl) > { >- snd_hctl_free(wwo->hctl); > snd_hctl_close(wwo->hctl); >+ snd_hctl_free(wwo->hctl); > } > wwo->hctl = NULL; > > > >------------------------------------------------------------------------ > > > > Please disregard this patch. The functions don't do what I thought they do.

1 0

Re: advapi32: Test and implement SystemFunction024/025.
by Hans Leidekker 21 May '06

21 May '06

On Sunday 21 May 2006 10:52, Mike McCormack wrote: > 32 bits of insecurity, courtesy of our friends at Microsoft and the NSA. ;-) Great work Mike. I see you left a tiny bit of obscurity in: + * PARAMS + * data [I] data to encrypt (16 bytes) + * key [I] key data (4 bytes) + * output [O] buffer to receive encrypted data (16 bytes) +NTSTATUS WINAPI SystemFunction024(const LPBYTE in, const LPBYTE key, LPBYTE out) -Hans

1 0

still need audio help?
by Kenneth Armstrong 21 May '06

21 May '06

Do you guys still need audio testing help? I found this here http://www.winehq.org/?issue=313#Testing%20Wine's%20Audio. If you do that would be good, I have a couple of days off coming up. And I would like to help get this audio stuff figured out, because I can install WinAmp and it works fine, but games that I install will not play any sound at all, even when I change my audio settings. (The main game that I have been trying to get worked out is Star Trek Voyager: Elite Force). Kenny Armstrong

3 2

Re: winspool: [1/4] Basic tests for AddMonitor
by Saulius Krasuckas 20 May '06

20 May '06

* On Mon, 10 Apr 2006, Detlef Riekenberg wrote: > > +static void test_AddMonitor(void) > +{ ... > + res = AddMonitorA(NULL, 2, NULL); > + /* NT: unchanged, 9x: ERROR_PRIVILEGE_NOT_HELD */ > + ok(!res && > + ((GetLastError() == MAGIC_DEAD) || > + (GetLastError() == ERROR_PRIVILEGE_NOT_HELD)), > + "returned %ld with %ld (expected '0' with: MAGIC_DEAD or " \ > + "ERROR_PRIVILEGE_NOT_HELD)\n", res, GetLastError()); Detlef, what version of 9x OS you have been testing this code on? On my ME system it generates an unhandled exception 0xC0000005: Access Violation.

1 0

Re: advapi32: Add tests for getting the groups, user and privileges of a token.
by Saulius Krasuckas 20 May '06

20 May '06

* On Sat, 13 May 2006, Robert Shearman wrote: > > +static void test_token_attr(void) > +{ ... > + LPTSTR SidString; ... > + ConvertSidToStringSid(Groups->Groups[i].Sid, &SidString); This makes advapi32_test.exe to not load on w9x. The missing import is advapi32!ConvertSidToStringSidA. As I want to get this fixed I am trying to understand what version (A or W) should this call be converted to. But after noticing LPTSTR I am lost :) Is the use of LPTSTR intended to be here? I find only three files of winetest code this type is used in: dlls\advapi32\tests\security.c dlls\comctl32\tests\comboex.c dlls\user\tests\wsprintf.c Why? Is it OK, at least?

2 2

Re: [WINED3D 3/3] Added some GLSL definitions and function protoypes to wined3d_gl.h
by Alexandre Julliard 20 May '06

20 May '06

"Jason Green" <jave27(a)gmail.com> writes: > These are functions and definitions that will need to be used before > implementing GLSL routines. This doesn't build here: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o baseshader.o baseshader.c In file included from wined3d_private.h:45, from baseshader.c:28: ../../include/wine/wined3d_gl.h:566: error: redefinition of typedef 'PFNGLCREATESHADEROBJECTARBPROC' /usr/X11R6/include/GL/glext.h:4066: error: previous declaration of 'PFNGLCREATESHADEROBJECTARBPROC' was here ../../include/wine/wined3d_gl.h:567: error: redefinition of typedef 'PFNGLSHADERSOURCEARBPROC' /usr/X11R6/include/GL/glext.h:4067: error: previous declaration of 'PFNGLSHADERSOURCEARBPROC' was here ../../include/wine/wined3d_gl.h:568: error: redefinition of typedef 'PFNGLCOMPILESHADERARBPROC' /usr/X11R6/include/GL/glext.h:4068: error: previous declaration of 'PFNGLCOMPILESHADERARBPROC' was here ../../include/wine/wined3d_gl.h:569: error: redefinition of typedef 'PFNGLCREATEPROGRAMOBJECTARBPROC' /usr/X11R6/include/GL/glext.h:4069: error: previous declaration of 'PFNGLCREATEPROGRAMOBJECTARBPROC' was here ../../include/wine/wined3d_gl.h:570: error: redefinition of typedef 'PFNGLATTACHOBJECTARBPROC' /usr/X11R6/include/GL/glext.h:4070: error: previous declaration of 'PFNGLATTACHOBJECTARBPROC' was here ../../include/wine/wined3d_gl.h:571: error: redefinition of typedef 'PFNGLLINKPROGRAMARBPROC' /usr/X11R6/include/GL/glext.h:4071: error: previous declaration of 'PFNGLLINKPROGRAMARBPROC' was here ../../include/wine/wined3d_gl.h:572: error: redefinition of typedef 'PFNGLDETACHOBJECTARBPROC' /usr/X11R6/include/GL/glext.h:4065: error: previous declaration of 'PFNGLDETACHOBJECTARBPROC' was here ../../include/wine/wined3d_gl.h:573: error: redefinition of typedef 'PFNGLDELETEOBJECTARBPROC' /usr/X11R6/include/GL/glext.h:4063: error: previous declaration of 'PFNGLDELETEOBJECTARBPROC' was here make[2]: *** [baseshader.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

sound report
by Sebastien Fievet 20 May '06

20 May '06

Sound report: * Kernel 2.6.14 * Sound driver: snd_sb16 * Sound card: Sound Blaster 16 value edition (EISA card) * 32 bit LFS v4.0 (aka Linux from Scratch) * Alsa version 1.0.9a * Tested against Wine CVS of 05/20/06 Results: * Tested under winealsa * Alsa run reported 2 failures. * Very, very annoying crackling at each input change and pause. Despite that sound by itself is clear. Sampling frequency increase obviously improve sound quality. I didn't notice sound level changes. * Full log file of the run attached.

1 0

Re: Re: wined3d: IWineD3DDeviceImpl_SetRenderState added renderstates (try #2)
by Roderick Colenbrander 20 May '06

20 May '06

> On 5/19/06, Jacob Peters <jacobcpeters(a)gmail.com> wrote: > > ChangeLog: I implemented more renderstates in device.c function > > IWineD3DDeviceImpl_SetRenderState() > > > > I added a few render states called by d3d8 demo app "mshdribl.exe", the > > one in the wiki. > > changed "glBlendEquation()" to "glBlendEquationEXT()" so I don't > conflict > > with opengl <2.0 > > > I forgot to attach the diff sorry Atleast you shouldn't call glBlendFuncSeparateEXT directly but call it using GL_EXTCALL as only modern opengl libraries like Nvidia's export this function. Second I'm not sure if your patch is correct. How did you get that demo app working, it won't start here? (it complains that it can't find any compatible direct3d devices) I want to see what other render states it uses, I guess it might be used D3DRS_SRCBLENDALPHA/DESTBLENDALPHA and friends. A while ago I submitted a patch for it but it wasn't accepted (I will clean it up this weekend). http://www.winehq.org/pipermail/wine-patches/2005-November/021821.html Regards, Roderick Colenbrander -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel May 2006