wine-devel March 2008

wine-devel@winehq.org

168 participants
411 discussions

Re: user32: Fix enumeration and add tests for EnumWindowStations andEnumDesktops, try X
by Dmitry Timoshkov 07 Mar '08

07 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Fixed, and with tests! Why not use A versions of APIs to simplify the tests? Also, though that's a matter of taste, ok(hdesk != 0) is more readable IMO than ok(!!hdesk). -- Dmitry.

1 0

Re: user32: Add a better stub for broadcastsystemmessage, try 2
by Steven Edwards 07 Mar '08

07 Mar '08

On Thu, Mar 6, 2008 at 6:47 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Fixes: BroadcastSystemMessage to not hang other processes any more. +static BOOL CALLBACK broadcastsystemmessagetopwindowcallback(HWND top_window, LPARAM lp) +static BOOL CALLBACK broadcastsystemmessagewindowstationcallback( LPWSTR winsta, LPARAM lp ) Just a matter of style...if ever there was a case for abbrevation this is it. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Forgot a release_obj in my broadcastsystemmessage patch.
by Maarten Lankhorst 06 Mar '08

06 Mar '08

Hi, Please don't apply the broadcastsystemmessage patch, there is a bug in enum_top_windows that I accidentally copied from enum_desktop. I'll send a fix for the enum_desktop call and a fixed version of the patch. Cheers, Maarten.

1 0

Recent valgrind regressions in msxml3
by Dan Kegel 06 Mar '08

06 Mar '08

Hi Alistair, I'm seeing some regressions in msxml3 in yesterday's git; see http://kegel.com/wine/valgrind/logs-2008-03-05/vg-msxml3_domdoc-diff.txt e.g. + Invalid read of size 4 + at HEAP_ValidateInUseArena (heap.c:925) + by RtlFreeHeap (heap.c:1288) + by SysFreeString (oleaut.c:196) + by test_domdoc (domdoc.c:658) + by func_domdoc (domdoc.c:2875) + by run_test (test.h:406) + by main (test.h:455) etc. Could you have a look? Also, have you tried running Valgrind yourself? It's not hard at all these days. - Dan

2 1

Re: slight winsock design change proposal
by James Hawkins 06 Mar '08

06 Mar '08

On Wed, Mar 5, 2008 at 6:28 PM, Christopher Harvey <arbuckle911(a)gmail.com> wrote: > I'm giving the mswsock.c file some development time. I need to know if > the winsock API has been inited. This has already been implemented, but > I need to get access to the num_startup variable from the mswsock.c > file. I hacked a bit and got it, but hesitate to continue because I > don't know if I changed it in the proper way to get access. If this > change is fine please accept it. if not please advise on the proper way > to see if winsock has been inited or not, from the mswsock.c file. > > Thanks. > > diff --git a/dlls/mswsock/mswsock.c b/dlls/mswsock/mswsock.c > index d283405..7f339c0 100644 > --- a/dlls/mswsock/mswsock.c > +++ b/dlls/mswsock/mswsock.c > @@ -62,9 +62,10 @@ BOOL WINAPI AcceptEx( > operation */ > { > FIXME("(listen=%ld, accept=%ld, %p, %d, %d, %d, %p, %p), not implemented\n", > - sListenSocket,sAcceptSocket,lpOutputBuffer,dwReceiveDataLength, > - dwLocalAddressLength,dwRemoteAddressLength,lpdwBytesReceived,lpOverlapped > - ); > + sListenSocket,sAcceptSocket,lpOutputBuffer,dwReceiveDataLength, > + dwLocalAddressLength,dwRemoteAddressLength,lpdwBytesReceived,lpOverlapped > + ); > + //get_num_startup(); Use this to see if Winsock has been inited yet or not > return FALSE; > } > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 502f309..03030a2 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5021,3 +5021,8 @@ INT WINAPI WSCWriteProviderOrder( LPDWORD entry, DWORD number ) > FIXME("(%p 0x%08x) Stub!\n", entry, number); > return 0; > } > + > +INT get_num_startup() > +{ > + return num_startup; > +} > diff --git a/include/winsock2.h b/include/winsock2.h > index a302331..dcca0e7 100644 > --- a/include/winsock2.h > +++ b/include/winsock2.h > @@ -728,6 +728,7 @@ typedef INT (WINAPI *LPFN_WSASTRINGTOADDRESSW)(LPSTR,INT,LPWSAPROTOCOL_INFOA,LPS > typedef DWORD (WINAPI *LPFN_WSAWAITFORMULTIPLEEVENTS)(DWORD,const WSAEVENT*,BOOL,DWORD,BOOL); > #endif /* WS_API_TYPEDEFS */ > > +typedef INT get_num_startup(); > > /* Condition function return values */ > #define CF_ACCEPT 0x0000 > Are you seriously asking if adding a hack to a public header in order to read a global variable from another dll is acceptable? That pretty much sums up the answer. -- James Hawkins

5 7

Getting apps running under Wine
by Martin Hinner 06 Mar '08

06 Mar '08

Hello, I would like to run some of our (win32-based) applications under Linux using Wine. At this time it is only for my personal use, but maybe someday some of our users will like to have it on Linux like me. I have managed to get all of them running, showing at least first dialog/window. But there are some problems: 1) User interface stuff. We are using dialogs (MFC CDialog) that have non-default font size (i.e. Times New Roman, 12 ). The font is displayed correctly under Wine, but dialog window has wrong size (it's smaller and some parts of dialog, mainly buttons at bottom, are not visible). I can send more info on this. How to solve this problem (other way than detecting Wine and resizing window manually) ? 2) Windows drivers. We use DLL that depends on some Win32 drivers. Linux driver is available with similar API, so it's not a big problem to change our application to use Linux library. I understand that clearest way how to solve this problem is to make .dll.so file, but it's quite complicated for this particular application and I would prefer much more to add few if conditions to our Windows code that would recognize Wine under Linux and load native .so file (not .dll.so!). Is this possible? How to deal with different calling conventions between gcc and Visual C++ 2003 ? 3) Windows service. We use a windows NT service (which can easily be ported to Linux,btw), an application communicates with the service using named pipe. Is it possible to communicate from "wined" application with some Linux program using technique other than TCP or Unix socket ? If no - is it possible to open Unix socket from our win app ? -- Martin Hinner http://martin.hinner.info http://www.auto-diagnostics.info

2 3

Re: msi [2/3]: Fix handling of published installer properties
by Alexandre Julliard 06 Mar '08

06 Mar '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > The tests are in the next patch. Fixes bug 7189. > http://bugs.winehq.org/show_bug.cgi?id=7189 You need to fix the todo_wine tests in the same patch, I can't apply a patch that causes failures: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:2233: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2259: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2341: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2469: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2495: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2610: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2633: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2797: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2823: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2900: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:3241: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 make: *** [install.ok] Error 11 And if I apply your 3/3 patch I now get: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:4398: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 make: *** [install.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Regression tests - recent regressions
by Austin English 06 Mar '08

06 Mar '08

In today's git, I've had a few regressions in make -k test: austin@zelda:~/wine-git$ grep -i 'Test failed' wine-0.9.56-420-g22f146f.txt visual.c:1741: Test failed: double texbem failed: Got color 0x00ff00ff, expected 0x00ffff00. systray.c:89: Test failed: ret 0x1 which is not a window systray.c:90: Test failed: hWnd overwritten msg.c:9415: Test failed: 30: ShowWindow(SW_RESTORE): in msg 0x0047 expecting wParam 0x8160 got 0x8162 msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9415: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): in msg 0x0047 expecting wParam 0x8170 got 0x8172 win.c:3271: Test failed: pixel should be black, color is 00205860 win.c:3275: Test failed: pixel should be black, color is 00205860 win.c:3302: Test failed: pixel should be black, color is 00205860 +heap adds: job.c:250: Test failed: GetState failed: 0x80004001 job.c:266: Test failed: Resume failed to return BG_E_EMPTY error: 0x80004001 input.c:470: Test failed: 01: 12 from 81 -> 01 unexpected input.c:470: Test failed: 01: a4 from 81 -> 01 unexpected input.c:461: Test failed: 03: 12 from 00 -> 00 instead of 80 -> 00 input.c:461: Test failed: 03: a4 from 00 -> 00 instead of 80 -> 00 input.c:538: Test failed: not enough messages found; looking for 0 I don't have time to pin these down any further, as I've got a midterm tomorrow then spring break after that. But thought those of you who made recent commits in this area should take a look. If you need a specific test run or log, then please e-mail me. -Austin

3 3

Re: [PATCH] GDI+: Implement GdipGetImageEncoders.
by Nathan Beckmann 06 Mar '08

06 Mar '08

Don't apply this patch. The test cases crash on Windows. I was using winetricks to test and accidentally did not test under Windows. - Nathan On Wed, Mar 5, 2008 at 11:21 AM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Implement helper GdipGetImageEncodersSize. > > Also included tests. > --- > dlls/gdiplus/gdiplus.spec | 4 +- > dlls/gdiplus/image.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/gdiplus/tests/image.c | 53 +++++++++++++++++++++++++++ > include/gdiplusenums.h | 13 +++++++ > include/gdiplusflat.h | 2 + > include/gdiplusimaging.h | 35 ++++++++++++++++++ > 6 files changed, 192 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index b4f314a..a477086 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -284,8 +284,8 @@ > @ stub GdipGetImageDecoders > @ stub GdipGetImageDecodersSize > @ stdcall GdipGetImageDimension(ptr ptr ptr) > -@ stub GdipGetImageEncoders > -@ stub GdipGetImageEncodersSize > +@ stdcall GdipGetImageEncoders(long long ptr) > +@ stdcall GdipGetImageEncodersSize(ptr ptr) > @ stub GdipGetImageFlags > @ stdcall GdipGetImageGraphicsContext(ptr ptr) > @ stdcall GdipGetImageHeight(ptr ptr) > diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c > index 5871209..330d90f 100644 > --- a/dlls/gdiplus/image.c > +++ b/dlls/gdiplus/image.c > @@ -831,3 +831,90 @@ GpStatus WINGDIPAPI GdipSetImagePalette(GpImage *image, > > return NotImplemented; > } > + > +/************************************************************************* > + * Encoders - > + * Implemented as dummy objects that let the user know which files are > + * supported. Actual encoding is done by OLE. > + * > + * This code is based heavily on libgdiplus (Mono): > + */ > + > +typedef enum { > + BMP, > + ICO, > +} ImageFormat; > + > +#define NUM_ENCODERS_SUPPORTED 2 > + > +/* ImageCodecInfo creation routines taken from libgdiplus */ > +static const WCHAR bmp_codecname[] = {'B', 'u', 'i','l', 't', '-','i', 'n', ' ', 'B', 'M', 'P', 0}; /* Built-in BMP */ > +static const WCHAR bmp_extension[] = {'*','.','B', 'M', 'P',';', '*','.', 'D','I', 'B',';', '*','.', 'R', 'L', 'E',0}; /* *.BMP;*.DIB;*.RLE */ > +static const WCHAR bmp_mimetype[] = {'i', 'm', 'a','g', 'e', '/', 'b', 'm', 'p', 0}; /* image/bmp */ > +static const WCHAR bmp_format[] = {'B', 'M', 'P', 0}; /* BMP */ > +static const BYTE bmp_sig_pattern[] = { 0x42, 0x4D }; > +static const BYTE bmp_sig_mask[] = { 0xFF, 0xFF }; > + > +static const WCHAR ico_codecname[] = {'B', 'u', 'i','l', 't', '-','i', 'n', ' ', 'I', 'C', 'O', 0}; /* Built-in ICO */ > +static const WCHAR ico_extension[] = {'*','.','I', 'C', 'O', 0}; /* *.ICO */ > +static const WCHAR ico_mimetype[] = {'i', 'm', 'a','g', 'e', '/', 'x', '-', 'i', 'c', 'o', 'n', 0}; /* image/x-icon */ > +static const WCHAR ico_format[] = {'I', 'C', 'O', 0}; /* ICO */ > +static const BYTE ico_sig_pattern[] = { 0x00, 0x00, 0x01, 0x00 }; > +static const BYTE ico_sig_mask[] = { 0xFF, 0xFF, 0xFF, 0xFF }; > + > +static const ImageCodecInfo codecs[NUM_ENCODERS_SUPPORTED] = > + { > + { /* BMP */ > + /* Clsid */ { 0x557cf400, 0x1a04, 0x11d3, { 0x9a, 0x73, 0x0, 0x0, 0xf8, 0x1e, 0xf3, 0x2e } }, > + /* FormatID */ { 0xb96b3cabU, 0x0728U, 0x11d3U, {0x9d, 0x7b, 0x00, 0x00, 0xf8, 0x1e, 0xf3, 0x2e} }, > + /* CodecName */ (const WCHAR*) bmp_codecname, > + /* DllName */ NULL, > + /* FormatDescription */ (const WCHAR*) bmp_format, > + /* FilenameExtension */ (const WCHAR*) bmp_extension, > + /* MimeType */ (const WCHAR*) bmp_mimetype, > + /* Flags */ ImageCodecFlagsEncoder | ImageCodecFlagsDecoder | ImageCodecFlagsSupportBitmap | ImageCodecFlagsBuiltin, > + /* Version */ 1, > + /* SigCount */ 1, > + /* SigSize */ 2, > + /* SigPattern */ (const BYTE*) bmp_sig_pattern, > + /* SigMask */ (const BYTE*) bmp_sig_mask, > + }, > + { /* ICO */ > + /* Clsid */ { 0x557cf407, 0x1a04, 0x11d3, { 0x9a, 0x73, 0x0, 0x0, 0xf8, 0x1e, 0xf3, 0x2e } }, > + /* FormatID */ { 0xb96b3cb5U, 0x0728U, 0x11d3U, {0x9d, 0x7b, 0x00, 0x00, 0xf8, 0x1e, 0xf3, 0x2e} }, > + /* CodecName */ (const WCHAR*) ico_codecname, > + /* DllName */ NULL, > + /* FormatDescription */ (const WCHAR*) ico_format, > + /* FilenameExtension */ (const WCHAR*) ico_extension, > + /* MimeType */ (const WCHAR*) ico_mimetype, > + /* Flags */ ImageCodecFlagsDecoder | ImageCodecFlagsSupportBitmap | ImageCodecFlagsBuiltin, > + /* Version */ 1, > + /* SigCount */ 1, > + /* SigSize */ 4, > + /* SigPattern */ (const BYTE*) ico_sig_pattern, > + /* SigMask */ (const BYTE*) ico_sig_mask, > + }, > + }; > + > +GpStatus WINGDIPAPI GdipGetImageEncodersSize(UINT *numEncoders, UINT *size) > +{ > + if (!numEncoders || !size) > + return InvalidParameter; > + > + *numEncoders = NUM_ENCODERS_SUPPORTED; > + *size = sizeof (codecs); > + > + return Ok; > +} > + > +GpStatus WINGDIPAPI GdipGetImageEncoders(UINT numEncoders, UINT size, ImageCodecInfo *encoders) > +{ > + if (!encoders || > + (numEncoders != NUM_ENCODERS_SUPPORTED) || > + (size != sizeof (codecs))) > + return InvalidParameter; > + > + memcpy(encoders, codecs, sizeof (codecs)); > + > + return Ok; > +} > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index 5ff164d..5f75c15 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -122,6 +122,58 @@ static void test_LoadingImages(void) > expect(InvalidParameter, stat); > } > > +static void test_encoders(void) > +{ > + GpStatus stat; > + UINT n; > + UINT s; > + ImageCodecInfo *codecs; > + int i; > + int bmp_found; > + > + static const WCHAR bmp_format[] = {'B', 'M', 'P', 0}; > + > + stat = GdipGetImageEncodersSize(NULL, NULL); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncodersSize(&n, &s); > + expect(stat, Ok); > + > + codecs = GdipAlloc(sizeof(ImageCodecInfo) * n); > + if (!codecs) > + return; > + > + stat = GdipGetImageEncoders(n, s, NULL); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(0, s, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s-1, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s+1, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s, codecs); > + expect(stat, Ok); > + > + bmp_found = FALSE; > + for (i = 0; i < n; i++) > + { > + if (CompareStringW(LOCALE_SYSTEM_DEFAULT, 0, > + codecs[i].FormatDescription, -1, > + bmp_format, -1) == CSTR_EQUAL) { > + bmp_found = TRUE; > + break; > + } > + } > + if (!bmp_found) > + ok(FALSE, "No BMP codec found.\n"); > + > + GdipFree(codecs); > +} > + > START_TEST(image) > { > struct GdiplusStartupInput gdiplusStartupInput; > @@ -137,6 +189,7 @@ START_TEST(image) > test_Scan0(); > test_GetImageDimension(); > test_LoadingImages(); > + test_encoders(); > > GdiplusShutdown(gdiplusToken); > } > diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h > index 7c97005..c579ebe 100644 > --- a/include/gdiplusenums.h > +++ b/include/gdiplusenums.h > @@ -257,6 +257,18 @@ enum HotkeyPrefix > HotkeyPrefixHide = 2 > }; > > +enum ImageCodecFlags > +{ > + ImageCodecFlagsEncoder = 1, > + ImageCodecFlagsDecoder = 2, > + ImageCodecFlagsSupportBitmap = 4, > + ImageCodecFlagsSupportVector = 8, > + ImageCodecFlagsSeekableEncode = 16, > + ImageCodecFlagsBlockingDecode = 32, > + ImageCodecFlagsBuiltin = 65536, > + ImageCodecFlagsSystem = 131072, > + ImageCodecFlagsUser = 262144 > +}; > > #ifndef __cplusplus > > @@ -286,6 +298,7 @@ typedef enum StringTrimming StringTrimming; > typedef enum StringFormatFlags StringFormatFlags; > typedef enum HotkeyPrefix HotkeyPrefix; > typedef enum PenAlignment GpPenAlignment; > +typedef enum ImageCodecFlags ImageCodecFlags; > > #endif /* end of c typedefs */ > > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index 1f635ba..b15a4ea 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -257,6 +257,8 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromStreamICM(IStream*,GpBitmap**); > GpStatus WINGDIPAPI GdipDisposeImage(GpImage*); > GpStatus WINGDIPAPI GdipFindFirstImageItem(GpImage*,ImageItemData*); > GpStatus WINGDIPAPI GdipFindNextImageItem(GpImage*,ImageItemData*); > +GpStatus WINGDIPAPI GdipGetImageEncodersSize(UINT *numEncoders, UINT *size); > +GpStatus WINGDIPAPI GdipGetImageEncoders(UINT numEncoders, UINT size, ImageCodecInfo *encoders); > GpStatus WINGDIPAPI GdipGetImageItemData(GpImage*,ImageItemData*); > GpStatus WINGDIPAPI GdipGetImageBounds(GpImage*,GpRectF*,GpUnit*); > GpStatus WINGDIPAPI GdipGetImageGraphicsContext(GpImage*,GpGraphics**); > diff --git a/include/gdiplusimaging.h b/include/gdiplusimaging.h > index c78e1b1..a843da1 100644 > --- a/include/gdiplusimaging.h > +++ b/include/gdiplusimaging.h > @@ -43,6 +43,24 @@ public: > EncoderParameter Parameter[1]; > }; > > +class ImageCodecInfo > +{ > +public: > + CLSID Clsid; > + GUID FormatID; > + const WCHAR* CodecName; > + const WCHAR* DllName; > + const WCHAR* FormatDescription; > + const WCHAR* FilenameExtension; > + const WCHAR* MimeType; > + DWORD Flags; > + DWORD Version; > + DWORD SigCount; > + DWORD SigSize; > + const BYTE* SigPattern; > + const BYTE* SigMask; > +}; > + > class BitmapData > { > public: > @@ -84,6 +102,23 @@ typedef struct EncoderParameters > EncoderParameter Parameter[1]; > } EncoderParameters; > > +typedef struct ImageCodecInfo > +{ > + CLSID Clsid; > + GUID FormatID; > + const WCHAR* CodecName; > + const WCHAR* DllName; > + const WCHAR* FormatDescription; > + const WCHAR* FilenameExtension; > + const WCHAR* MimeType; > + DWORD Flags; > + DWORD Version; > + DWORD SigCount; > + DWORD SigSize; > + const BYTE* SigPattern; > + const BYTE* SigMask; > +} ImageCodecInfo; > + > typedef struct BitmapData > { > UINT Width; > -- > 1.5.4.2 > >

1 1

Re: WineD3D: Implement depth copy from onscreen to offscreen surface when depth fixup is used
by H. Verbeet 06 Mar '08

06 Mar '08

On 06/03/2008, Frank Richter <frank.richter(a)gmail.com> wrote: > This doesn't work. The problem with doing depth copy with fixed up depth stencil is that the size of the render buffer is different from the depth stencil size. Basically what needs to happen is that the render buffer contents need to be blitted to the depth stencil before copying the depth stencil from offscreen to onscreen. Aside from that, depth stencil copying is broken (in that it doesn't always copy when it should, and sometimes copies when it shouldn't). I've got a patch that fixes this, but it causes regressions. Changing anything in the depth copying code would cause some nasty conflicts in my patch. Of course if you're interested in tracking down regressions I'd be happy to send you the patch.

1 0

← Newer
1
...
34
35
36
37
38
39
40
41
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel March 2008