wine-devel February 2010

wine-devel@winehq.org

97 participants
256 discussions

[PATCH] server: Fix console create function
by XueFeng Chang 23 Feb '10

23 Feb '10

Check create_event return value. --- server/console.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/console.c b/server/console.c index a79dc67..3758a71 100644 --- a/server/console.c +++ b/server/console.c @@ -294,7 +294,7 @@ static struct object *create_console_input( struct thread* renderer ) console_input->win = 0; console_input->event = create_event( NULL, NULL, 0, 1, 0, NULL ); - if (!console_input->history || !… [View More]

1 0

Trouble compiling Wine tests with Cygwin
by Alex Villacís Lasso 22 Feb '10

22 Feb '10

I have a VB6 application that requires oledb32 to convert from DBTYPE_VARIANT to DBTYPE_BYTES, and fails with builtin oledb32 since conversions to DBTYPE_BYTES are unimplemented. I set up a VirtualBox VM with Windows XP and the latest Cygwin in order to add a oledb32 test to show me what should be done for these conversions to DBTYPE_BYTES. However, I have trouble when running "make test" on dlls/oledb32/tests. I get the following: ../../../tools/winegcc/winegcc -B../../../tools/… [View More]

2 2

Re: includes: Fix IsEqualPropertyKey definitions
by Alexandre Julliard 22 Feb '10

22 Feb '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -48,7 +48,11 @@ > #endif > > #ifndef IsEqualPropertyKey > +#ifdef __cplusplus > #define IsEqualPropertyKey(a,b) (((a).pid == (b).pid) && IsEqualIID((a).fmtid,(b).fmtid)) > +#else > +#define IsEqualPropertyKey(a,b) (((a)->pid == (b)->pid) && IsEqualIID(&(a)->fmtid,&(b)->fmtid)) > +#endif This doesn't match the PSDK. Where does this come from? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 3/5] d3dx9_36: Implement stubbed ID3DXConstantTable interface
by Henri Verbeet 22 Feb '10

22 Feb '10

On 21 February 2010 22:30, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + if (IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_ID3DXConstantTable)) ID3DXConstantTable extends ID3DXBuffer. > + ERR("Interface %s not found\n", debugstr_guid(riid)); Not implementing a random interface an application asks for is hardly an internal error. You could argue for making it a FIXME, but I think WARN is most appropriate.

1 0

Re: [PATCH] shell32: Allow copy operation to overwrite an existing write protected file + tests
by Alexandre Julliard 22 Feb '10

22 Feb '10

Christian Costa <titan.costa(a)wanadoo.fr> writes: > @@ -627,6 +627,14 @@ static DWORD SHNotifyCopyFileW(LPCWSTR src, LPCWSTR dest, BOOL bFailIfExists) > > TRACE("(%s %s %s)\n", debugstr_w(src), debugstr_w(dest), bFailIfExists ? "failIfExists" : ""); > > + if (PathFileExistsW(dest)) > + { > + /* Destination file may already exist with read only attribute */ > + DWORD attribs = GetFileAttributesW(dest); > + if (… [View More]

1 0

Re: include[1/2]: add a strcmpW-equivalent function usable in tests.
by Dmitry Timoshkov 22 Feb '10

22 Feb '10

Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > +/* strcmpW is avaiable for tests compiled under Wine, but not in standalone > + * builds under Windows, so we reimplement it under a different name. */ > +static inline int winetest_strcmpW( const WCHAR *str1, const WCHAR *str2 ) > +{ > + while (*str1 && (*str1 == *str2)) { str1++; str2++; } > + return *str1 - *str2; > +} 'inline' should not be used in Wine tests, and existing 'inline's should be … [View More]

2 1

Re: [PATCH 02/10] oleaut32: Improved ICreateTypeInfo2_fnAddFuncDesc implementation
by Paul Vriens 22 Feb '10

22 Feb '10

On 02/22/2010 01:57 AM, Piotr Caban wrote: > + TRACE("(%p,%d,%p)\n", iface, index, pFuncDesc); > + TRACE("{%d,%p,%p,%d,%d,%d,%d,%d,%d,%d,{%d},%d}\n", pFuncDesc->memid, > + pFuncDesc->lprgscode, pFuncDesc->lprgelemdescParam, pFuncDesc->funckind, > + pFuncDesc->invkind, pFuncDesc->callconv, pFuncDesc->cParams, > + pFuncDesc->cParamsOpt, pFuncDesc->oVft, pFuncDesc->cScodes, > + pFuncDesc->… [View More]

1 0

IShellBrowser/ICommDlgBrowser Theme draw problem
by Kenneth Robinette 22 Feb '10

22 Feb '10

I am testing a SSH file transfer program which makes use of the Microsoft IShellBrowser and ICommDlgBrowser interfaces for the "local" file system view. The interface listview header (detail view) does not get painted correctly when a theme is enabled under Wine. If a theme is not selected, the problem does not happen. This can be seen using an example program available for general public download at: http://www.codeproject.com/KB/shell/explorer.aspx?df=100&forumid=2239&exp=0… I … [View More]

2 1

Re: makefiles: Add some msvcrt imports needed under Cygwin
by Austin English 22 Feb '10

22 Feb '10

On Sat, Feb 20, 2010 at 11:20 AM, <cerebro.alexiel(a)gmail.com> wrote: > diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in > index dce8259..1a36216 100644 > --- a/programs/xcopy/Makefile.in > +++ b/programs/xcopy/Makefile.in > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = xcopy.exe > APPMODE = -mconsole -municode -mno-cygwin > -IMPORTS = shell32 user32 … [View More]

3 3

Re: [PATCH 2/2] wined3d: Fix calculation of pitch for ATI2N format
by Stefan Dösinger 22 Feb '10

22 Feb '10

On the big picture I am not sure if the test conclusively shows what is going on. If your test's offset of 2160 bytes is correct something odd is going on. Please add a test explicitly testing the pitch returned in D3DLOCKED_RECT.Pitch. > + hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 128, 128, MAKEFOURCC('A','T','I','2'), D3DPOOL_SCRATCH, &surface, 0); > + ok(SUCCEEDED(hr), "CreateOffscreenPlainSurface failed (%08x)\n", hr); I am not sure if ATI2N surfaces are … [View More]

2 2

← Newer
1
...
5
6
7
8
9
10
11
...
26
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2010