wine-devel January 2012

wine-devel@winehq.org

83 participants
193 discussions

Rules for code freeze
by Alexandre Julliard 30 Jan '12

30 Jan '12

Folks, We are now in code freeze, so all patches that are not obviously harmless need to have a justification as to why the patch should be applied. In most cases, that simply means pointing to the corresponding bug that is fixed by the patch. Patches that seem risky will be marked pending or deferred. If you still think they should go in, you should convince me that they fix something important that is worth the risk. Patches that only change the tests can't break apps so they will be accepted freely, at least until we get closer to release. Patches that require translation updates will only be accepted for the next two weeks, to give translators time to catch up afterwards. I'm planning to make rc releases every week until we run out of bugs. The release schedule may be a bit more random than usual because of travel constraints (not to mention skiing constraints ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: fix MSVC build in imagelist.c
by Alexandre Julliard 30 Jan '12

30 Jan '12

Thomas Faber <thfabba(a)gmx.de> writes: > This removes the use of a Variable-Length Array in ImageList_CreateImage > and replaces it with HeapAlloc/HeapFree, as it is done in several > other functions in this file. > Alas, FIELD_OFFSET is "not const enough" for ANSI C. Using sizeof instead would be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] include: Handle rmxftmpl.x when needed by d3dx9 without the need to make all includes. (try 2)
by Rico Schüller 30 Jan '12

30 Jan '12

Please ignore this patch, it seems to break make crosstest. Cheers Rico Am 30.01.2012 09:00, schrieb Rico Schüller: > Hi, > > this is try 2 for fixing the build for d3dx9_36 without requiring to > make all includes. > > Improvements: > - don't use a generic rule, use a file specific one > > Cheers > Rico > > --- > Make.rules.in | 3 +++ > include/Makefile.in | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > >

1 0

Re: kernel32: add a stub for LCMapStringEx (try 2)
by Dmitry Timoshkov 30 Jan '12

30 Jan '12

Austin English <austinenglish(a)gmail.com> wrote: > Forgot the include changes. Forwarding it to LCMapString would be much better. -- Dmitry.

3 2

Re: [PATCH 4/5] ddraw/tests: Port the depth blit test to ddraw2
by Henri Verbeet 30 Jan '12

30 Jan '12

On 22 January 2012 16:32, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* FIXME: This is wrong, d3d2 does not have D3DRENDERSTATE_LIGHTING. D3DLVERTEX should > + * disable lighting. This needs more tests and fixes after Wine 1.4 */ > + hr = IDirect3DDevice2_SetRenderState(device, D3DRENDERSTATE_LIGHTING, FALSE); It probably makes sense to just skip this call and add a todo_wine for the failing tests. Also, if all that's needed for this is setting WINED3D_RS_LIGHTING in IDirect3DDeviceImpl_2_DrawPrimitive(), I think that should be ok to go in before 1.4.

2 1

Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed. (try 2)
by Dmitry Timoshkov 30 Jan '12

30 Jan '12

Adam Martinson <adam.r.martinson(a)gmail.com> wrote: > Fixes bug 26924. Please add the tests. -- Dmitry.

1 0

re: Best way to overlay a filesystem for a Wine app?
by Dan Kegel 30 Jan '12

30 Jan '12

Hi Scott, I agree with what Vrit said. Here's what I recall learning from helping package Picasa: - don't package the installer - rely on the system's update manager to pull updated versions of the package from the repository - install everything read-only into /opt/companyname/appname - start the app using a shell script that creates a wineprefix on 1st run - The wineprefix should have real directories (so the app can create files in Program Files, ugh), should symlink to all the readonly files in /opt, and have real copies of any files that can't be read-only As Vrit said, the script that creates the wineprefix is very app-specific, but once you write one, it's probably easy to write the next one. - If you are running your own repo, you should put exactly one app per repo. Otherwise you run into trouble because Canonical would want to review all the apps in the repo every time you update any one of them. So no overlay filesystem needed, symlinks should usually suffice. (Picasa also went further and bundled a snapshot of wine, too, and modified the app slightly to display unix paths, which required adding one little extension to wine. I'm sure the wine patch is around if someone wants it. And since it was in a non-ubuntu repo, it had to do a strange song and dance to avoid autoupdates being disabled when the user upgraded to a new version of ubuntu. This was considered safe because picasa was fairly well self-contained and maintained, and was unlikely to break on system updates.) In case you want to look at picasa's scripts, the download page seems to be gone, but the repo seems to still be there: http://dl.google.com/linux/deb/pool/non-free/p/picasa/picasa_3.0-current_i3… http://dl.google.com/linux/deb/pool/non-free/p/picasa/picasa_3.0-current_am… 4ecf30186ce76430a7791cee2608f47e07b015e6 picasa_3.0-current_amd64.deb fe8e83b29a10b5d663e87861d85512faea036c06 picasa_3.0-current_i386.deb Still installs and runs ok on 11.10.

2 2

Re: patch msvcrt.dll file.c MSVCRT_tmpfile() open_flags --> stream_flags
by Vitaliy Margolen 29 Jan '12

29 Jan '12

On 01/29/2012 07:25 AM, fred wrote: > Hi Wine-Team > > A old bugfix on my system > You need to fix at least these issues with your e-mail: - One e-mail per patch. - All patches needs to be submitted using git format-patch.. - You have to specify your full name in From: address For more details see: http://wiki.winehq.org/SubmittingPatches Vitaliy.

1 0

Re: [po]updated korean resource(2012-1-28)
by Frédéric Delanoy 29 Jan '12

29 Jan '12

2012/1/28 Hwang YunSong(황윤성) <hys545(a)dreamwiz.com> > > fuzzy sections tranlated > > <http://www.dreamwiz.com/> http://www.dreamwiz.com/ > > <http://mall.shinsegae.com/display/display/planshop.do?disp_ctg_id=10049845&…> > > You should send your patch in plain text format (as all mails to wine-devel / wine-patches). Also, you shouldn't specify a date in the patch subject line (Change PO-Revision-Date in the po file instead for instance) so "[po]updated korean resource(2012-1-28)" should be sthg like "po: Update Korean translation" to conform to naming conventions (see http://wiki.winehq.org/SubmittingPatches). Frédéric

1 0

HRBlock error. Sure would like to do my taxes on Linux using Wine.
by Ken Stephens 29 Jan '12

29 Jan '12

I get the following error when trying to load HRBlock software: Error Messsage [kens@atlas HRBlock2011]$ wine tcauto.exe err:winediag:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. Usually, you can find it in the winbind package of your distribution. fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 32 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 32 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels fixme:alsa:AudioClient_GetMixFormat Don't know what to do with 10000 channels, pretending there's only 2 channels err:ole:CoGetClassObject class {96749377-3391-11d2-9ee3-00c04f797396} not registered err:ole:CoGetClassObject class {96749377-3391-11d2-9ee3-00c04f797396} not registered err:ole:create_server class {96749377-3391-11d2-9ee3-00c04f797396} not registered fixme:ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported err:ole:CoGetClassObject no class object {96749377-3391-11d2-9ee3-00c04f797396} could be created for context 0x17 fixme:win:EnumDisplayDevicesW ((null),0,0x32f70c,0x00000000), stub! fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! fixme:urlmon:InternetBindInfo_GetBindString not supported string type 12 fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! fixme:wininet:InternetLockRequestFile STUB fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know what to do! Application tried to create a window, but no driver could be loaded. Unknown error (0). [kens@atlas HRBlock2011]$ err:ntdll:RtlDeleteResource Deleting active MRSW lock (0x111bf4), expect failure err:ntdll:RtlDeleteResource Deleting active MRSW lock (0x1124fc), expect failure [kens@atlas HRBlock2011]$ -- Ken Stephens, SV Aventura, Portland, OR

4 3

Re: wined3d: downgrade a noisy FIXME to a WARN
by Stefan Dösinger 29 Jan '12

29 Jan '12

Am Samstag, 28. Januar 2012, 14:19:22 schrieb Austin English: > Follow up to > http://www.winehq.org/pipermail/wine-patches/2012-January/110971.html. I > was hoping to get it in before 1.4, to reduce users asking about it in > #winehq/forums. > > I know Henri feels it should be properly fixed instead, but given > http://www.winehq.org/pipermail/wine-devel/2012-January/093977.html, I > don't see that happening, and certainly not before 1.4. No one has > sent a simple downgrade patch, instead opting to go with the > FIXME_once approach. Hopefully this is a fair compromise. We don't want to downgrade all flags. Most(all?) of the noise comes from the WRITEONLY usage flag. The other flags are more serious should an app use them.

1 0

Re: user32: Only call SetWindowPos() in UpdateLayeredWindowIndirect() if needed.
by Dmitry Timoshkov 29 Jan '12

29 Jan '12

Adam Martinson <adam.r.martinson(a)gmail.com> wrote: > Fixes bug 26924. This needs the tests. -- Dmitry.

1 0

NLS files and FONTSIGNATURE
by Pablo Saratxaga 28 Jan '12

28 Jan '12

Kaixo, I'm planning to create/fix/check all the possible NLS files. There is, however, an entry on those files that is problematic for me, namely the LOCALE_FONTSIGNATURE one. >From the Microsoft docs I understand it is made of 3 bitfields, one 128bit for unicode coverage, and two 64bit ones for codepage ("default" and "supported"). For those last two there is no problem, after the normal endianess switching I get an hex number with bits that make sens. eg for rus.nls file I have a fontsignature being: L"\x0203\x8000\x3848\x0000\x0000\x0000\x0000\x0000\x0004\x0000\x0000\x0002\x0004\x0000\x0000\x0202" the default and supported codepage parts are respectively: \x0004\x0000\x0000\x0002 \x0004\x0000\x0000\x0202 after switching \x(1)\x(2)\x(3)\x(4) to 0x(4)(3)(2)(1) I get: 0x0002000000000004 and 0x0202000000000004 which perfectly match bits 2, 49, 57; code pages 1250, 866, 855 But for the unicode coverage part I'm lost... In the LOCALE_FONTSIGNATURE it is: \x00a3\x8000\x7878\x38c9\x0016\x0000\x0000\x0000 In order to get a 128 bit number that makes sense I had to do the following switching: \x(1)\x(2)\x(3)\x(4)\x(5)\x(6)\x(7)\x(8) to 0x(2)(7)(6)(5)(4)(3)(8)(1) but it seems strange to me. Also, font signatures for other nls don't make sense with that substitution. So; how should I made the conversion between the format used in *.nls files and the 128 bit number used as bitfield to calculate the flags? Are the values in *.nls files trusty? Thanks -- Ki ça vos våye bén, Pablo Saratxaga http://chanae.walon.org/pablo/ PGP Key available, key ID: 0xD9B85466

1 0

Save backtrace feature
by Bruno Jesus 28 Jan '12

28 Jan '12

I'm not sure what this console error means but it's always related to exceptions and crashes: err:seh:setup_exception_record stack overflow 848 bytes in thread 0009 eip 7bc79df6 esp 00230fe0 stack 0x230000-0x231000-0x330000 When an error like this happens during a crash the new error window with the save backtrace feature will keep "Loading detailed information" forever. I guess it should say something like "could not load required information". I looked in the list emails and it looks like this issue was not reported yet. I'm sorry if it already was discussed and I missed it. Best wishes, Bruno

2 1

Re: [PATCH] winecoreaudio.drv: Improve underrun handling
by Ken Thomases 28 Jan '12

28 Jan '12

On Jan 27, 2012, at 3:46 PM, Andrew Eikum wrote: > + if(list_count(&This->queued_bufinfos) == 0){ > + sc = AudioQueueGetCurrentTime(This->aqueue, NULL, &req_time, NULL); This isn't quite the same as the next start time. Even if there are no remaining queued buffers, the queue may still be playing some audio from the last of them. In that case, the queue's current time would not be the actual desired start time of this buffer. Have you verified that the queue schedules it after whatever audio may be playing? Also, what about the fact that AudioQueueGetCurrentTime() seems to return an unreliable time when the queue is paused? > + if(req_time.mFlags & kAudioTimeStampSampleTimeValid){ > + sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, > + This->public_buffer, 0, NULL, 0, 0, 0, NULL, &req_time, &start_time); > + if(sc != noErr){ > + OSSpinLockUnlock(&This->lock); > + WARN("Unable to enqueue buffer: %lx\n", sc); > + return E_FAIL; > + } > + }else{ > + sc = AudioQueueEnqueueBufferWithParameters(This->aqueue, > + This->public_buffer, 0, NULL, 0, 0, 0, NULL, NULL, &start_time); > + if(sc != noErr){ > + OSSpinLockUnlock(&This->lock); > + WARN("Unable to enqueue buffer: %lx\n", sc); > + return E_FAIL; > + } I would avoid duplicating those two branches just to change between &req_time or NULL. Either use a pointer variable to hold the argument you're going to pass, computed in an "if", or use the conditional ?: operator inline. -Ken

1 0

Re: Wine release 1.4-rc1
by James McKenzie 27 Jan '12

27 Jan '12

Alexandre: Congratulations to the Wine Team. Now to beat on it... James On Fri, Jan 27, 2012 at 12:58 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > The Wine development release 1.4-rc1 is now available. > -- > Alexandre Julliard > julliard(a)winehq.org >

1 0

brainstorm: what are the audio stumbling blocks?
by Joerg-Cyril.Hoehle＠t-systems.com 27 Jan '12

27 Jan '12

Hi, What are the areas that would have the most impact if fixed? You are invited to participate and share your thoughts. I believe we need to distinguish winmm/dsound/mmdevapi/OS. mmdevapi: A. lock-less timer callback design, bug #. But I don't think where we would get the most improvement from avoiding a few EnterCriticalSection. B. Stability of time base, bug #. Perhaps major. My render "worst case" test showed that CreateTimerQueue never invoked callbacks every 10ms as asked rather than 8 or 12ms. I don't know if that's the Linux jiffies we see here. C. too small ALSA buffer for the backend I've sketched a "hidden frames" design that would allow using a larger ALSA or OSS buffer, but that needs a reliable estimate of how much ALSA has buffered. Also, that's at odds with DSound and XAudio2 which want short latency and presumably don't send much data in advance. Every audio HW guy recommends using audio buffers as large as possible. Can't we just because of the f**ing 10ms period? D. timer frequency Is it really important to match native's 10ms period? The UNIX world is trying to decrease the number of interrupts in order to preserve battery life, but we go backwards and move from a model which dynamically computed the next wake-up based on the number of submitted frames to a tiny fixed period. Are we crazy? E. lead-in aka. "ALSA won't start", bug # F. lead-out aka. finish playing trailing frames not modulo period size, bug # G. other mmdevapi winmm: H. GetPosition is not (yet) == mmdevapi's GetPosition I. other winmm DSound: J. time base? It uses timeSetEvent. What if using mmdevapi's event? K. buffer size too small or not matching whatever needs? L. issues with GetCurrentPadding/GetPosition The "true position" may be too far away from the write pointer, e.g. PA's typical 2s latency. Deal with that, matching DSound's and the apps' expectations as well as Linux/BSD/OSX sound systems. M. DSound's underlying model is a ring buffer. This does not match mmdevapi's. Should we bypass mmdevapi because all it adds is latency? Reinvent HW acceleration? Provide a hidden API in mmdevapi? N. other DSound XAudio2: Modern apps will use that because mmdevapi is too low-level, presumably DSound usage will decrease. O. XAudio2 appears to use the "worst case small period size writes" known from the Rage bug # P. other Capture: Q. whatever capture issues UNIX host: R. thread priority -- no "Pro Audio" / Real-Time priority S. reliability of event/interrupt delivery over sustained intervals (hours, not minutes). T. Wine SetEvent & server round-trip times Other: U. FMOD & whatever, any particular constraints? V. other? Thanks for your contribution, Jörg Höhle

2 4

Re: Wine release 1.4-rc1
by Alexandre Julliard 27 Jan '12

27 Jan '12

Alexandre Julliard <julliard(a)winehq.org> writes: > The source is available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.3.38.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-1.3.38.tar.bz2 Of course, that should read http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.4-rc1.tar.bz2 http://prdownloads.sourceforge.net/wine/wine-1.4-rc1.tar.bz2 Hopefully my release scripts will be bug-free by 1.4 final ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/1] crypt32: Fix domain component length check.
by Austin English 27 Jan '12

27 Jan '12

On Fri, Jan 27, 2012 at 10:11, Erich E. Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > > Description: > This patch fixes an issue where the domain component in > match_domain_component will not match when the allowed_component is > NULL terminated. This currently affects the Battle.net System Checker > (Bug #28162), which passes a server_component of "net" and an > allowed_component of "net\000". > > Changelog: > crypt32: Fix domain component length check. Forgot the patch. -- -Austin

3 2

Re: [PATCH 1/2] itss: Enlarge buffer to include space for a catenated value.
by Jacek Caban 27 Jan '12

27 Jan '12

Hi Erich, On 01/27/12 04:58, Erich E. Hoover wrote: > --- a/dlls/itss/storage.c > +++ b/dlls/itss/storage.c > @@ -418,7 +418,7 @@ static HRESULT WINAPI ITSS_IStorageImpl_OpenStorage( > if( !chmfile ) > return E_FAIL; > > - len = strlenW( This->dir ) + strlenW( pwcsName ) + 1; > + len = strlenW( This->dir ) + strlenW( pwcsName ) + strlenW( szRoot ) + 1; szRoot is a constant string, so there is no need to call strlenW on it. IMO it would be best to get rid of szRoot and use character assignment instead. Cheers, Jacek

1 0

Re: [PATCH 2/2] winmm: Restore useful MMSYSERR_* codes at open time.
by Andrew Eikum 27 Jan '12

27 Jan '12

On Fri, Jan 27, 2012 at 02:02:22PM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > + case S_FALSE: /* as in IsFormatSupported */ > + case AUDCLNT_E_UNSUPPORTED_FORMAT: > + return WAVERR_BADFORMAT; I think I'd rather special-case how we handle IsFormatSupported, rather than put S_FALSE->BADFORMAT into the generic conversion. Andrew

1 0

Re: vbscript: Get rid of unused SET_CALLED macro
by Marvin 27 Jan '12

27 Jan '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16686 Your paranoid android. === WNT4WSSP6 (32 bit createobj) === createobj.c:731: Test failed: CoCreateInstance failed: 80040154 createobj: unhandled exception c0000005 at 00402A21

1 0

mmdevapi/tests: Perform renderer padding & position tests.
by Joerg-Cyril.Hoehle＠t-systems.com 27 Jan '12

27 Jan '12

Alexandre, You wrote: >It doesn't work here: Backtrace: =>0 get_audio_session+0xbd() in winealsa 1 AudioClient_Initialize+0x5ae(iface=0x30c80, mode=AUDCLNT_SHAREMODE_SHARED, flags=0, duration=<is not available>, period=0x186a0, fmt=0x30f00, sessionguid=0x22fa00) [dlls/winealsa.drv/mmdevdrv.c:1075] in winealsa 2 test_session+0x114() [dlls/mmdevapi/tests/render.c:1298] in mmdevapi_test Could you please investigate this? The crash happens in test_session, before the one change to this function by my patch. The tests have been running thousands of iterations on my dual core MacOS (with my wip lock-free patches) and a single core Linux ALSA/dmix box. Several people have run the tests on native, including 64bit MS-Windows. I can't rule out that one of my latest additions may have introduced a bug, but so far I'd rather believe that my renderer tests have uncovered a bug in mmdevapi that shows up in your environment only. Why? On my side, I think I'll add ok(ref=0) checks around every IAC_Release. Thank you, Jörg Höhle

2 1

Re: mmdevapi/tests: Perform renderer padding & position tests.
by Alexandre Julliard 26 Jan '12

26 Jan '12

Joerg-Cyril.Hoehle(a)t-systems.com writes: > Hi, > > this again fixes a few flaky failures on testbot but has potential > to introduce more flaky failures, esp. with PulseAudio. It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M mmdevapi.dll -T ../../.. -p mmdevapi_test.exe.so ../../../../wine/dlls/mmdevapi/tests/render.c && touch render.ok render.c:1081: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests. render.c:1081: Tests skipped: Rerun with WINETEST_DEBUG=2 for GetPosition tests. wine: Unhandled page fault on read access to 0xffffffffffffffb8 at address 0x2adef8d7577d (thread 003f), starting debugger... Unhandled exception: page fault on read access to 0xffffffffffffffb8 in 64-bit code (0x00002adef8d7577d). Register dump: rip:00002adef8d7577d rsp:000000000022f830 rbp:000000000022fa00 eflags:00010283 ( R- -- I S - - -C) rax:0000000000000000 rbx:0000000000030af0 rcx:000000000022fa00 rdx:0000000000000000 rsi:00002adef8b53cb0 rdi:000000000022fa00 r8:0000000000000020 r9:000000000022f700 r10:0000000000000010 r11:000000000022f730 r12:0000000000000002 r13:ffffffffffffff98 r14:00002adef8f870f0 r15:0000000000030d90 Stack dump: 0x000000000022f830: 0000000000030f28 0000000000030c80 0x000000000022f840: 000000008007000e 0000000000000000 0x000000000022f850: 000000000022fa00 0000000000000000 0x000000000022f860: 0000000000000000 00002adef8d78e4f 0x000000000022f870: 0000000000000000 00002adef3fdcce1 0x000000000022f880: 000000000022fa48 0000000000030d68 0x000000000022f890: 0000000000000000 00002adef8d77f2f 0x000000000022f8a0: 0000000000031080 00002ade0000000e 0x000000000022f8b0: 000000000022f8e8 0000000000030d68 0x000000000022f8c0: 0000bb800022fa00 0000000400005355 0x000000000022f8d0: 5b5b5b5b5b5b5b5b 5b5b5b5b5b5b5b5b 0x000000000022f8e0: 2020202020202020 2020202020202020 Backtrace: =>0 0x00002adef8d7577d get_audio_session+0xbd() in winealsa (0x000000000022fa00) 1 0x00002adef8d78e4f AudioClient_Initialize+0x5ae(iface=0x30c80, mode=AUDCLNT_SHAREMODE_SHARED, flags=0, duration=<is not available>, period=0x186a0, fmt=0x30f00, sessionguid=0x22fa00) [/home/julliard/wine/build/obj-elf64/dlls/winealsa.drv/../../../wine/dlls/winealsa.drv/mmdevdrv.c:1075] in winealsa (0x000000008007000e) 2 0x00002adef3fd6fb5 test_session+0x114() [/home/julliard/wine/build/obj-elf64/dlls/mmdevapi/tests/../../../../wine/dlls/mmdevapi/tests/render.c:1298] in mmdevapi_test (0x0000000000000000) 3 0x00002adef3fda2d3 func_render+0x292() [/home/julliard/wine/build/obj-elf64/dlls/mmdevapi/tests/../../../../wine/dlls/mmdevapi/tests/render.c:2150] in mmdevapi_test (0x000000000022fb38) 4 0x00002adef3fcc429 main+0x308(argc=<is not available>, argv=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/mmdevapi/tests/../../../../wine/include/wine/test.h:556] in mmdevapi_test (0x000000000001079c) 5 0x00002adef3fdd8c2 __wine_spec_exe_entry+0xa1(peb=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/winecrt0/../../../wine/dlls/winecrt0/exe_entry.c:36] in mmdevapi_test (0x00002adef2285a30) 6 0x00002adef3278404 start_process+0xb3(peb=0x7fffffbef000) [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1053] in kernel32 (0x00002adef3fdd820) 7 0x00002adef2ae328b call_thread_func+0x6a(entry=0x2adef3278350, arg=0x7fffffbef000, frame=0x0(nil)) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/signal_x86_64.c:3189] in ntdll (0x00007fff3177aa50) 8 0x00002adef2adcbb6 call_thread_entry_point+0x29() in ntdll (0x00007fff3177aa50) 9 0x00002adef2aaf1d6 start_process+0x15(kernel_start=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2612] in ntdll (0x00007fff3177aa50) 10 0x00002adef1f5f3a3 wine_call_on_stack+0x12() in libwine.so.1 (0x00007fff3177aa50) 11 0x00002adef1f5f3f9 wine_switch_to_stack+0x8(func=<is not available>, arg=<is not available>, stack=<is not available>) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/port.c:59] in libwine.so.1 (0x00007fffffbef000) 12 0x00002adef2ab4f10 LdrInitializeThunk+0x45f(kernel_start=0x2adef3278350, unknown2=<is not available>, unknown3=<is not available>, unknown4=<is not available>) [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2668] in ntdll (0x00007fffffbef000) 13 0x00002adef327e885 __wine_kernel_init+0x8f4() [/home/julliard/wine/build/obj-elf64/dlls/kernel32/../../../wine/dlls/kernel32/process.c:1254] in kernel32 (0x00007fff3177bce0) 14 0x00002adef2ab5874 __wine_process_init+0x273() [/home/julliard/wine/build/obj-elf64/dlls/ntdll/../../../wine/dlls/ntdll/loader.c:2877] in ntdll (0x0000000000000400) 15 0x00002adef1f5d325 wine_init+0x294(argc=<is not available>, argv=0x7fff3177c4b8, error="", error_size=0x400) [/home/julliard/wine/build/obj-elf64/libs/wine/../../../wine/libs/wine/loader.c:831] in libwine.so.1 (0x0000000000000400) 16 0x000000007bf00d41 main+0x70(argc=0x3, argv=0x7fff3177c4b8) [/home/julliard/wine/build/obj-elf64/loader/../../wine/loader/main.c:230] in <wine-loader> (0x0000000000000003) 17 0x00002adef24ebead __libc_start_main+0xfc(main=<is not available>, argc=<is not available>, ubp_av=<is not available>, init=<is not available>, fini=<is not available>, rtld_fini=<is not available>, stack_end=0x7fff3177c4a8) [/home/aurel32/eglibc/eglibc-2.13/csu/libc-start.c:228] in libc.so.6 (0x0000000000000000) 18 0x000000007bf00e3d _start+0x28() in <wine-loader> (0x0000000000000000) 0x00002adef8d7577d get_audio_session+0xbd in winealsa: cmpq 0x0000000000000020(%r13),%rbx -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: Parse MCI colon notation as in T:MM:SS:F.
by Alexandre Julliard 26 Jan '12

26 Jan '12

Joerg-Cyril.Hoehle(a)t-systems.com writes: > + if (seen < 2) return FALSE; > + if (shift && (val >= 256 || (seen&1))) return FALSE; > + total |= val << shift; > + *data = (seen&1) ? -total : total; > + *ptr = ret; > + return TRUE; This is still fairly ugly. If you need two flags, declare two flag variables, instead of that sort of counter/flag mix. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2012