wine-devel July 2012

wine-devel@winehq.org

69 participants
314 discussions

Noticed openwatcom.org's afxapi
by Dan Kegel 22 Jul '12

22 Jul '12

"Initial checkin of afxapi, a class library aiming to provide source-level compatibility with MFC." http://www.openwatcom.org:4000/@md=d&cd=//depot/openwatcom/bld/afxapi/inclu… Wonder how that's going.

1 0

Error When Using winedbg on 64-bit Ubuntu 12.04
by John Edmonds 22 Jul '12

22 Jul '12

I'm using 64-bit Ubuntu 12.04. I built and installed wine using the instructions from http://wiki.winehq.org/WineOn64bit. Whenever I try to debug an application using winedbg I get the following error message: > /var/chroot/usr/local/bin/winedbg ~/.wine/drive_c/windows/system32/notepad.exe err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\notepad.exe" failed, status c0000022 WineDbg starting on pid 0023 couldn't load main module (2) Process of pid=0023 has terminated This is the output when the same command is run with WINEDEBUG=warn+all: http://pastebin.com/RjErdbt8. My source tree is synced to git commit 020a68e1350eaf7293718732c1c9203e460709c6. Has anyone had success debugging Windows applications on 64-bit Linux? Thanks, John Edmonds

3 2

Re: [PATCH 3/5] wined3d: Don't use GL_EXTCALL for WGL extension functions.
by Henri Verbeet 22 Jul '12

22 Jul '12

Actually, ignore this one, it shouldn't be needed anymore.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA. (try 2)
by Nikolay Sivov 20 Jul '12

20 Jul '12

On 7/20/2012 16:02, Roman Dadkov wrote: > This patch adds additional check for the returned results in the test > for the function WNetGetUniversalNameA. > The following cases are checked: > 1 transmission of an incorrect buffer size > 2 transmission of an incorrect buffer pointer > 3 transmission path to the file > Similar checks are carried out to call a function with parameter > REMOTE_NAME_INFO_LEVEL. > > + fail_size = sizeof(driveA) / sizeof(char) - 1; // buffer size is less than the path I don't know if this will be accepted as is, but anyway don't use cpp style comments in future. > + if(drive_type == DRIVE_REMOTE) > + todo_wine ok(ret == WN_NO_ERROR, "WNetGetUniversalNameW failed: %08x\n", ret); > + else > + todo_wine ok(ret == ERROR_NOT_CONNECTED, "WNetGetUniversalNameW gave wrong error: %08x\n", ret); > This is mostly matter of taste but in such cases you can use todo_wine {} and place all test call inside.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA. (try 2)
by Marvin 20 Jul '12

20 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20185 Your paranoid android. === W2KPROSP4 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === WXPPROSP3 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W2K3R2SESP2 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === WVISTAADM (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PRO (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PROX64 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === TEST64_W7SP1 (32 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === W7PROX64 (64 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca === TEST64_W7SP1 (64 bit mpr) === mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca mpr.c:121: Test failed: WNetGetUniversalNameA failed: 000008ca

1 0

Re: gdiplus: Set actual resolution of a being encoded image.
by Vincent Povirk 20 Jul '12

20 Jul '12

Looks good, thanks.

1 0

Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA.
by Marvin 19 Jul '12

19 Jul '12

1 0

Re: fusion: Don't assume a specific compiler behaviour
by Ruslan Kabatsayev 19 Jul '12

19 Jul '12

Hello, > Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. No, it's not compilers, it's intel's "shr" instruction behavior: it masks bit count lower 5 bits, thus making 33 effectively 1. Corresponding ARM instruction most likely does true 33 bit shift giving you zero result. Regards, Ruslan PS I didn't look at types your patch works on, but be careful to not mess up 64 bit types this way. On Thu, Jul 19, 2012 at 11:49 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > maybe it's some braindamage by me, but when i is greater or equal to 32 a shift of HighPart by e.g. 33 doesn't make much sense. For some reason this works on x86 but not on ARM. Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. > If i'm right i don't want to know how much places there are in Wine with assumptions like this, i'll most likely find them with the testsuite on ARM, but i's quite hard to get to the point where you see them... > --- > dlls/fusion/assembly.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/fusion/assembly.c b/dlls/fusion/assembly.c > index d04ba73..8e6bfcb 100644 > --- a/dlls/fusion/assembly.c > +++ b/dlls/fusion/assembly.c > @@ -506,7 +506,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 0; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > assembly->numtables++; > } > @@ -522,7 +522,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 0; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > assembly->tables[i].rows = assembly->numrows[offidx]; > offidx++; > @@ -534,7 +534,7 @@ static HRESULT parse_clr_tables(ASSEMBLY *assembly, ULONG offset) > for (i = 1; i < MAX_CLR_TABLES; i++) > { > if ((i < 32 && (assembly->tableshdr->MaskValid.u.LowPart >> i) & 1) || > - (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> i) & 1)) > + (i >= 32 && (assembly->tableshdr->MaskValid.u.HighPart >> (i-32)) & 1)) > { > currofs += get_table_size(assembly, previ) * assembly->numrows[offidx - 1]; > assembly->tables[i].offset = currofs; > -- > 1.7.4.1 > > > -- > > Best Regards, André Hentschel > > >

2 1

Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.
by Austin English 19 Jul '12

19 Jul '12

On Wed, Jul 18, 2012 at 6:33 PM, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Without this patch, Internet Explorer 6 produces a lot of messages like > "fixme:wininet:InternetCanonicalizeUrlW Unhandled flags 0x04000000" > > Wine's wininet.h was missing ICU_ENCODE_PERCENT, which is present in > the wininet.h from the Windows 7 SDK. > > Wine previously treated ICU_ESCAPE like ICU_DECODE. This is incorrect, > MSDN and empirical tests agree that ICU_ESCAPE should be ignored: > http://msdn.microsoft.com/en-us/library/windows/desktop/aa384342(v=vs.85).a… > https://testbot.winehq.org/JobDetails.pl?Key=20155 Why didn't you include the tests in the patch? -- -Austin

2 2

Re: [1/2]usp10: cache OUTLINETEXTMETRICW instead of just TEXTMETRICW
by Dmitry Timoshkov 19 Jul '12

19 Jul '12

Aric Stewart <aric(a)codeweavers.com> wrote: > + sc->tm = heap_alloc(size); > + GetOutlineTextMetricsW(hdc, size, sc->tm); otmSize exists for a reason, if GetOutlineTextMetrics currently doesn't check it this doesn't mean it won't at some point in future. -- Dmitry.

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2012