wine-devel June 2014

wine-devel@winehq.org

43 participants
148 discussions

Re: [PATCH 2/3] mmdevapi: Don't stop sending event signals after IAudioClient::Stop
by Marvin 27 Jun '14

27 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7740 Your paranoid android. === w7u (32 bit capture) === capture.c:427: Test failed: Wait(event) after Stop gave 102 === w8 (32 bit capture) === capture.c:228: Test failed: Position 1655 expected 823 capture.c:256: Test failed: Position 1655 expected 823 capture.c:307: Test failed: expect DISCONTINUITY 0 capture.c:313: Test failed: Position 2103 gap 832 capture.c:333: Test failed: Position 3063 expected 1719 capture.c:334: Test failed: flags 1 capture.c:358: Test failed: Position 4215 expected 2167 === w7u (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.501088 render.c:2005: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1976: Test failed: Got wrong volume: 0.671337 render.c:2005: Test failed: Got wrong volume: 0.671337

1 0

Re: [PATCH 1/4] vbscript: Implemented TypeName(try 4)
by Piotr Caban 27 Jun '14

27 Jun '14

This patch was already committed. Please update wine source before sending patches. Cheers, Piotr

2 1

Re: [PATCH 2/5] d3d8/tests: Add some lost device tests.
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [PATCH 4/4] vbscript: Implemented Abs(try 4)
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [PATCH 3/4] vbscript: Implemented Sgn(try 4)
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [PATCH 2/4] vbscript: Implemented VarType(try 4)
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [PATCH 1/4] vbscript: Implemented TypeName(try 4)
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [2/7] advapi32: Changed an invalid comment
by Marvin 27 Jun '14

27 Jun '14

1 0

Re: [PATCH 4/4] vbscript: Implemented Abs(try 4)
by Piotr Caban 27 Jun '14

27 Jun '14

On 06/27/14 04:44, Shuai Meng wrote: > static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + double v; > + HRESULT hres; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + > + if(V_VT(arg) == VT_NULL) > + return return_null(res); > + > + hres = to_double(arg, &v); > + if (FAILED(hres)) > + return hres; > + > + if(res) { > + V_VT(res) = VT_R8; > + V_R8(res) = v >= 0 ? v : -v; > + } > + return S_OK; > } You can use return_double helper here. Also there are 2 newlines after assert.

1 0

Re: [PATCH 2/4] vbscript: Implemented VarType(try 4)
by Piotr Caban 27 Jun '14

27 Jun '14

On 06/27/14 04:40, Shuai Meng wrote: > + if(res) { > + V_VT(res) = VT_I2; > + V_I2(res) = V_VT(arg); > + } > + return S_OK; You can use return_short helper here.

1 0

← Newer
1
2
3
4
5
6
7
...
15
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2014