Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23875
Your paranoid android.
=== w864 (32 bit rpc) ===
rpc.c:815: Test failed: GUID does not appear to contain a MAC address: {6eb1cf99-3c79-11e6-be78-e71666c2e04a}
=== w864 (64 bit rpc) ===
rpc.c:815: Test failed: GUID …
[View More]does not appear to contain a MAC address: {f4f8b15d-3c7a-11e6-be78-e71666c2e04a}
[View Less]
On Sun, Jun 26, 2016 at 11:42:31AM +0200, Thomas Faber wrote:
> From e80a75cfe223a82eea4c55874975e54de4981282 Mon Sep 17 00:00:00 2001
> From: Thomas Faber <thomas.faber(a)reactos.org>
> Date: Sun, 26 Jun 2016 10:59:08 +0200
> Subject: wordpad: Avoid buffer overrun in registry_set_filelist.
>
> Signed-off-by: Thomas Faber <thomas.faber(a)reactos.org>
> ---
> programs/wordpad/registry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> …
[View More]diff --git a/programs/wordpad/registry.c b/programs/wordpad/registry.c
> index bf2af5b..e047f37 100644
> --- a/programs/wordpad/registry.c
> +++ b/programs/wordpad/registry.c
> @@ -298,7 +298,7 @@ void registry_set_filelist(LPCWSTR newFile, HWND hMainWnd)
> if(!lstrcmpiW(pFiles[i], newFile))
> {
> int j;
> - for(j = 0; pFiles[j] && j < i; j++)
> + for(j = 0; j < i && pFiles[j]; j++)
> {
> pFiles[i-j] = pFiles[i-j-1];
> }
This looks odd to me. I don't see how this could avoid an overflow;
pFiles[i] is valid at this point and so pFiles[j] will be ok if j == i.
More confusingly though, is why pFiles[j] is in the test at all.
Huw.
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23872
Your paranoid android.
=== w1064 (64 bit device) ===
device.c:4348: Test failed: cw is 0xf60, expected 0x7f.
device.c:4357: Test failed: Callback cw is 0xf60, expected 0x7f.
Folks,
I'll be out on vacation next week, so there won't be any commits. Feel
free to keep sending patches, I'll try to catch up when I get back, and
make the next release on schedule two weeks from now.
--
Alexandre Julliard
julliard(a)winehq.org
On 23 June 2016 at 13:29, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote:
> This trades some memory for speed, but since currently selecting
> 1000 files takes over a minute but the required memory for those
> 1000 filenames is only 262 kB (worst case), this seems a reasonable
> trade-off.
>
That's probably fine, but is there any reason this can't use the
standard approach of just doubling the buffer size when you run out of
space?
If this is performance critical code, the …
[View More]multiple copies of the
string related to GetName() probably don't help either.
[View Less]
On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> + switch (desc->ViewDimension)
> + {
> + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY:
> + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count)
I noticed too late for the other normalisation functions, but
"ArraySize" is unsigned.
On Jun 23, 2016, at 11:15 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
>
> diff --git a/dlls/msvcp120/tests/msvcp120.c b/dlls/msvcp120/tests/msvcp120.c
> index 7c94906..354b2d3 100644
> --- a/dlls/msvcp120/tests/msvcp120.c
> +++ b/dlls/msvcp120/tests/msvcp120.c
> @@ -592,7 +592,7 @@ static void test_xtime_get(void)
> diff = p__Xtime_diff_to_millis2(&after, &before);
>
> ok(diff >= tests[i],
> - "xtime_get() …
[View More]not functioning correctly, test: %d, expect: ge %d, got: %d\n",
> + "xtime_get() not functioning correctly, test: %d, expect: %d, got: %d\n",
> i, tests[i], diff);
> }
Too late on this one, but I think the "ge" was supposed to mean "greater than or equal to", given the actual test being performed. Probably best to replace it with ">=".
-Ken
[View Less]
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23833
Your paranoid android.
=== w1064 (32 bit locale) ===
locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name
locale.c:2371: Test failed: unexpected error code -559038737
locale.c:2462: Test failed: …
[View More]Expected lcid == 0, got got 00001000, error -559038737
locale.c:4192: Test failed: IsValidLocaleName should have failed
locale.c:4194: Test failed: IsValidLocaleName should have failed
locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87
locale.c:4579: Test failed: For id 7, Expected IVC, got ''
=== w1064 (64 bit locale) ===
locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name
locale.c:2371: Test failed: unexpected error code -559038737
locale.c:2462: Test failed: Expected lcid == 0, got got 00001000, error -559038737
locale.c:4192: Test failed: IsValidLocaleName should have failed
locale.c:4194: Test failed: IsValidLocaleName should have failed
locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87
locale.c:4579: Test failed: For id 7, Expected IVC, got ''
[View Less]