wine-devel June 2016

wine-devel@winehq.org

52 participants
219 discussions

Re: msvcrt: Implement _wperror
by Piotr Caban 21 Jun '16

21 Jun '16

On 06/21/16 10:09, Hugh McMaster wrote: > dlls/msvcrt/msvcrt.spec | 2 +- > 2 files changed, 36 insertions(+), 1 deletion(-) Please also update other msvc*/ucrtbase spec files as well. > /********************************************************************* > + * _wperror (MSVCRT.@) > + */ > +void CDECL MSVCRT__wperror(const MSVCRT_wchar_t* str) > +{ > + int err, size, len; > + static const WCHAR colon_spaceW[] = {':',' ',0}; > + static const WCHAR newlineW[] = {'\n',0}; > + MSVCRT_wchar_t *buffer = NULL; > + > + err = *MSVCRT__errno(); > + if (err < 0 || err > MSVCRT__sys_nerr) err = MSVCRT__sys_nerr; > + > + size = MultiByteToWideChar(CP_ACP, 0, MSVCRT__sys_errlist[err], -1, NULL, 0) + 1 /* add \n */; > + > + if (str && *str) > + size += lstrlenW(str) + 2; /* add str length, colon and space */ > + > + buffer = MSVCRT_malloc(size * sizeof(MSVCRT_wchar_t)); > + if (!buffer) return; > + > + if (str && *str) > + { > + lstrcpyW(buffer, str); > + lstrcatW(buffer, colon_spaceW); > + } > + else buffer[0] = 0; > + > + len = lstrlenW(buffer); > + MultiByteToWideChar(CP_ACP, 0, MSVCRT__sys_errlist[err], -1, buffer + len, size - len); > + lstrcatW(buffer, newlineW); > + MSVCRT__write(2, buffer, lstrlenW(buffer) * sizeof(MSVCRT_wchar_t)); > + MSVCRT_free(buffer); > +} This is not how the function works. It shouldn't print wchar_t string to stderr. Probably the simplest implementation is to convert input parameter and call _perror (CP_ACP is not the correct encoding, you can use MSVCRT_wcstombs). Thanks, Piotr

2 3

Re: Fix overflow when left-shifting
by Dmitry Timoshkov 21 Jun '16

21 Jun '16

Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > Subject: [PATCH] widi: Fix overflow when left-shifting The tool name is 'widl'. -- Dmitry.

1 0

Re: [PATCH v2] jscript: Properly handle arguments in Object constructor.
by Marvin 20 Jun '16

20 Jun '16

1 0

Re: jscript: Properly handle arguments in Object constructor.
by Marvin 20 Jun '16

20 Jun '16

1 0

Re: [PATCH 1/2] winex11: fix gl drawable type
by Alexandre Julliard 20 Jun '16

20 Jun '16

Miklós Máté <mtmkls(a)gmail.com> writes: > @@ -1344,7 +1344,7 @@ static BOOL create_gl_drawable( HWND hwnd, struct gl_drawable *gl ) > > if (data) > { > - gl->type = DC_GL_WINDOW; > + gl->type = DC_GL_CHILD_WIN; This can't possibly work, top-level windows and child windows have to be treated differently. -- Alexandre Julliard julliard(a)winehq.org

2 2

Images in MyHeritage Family Tree Builder
by Stephen Davies 20 Jun '16

20 Jun '16

I am running WINE 1.9.11 (Staging) under Fedora 22. I have been running the MyHeritage Family Tree Builder V7 product on this box for several years without issue but recently (last month perhaps), FTB is no longer able to display JPEG photographs. The JPEG files exist in the relevant directory but they all display as blank images. FTB has not changed but there have been numerous updates to F22 and to WINE suggesting that this may be the cause. Can anybody throw any light on what may have happened? Cheers and thanks, Stephen

3 4

Re: comctl32/tests: Use EqualRect() instead of memcmp() to compare RECTs.
by Marvin 20 Jun '16

20 Jun '16

1 0

Re: d3d8/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin 20 Jun '16

20 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23732 Your paranoid android. === w8 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:7573: Test failed: Got unexpected hr 0. device.c:7575: Test failed: Got unexpected hr 0. === w1064 (32 bit device) === device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 2/5] d3drm: Add stubs for IDirect3DRMFrame interface. (v5)
by Henri Verbeet 20 Jun '16

20 Jun '16

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > +static HRESULT WINAPI d3drm_frame1_AddChild(IDirect3DRMFrame *iface, IDirect3DRMFrame *child) > +{ > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface); > + struct d3drm_frame *child_frame = unsafe_impl_from_IDirect3DRMFrame(child); > + > + TRACE("iface %p, child %p.\n", iface, child); > + > + if (!child_frame) > + return D3DRMERR_BADOBJECT; That's redundant, d3drm_frame3_AddChild() already takes care of that.

2 6

Re: [PATCH] msi: allocate correct buffer size (Coverity)
by Hans Leidekker 20 Jun '16

20 Jun '16

On Sat, 2016-06-18 at 10:02 +0200, Marcus Meissner wrote: > 713180 Out-of-bounds access > 713179 Out-of-bounds access > > We pass in a size of 1 character more to MBtoWC than we allocated earlier. No, Coverity doesn't see that MsiEnumComponentsExW and MsiEnumProductsExW return size excluding the terminating null.

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2016