wine-devel June 2016

wine-devel@winehq.org

52 participants
219 discussions

Re: ws2_32: Ensure default route IP addresses are returned first in gethostbyname
by Marvin 19 Jun '16

19 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23725 Your paranoid android. === w7pro64 (64 bit sock) === sock.c:7738: Test failed: bytesReturned isn't supposed to be 1 sock.c:7784: Test failed: Waiting for timeout failed with 0 + errno 997

1 0

Re: [PATCH 5/5] d3drm/tests: Modify all QI tests to compare vtables. (resend)
by Henri Verbeet 19 Jun '16

19 Jun '16

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + { &IID_IUnknown, &IID_IUnknown, NULL, S_OK }, Is the NULL "vtable_iid" here intentional?

2 2

WineConf 2016
by Michael Stefaniuc 19 Jun '16

19 Jun '16

Hello guys, it's that time of the year again where we start thinking about the next WineConf. Last year would already have been the turn for North America so the next WineConf will happen definitely there. Jeremy White / CodeWeavers, as always, was very generous and offered to host it in Minneapolis (or was it St. Paul? ;). But if you're in US / Canada and really hoped to host the next WineConf now is your time to speak up! The Twin Cities are beautiful at -30 C but we wouldn't mind seeing other places too. bye michael

4 4

Re: [PATCH 4/5] d3drm: Fix viewport object creation. (resend)
by Henri Verbeet 19 Jun '16

19 Jun '16

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > @@ -861,10 +863,19 @@ static HRESULT WINAPI d3drm2_CreateShadow(IDirect3DRM2 *iface, IDirect3DRMVisual > FIXME("iface %p, device %p, camera %p, x %u, y %u, width %u, height %u, viewport %p partial stub!\n", > - iface, device, camera, x, y, width, height, viewport); > + iface, device, camera, x, y, width, height, viewport); I thought that was fine the way it was. > -HRESULT Direct3DRMViewport_create(REFIID riid, IUnknown **out) > +HRESULT d3drm_viewport_create(struct d3drm_viewport **viewport, IDirect3DRM *d3drm) > { > struct d3drm_viewport *object; > > - TRACE("riid %s, out %p.\n", debugstr_guid(riid), out); > + TRACE("out %p, d3drm %p.\n", viewport, d3drm); "viewport"

1 0

Re: [PATCH 3/5] d3drm: Fix frame object creation method. (v3 resend)
by Henri Verbeet 19 Jun '16

19 Jun '16

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/d3drm_private.h b/dlls/d3drm/d3drm_private.h > index 817accf..1f4094b 100644 > --- a/dlls/d3drm/d3drm_private.h > +++ b/dlls/d3drm/d3drm_private.h > @@ -44,6 +44,27 @@ struct d3drm_texture > D3DRMIMAGE *image; > }; > > +struct d3drm_frame > +{ > + IDirect3DRMFrame IDirect3DRMFrame_iface; > + IDirect3DRMFrame2 IDirect3DRMFrame2_iface; > + IDirect3DRMFrame3 IDirect3DRMFrame3_iface; > + IDirect3DRM *d3drm; > + LONG ref; > + struct d3drm_frame *parent; > + ULONG nb_children; > + ULONG children_capacity; > + IDirect3DRMFrame3** children; > + ULONG nb_visuals; > + ULONG visuals_capacity; > + IDirect3DRMVisual** visuals; > + ULONG nb_lights; > + ULONG lights_capacity; > + IDirect3DRMLight** lights; > + D3DRMMATRIX4D transform; > + D3DCOLOR scenebackground; > +}; "IDirect3DRMFrame3 **children", "IDirect3DRMVisual **visuals" and "IDirect3DRMLight **lights". > @@ -51,11 +72,11 @@ void d3drm_object_cleanup(IDirect3DRMObject *iface, struct d3drm_object *object) > > HRESULT d3drm_device_create(struct d3drm_device **out) DECLSPEC_HIDDEN; > HRESULT d3drm_texture_create(struct d3drm_texture **texture, IDirect3DRM *d3drm) DECLSPEC_HIDDEN; > +HRESULT d3drm_frame_create(struct d3drm_frame **frame, IUnknown* parent_frame, IDirect3DRM *d3drm) DECLSPEC_HIDDEN; "IUnknown *parent_frame". > -HRESULT Direct3DRMFrame_create(REFIID riid, IUnknown *parent, IUnknown **out) > +HRESULT d3drm_frame_create(struct d3drm_frame **frame, IUnknown* parent_frame, IDirect3DRM *d3drm) Like above. > { > struct d3drm_frame *object; > - HRESULT hr; > + HRESULT hr = D3DRM_OK; > > - TRACE("riid %s, parent %p, out %p.\n", debugstr_guid(riid), parent, out); > + TRACE("out %p, parent_frame %p, d3drm %p.\n", frame, parent_frame, d3drm); "frame" instead of "out". > + if (parent_frame) > { > IDirect3DRMFrame3 *p; > > - hr = IDirect3DRMFrame_QueryInterface(parent, &IID_IDirect3DRMFrame3, (void**)&p); > + hr = IDirect3DRMFrame_QueryInterface(parent_frame, &IID_IDirect3DRMFrame3, (void**)&p); > if (hr != S_OK) "if (FAILED(hr = ...))" and "(void **)".

1 0

Re: [PATCH 1/4] d3drm: Add stubs for IDirect3DRMFrame interface. (v4)
by Henri Verbeet 17 Jun '16

17 Jun '16

On 17 June 2016 at 09:38, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v4: Replaced GetVisuals, GetParent and GetTransform with thunks to version 2. > > v3: Added version 1->3 thunks for only those frame1 methods that have tests (see test_Frame). The rest will be stubs returning E_NOTIMPL. Also avoid the use of QI in Add/DeleteChild. > Doesn't that potentially break currently working applications? And while having tests is great, I'm not sure I agree with the premise that it's better to return E_NOTIMPL than to forward to an implementation that may have subtle differences but probably doesn't in most cases. > +static HRESULT WINAPI d3drm_frame1_QueryInterface(IDirect3DRMFrame *iface, REFIID riid, void **out) > +{ > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface); > + > + TRACE("iface %p, riid %s, out %p.\n", iface, debugstr_guid(riid), out); > + > + return IDirect3DRMFrame3_QueryInterface(&frame->IDirect3DRMFrame3_iface, riid, out); > +} This may have come up before, but any reason you can't call d3drm_frame3_QueryInterface() directly here?

3 5

Re: [PATCH] msscript: Implement FindConnectionPoint()
by Jacek Caban 17 Jun '16

17 Jun '16

Hi Nikolay, On 06/16/2016 09:20 PM, Nikolay Sivov wrote: > +struct ConnectionPoint { > + IConnectionPoint IConnectionPoint_iface; > + ScriptControl *control; > + IConnectionPointContainer *container; Do you need to store IConnectionPointContainer here if you also store ScriptControl? Other than that the patch looks good to me. Thanks, Jacek

1 0

Re: [PATCH 3/5] d3drm/tests: Add refcount tests for IDirect3DRMFrame*. (v2)
by Stefan Dösinger 17 Jun '16

17 Jun '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-16 um 00:23 schrieb Aaryaman Vasishta: > This might be a stupid question, but by the full blown QI + > refcounting tests, did you mean what test_frame_qi does? Because > those tests are already present upstream. Yeah, this test is perfectly fine for testing frame refcount links. You can just drop patch 3/5. (I've re-CCed wine-devel) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXYxntAAoJEN0/YqbEcdMw9HMP/0kwOc2M6z3bchxsxYJQAF77 ao8uYZvOjkz2Kzp3XGaRMuja2H55qpvNFe0JGmi3pHnGaNQ5SY2s4nqmYFjgUB3u +PNXAXGspalI/1Hx2dFuFYpjZ0FxUA3kaqQeyloBn3zjycb+XtRohQbyv0LOnrDb hRck+jyPpszjDbQruHBRh7Q1VnFMPQXjayfbrY6VhQnxvVKt2aY7mA/fmqRltfwF 9XKOMekT5zoNufjb1ll6+558Nl/+cek37sDr2d09WOO/hlfeovEKKqnYJfucV/bS ZNKN31JFx94KAFaG/JsIiLwS+lJq2bU92ZHWpkQc6CbcRcm8nOFMtZQ9EPh3iRqW ou2i00/UMBXwhoNMOq6yAI6FG6CvUyf7HKqEKhWyJHtaiJ85/ZPgtT+xqOvNSld8 9O54r1JbaDJ5SIQaDiIGc/XmyMot0hLjGMu5l9r/bIF+XTfsP8Bjge+hHe28yaL+ h7qwKWMes52DWxW1BHv6NTFRm1GAuSFaTz5QCyp1zNWegOqS05tmEWjISQ79871g urJg0XcEiKvftx7irWDUOM8gPAOKgSfxfFsVc0zMTJcFRUm6h5tFXld6nDYG7oMy KXU7guPKOdaW2KBM2mqYBUy6yXmAZ5fJXRRvl0Ai/fatvqoH+6RdNwVhEe1DL+BH 4zWH/+UP6vfFOXvAVHpk =hG2j -----END PGP SIGNATURE-----

2 1

IMM / IME work
by Aric Stewart 16 Jun '16

16 Jun '16

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: [PATCH 5/5] mshtml: Added IHTMLButtonElement::form property implementation.
by Marvin 16 Jun '16

16 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23683 Your paranoid android. === build (build) === Patch failed to apply

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel June 2016