wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Winelib stack overflow
by Vitor Ramos 07 Nov '22

07 Nov '22

Hello, I am not sure if this is the appropriate channel but here we go. I am trying to port a windows c++ application using winelib and I found an issue while using some c++ STL containers. Here is a minimal example: # winelib.dll.so ```c++ #include <windows.h> #include <unordered_map> #include <string> extern "C" int f1(long z) { std::unordered_map<int, std::string> y; return 10; } spec file ```c++ 2 stdcall f1(long) ``` # Building winelib.dll.so winemaker --console --dll . winebuild --implib -E winedll.spec -o libwinedll.a winebuild --fake-module --dll -E winedll.spec -o winedll.dll make cp libwinedll.a winedll.dll.so /usr/local/lib/wine/x86_64-unix cp winedll.dll /home/$USER/.wine/drive_c/windows/system32 win64 app ```c++ #include <iostream> extern "C"{ int f1(long z); } int main(){ int ret = f1(2); std::cout << ret << std::endl; } ``` # Building win64 app winemaker . -iwinedll make # Running wine64 win64app.exe.so # Output 0110:err:virtual:virtual_setup_exception stack overflow 2128 bytes in thread 0110 addr 0x17008c804 stack 0x207b0 (0x20000-0x21000-0x120000) If I remove the "std::unordered_map<int, std::string> y" from the custom lib it runs normally. I suspect that wine uses too much of the stack to construct the object, but it's just a wild guess. Does anybody know what the issue could be? Is it possible to increase the stack size? Thanks.

3 4

TestBot News
by Francois Gouget 07 Nov '22

07 Nov '22

* The TestBot has a new Windows 11 VM. It's a new Windows version so it has almost 40 extra failures. To avoid false positives it's only going to be running WineTest until the new failures have been flagged. But you can already select it in the list of available VMs to run tests on it. * There are now two PCI-Passthrough configurations: - w11pro64_amd -> AMD RX6600 GPU - w11pro64_nv -> NVIDIA RTX3050 GPU These have a surprising number of extra failures, about 12, when fgtb-w10pro64-rx550 only has about 2 extra failures. So I will recheck the configuration of the new VMs (on the AMD side it may have the clipboard problem again, but then a number of failures appeared to be in the d3d tests). These are also only running WineTest for now so as to not cause false positives but you can select them in the list of available VMs. -- Francois Gouget <fgouget(a)codeweavers.com>

1 2

invalid read errno bug
by xantares09＠hotmail.com 01 Nov '22

01 Nov '22

Hello, I'm hoping to get more attention for this bug report that have not been confirmed yet: https://bugs.winehq.org/show_bug.cgi?id=53677 Everything should be provided to ease reproducing, Regards

1 0

Wine staging 7.20 release
by Alistair Leslie-Hughes 01 Nov '22

01 Nov '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.20 (504 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * sapi: Implement ISpObjectToken OpenKey * sapi: EnumTokens setup enumeration members * sapi: Implement ISpObjectTokenEnumBuilder Item * sapi: Add default voice registry key * sapi: Return dump object in ISpObjectTokenEnumBuilder Next Added: * None Updated: * nvcuda-CUDA_Support * mfplat-streaming-support Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: ntdll: Fix build on systems without ENODATA (was: [PATCH] ntdll: Complete error case in get_initial_environment)
by Erich E. Hoover 19 Oct '22

19 Oct '22

On Wed, Oct 19, 2022 at 3:05 PM Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > > On Wed, 19 Oct 2022, Erich E. Hoover wrote: > >> https://gitlab.winehq.org/wine/wine/-/merge_requests/1097 > > It looks like this just got merged. Gerald, would you check and see > > if ENOATTR is defined on your system? > > I checked, and FreeBSD (12 and 14, so current and future versions) both > define ENOATTR guarded by #ifndef _POSIX_SOURCE, so generally available. > > > This commit removes the compile warning > > It actually was hard build error. Yes, sorry - I misspoke. > > but you're going to get a lot of unnecessary console warnings > > ("attribute does not exist" is not an error here). > > Is it possible Alexandre's adjusted version of my submission avoids this? > ... No. If the filesystem supports extended attributes (!ENOTSUP) then you will get an error if there aren't any xattr for the file. I suspect that we either want: === #ifdef ENODATA if (errno == ENODATA) return ret; #endif #ifdef ENOATTR if (errno == ENOATTR) return ret; #endif === Or we want to do something like this: === #ifndef ENOATTR #define ENOATTR ENODATA #endif === and then check against ENOATTR instead (little bit of research says that platforms that define both use ENOATTR in this case). Best, Erich

1 0

Re: [PATCH] ntdll: Complete error case in get_initial_environment
by Esme Povirk (any/all) 19 Oct '22

19 Oct '22

> That's more involved than the previous process, but I think I got it: > https://gitlab.winehq.org/gerald/wine/-/commit/2bdbfb583452a62c7d6acf7f416b… > > Is there anything else to do? I found the actual MR at https://gitlab.winehq.org/wine/wine/-/merge_requests/1097, and it looks right to me. Nothing else to do for now, hopefully someone will come along and review it. > PS: It shows the test-linux32 pipeline as failed, while the other two > succeeded; looks like a false positive to the, though. Yes, those errors have been showing up for every MR. -- https://my.pronouns.page/are/any

2 1

Wine staging 7.19 release
by Alistair Leslie-Hughes 17 Oct '22

17 Oct '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.19 (502 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * winegstreamer: Return S_OK from H264 decoder GetAttributes. * Implement retrieving DOS attributes in [fd_]get_file_info(). * ntdll: Implement storing DOS attributes in NtSetInformationFile. * ntdll: Implement storing DOS attributes in NtCreateFile. * sapi: Implement ISpObjectToken GetId * secur32: Input Parameter should be NULL on first call to InitializeSecurityContextW. * sapi: Implement ISpRegDataKey CreateKey * sapi: Implement ISpRegDataKey GetStringValue * ntdll: Improve stub of NtQueryEaFile. * winegstreamer: Reimplement AAC decoder using wg_transform. Added: * None Updated: * ntdll-DOS_Attributes * wined3d-bindless-texture * ntdll-Junction_Points Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: fixing some fixme code
by Jin-oh Kang 16 Oct '22

16 Oct '22

On Mon, Sep 12, 2022, 11:11 AM Owen Hogarth <gurenchan(a)gmail.com> wrote: > Hello guys, I am trying to get this program; R Trader Pro to work on Linux. > I installed winetricks and then I received some different errors. > > I would like to fix the problem but I would also like to avoid doing > unnecessary work, that's why I am asking on the development mailing list. > > Here's the new error log, is it possible to get the program working? > ... > An error occured while contacting the license server. > > Raised in : com.omnesys.omne.om.OMField > Method : OMsetData > Error : no data > Raised in : 31004 1 unknown host 20014 1 unknown addr > > Method : OMaddData > Error : create error > Please contact Omnesys Technologies Inc., at www.omnesys.com. > Please launch the application or the installer with the following command line (without angle brackets): export WINEPREFIX="$HOME/.wine-traderpro-test" # (or whatever wineprefix path you prefer) WINEDEBUG=+winsock wine <path to exe...> Also, please make sure you don't use native DLLs from winetricks when debugging or reporting a bug.

2 8

[PATCH 1/2] qedit/tests: Check the Sample Grabber's buffer during and after flushing.
by Gabriel Ivăncescu 04 Oct '22

04 Oct '22

Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/qedit/tests/samplegrabber.c | 234 +++++++++++++++++++++++++++++++ 1 file changed, 234 insertions(+) diff --git a/dlls/qedit/tests/samplegrabber.c b/dlls/qedit/tests/samplegrabber.c index 8e68e3e..e66180f 100644 --- a/dlls/qedit/tests/samplegrabber.c +++ b/dlls/qedit/tests/samplegrabber.c @@ -1036,6 +1036,239 @@ static void test_connect_pin(void) ok(!ref, "Got outstanding refcount %d.\n", ref); } +struct frame_thread_params +{ + IMemInputPin *sink; + IMediaSample *sample; + DWORD delay; +}; + +static DWORD WINAPI frame_thread(void *arg) +{ + struct frame_thread_params *params = arg; + HRESULT hr; + + if (params->delay) + { + if (winetest_debug > 1) trace("%04x: Sleeping %u ms.\n", GetCurrentThreadId(), params->delay); + Sleep(params->delay); + } + if (winetest_debug > 1) trace("%04x: Sending frame.\n", GetCurrentThreadId()); + hr = IMemInputPin_Receive(params->sink, params->sample); + if (winetest_debug > 1) trace("%04x: Returned %#x.\n", GetCurrentThreadId(), hr); + IMediaSample_Release(params->sample); + free(params); + return hr; +} + +static HANDLE send_frame_time(IMemInputPin *sink, REFERENCE_TIME start_time, unsigned char color, DWORD delay) +{ + struct frame_thread_params *params = malloc(sizeof(*params)); + IMemAllocator *allocator; + REFERENCE_TIME end_time; + IMediaSample *sample; + HANDLE thread; + HRESULT hr; + BYTE *data; + + hr = IMemInputPin_GetAllocator(sink, &allocator); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMemAllocator_GetBuffer(allocator, &sample, NULL, NULL, 0); + if (hr == VFW_E_NOT_COMMITTED) + { + IMemAllocator_Commit(allocator); + hr = IMemAllocator_GetBuffer(allocator, &sample, NULL, NULL, 0); + } + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMediaSample_GetPointer(sample, &data); + ok(hr == S_OK, "Got hr %#x.\n", hr); + memset(data, 0x55, 32 * 16 * 2); + + hr = IMediaSample_SetActualDataLength(sample, 32 * 16 * 2); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + start_time *= 10000000; + end_time = start_time + 10000000; + hr = IMediaSample_SetTime(sample, &start_time, &end_time); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + params->sink = sink; + params->sample = sample; + params->delay = delay; + thread = CreateThread(NULL, 0, frame_thread, params, 0, NULL); + + IMemAllocator_Release(allocator); + return thread; +} + +static HANDLE send_frame(IMemInputPin *sink, DWORD delay) +{ + return send_frame_time(sink, 0, 0x55, delay); /* purple */ +} + +static HRESULT join_thread_(int line, HANDLE thread) +{ + DWORD ret; + ok_(__FILE__, line)(!WaitForSingleObject(thread, 1000), "Wait failed.\n"); + GetExitCodeThread(thread, &ret); + CloseHandle(thread); + return ret; +} +#define join_thread(a) join_thread_(__LINE__, a) + +static void test_buffer_flush(void) +{ + AM_MEDIA_TYPE req_mt = + { + .majortype = MEDIATYPE_Video, + .subtype = MEDIASUBTYPE_RGB565, + .formattype = FORMAT_VideoInfo, + .bTemporalCompression = TRUE, + }; + LONG buf[(32 * 16 * 2) / sizeof(LONG)], size = sizeof(buf); + IPin *sink, *source, *renderer_pin; + struct testfilter testsource; + ISampleGrabber *grabber; + IMediaControl *control; + IFilterGraph2 *graph; + IMemInputPin *input; + IBaseFilter *filter; + OAFilterState state; + IMediaFilter *mf; + HANDLE thread; + DWORD ticks; + unsigned i; + HRESULT hr; + ULONG ref; + + testfilter_init(&testsource); + CoCreateInstance(&CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER, + &IID_IFilterGraph2, (void **)&graph); + CoCreateInstance(&CLSID_NullRenderer, NULL, CLSCTX_INPROC_SERVER, + &IID_IBaseFilter, (void **)&filter); + IFilterGraph2_AddFilter(graph, filter, L"sink"); + IBaseFilter_FindPin(filter, L"In", &renderer_pin); + IBaseFilter_Release(filter); + + filter = create_sample_grabber(); + IFilterGraph2_AddFilter(graph, &testsource.filter.IBaseFilter_iface, L"source"); + IFilterGraph2_AddFilter(graph, filter, L"sample grabber"); + IBaseFilter_FindPin(filter, L"In", &sink); + IBaseFilter_FindPin(filter, L"Out", &source); + IBaseFilter_QueryInterface(filter, &IID_ISampleGrabber, (void **)&grabber); + IFilterGraph2_QueryInterface(graph, &IID_IMediaControl, (void **)&control); + IPin_QueryInterface(sink, &IID_IMemInputPin, (void **)&input); + + ISampleGrabber_SetMediaType(grabber, &req_mt); + ISampleGrabber_SetBufferSamples(grabber, TRUE); + + testsource.sink_mt = &req_mt; + hr = IFilterGraph2_ConnectDirect(graph, &testsource.source.pin.IPin_iface, sink, &req_mt); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IFilterGraph2_ConnectDirect(graph, source, renderer_pin, &req_mt); + ok(hr == S_OK, "Got hr %#x.\n", hr); + IPin_Release(renderer_pin); + + IFilterGraph2_QueryInterface(graph, &IID_IMediaFilter, (void **)&mf); + IMediaFilter_SetSyncSource(mf, NULL); + IMediaFilter_Release(mf); + + hr = IMemInputPin_ReceiveCanBlock(input); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == VFW_E_WRONG_STATE, "Got hr %#x.\n", hr); + + hr = IMediaControl_Pause(control); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 0, &state); + ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + thread = send_frame(input, 0); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(WaitForSingleObject(thread, 100) == WAIT_TIMEOUT, "Thread should block in Receive().\n"); + + for (i = 0; i < 3; i++) + { + ticks = GetTickCount(); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + } + + hr = IMediaControl_Stop(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = join_thread(thread); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(state == State_Stopped, "Got state %d.\n", state); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMediaControl_Pause(control); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 0, &state); + ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + thread = send_frame(input, 0); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(WaitForSingleObject(thread, 100) == WAIT_TIMEOUT, "Thread should block in Receive().\n"); + + for (i = 0; i < 3; i++) + { + ticks = GetTickCount(); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + } + + IPin_BeginFlush(sink); + hr = join_thread(thread); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == S_OK, "Got hr %#x.\n", hr); + IPin_EndFlush(sink); + + hr = IMediaControl_GetState(control, 0, &state); + todo_wine ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + ticks = GetTickCount(); + thread = send_frame(input, 150); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IMediaControl_Stop(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = join_thread(thread); + todo_wine ok(hr == S_OK, "Got hr %#x.\n", hr); + + IPin_Release(sink); + IPin_Release(source); + IMemInputPin_Release(input); + IMediaControl_Release(control); + ref = IFilterGraph2_Release(graph); + ok(!ref, "Got outstanding refcount %d.\n", ref); + ISampleGrabber_Release(grabber); + ref = IBaseFilter_Release(filter); + ok(!ref, "Got outstanding refcount %d.\n", ref); + ref = IBaseFilter_Release(&testsource.filter.IBaseFilter_iface); + ok(!ref, "Got outstanding refcount %d.\n", ref); +} + START_TEST(samplegrabber) { IBaseFilter *filter; @@ -1059,6 +1292,7 @@ START_TEST(samplegrabber) test_aggregation(); test_media_types(); test_connect_pin(); + test_buffer_flush(); CoUninitialize(); } -- 2.21.0

5 7

WineConf - starting next week!
by Jeremy White 29 Sep '22

29 Sep '22

Hi folks, We are excited to welcome you in person to the 2022 Wine Conference, held in conjunction with the X.org developers conference (XDC) and the FOSS XR conference. The XDC conference will start on Tuesday morning, October 4th. The program is here: https://indico.freedesktop.org/event/2/timetable/#all.detailed The official events start at 8:30 am, but we will have coffee and pastries available from 7:30 on Tuesday and 8 on Wednesday and Thursday. WineConf proper will start on Wednesday morning, October 5th, with Alexandre's keynote. We expect everyone attending to be vaccinated and to be respectful of people that are trying to avoid catching COVID. Masks are mandatory, except when presenting or eating. The plan is to gather at Brit's Pub, both Monday and Tuesday in the late afternoon to welcome arrivals. We’ll try to have a table with some sort of a sign, and folks can connect, have a drink, and then perhaps group up to explore alternate food. Note that if the weather is nice, we may be up on the roof, so explore far to find us. We will be on the Minneapolis campus of St. Thomas, which is a mildly confusing campus. We have given instructions and a picture to guide you here: https://indico.freedesktop.org/event/2/page/10-attending-xdc-wineconf-foss-… We are working on the remote experience, and expect to have streaming of all events available. The above page will have those details just as soon as they are finalized. We have a page of instructions for folks that will be presenting: https://indico.freedesktop.org/event/2/page/18-speaker-instructions We are also excited to announce the happy hour taking place on Wednesday, from 6:00 pm until 8:00 pm. The hope is that all three projects can mingle and socialize and enjoy the return of in person meetings. We will again use a Matrix chat room just for the conference. Matrix has a variety of apps, and Element, the default one is easy to configure on many devices, including mobile phones. The link to that channel is here: https://matrix.to/#/#xdc-wineconf-fossxr-2022:matrix.org We find the chat channel a good place to learn what restaurants and bars are chosen, and just a good way to track the social aspects of the conference. We look forward to seeing you next week! Cheers, Jeremy

1 0

Winelib portability on USB booted system
by Brent Burkholder 29 Sep '22

29 Sep '22

We had originally tried a software port using winelib 5, and it was just a no-go in functionality. Wine 7 is working a LOT better for what we're doing (Windows GUI with ability to do low level Linux hooks), so thank you all for all of the hard work! Unfortunately, even though the software is running great on our development machine, when I try to run it on another system (configured USB boot, should have the same version of wine, etc) it doesn't run at all with pretty much no feedback. Can anyone help me understand why, or what I need to be looking for? Both systems are starting with the same script (I've done a lot of variations, directly launching myself, and it doesn't seem to matter.) #!/bin/bash sudo env "PATH=/opt/wine-devel/bin:$PATH" /opt/wine-devel/bin/wine xerase.exe.so The compiling system starts right up. The USB boot system that I'm trying to run it on gives me 0078:fixme:wineusb:add_unix_device Interface 1 has 2 alternate settings; using the first one. Wine: failed to start L"F:\\home\\test\.wine\\drive_c\\XERASxlnx\\xerase.exe.so" Application could not be started, or no application associated with the specified file. ShellExecuteEx failed: File not found. If I do the command directly instead of through a script I get exactly the same thing. If I cut out the env path stuff (1), or keep the path but call just wine (2), or just call wine (bashrc has the path now) same results 1. sudo /opt/wine-devel/bin/wine xerase.exe.so 2. sudo env "PATH=/opt/wine-devel/bin:$PATH" wine xerase.exe.so 3. sudo wine xerase.exe.so 4. sudo wine /home/test/.wine/drive_c/XERASxlnx/xerase.exe.so 0078:fixme:wineusb:add_unix_device Interface 1 has 2 alternate settings; using the first one. Wine: failed to start L"F:\\home\\test\.wine\\drive_c\\XERASxlnx\\xerase.exe.so" Application could not be started, or no application associated with the specified file. ShellExecuteEx failed: File not found. So... observations... 1. Not sure where F: is coming from? C: I might understand (though frankly, I'd just as soon the program realize we're using the unix file structure, not any virtualized windows stuff for what we're doing) When I look at .wine/dosdevices on both systems... Build/working system: z: -> / c: -> ../drive_c <com devices> . .. Not working USB booted system: z: -> / c: -> ../drive_c d:: -> /dev/sda1 g:: -> /dev/sda f:: -> /dev/sd5 e:: -> /dev/sda2 <com devices> d: -> /boot/efi f: -> / . .. Any suggestions in changes to compilation or environmental variables to get wine to start running it? I guess I could delete d::, g::, f::, e::, d:, and f: and see if that makes a difference but figured I'd ask the question first Brent Burkholder Extreme Protocol Solutions bburk(a)extremeprotocol.com<mailto:bburk@extremeprotocol.com>

2 2

wine-7.0.1-rc1 Available
by Michael Stefaniuc 28 Sep '22

28 Sep '22

Hello, I have pushed wine-7.0.1-rc1 (217323fff7da7f318a30348b4665ace55d04c50b) to https://github.com/mstefani/wine-stable/tree/stable https://people.redhat.com/mstefani/wine/stable/ And created the draft merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/955 Bugs and most other fixes are from the 7.1 to 7.8 era. Previous x.0.1 releases would include only stuff from x.1 to x.4 or x.5 devel versions to fill the "budget" of about 100 cherry picks. Also this is lowest amount of bugs fixed since 1.8.1. The "use long" commits were a major nuisance so I might have missed bugs due to the long patch dependency chains. If your favorite bug is missing please let me know. The rest of the commits picked are small and found by keywords in the commit message. The longer commit messages help here. There are a bunch of "newer" (> 7.8) commits and those are mostly there to fix the currently "broken in 7.0 too" tests. The usual plan is to wait for feedback for 7-10 days before the real 7.0.1 is released. There will be definitely a -rc2 as I need to cherry pick or backport some of the gitlab related commits. What's new in this release: - Various bug fixes - Translation updates ---------------------------------------------------------------- Bugs fixed in 7.0.1 (total 31): 12732 Nota Bene crashes on install 44202 undname.c fails to parse symbols with rvalue-reference semantics '&&' 45916 x64dbg fails to load debuggee, needs ThreadScheduler_ScheduleTask 50352 Maximum sockets per process is set very low 50370 Gothic 1 doesn't start correctly when screen resolution of the game matches display resolution 50433 'MsiBreak' custom action debugging aid should use custom action's name from 'CustomAction' table (currently uses 'Target' field) 50869 Killing Wine process in Wine 6.5 doesn't terminate the application because of the new use of start.exe 51163 WinOffice Pro 5.3 stops after splashscreen, needs WMI class SoftwareLicensingProduct 51619 advapi32:registry fails in Wine because French & German timezone name translations are too long 51900 regression: REAPER scrollbars flash between themed and non-themed 52163 postgresql-9.3 installer expects scrrun:filesys_GetTempName to return filename with TMP suffix 52298 Opening PPT with Freeoffice Presentations crashes on unimplemented function ole32.dll.OleConvertIStorageToOLESTREAMEx 52426 BCryptSignHash mishandles empty arguments 52434 Light Blue theme has rendering errors in tree views 52436 In Light Blue theme, checkable toggle buttons (BS_AUTOCHECKBOX) look unchecked when hovered 52446 Normal dlls with native subsystem id are no longer processed when importing system dlls with uppercase names 52476 QuickLOAD (VB5 app) input value is changed by factor 10 52494 shell32 progman_dde tests crash if run immediately after prefix creation 52510 alt:V mod for Grand Theft Auto V fails due to missing concrt140._Byte_reverse_table@details@Concurrency@@3QBEB 52562 advapi32:registry fails in Wine because some French timezone name translations are too long 52581 Internet MIDI crashes with Light Blue theme enabled 52583 ApiSetView does not display export ordinals correctly 52616 SteelSeries GG installer crashes on unimplemented function setupapi.dll.SetupQueryInfVersionInformationW 52618 32-bit EXEs do not launch from build dir on macOS 10.14 in WOW64 52626 MahjongSoul needs unimplemented function combase.dll.RoSetErrorReportingFlags 52667 DTS Master Audio Suite can't select save file location when wine's "Light" theme is used 52679 Anno 1602 / 1602 A.D. graphics too dark / black 52704 FreeHand 9 demo: invalid handle exception (0xc0000008) when attaching uxtheme.dll 52787 Invalid function prototype for "RegisterUserApiHook" when compiling for C++ 52953 GuiPy crashes on unimplemented function xmllite.dll.CreateXmlReaderInputWithEncodingCodePage 53430 urlmon:url fails due to unexpected redirection ---------------------------------------------------------------- Changes since 7.0: Alex Henrie (14): explorer: Only try to destroy the IShellWindows object if it exists. tzres: Inform translators of 31-character limit. po: Update Catalan translation. msi: Fix memory leak in get_fusion_filename (Coverity). winhttp: Fix memory leak on error path in WinHttpCrackUrl (Coverity). adsldp: Fix memory leak on error path in search_ExecuteSearch (Coverity). conhost: Fix memory leak on error path in create_screen_buffer (cppcheck). dbghelp: Fix memory leak on error path in dwarf2_read_range (cppcheck). ws2_32: Fix memory leak on error path in get_local_ips (cppcheck). ws2_32: Fix memory leaks on error paths in unix_gethostby* (scan-build). sane: Fix memory leak in create_item (Coverity). winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity). shell32: Fix sizeof argument in DoPaste (Coverity). mciwave: Fix bad free in MCI_SendCommandAsync (Coverity). Alexandre Julliard (9): user.exe: Make sure that the thunk selector doesn't get freed. makefiles: Disable printf format warnings for non-PE msvcrt modules. README: Mention Gitlab. kernel32/tests: Fix affinity test when there are too many CPUs. ntdll/tests: Fix affinity test when there are too many CPUs. secur32/tests: Update for new WineHQ certificate. urlmon/tests: Run tests against the gitlab server to avoid redirects. webservices/tests: Mark tests that fail on 64-bit as todo. wininet/tests: Update WineHQ certificate. Alistair Leslie-Hughes (1): msado15: Return valid object in Recordset::Clone. Andrey Gusev (1): d3d11: Implement the ID3DUserDefinedAnnotation interface. Aurimas Fišeras (1): po: Update Lithuanian translation. Bastien Orivel (1): ws2_32: Fix setsockopt(TCP_NODELAY) when optlen is less than 4. Ben Shefte (1): ntdll: Use case insensitive comparison in is_import_dll_system(). Bhavesh Davda (1): wined3d: Add GPU information for NVIDIA Ampere A10 and AMD Radeon Pro V620 GPUs. Brandon Moore (1): msadpm: Stop decoding instead of crashing for invalid adpcm data. Brendan Shanks (1): makefiles: On macOS, use @rpath instead of @loader_path when building Unix libs. David Kahurani (1): oleaut32: Do not skip the first decimal digit in VarParseNumFromStr(). Dmitry Timoshkov (2): ieframe: Clear a being invalidated history entry. ieframe: Initialize new history log entry. Eric Pouech (3): start: Wrap child inside a job so it gets killed when start.exe terminates. include/msvcrt: Redefine towlower* & towupper* with wint_t types. msacm32: Use extended structure definition for driver configuration. Fabian Maurer (4): printui: Use LocalFree for memory allocated by LocalAlloc (Coverity). mfplay: Prevent usage of uninitialized pointer in error case (Coverity). mfplat: Prevent use after free (Coverity). shell32: Prevent user after free in error case (Coverity). Floris Renaud (1): po: Update Dutch Translation. François Gouget (8): po: Fix the French translation of 'code page'. po: Fix backslash duplication in a French translation. po: Remove a space before a linefeed in the French translation. po: Remove spaces before linefeeds in the Spanish translation. po: Remove a space before a linefeed in the Chinese translation. po: Fix an accelerator shortcut in the Norwegian Bokmål translation. inetmib1: Avoid overflows in IPv4 address comparisons. inetmib1: Fix the IPv4 address network order for comparisons. Gabriel Ivăncescu (3): ddraw: Use WINED3D_SWAPCHAIN_NO_WINDOW_CHANGES only if window is not in foreground. jscript: Handle NULL return pointers in all constructors. mshtml: Fix leak on failure in return_nsstr. Gerald Pfeifer (1): iphlpapi: Zero-init prefix_len to avoid a compiler warning. Gijs Vermeulen (1): setupapi: Add SetupQueryInfVersionInformationA/W stub. Giovanni Mascellani (3): winegstreamer: Do not block forever if EOS races with command queue. mfplat: Avoid a race condition when releasing a tracked sample. mfmediaengine: Fix a memory leak. Hans Leidekker (1): msi: Use custom action name for MsiBreak handling. Henri Verbeet (2): d3d11/tests: Add some tests for ID3DUserDefinedAnnotation. wined3d: Add GPU information for NVIDIA Tesla T4. Kevin Puetz (1): winegcc: --out-implib needs to propagate -m32/-m64 to winebuild. Lauri Kenttä (2): po: Update Finnish translation. readme: Update Finnish translation. Louis Lenders (2): wbemprox: Add some properties of SoftwareLicensingProduct class. ole32: Add stub for OleConvertIStorageToOLESTREAMEx. Martin Storsjö (1): ntdll: Zero-initialize the syscall_frame used for starting threads on ARM/ARM64. Matteo Bruni (1): combase: Add RoSetErrorReportingFlags() stub. Michael Stefaniuc (1): tools: Get the ANNOUNCE bug list from the stable-notes git notes. Mohamad Al-Jaf (1): hid: Implement HidD_GetPhysicalDescriptor. Nikolay Sivov (4): comctl32/listview: Initialize subitem text buffer before drawing each subitem. uxtheme: Fix double free on registry key handle. xmllite/reader: Implement CreateXmlReaderInputWithEncodingCodePage(). evr/sample: Avoid a race condition when releasing a tracked sample. Paul Gofman (1): concrt140: Add ?_Byte_reverse_table@details@Concurrency@@3QBEB data export. Piotr Caban (2): ucrtbase: Add support for r-value demangling in unDName. msvcr100: Improve ThreadScheduler_ScheduleTask_loc stub. Piotr Kleski (1): bcrypt: Return BCryptSignHash len when only output is NULL. Robert Wilhelm (2): scrrun: Add test for GetTempName. scrrun: Generate temp name with tmp suffix. Rémi Bernon (1): mf: Handle MESourceSeeked and MEStreamSeeked state change events. Santino Mazza (2): ncrypt/tests: Test key import of an rsa key. ncrypt: Make NCryptOpenStorageProvider return a valid stub pointer. Saulius Krasuckas (1): ntdll: Check __WINE_PE_BUILD instead of compiler macros. Zebediah Figura (12): ws2_32/tests: Add tests for WSAStartup(). ws2_32: Always fill the WSADATA structure in WSAStartup(). ws2_32: Cap the negotiated winsock version to 1.1 or 2.2. ws2_32: Return 32767 or 0 in the iMaxSockets field. ws2_32: Return 65467 or 0 in the iMaxUdpDg field. ws2_32: Return WSAEFAULT instead of WSAEINVAL from WSAStartup() if "data" is NULL. configure: Fix the check for CAPI support. d3dx9: Don't mark annotation variables as dirty. winegstreamer: Release stream_cs on error in stream_thread(). setupapi: Avoid leaking subKey in SETUPDI_AddDeviceInterfaces(). server: Allocate enough space for the backslash in dup_nt_name() (Valgrind). tiff: Explictly link to zlib. Zhiyi Zhang (12): user32/tests: Test painting standard scroll bars in hovered state. user32: Draw standard scroll bars in hovered state only when they were previously painted by DefWinProc(). comctl32/button: Use pressed state when a pushlike checkbox or radio button is checked and hovered. comctl32/treeview: Do not draw client edge without WS_EX_CLIENTEDGE. light.msstyles: Do not use transparent treeview parts. uxtheme/tests: Add IsThemePartDefined() tests. uxtheme: Search parts of any state in IsThemePartDefined(). light.msstyles: Add Menu stub class. user32/tests: Test NUMCOLORS for display DCs. win32u: Return -1 for NUMCOLORS with 8-bit display DCs. include: Avoid a C++ keyword for RegisterUserApiHook(). light.msstyles: Use stretch sizing type for scroll bar arrow button background. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Wine staging 7.18 release
by Alistair Leslie-Hughes 23 Sep '22

23 Sep '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.18 (514 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * ws2_32: Return a valid value for WSAIoctl SIO_IDEAL_SEND_BACKLOG_QUERY. * dwrite: Test IDWriteTextFormat with nonexistent font. * dwrite: Use MapCharacters for non-visual characters. * dwrite: Use MapCharacters for dummy line metrics. Added: * None Updated: * server-unix_name * ntdll-Junction_Points Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

What macOS SDK is being tested against on gitlab?
by Dean Greer 23 Sep '22

23 Sep '22

Hi everyone, I’d just tried to build the current git and winemac.drv is failing building on macOS Monterey with the latest 12.3 SDK so I’m assuming the gitlab test is using an older macOS SDK?

3 10

How to test out wines WoW64?
by Dean Greer 23 Sep '22

23 Sep '22

Hi everyone, Since there now seems to be support within winex11.drv and winemac.drv what patches are now required to make use of the WoW64 work? I'd like to have this enabled within the macOS packages as soon as possible even if that means possibly carrying some patches locally for a while, ideally having a way to build the contents of i386-windows without needing to build i386-unix.

2 3

[vkd3d] Handling object components within the HLSL compiler.
by Francisco Casas 20 Sep '22

20 Sep '22

Hello, I write this update on what I am working on, because I think it introduces some architectural changes that may be good to discuss, or at least mention. Sorry if this text is a bit dense, I hope to send all this as a merge request in a couple of days from now. Albeit we may want to avoid merging before the code freeze ends. More than a week ago, I started trying to implement SM1 resource loads. For this, in particular, it is necessary to infer each sampler's dimensions from usage (a use in a tex2D implies that the sampler is 2D, if not previously declared as such). This gets complicated when there are arrays of samplers, because each sampler component can have a different dimension, and yet being part of the same variable. For solving this I tried introducing a field to allow us to store data for each component within hlsl_ir_var. But this turned to be a complicated solution. As now, we lost the component information in the derefs once we start working with register offsets. I also wanted to have per-component data because I realized that, in general, we are not handling object components properly when they are part of a larger array/struct. But then I thought on an alternative solution: adding a compiler pass to promote each object component within a large variable to a new standalone variable, and prepend a store from this standalone variable to the the original path of the component within the large variable; relying on copy-prop and dce so that all references that refer to these components end up pointing to the new standalone variable. This allows us to use the fields of the hlsl_ir_var (in particular, the register allocation) for each object component, which solves the problem. While that strategy works, I then realized that we cannot use it when targeting SM1 profiles, because we wouldn't be replicating the CTAB (which doesn't introduce a new variable for each component in multi-dimensional object arrays, just increases its register size). SM4 on the other hand seems to do this, separating each sampler and texture as its own variable in the RDEF block. My conclusion then, is that it is a good idea to separate each object component into its own variable in SM4 (as long they are named with the correct subscripts, like "foo.tex[3]"). And while we can't do that in SM1, the good news is that SM1 doesn't allow objects as components of larger types except within (possible multi-dimensional) arrays. Samplers and Textures cannot be components of structs within SM1 profiles, so we only have to support those cases in hlsl_sm1.c. This approach also has the benefit that now, all the component register allocation information should be representable using the fields in the hlsl_ir_var struct and the register size data within hlsl_type [1], since each variable should only care about a single register type now. Storing register allocation data component-wise should not be necessary. So I am implementing a series of patches to ensure that: * When targeting SM4 profiles, all object components are separated into a sole variable. * When targeting SM1 profiles, it is not allowed to declare objects as components of structs; so they will either be a sole variable, or belong to either a (possibly multi-dimensional) array of elements of the same type, as declared within the shader. * SM1 resource loads work. My plan for this series, in terms of patches is: * Parse the tex3D() intrinsic. (already made by zf) * Parse the tex2D() intrinsic. (already made by zf) * Validate that object are not components of structs in SM1. * Properly allocate registers for object arrays for SM1. * Infer sampler register dimensions and write declarations in SM1. * Write resource loads in SM1. * Separate objects as standalone variables in SM4. * Lower combined samplers to separate sampler and texture objects for SM4. (already made by zf) * Lower separate sampler and texture objects to combined samplers for SM1. (already made by zf) It remains to check if object arrays are handled properly in the last two [2], or modify these patches accordingly. Best regards, Francisco. --- [1] I know we intend to remove this field later, when we move register allocation to each sm*_write.c, but I think we probably want to replace those precomputed register offset fields with equivalent SM-specific functions that retrieve the register offset for each component. [2] In SM1 profiles, when there are texture arrays and they are used together with samplers, only one variable is created (not one for each pair of components). This is allowed: ``` Texture2D tex[3][2]; sampler sam; float4 main() : SV_TARGET { return tex[0][1].Sample(sam, float2(1, 2)) + tex[1][0].Sample(sam, float2(1, 2)); } ``` This is allowed (but "not yet implemented" in fxc 9 and 10) ``` Texture2D tex; sampler sam[2][3]; float4 main() : SV_TARGET { return tex.Sample(sam[0][2], float2(1, 2)) + tex.Sample(sam[1][0], float2(1, 2)); } ``` This is not allowed: ``` Texture2D tex[3]; sampler sam[4]; float4 PSMain() : SV_TARGET { return tex[1].Sample(sam[1], float2(1, 2)) + tex[2].Sample(sam[0], float2(1, 2)); } ``` gives: ``` error X4581: Cannot use texture arrays on DX9 targets with multiple samplers. ```

2 5

Request for new 7.0 stable release
by Nick Sarnie 18 Sep '22

18 Sep '22

Hi, I'm part of the Wine packaging team for Gentoo. We noticed that the 7.0.x stable branch is currently at 7.0, and the 6.0.x stable branch has had some maintenance releases after the release of 7.0, so there have been some bug fixes backported to 6.0.x (e.g. 6.0.4) that are not available in the 7.0 stable release. Would the Wine team be willing to do a maintenance release for the 7.0.x branch to include these bug fixes (and possibly others)? If not, would you please explain the rationale behind that decision and the intended stable branch release cadence? Thanks for your time, Sarnex

2 2

WineHQ.org Downtime
by Jeremy Newman 12 Sep '22

12 Sep '22

The WineHQ.org server will be down for maintenance and upgrades starting today 2022-09-12 at 13:00 CDT (GMT-5) This downtime will be a minimum of 30 minutes, but could take longer depending on any issues that arise. This will take offline all mailing lists and websites during the maintenance timeframe. After the maintenance is complete, various services may take longer to come back online or may exhibit unexpected behavior. We will be fixing these issues are quickly as we can. Thanks for your patience and I will reply back to this thread if anything changes. I will also be online on the #winehackers IRC room. -N

1 1

Re: fixing some fixme code
by Jin-oh Kang 12 Sep '22

12 Sep '22

Forwarding to wine-devel. Please remember to use the "reply all" button next time. Thank you! On Mon, Sep 12, 2022, 11:11 AM Owen Hogarth <gurenchan(a)gmail.com> wrote: > Hello guys, I am trying to get this program; R Trader Pro to work on Linux. > I installed winetricks and then I received some different errors. > > I would like to fix the problem but I would also like to avoid doing > unnecessary work, that's why I am asking on the development mailing list. > > Here's the new error log, is it possible to get the program working? > 017c:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 0174:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 0174:fixme:file:NtLockFile I/O completion on lock not implemented yet > 0174:fixme:ntdll:NtQuerySystemInformation info_class > SYSTEM_PERFORMANCE_INFORMATION > 0194:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0174:fixme:imm:ImeSetActiveContext (0x2ca590, 1): stub > 0174:fixme:imm:ImmReleaseContext (0004006E, 002CA590): stub > 017c:fixme:imm:ImeSetActiveContext (0x3c780, 0): stub > 017c:fixme:imm:ImmReleaseContext (0000000000020082, 000000000003C780): stub > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0174:err:richedit:ReadStyleSheet skipping optional destination > 0174:err:richedit:ReadStyleSheet skipping optional destination > 0174:err:richedit:ReadStyleSheet skipping optional destination > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0174:fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, > advertised shortcut > 0174:fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, > advertised shortcut > 0174:fixme:msi:ITERATE_CreateShortcuts poorly handled shortcut format, > advertised shortcut > 01e8:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 01f0:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 01e0:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 01f8:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > regsvr32: Successfully registered DLL 'C:\Program Files > (x86)\Rithmic\Rithmic Trader Pro\StockChartX.ocx' > 0174:fixme:msi:internal_ui_handler internal UI not implemented for message > 0x0b000000 (UI level = 5) > 0174:fixme:msi:internal_ui_handler internal UI not implemented for message > 0x0b000000 (UI level = 5) > 0174:fixme:wincodecs:jpeg_decoder_get_metadata_blocks stub > 0200:err:winediag:is_broken_driver Broken NVIDIA RandR detected, falling > back to RandR 1.0. Please consider using the Nouveau driver instead. > 0200:fixme:mscoree:parse_supported_runtime > sku=L".NETFramework,Version=v4.5.2" not implemented > 0200:fixme:mscoree:parse_supported_runtime > sku=L".NETFramework,Version=v4.5.2" not implemented > 0200:fixme:ntdll:NtQuerySystemInformation info_class > SYSTEM_PERFORMANCE_INFORMATION > 0200:fixme:nls:GetFileMUIPath stub: 0x10, > L"C:\\windows\\system32\\tzres.dll", (null), 0032EE98, 00DAA728, 0032EE9C, > 0032EE90 > 0200:fixme:nls:GetFileMUIPath stub: 0x10, > L"C:\\windows\\system32\\tzres.dll", (null), 0032EE98, 00DAA728, 0032EE9C, > 0032EE90 > 0200:fixme:nls:GetFileMUIPath stub: 0x10, > L"C:\\windows\\system32\\tzres.dll", (null), 0032EE98, 00DAA728, 0032EE9C, > 0032EE90 > 0200:fixme:imm:ImeSetActiveContext (0xdc41c0, 1): stub > 0200:fixme:imm:ImmReleaseContext (00030080, 00DC41C0): stub > 0200:fixme:winsock:errno_from_unix unknown error: Device or resource busy > 0200:err:winediag:getaddrinfo Failed to resolve your host name IP > 0218:fixme:wbemprox:wbem_locator_ConnectServer authentication not supported > 0218:fixme:wbemprox:wbem_locator_ConnectServer specific locale not > supported > 0218:fixme:wbemprox:wbem_locator_ConnectServer unsupported flags > 021c:fixme:wbemprox:wbem_locator_ConnectServer authentication not supported > 021c:fixme:wbemprox:wbem_locator_ConnectServer specific locale not > supported > 021c:fixme:wbemprox:wbem_locator_ConnectServer unsupported flags > wine: Read access denied for device L"\\??\\Z:\\", FS volume label and > serial are not available. > 0200:fixme:winsock:errno_from_unix unknown error: Device or resource busy > 0200:err:winediag:getaddrinfo Failed to resolve your host name IP > 0200:fixme:winsock:errno_from_unix unknown error: Device or resource busy > 0200:err:winediag:getaddrinfo Failed to resolve your host name IP > An error occured while contacting the license server. > > Raised in : com.omnesys.omne.om.OMField > Method : OMsetData > Error : no data > Raised in : 31004 1 unknown host 20014 1 unknown addr > > Method : OMaddData > Error : create error > Please contact Omnesys Technologies Inc., at www.omnesys.com. > > On Mon, Sep 12, 2022 at 8:51 AM Jin-oh Kang <jinoh.kang.kr(a)gmail.com> > wrote: > >> On Mon, Sep 12, 2022, 9:46 AM Zebediah Figura <zfigura(a)codeweavers.com> >> wrote: >> >>> On 9/11/22 19:38, Jin-oh Kang wrote: >>> >> and secondly because it's actually quite hard if not >>> >> impossible to implement (POSIX has no way to wait for a mandatory >>> lock, >>> >> for instance). >>> >> >>> > >>> > We don't use POSIX locks to implement file locks; they are emulated >>> > entirely in the server, which I guess is specifically designed to avoid >>> > that problem with POSIX file lock semantics. Thus, this won't be *that* >>> > hard to implement; nonetheless, asynchronous I/O is not really easy to >>> > implement in general, especially for those new to wine codebase. >>> >>> I don't see where you're getting that; we do indeed use POSIX locks. See >>> set_unix_lock() in server/fd.c. >> >> >> I stand corrected. >> >> There's no poll() for file locks, so it would have to busy-wait anyway. >> >> I did incorrectly use the term >>> "mandatory", though; we don't set mandatory locks on a file. >>> >>

1 0

fixing some fixme code
by Owen Hogarth 12 Sep '22

12 Sep '22

Hello, I tried to run an application and saw that there are a few unimplemented features, such as: 00d0:fixme:file:NtLockFile I/O completion on lock not implemented yet I was reading the developers guide and wanted to say hello to the mailing list.

3 4

Wine staging 7.17 release
by Alistair Leslie-Hughes 10 Sep '22

10 Sep '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.17 (529 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * ntdll: Add support for FileFsFullSizeInformation class in NtQueryVolumeInformationFile(try 2) Added: * None Updated: * None Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Ubuntu 20.04 vs 32bit wine [-staging] - more detailed documentation?
by Sebastian M. Ernst 09 Sep '22

09 Sep '22

Hi all, just burned *a lot* of time making Wine (Staging) for 64 and **32 bit** work on Ubuntu 20.04 (Ubuntu 22.04 was a little less painful) as part of a Github action of mine. The official documentation that is very commonly referred / pointed to ("if it does not work, you did not follow the instructions there to the letter") ... https://wiki.winehq.org/Ubuntu ... misses a few, apparently constantly shifting details on the 32 bit side of things. The "authoritative resource" on this topic appears to be this lovely long Github issue ... https://github.com/actions/runner-images/issues/4589 ... which thankfully also provides up-to-date workarounds (with rather significant side-effects), like the following as of July 26: ```bash sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list sudo apt-get update -qq sudo apt-get install -yqq --allow-downgrades libgd3/focal libpcre2-8-0/focal libpcre2-16-0/focal libpcre2-32-0/focal libpcre2-posix2/focal sudo apt-get purge -yqq libmono* moby* mono* php* libgdiplus libpcre2-posix3 libzip4 ``` See, in the following order: - https://github.com/actions/runner-images/issues/4589#issuecomment-980506595 - https://github.com/actions/runner-images/issues/4589#issuecomment-1100899313 - https://github.com/actions/runner-images/issues/4589#issuecomment-1123074635 - https://github.com/actions/runner-images/issues/4589#issuecomment-1194891446 I am not sure if (or how) this belongs into your wiki (of if it can even be fixed / worked around partially within the dependencies of the packages from WineHQ's PPA). But since the above mentioned Github issue is not easy to find between a lot of other related but less helpful "noise" in online search results (and takes a while to comprehend), it might warrant creating a central, well known place that documents this behaviour in an up-to-date manner. Either way, in all honesty, thx to everybody who keeps 32 bit support running. For better or for worse, it is still badly needed. Best regards, Sebastian

3 2

[PATCH] include: disable some process/thread functions when in UAP mode
by Steve Lhomme 08 Sep '22

08 Sep '22

Wine doesn't use the winapifamily.h features but this header is also used in mingw-w64. These functions are also defined in processthreadsapi.h and many of them are not supposed to be called by non desktop apps. In order to have mingw-w64 avoid making these functions public when they should not, winbase.h need to match the mingw-w64 processthreadsapi.h. Either this is fixed in Wine it will need careful update of winbase.h when imported in mingw-w64. --- include/winbase.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/include/winbase.h b/include/winbase.h index 0a8409c10e1..f8f04643637 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -20,6 +20,7 @@ #define __WINE_WINBASE_H #include <winerror.h> +#include <winapifamily.h> #ifdef __cplusplus extern "C" { @@ -1901,15 +1902,19 @@ WINBASEAPI BOOL WINAPI CreateProcessA(LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES, WINBASEAPI BOOL WINAPI CreateProcessW(LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION); #define CreateProcess WINELIB_NAME_AW(CreateProcess) WINADVAPI BOOL WINAPI CreateProcessAsUserA(HANDLE,LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINADVAPI BOOL WINAPI CreateProcessAsUserW(HANDLE,LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION); +#endif #define CreateProcessAsUser WINELIB_NAME_AW(CreateProcessAsUser) WINBASEAPI BOOL WINAPI CreateProcessInternalA(HANDLE,LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION,HANDLE*); WINBASEAPI BOOL WINAPI CreateProcessInternalW(HANDLE,LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION,HANDLE*); #define CreateProcessInternal WINELIB_NAME_AW(CreateProcessInternal) WINADVAPI BOOL WINAPI CreateProcessWithLogonW(LPCWSTR,LPCWSTR,LPCWSTR,DWORD,LPCWSTR,LPWSTR,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION); WINADVAPI BOOL WINAPI CreateProcessWithTokenW(HANDLE,DWORD,LPCWSTR,LPWSTR,DWORD,void *,LPCWSTR,STARTUPINFOW *,PROCESS_INFORMATION *); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI HANDLE WINAPI CreateRemoteThread(HANDLE,LPSECURITY_ATTRIBUTES,SIZE_T,LPTHREAD_START_ROUTINE,LPVOID,DWORD,LPDWORD); WINBASEAPI HANDLE WINAPI CreateRemoteThreadEx(HANDLE,LPSECURITY_ATTRIBUTES,SIZE_T,LPTHREAD_START_ROUTINE,LPVOID,DWORD,LPPROC_THREAD_ATTRIBUTE_LIST,LPDWORD); +#endif WINADVAPI BOOL WINAPI CreateRestrictedToken(HANDLE,DWORD,DWORD,PSID_AND_ATTRIBUTES,DWORD,PLUID_AND_ATTRIBUTES,DWORD,PSID_AND_ATTRIBUTES,PHANDLE); WINBASEAPI HANDLE WINAPI CreateSemaphoreA(LPSECURITY_ATTRIBUTES,LONG,LONG,LPCSTR); WINBASEAPI HANDLE WINAPI CreateSemaphoreW(LPSECURITY_ATTRIBUTES,LONG,LONG,LPCWSTR); @@ -1958,7 +1963,9 @@ WINBASEAPI void WINAPI DeleteFiber(LPVOID); WINBASEAPI BOOL WINAPI DeleteFileA(LPCSTR); WINBASEAPI BOOL WINAPI DeleteFileW(LPCWSTR); #define DeleteFile WINELIB_NAME_AW(DeleteFile) +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI void WINAPI DeleteProcThreadAttributeList(struct _PROC_THREAD_ATTRIBUTE_LIST*); +#endif WINBASEAPI BOOL WINAPI DeleteTimerQueue(HANDLE); WINBASEAPI BOOL WINAPI DeleteTimerQueueEx(HANDLE,HANDLE); WINBASEAPI BOOL WINAPI DeleteTimerQueueTimer(HANDLE,HANDLE,HANDLE); @@ -2248,12 +2255,16 @@ WINBASEAPI BOOL WINAPI GetLogicalProcessorInformation(PSYSTEM_LOGICAL_PRO WINBASEAPI BOOL WINAPI GetLogicalProcessorInformationEx(LOGICAL_PROCESSOR_RELATIONSHIP,PSYSTEM_LOGICAL_PROCESSOR_INFORMATION_EX,PDWORD); WINBASEAPI DWORD WINAPI GetProcessHeaps(DWORD,PHANDLE); WINBASEAPI DWORD WINAPI GetProcessId(HANDLE); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI DWORD WINAPI GetProcessIdOfThread(HANDLE); +#endif WINBASEAPI BOOL WINAPI GetProcessIoCounters(HANDLE,PIO_COUNTERS); WINBASEAPI BOOL WINAPI GetProcessPriorityBoost(HANDLE,PBOOL); WINBASEAPI BOOL WINAPI GetProcessShutdownParameters(LPDWORD,LPDWORD); WINBASEAPI BOOL WINAPI GetProcessTimes(HANDLE,LPFILETIME,LPFILETIME,LPFILETIME,LPFILETIME); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI DWORD WINAPI GetProcessVersion(DWORD); +#endif WINBASEAPI BOOL WINAPI GetProcessWorkingSetSize(HANDLE,PSIZE_T,PSIZE_T); WINBASEAPI BOOL WINAPI GetProcessWorkingSetSizeEx(HANDLE,SIZE_T*,SIZE_T*,DWORD*); WINBASEAPI BOOL WINAPI GetProductInfo(DWORD,DWORD,DWORD,DWORD,PDWORD); @@ -2282,7 +2293,9 @@ WINBASEAPI DWORD WINAPI GetShortPathNameA(LPCSTR,LPSTR,DWORD); WINBASEAPI DWORD WINAPI GetShortPathNameW(LPCWSTR,LPWSTR,DWORD); #define GetShortPathName WINELIB_NAME_AW(GetShortPathName) WINBASEAPI VOID WINAPI GetStartupInfoA(LPSTARTUPINFOA); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI VOID WINAPI GetStartupInfoW(LPSTARTUPINFOW); +#endif #define GetStartupInfo WINELIB_NAME_AW(GetStartupInfo) WINBASEAPI HANDLE WINAPI GetStdHandle(DWORD); WINBASEAPI BOOL WINAPI GetSystemCpuSetInformation(SYSTEM_CPU_SET_INFORMATION*,ULONG,ULONG*,HANDLE,ULONG); @@ -2400,7 +2413,9 @@ WINBASEAPI BOOL WINAPI InitializeContext2(void *,DWORD,CONTEXT **,DWORD * WINBASEAPI void WINAPI InitializeCriticalSection(CRITICAL_SECTION *lpCrit); WINBASEAPI BOOL WINAPI InitializeCriticalSectionAndSpinCount(CRITICAL_SECTION *,DWORD); WINBASEAPI BOOL WINAPI InitializeCriticalSectionEx(CRITICAL_SECTION *,DWORD,DWORD); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI InitializeProcThreadAttributeList(struct _PROC_THREAD_ATTRIBUTE_LIST*,DWORD,DWORD,SIZE_T*); +#endif WINADVAPI BOOL WINAPI InitializeSecurityDescriptor(PSECURITY_DESCRIPTOR,DWORD); WINADVAPI BOOL WINAPI InitializeSid(PSID,PSID_IDENTIFIER_AUTHORITY,BYTE); WINBASEAPI VOID WINAPI InitializeSListHead(PSLIST_HEADER); @@ -2559,7 +2574,9 @@ WINBASEAPI VOID WINAPI OutputDebugStringW(LPCWSTR); WINBASEAPI BOOL WINAPI PeekNamedPipe(HANDLE,PVOID,DWORD,PDWORD,PDWORD,PDWORD); WINBASEAPI BOOL WINAPI PostQueuedCompletionStatus(HANDLE,DWORD,ULONG_PTR,LPOVERLAPPED); WINBASEAPI DWORD WINAPI PrepareTape(HANDLE,DWORD,BOOL); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI ProcessIdToSessionId(DWORD,DWORD*); +#endif WINADVAPI BOOL WINAPI PrivilegeCheck(HANDLE,PPRIVILEGE_SET,LPBOOL); WINADVAPI BOOL WINAPI PrivilegedServiceAuditAlarmA(LPCSTR,LPCSTR,HANDLE,PPRIVILEGE_SET,BOOL); WINADVAPI BOOL WINAPI PrivilegedServiceAuditAlarmW(LPCWSTR,LPCWSTR,HANDLE,PPRIVILEGE_SET,BOOL); @@ -2680,7 +2697,9 @@ WINADVAPI BOOL WINAPI SetPrivateObjectSecurity(SECURITY_INFORMATION,PSEC WINADVAPI BOOL WINAPI SetPrivateObjectSecurityEx(SECURITY_INFORMATION,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,ULONG,PGENERIC_MAPPING,HANDLE); WINBASEAPI BOOL WINAPI SetProcessAffinityMask(HANDLE,DWORD_PTR); WINBASEAPI BOOL WINAPI SetProcessPriorityBoost(HANDLE,BOOL); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI SetProcessShutdownParameters(DWORD,DWORD); +#endif WINBASEAPI BOOL WINAPI SetProcessWorkingSetSize(HANDLE,SIZE_T,SIZE_T); WINBASEAPI BOOL WINAPI SetProcessWorkingSetSizeEx(HANDLE,SIZE_T,SIZE_T,DWORD); WINBASEAPI BOOL WINAPI SetSearchPathMode(DWORD); @@ -2698,7 +2717,9 @@ WINBASEAPI BOOL WINAPI SetSystemTimeAdjustment(DWORD,BOOL); WINBASEAPI DWORD WINAPI SetTapeParameters(HANDLE,DWORD,LPVOID); WINBASEAPI DWORD WINAPI SetTapePosition(HANDLE,DWORD,DWORD,DWORD,DWORD,BOOL); WINBASEAPI DWORD_PTR WINAPI SetThreadAffinityMask(HANDLE,DWORD_PTR); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI SetThreadContext(HANDLE,const CONTEXT *); +#endif WINBASEAPI BOOL WINAPI SetThreadErrorMode(DWORD,LPDWORD); WINBASEAPI DWORD WINAPI SetThreadExecutionState(EXECUTION_STATE); WINBASEAPI DWORD WINAPI SetThreadIdealProcessor(HANDLE,DWORD); @@ -2731,7 +2752,9 @@ WINBASEAPI BOOL WINAPI SwitchToThread(void); WINBASEAPI BOOL WINAPI SystemTimeToFileTime(const SYSTEMTIME*,LPFILETIME); WINBASEAPI BOOL WINAPI TerminateJobObject(HANDLE,UINT); WINBASEAPI BOOL WINAPI TerminateProcess(HANDLE,DWORD); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI TerminateThread(HANDLE,DWORD); +#endif WINBASEAPI DWORD WINAPI TlsAlloc(void); WINBASEAPI BOOL WINAPI TlsFree(DWORD); WINBASEAPI LPVOID WINAPI TlsGetValue(DWORD); @@ -2753,7 +2776,9 @@ WINBASEAPI BOOL WINAPI UmsThreadYield(void *); WINBASEAPI HRESULT WINAPI UnregisterApplicationRestart(void); WINBASEAPI BOOL WINAPI UnregisterWait(HANDLE); WINBASEAPI BOOL WINAPI UnregisterWaitEx(HANDLE,HANDLE); +#if WINAPI_FAMILY_PARTITION (WINAPI_PARTITION_DESKTOP) WINBASEAPI BOOL WINAPI UpdateProcThreadAttribute(struct _PROC_THREAD_ATTRIBUTE_LIST*,DWORD,DWORD_PTR,void*,SIZE_T,void*,SIZE_T*); +#endif WINBASEAPI BOOL WINAPI UpdateResourceA(HANDLE,LPCSTR,LPCSTR,WORD,LPVOID,DWORD); WINBASEAPI BOOL WINAPI UpdateResourceW(HANDLE,LPCWSTR,LPCWSTR,WORD,LPVOID,DWORD); #define UpdateResource WINELIB_NAME_AW(UpdateResource) -- 2.29.2

3 3

[PATCH] ntdll: Complete error case in get_initial_environment
by Gerald Pfeifer 06 Sep '22

06 Sep '22

GCC 12 (rightfully) would warn dlls/ntdll/unix/env.c:1910:12: warning: 'env_pos' may be used uninitialized Signed-off-by: Gerald Pfeifer <gerald(a)pfeifer.com> --- dlls/ntdll/unix/env.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/unix/env.c b/dlls/ntdll/unix/env.c index 105038a34cb..cbbfb99f4b3 100644 --- a/dlls/ntdll/unix/env.c +++ b/dlls/ntdll/unix/env.c @@ -920,7 +920,11 @@ static WCHAR *get_initial_environment( SIZE_T *pos, SIZE_T *size ) *size = 1; for (e = main_envp; *e; e++) *size += strlen(*e) + 1; - if (!(env = malloc( *size * sizeof(WCHAR) ))) return NULL; + if (!(env = malloc( *size * sizeof(WCHAR) ))) + { + *pos = 0; + return NULL; + } ptr = env; end = env + *size - 1; for (e = main_envp; *e && ptr < end; e++) -- 2.34.1

2 1

RFC: Allow marking unreliable tests as flaky.
by Francois Gouget 02 Sep '22

02 Sep '22

Wine has many unreliable tests which makes it hard to know whether a patch causes new failures. So one proposal was to mark unreliable tests as flaky, and have a mode where flaky failures can ignored by setting $WINETEST_ALLOW_FLAKY. So one would be able to apply a patch, run 'WINETEST_ALLOW_FLAKY=1 make test' and if that fails that means the patch introduces a new failure. The way it works is that when a flaky test fails the message is 'Flaky failed...' instead of 'Test failed...'. I also added the count of flaky failures to the summary line. So the flaky failures are not totally swept under the rug. The main difference is that if $WINETEST_ALLOW_FLAKY is set, the exit code is 0 if the only failures are flaky ones. That still leaves some open questions though: * Should the message be 'Test failed' instead of 'Flaky failed' when $WINETEST_ALLOW_FLAKY is not set? I opted for the latter because it adds information that the failed test has been marked as flaky. * Should tests that fail systematically on some platforms but not others (for instance specific Windows versions, specific locales, specific GPUs) be marked as flaky? Or should flaky be reserved for tests that fail randomly? * What about failures where the message is different every time so that the failure always looks new? Should these not be marked as flaky since it only impacts the TestBot? * On a related note the patch below has flaky_windows and flaky_wine macros. Is that too fine grained? Maybe we don't want to run the risk of marking a test as flaky_windows only to discover later that it can also fail in Wine? But conversely, wouldn't it be valuable to know that a test is only flaky in Wine and not in Windows? Note: flaky_windows is a bit long but I was worried that flaky_win would be too similar to flaky_wine. * I decided having flaky_{windows,wine}_if() macros would be overkill. * How does one know a flaky directive can be removed? * Is it allowed to submit a patch that contains new flaky directives? * Also the flaky directive cannot deal with tests that randomly crash, prematurely exit, or time out. These issues are rarer so maybe we can hope they can all be fixed? * How does this impact bug 48912, aka "Allow blacklisting unreliable and always new failures"? https://bugs.winehq.org/show_bug.cgi?id=48912 * test.winehq.org and the TestBot will need to be updated to highlight the new messages and, more importantly, to recognize the new summary line. The patch is below and I bundled it with tweaks to a few tests for illustration purposes: d3d8:device - Failure happens on Windows (rarely) and Wine. dinput:mouse - Failure happens on Windows 7 and Wine. mmdevapi:render - Timing issue. schedsvc:atsvcapi - Wine-only failure. --- dlls/d3d8/tests/device.c | 2 +- dlls/dinput/tests/mouse.c | 2 +- dlls/mmdevapi/tests/render.c | 2 +- dlls/schedsvc/tests/atsvcapi.c | 2 +- include/wine/test.h | 78 +++++++++++++++++++++++++++++----- 5 files changed, 72 insertions(+), 14 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index cb1e83b64b3..f0e8c27fafd 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -3356,7 +3356,7 @@ static void test_wndproc(void) expect_messages = sc_maximize_messages; SendMessageA(focus_window, WM_SYSCOMMAND, SC_MAXIMIZE, 0); - ok(!expect_messages->message, "Expected message %#x for window %#x, but didn't receive it.\n", + flaky ok(!expect_messages->message, "Expected message %#x for window %#x, but didn't receive it.\n", expect_messages->message, expect_messages->window); expect_messages = NULL; flush_events(); diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c index 8be808e5da6..dcb5453a825 100644 --- a/dlls/dinput/tests/mouse.c +++ b/dlls/dinput/tests/mouse.c @@ -156,7 +156,7 @@ static void test_acquire(IDirectInputA *pDI, HWND hwnd) SetActiveWindow( hwnd ); hr = IDirectInputDevice_Acquire(pMouse); - ok(hr == S_OK, "Acquire() failed: %#lx\n", hr); + flaky ok(hr == S_OK, "Acquire() failed: %#lx\n", hr); mouse_event(MOUSEEVENTF_MOVE, 10, 10, 0, 0); cnt = 1; diff --git a/dlls/mmdevapi/tests/render.c b/dlls/mmdevapi/tests/render.c index 4e19b91c5f5..882be89b7ff 100644 --- a/dlls/mmdevapi/tests/render.c +++ b/dlls/mmdevapi/tests/render.c @@ -1098,7 +1098,7 @@ static void test_clock(int share) ok(pos == 0, "GetPosition returned non-zero pos before being started\n"); hr = IAudioClient_Start(ac); /* #1 */ - ok(hr == S_OK, "Start failed: %08lx\n", hr); + flaky ok(hr == S_OK, "Start failed: %08lx\n", hr); Sleep(100); slept += 100; diff --git a/dlls/schedsvc/tests/atsvcapi.c b/dlls/schedsvc/tests/atsvcapi.c index 3aaad8b5cfe..83774804b40 100644 --- a/dlls/schedsvc/tests/atsvcapi.c +++ b/dlls/schedsvc/tests/atsvcapi.c @@ -168,7 +168,7 @@ START_TEST(atsvcapi) skip_tests_delete: ret = NetrJobDel(server_name, jobid, jobid); - ok(ret == ERROR_SUCCESS, "NetrJobDel error %lu\n", ret); + flaky_wine ok(ret == ERROR_SUCCESS, "NetrJobDel error %lu\n", ret); skip_tests: SetUnhandledExceptionFilter(old_exception_filter); diff --git a/include/wine/test.h b/include/wine/test.h index 01ba81f4857..422ba3dce38 100644 --- a/include/wine/test.h +++ b/include/wine/test.h @@ -50,6 +50,9 @@ extern int winetest_time; /* running in interactive mode? */ extern int winetest_interactive; +/* always count flaky tests as successful (BOOL) */ +extern int winetest_allow_flaky; + /* report successful tests (BOOL) */ extern int winetest_report_success; @@ -117,6 +120,13 @@ extern void winetest_pop_context(void); #define trace trace_(__FILE__, __LINE__) #define wait_child_process wait_child_process_(__FILE__, __LINE__) +#define flaky_if(is_flaky) for (winetest_start_flaky(is_flaky); \ + winetest_loop_flaky(); \ + winetest_end_flaky()) +#define flaky flaky_if(1) +#define flaky_windows flaky_if(!strcmp(winetest_platform, "windows")) +#define flaky_wine flaky_if(!strcmp(winetest_platform, "wine")) + #define todo_if(is_todo) for (winetest_start_todo(is_todo); \ winetest_loop_todo(); \ winetest_end_todo()) @@ -200,6 +210,9 @@ int winetest_interactive = 0; /* current platform */ const char *winetest_platform = "windows"; +/* always count flaky tests as successful (BOOL) */ +int winetest_allow_flaky; + /* report successful tests (BOOL) */ int winetest_report_success = 0; @@ -214,6 +227,7 @@ static const struct test *current_test; /* test currently being run */ static LONG successes; /* number of successful tests */ static LONG failures; /* number of failures */ +static LONG flaky_failures; /* number of failures inside flaky block */ static LONG skipped; /* number of skipped test chunks */ static LONG todo_successes; /* number of successful tests inside todo block */ static LONG todo_failures; /* number of failures inside todo block */ @@ -229,6 +243,8 @@ struct tls_data { const char* current_file; /* file of current check */ int current_line; /* line of current check */ + unsigned int flaky_level; /* current flaky nesting level */ + int flaky_do_loop; unsigned int todo_level; /* current todo nesting level */ int todo_do_loop; char *str_pos; /* position in debug buffer */ @@ -355,9 +371,18 @@ int winetest_vok( int condition, const char *msg, va_list args ) { if (condition) { - winetest_print_context( "Test succeeded inside todo block: " ); - vprintf(msg, args); - InterlockedIncrement(&todo_failures); + if (data->flaky_level) + { + winetest_print_context( "Flaky succeeded inside todo block: " ); + vprintf(msg, args); + InterlockedIncrement(&flaky_failures); + } + else + { + winetest_print_context( "Test succeeded inside todo block: " ); + vprintf(msg, args); + InterlockedIncrement(&todo_failures); + } return 0; } else @@ -381,9 +406,18 @@ int winetest_vok( int condition, const char *msg, va_list args ) { if (!condition) { - winetest_print_context( "Test failed: " ); - vprintf(msg, args); - InterlockedIncrement(&failures); + if (data->flaky_level) + { + winetest_print_context( "Flaky failed: " ); + vprintf(msg, args); + InterlockedIncrement(&flaky_failures); + } + else + { + winetest_print_context( "Test failed: " ); + vprintf(msg, args); + InterlockedIncrement(&failures); + } return 0; } else @@ -456,6 +490,27 @@ void winetest_win_skip( const char *msg, ... ) va_end(valist); } +void winetest_start_flaky( int is_flaky ) +{ + struct tls_data *data = get_tls_data(); + data->flaky_level = (data->flaky_level << 1) | (is_flaky != 0); + data->flaky_do_loop=1; +} + +int winetest_loop_flaky(void) +{ + struct tls_data *data = get_tls_data(); + int do_flaky=data->flaky_do_loop; + data->flaky_do_loop=0; + return do_flaky; +} + +void winetest_end_flaky(void) +{ + struct tls_data *data = get_tls_data(); + data->flaky_level >>= 1; +} + void winetest_start_todo( int is_todo ) { struct tls_data *data = get_tls_data(); @@ -601,14 +656,16 @@ static int run_test( const char *name ) printf( "%04x:%s:%s Silenced %d todos, %d skips and %d traces.\n", (UINT)GetCurrentProcessId(), test->name, winetest_elapsed(), (UINT)muted_todo_successes, (UINT)muted_skipped, (UINT)muted_traces); - printf( "%04x:%s:%s %d tests executed (%d marked as todo, %d %s), %d skipped.\n", + printf( "%04x:%s:%s %d tests executed (%d marked as todo, %d as flaky, %d %s), %d skipped.\n", (UINT)GetCurrentProcessId(), test->name, winetest_elapsed(), - (UINT)(successes + failures + todo_successes + todo_failures), - (UINT)todo_successes, (UINT)(failures + todo_failures), + (UINT)(successes + failures + flaky_failures + todo_successes + todo_failures), + (UINT)todo_successes, (UINT)flaky_failures, (UINT)(failures + todo_failures), (failures + todo_failures != 1) ? "failures" : "failure", (UINT)skipped ); } - status = (failures + todo_failures < 255) ? failures + todo_failures : 255; + status = failures + todo_failures; + if (!winetest_allow_flaky) status += flaky_failures; + if (status > 255) status = 255; return status; } @@ -665,6 +722,7 @@ int main( int argc, char **argv ) if (GetEnvironmentVariableA( "WINETEST_DEBUG", p, sizeof(p) )) winetest_debug = atoi(p); if (GetEnvironmentVariableA( "WINETEST_INTERACTIVE", p, sizeof(p) )) winetest_interactive = atoi(p); + if (GetEnvironmentVariableA( "WINETEST_ALLOW_FLAKY", p, sizeof(p) )) winetest_allow_flaky = atoi(p); if (GetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", p, sizeof(p) )) winetest_report_success = atoi(p); if (GetEnvironmentVariableA( "WINETEST_TIME", p, sizeof(p) )) winetest_time = atoi(p); winetest_last_time = winetest_start_time = GetTickCount(); -- 2.30.2

7 12

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel