wine-devel

wine-devel@winehq.org

3 participants
84400 discussions

[PATCH v2 0/1] MR268: riched20: Commit and repaint after the SetFont method is called. (#53169)
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: riched20: Commit and repaint after the SetFont method is called. https://gitlab.winehq.org/wine/wine/-/merge_requests/268

2 3

[PATCH v2 0/1] MR267: riched20: Commit and repaint after changing TextFont properties. (#53170)
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: riched20: Commit and repaint after changing TextFont properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/267

3 4

[PATCH 0/2] MR282: ntdll: Set r11 on exit from syscall dispatcher on x64.
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/282

2 2

[PATCH 0/3] MR281: A few fixes in xmllite
by David Kahurani (＠kahurani) 20 Jun '22

20 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/281

2 3

[PATCH 0/1] MR280: include: Add definition of ScriptPlaceOpenType().
by Jactry Zeng (＠jactry) 20 Jun '22

20 Jun '22

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/280

3 2

[PATCH 0/2] MR269: ntdll: Respect zero_bits when mapping a builtin or native PE file.
by Brendan Shanks (＠bshanks) 20 Jun '22

20 Jun '22

Without the changes, the test passes or fails based on the binutils version being used. v2.35 (used on the Debian 11 testbot) gives 64-bit DLLs an image base under 4GB, and the test always passes. On a system with binutils 2.37 or later, 64-bit DLLs are based above 4GBs, and the test will fail. The map_view() change fixes native DLLs, and virtual_map_section() for builtin DLLs. I wasn't sure how to test a native DLL. This showed up under Wow64 when running the 64-bit Notepad++ installer (a 32-bit EXE), which runs 32-bit regsvr32 to register a 64-bit DLL. regsvr32 calls LoadLibraryExW() with LOAD_LIBRARY_AS_IMAGE_RESOURCE, which was returning a truncated pointer to the DLLs base address. Accessing this then crashed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/269

3 3

[PATCH 0/1] MR277: cmd: Handle lines with just spaces in bracket blocks.
by Bernhard Übelacker (＠bernhardu) 20 Jun '22

20 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51599 This patch attempts to ignore lines with just spaces inside bracket blocks like it does already for completely empty lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/277

3 4

[PATCH 0/1] MR279: d3drm: IDirect3DRMMeshBuilder3 Optimize fake success
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '22

20 Jun '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/279

2 1

[PATCH 0/9] MR278: d2d1: Partially implement effect registration parsing.
by Nikolay Sivov (＠nsivov) 19 Jun '22

19 Jun '22

This slightly reworks xmllite integration comparing to earlier patches, and add a proper forward to CreateEffect(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/278

3 9

[PATCH v4 1/8] server: Actually set initial status in set_async_direct_result handler.
by Jinoh Kang 19 Jun '22

19 Jun '22

Commit 15483b1a126 (server: Allow calling async_handoff() with status code STATUS_ALERTED., 2022-02-10) introduced the set_async_direct_result handler which calls async_set_initial_status(). However, the async_set_initial_status() call does nothing since async->terminated is set, leaving the async in a confusing state (unknown_status = 1 but pending/completed). So far, this issue is unlikely to have been a problem in practice for the following reasons: 1. async_set_initial_status() would have unset unknown_status, but it remains set instead. This is usually not a problem, since unknown_status is usually ever read by code paths effectively unreachable for non-device (e.g. socket) asyncs. It would still potentially allow set_async_direct_result to be called multiple times, but it wouldn't actually happen in practice unless something goes wrong. 2. async_set_initial_status() would have set initial_status; however, it is left with the default value STATUS_PENDING. If the actual status is something other than that, the handler closes the wait handle and async_satisfied (the only realconsumer of initial_status) would never be called anyway. For reasons above, this issue is not effectively observable or testable. Nonetheless, the current code does leave the async object in an inconsistent state. Fix this by removing the !async->terminated check in async_set_initial_status(). Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- Notes: v1 -> v2: no changes v2 -> v3: no changes v3 -> v4: reuse async_set_initial_status() per feedback server/async.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/server/async.c b/server/async.c index 7d0ff10f7a4..e92d4583c1e 100644 --- a/server/async.c +++ b/server/async.c @@ -303,11 +303,8 @@ struct async *create_async( struct fd *fd, struct thread *thread, const async_da void async_set_initial_status( struct async *async, unsigned int status ) { assert( async->unknown_status ); - if (!async->terminated) - { - async->initial_status = status; - async->unknown_status = 0; - } + async->initial_status = status; + async->unknown_status = 0; } void set_async_pending( struct async *async ) -- 2.34.1

3 10

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel