wine-devel

wine-devel@winehq.org

4 participants
84464 discussions

controls/edit.c not so clean - help please
by Carl Sopchak 11 Nov '02

11 Nov '02

The following code is in the EDIT_MakeFit() function: if ((es->buffer_limit > 0) && (size > es->buffer_limit)) { EDIT_NOTIFY_PARENT(es, EN_MAXTEXT, "EN_MAXTEXT"); return FALSE; } if ((es->buffer_limit > 0) && (size > es->buffer_limit)) size = es->buffer_limit; Obviously, the second IF condition is never true, since it's the same as the prior IF, which does a 'return FALSE'. EDIT_MakeFit() is ONLY called by EDIT_EM_ReplaceSel(), so it sppears that the second IF is attempting to limit the amount of text that is replaced to the buffer_limit. Obviously, the first IF just notifies the parent that the limit would be exceeded, then returns without modifying the edit control. Although EDIT_MakeFit() is only called from one place, EDIT_EM_ReplaceSel() is called all over the place, enumerated below. Can anyone tell me if any of these invocations should (a) fail without replacing, (b) replace the limited amount of text, or (c) ignore the limit? EDIT_WM_Clear() - Processes WM_CLEAR message - I assume it's moot here... Processing of EM_REPLACESEL message. See note below... EDIT_EM_Undo() - Processes EM_UNDO and WM_UNDO messages EDIT_WM_Char() - Process WM_CHAR message EDIT_WM_Create() - Processes WM_CREATE message - I assume it's moot here... EDIT_WM_Paste - Process WM_PASTE message EDIT_WM_SetText - Process WM_SETTEXT message. See note below... Note: Under the message EM_LIMITTEXT, MSDN states that WM_SETTEXT will not adhear to the limit, but doesn't mention any other text modification messages. The man pages for the other messages do not mention how it's action is effected by the limit. MSDN does state "The EM_LIMITTEXT message limits only the text the user can enter." Unfortunately, I don't have a MS Windows box readily available to test some of these things out on... - - - - - - - - - Another question about this code from controls/edit.c/EDIT_WM_Char(): /* Protect read-only edit control from modification */ if(es->style & ES_READONLY) return; /* BECAUSE OF THIS... */ control = GetKeyState(VK_CONTROL) & 0x8000; switch (c) { case '\r': /* If the edit doesn't want the return and it's not a multiline edit, do nothing */ if(!(es->style & ES_MULTILINE) && !(es->style & ES_WANTRETURN)) break; case '\n': if (es->style & ES_MULTILINE) { if (es->style & ES_READONLY) { /* ... WE NEVER GET HERE! */ EDIT_MoveHome(es, FALSE); EDIT_MoveDown_ML(es, FALSE); } else { static const WCHAR cr_lfW[] = {'\r','\n',0}; EDIT_EM_ReplaceSel(es, TRUE, cr_lfW, TRUE, TRUE); } } break; The place that I marked "/* BECAUSE OF THIS... */" means that the code marked by "/* ... WE NEVER GET HERE! */" will never get executed. My question: In a read only multiline edit control, should a newline move the cursor to the beginning of the next line of text in the control? (I could make this change, but don't have any way of testing it...) - - - - - Thanks for the help, Carl

3 3

Help support
by Dimitrie O. Paun 11 Nov '02

11 Nov '02

Another on for the 0.9 TODO: -- launching Help from apps This does not work now, IIRC. It's rather 'simple', and visible from the user POV, so needs fixing IMO. -- Dimi.

9 24

Quicken 2000 / edit.c MakeFit() bug...
by Carl Sopchak 11 Nov '02

11 Nov '02

I'm having the following problem with Quicken 2000 Deluxe under wine (CVS as of Thursday morning [and all prior versions]): When I open an investment account, then click on the security name in an existing transaction, and that security name is fairly long (say, 20+ characters), the name gets replaced by the trandaction date! This does not happen with MS Windows. (Before I go any farther, I must say that I know virtually NOTHING about windows programming, and only a small bit more about Wine coding and debugging...) After spending two days drudging through --debugmsg +all logs, I think I have a pretty good idea what's happening. It appears that Quicken uses a single Edit Control for all of it's input fields. When the account is opened, the initial editable field is the date of a new transaction. Quicken sets the maximum input length (with EM_LIMITTEXT) to 10. (Makes sense for a date...) This sets buffer_limit in it's EDITSTATE to 10. Now, when you then go and click on the security name in that existing transaction, Quicken uses WM_SETTEXT to set it's value. Under Wine, this fails, because the size of the string is greater than es->buffer_limit (checked near the top of EDIT_MakeFit() in controls/edit.c). Now, EDIT_MakeFit() does notify Quicken with EN_MAXTEXT, but Quicken doesn't seem to respond in any sensible manner (like getting a bigger control and trying again). (I have not followed this path past this point, but I know that the security name gets wiped out...) Quicken will, AFTER issuing the SETTEXT, try to re-size the field with EM_LIMITTEXT to 30, a security name length. I quote from MSDN (EM_LIMITTEXT Message Remarks section): "The EM_LIMITTEXT message limits only the text the user can enter. It does not affect any text already in the edit control when the message is sent, nor does it affect the length of the text copied to the edit control by the WM_SETTEXT message. If an application uses the WM_SETTEXT message to place more text into an edit control than is specified in the EM_LIMITTEXT message, the user can edit the entire contents of the edit control. " So, according to MSDN, the WM_SETTEXT should successfully set the text to the full length, regardless of the value of buffer_limit. I am in the process of making this change and testing it. I guess my main concern at this point is, "Are there any other ramifications to making this change that I should be concerned about?" If anyone wants to point me in a direction here, I'll follow through... Carl

1 0

Re: Help support
by Mike Hearn 11 Nov '02

11 Nov '02

Well, I for one (though as i'm not writing the code this is just my comments) would not be willing to choose a rendering engine based on whether it works or not on platform X. Both Mozilla and KHTML work quite well on a large number of platforms. I'd need to know a lot more about why Mozilla doesn't work well on OpenBSD before ruling out gecko - like, is it due to something missing on OpenBSD itself. In particular due to the very few numbers of people using it on the desktop, I'd say if Mozilla doesn't work on that platform it's the problem of obsd or mozilla, not Wine. On the other hand, I don't really think Gecko is right for this anyway, so it's something of a moot point. Generally though I'd say that making decisions based on what certain platforms can and cannot do is a bad idea when said platform is in the minority of usage (esp when it's all open source). Flame away. On Mon, 2002-11-11 at 11:23, Keith Matthews wrote: > On 11 Nov 2002 08:29:49 +0000 > "Mike Hearn" <m.hearn(a)signal.qinetiq.com> wrote: > > > Hi, > > > > Please make sure you try whatever rendering engine you choose with a > > wide sample of CHM pages. From what I remember of my Windows days, CHM > > help often contains lots of IEisms, from VBScript to IE specific > > DHTML, ie they're not standard HTML despite the name. > > > > Whatever renderer is chosen then should be one we can easily fork and > > massage into a relatively IE compatible one. Here is a quick roundup > > of the options based on what I know of the available engines: > > > > - Gecko: the best (in terms of features/compatability/speed) rendering > > engine around. Also benefits from being very widely deployed at least > > on Linux. Note that soon Mozilla will be splitting into a GRE (gecko > > runtime environment), then an XRE (xul runtime) layered on top, with > > Mozilla being an "application" on top of that framework. When this > > happens, making the GRE a dependancy of Wine would not be such a big > > deal IMHO, it's only a few megs at the moment. > > > > * Pros: We get a high quality rendering engine that we know is > > powerful enough to do what we need, and when the GRE thing happens > > it'll be relatively easy to embed too. Already has IWebBrowser > > interfaces(bitrotted afaik). > > * Cons: Gecko codebase is huge and complex, adding whatever IEisms > > are > > necessary may be hard. Overhead of XPCOM etc. > > > I'll add something else here. > > Mozilla is an absolute pain to run on OpenBSD. The porting team have > recently worked out that they can get it to run as long as they > statically link it. > > I have no idea if the Gecko part is affected by this, and I'm aware that > Wine does not currently run on OBSD anyway, but why make things more > difficult. > > Konq runs happily so KHTML is probably no problem and I have not heard > of any problems with GtkHTML. > >

1 0

Free to a good home :)
by Thomas Wickline 11 Nov '02

11 Nov '02

Hello, I have went through my closet and I have found some computer Stuff that I no longer use. And if anyone here is in need of any of this I will be more than glad to let you have it .... No strings attached.. Don't be shy to ask the items are only collecting dust and taking up space. Everything works as far I know.. If you are in need of one of these Items just send me a private E-Mail and ill send it to you. 1) 2 - 128MB PC133 SDram Chips ( Corsair ) 2) 1 - Netgear 10/100 Mbps PCI Ethernet Card and Cables 3) 1 - Philips USB Digital Speaker system works as Analog speakers as well ( Model DSS 350 ) 4) 1 - PS/2 Microsoft two button scroll Intellimouse 5) 1 - Microsoft SideWinder USB Force Feedback-2 JoyStick 6) 1 - 6.2 Gig Seagate HD ( used but still works ) 7) 10 - 1.44 MB floppy drives 8) Ethernet, Printer & Phone Cables, Mouse Pads, HD & CD-Rom Brackets Since Ender does not want a new HD and I offered to get him one I will send $50.00 to the Wine Party Fund $25.00 to Marcus Meissner & $25.00 to Douglas Ridgway http://www.winehq.com/about/index.php?contrib#donate Thomas Wickline

2 1

Re: Question regarding the debate over whether Wine Is Not an Emulator or not..
by Dmitry Timoshkov 11 Nov '02

11 Nov '02

"Keith Matthews" <keith_m(a)sweeney.demon.co.uk> wrote: > On Mon, 11 Nov 2002 00:47:44 -0500 > "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > > > On November 8, 2002 10:22 pm, Francois Gouget wrote: > > > If going that way you can use the following: > > > > > > Debunking Wine Myths > > > > > > 1. Myth 1: "Wine is slow because it is an emulator" > > > http://www.winehq.com/about/index.php?myths > > > > Yeah, that's a good start. But I think it's better to avoid the > > whole issue by just not using the work emulator that much. It > > doesn't seem to matter that we say it's NOT an emulator. People > > seem to remember something about an emulator... :( > > > > We should try to position Wine as a (1) PE loader, and (2) toolkit. > > Both are Good Things in geek culture (see ELF loader, and GTK/QT/wxWindows), > > so hopefully we'll have fewer battles to fight. > > > > I think Wine is actually a 'glue', albeit a very thick one. Probably it would be helpful to add that even under NT based OSes Win32 is implemented (emulated) on the top of the Native API. In other words even Microsoft platforms has another layer of APIs under Win32 API. -- Dmitry.

1 0

Error while trying to run a wine
by sean 11 Nov '02

11 Nov '02

When running wine with a program that i developed with with delphi 6. I get the following error " variant array out of bounds" can anyone help me i dont know where to start looking to fix this problem -- This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager.Please note that any views or opinions presented in this email are solely those of the author and not necessarily those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses.The company accepts no liability for any damage caused by any virus transmitted by this email.

2 1

Re: Mozilla 1.0.1 Win32 works almost flawlessly
by Dimitrie O. Paun 11 Nov '02

11 Nov '02

On November 7, 2002 11:40 am, Andreas Mohr wrote: [Cc:ed to the list maybe people want to comment of it] > Now how to solve the winelauncher wineboot launch problem ? > This needs to be done on first launch only, and it needs to avoid race > conditions. > Maybe we could add the lockfile command (courtesy procmail) to Wine > and implement it with that ? I think we need a well defined notion of 'boot' What about this: on server startup, we do this: if (wine_need_reboot()) spawn("wineboot"); The thing is: 1. dead simple 2. atomic, avoids races 3. fast Surely I may be missing something, but what's wrong with the above? (mind you, I know nothing about the server, but still... :)) -- Dimi.

3 2

Newbe posting, OCX files.
by Ben Clewett 11 Nov '02

11 Nov '02

Dear Wine, I have been discussing using WINE as an alternate platform for our company as a way of porting our code to Linux. Something I belive is in the interestes of all centient companies. I have been told that there is a problem of running .OCX visual controls though Wine. Can somebody clarify this for me? With thanks, Ben Clewett.

1 0

Question regarding the debate over whether Wine Is Not an Emulator or not..
by Dustin Navea 11 Nov '02

11 Nov '02

In the wine users guide intro it says, and I quote: The former method uses emulation to connect a Windows application to the Wine libraries. You can run your Windows application directly with the emulator, by installing through Wine or by simply copying the Windows executables onto your Linux system. Should I change this or no, because AFAIK, to some people "emulators have not and will not ever un things as fast as the original" and that would give them a bad idea about wine. -Dustin __________________________________________________ Do you Yahoo!? U2 on LAUNCH - Exclusive greatest hits videos http://launch.yahoo.com/u2

4 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel