wine-devel

wine-devel@winehq.org

11 participants
84440 discussions

Bug 572
by Andriy Palamarchuk 26 Apr '02

26 Apr '02

Alexandre, could you look at bug 572: http://bugs.codeweavers.com/show_bug.cgi?id=572 It is possible that this bug is caused by your patch. Thanks, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

2 2

existing cooperation with mono?
by Freddy BL 26 Apr '02

26 Apr '02

Hi Wine-Team! Existing cooperations between the Wine-project and the Mono-project (http://www.go-mono.org)? At the moment it seams, that in the future there exists under MS-Windows three types of programs: programs which are in native-code (that can be run on Wine and can be portet to Linux by re-compiling with Wine), programs which are in MS-IL-code (that can in the future be run on Mono I hope) and mixed programs (IL-Code-programs, which integrate Native-Code DLLs and Native-Code-programs, which integrate IL-Code DLLs). And I think, that for the last type of programs a cooperation between the Wine-Devels and the Mono-Devels is very advantageous. So, existing this cooperations? (One of the results of an coopration could be an installer like that by CodeWeavers, which can be install both (Wine and Mono) for example) Greatings Freddy BL _________________________________________________________________ Senden und empfangen Sie Hotmail über Ihr Mobilgerät: http://mobile.msn.com

3 2

[Germany] Linuxtag
by Uwe Bonnes 26 Apr '02

26 Apr '02

Hallo, is there anybody beside me willing to care for a booth at Linuxtag June 6-9 in Karlsruhe? Please give feedback so I can apply for a booth. Beside our normal program winex and crossover might be good objects to demonstrate. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

More BUG fixes for winsock2 patch series
by Martin Wilck 26 Apr '02

26 Apr '02

Patch: BUGS in my recently submitted patch series This applies over my complete patch series - I will send clean patches tomorrow. The fixes in server/file.c and server/serial.c relate to Rein Klazes' problem. Rein: please tell me if they fix it!! Patch http://www.winehq.com/hypermail/wine-patches/2002/04/0163.html is also needed. Modfied files: dlls/winsock: socket.c (allocation error) server: sock.c (remove socket from select loop for blocking sockets, too) file.c (try to serve async requests immediately) serial.c (dito) diff -ruNX ignore CVS/wine/dlls/winsock/socket.c TMP/wine/dlls/winsock/socket.c --- CVS/wine/dlls/winsock/socket.c Thu Apr 25 20:20:37 2002 +++ TMP/wine/dlls/winsock/socket.c Thu Apr 25 19:46:05 2002 @@ -2479,7 +2479,7 @@ goto error; } - iovec = WS_ALLOC ( dwBufferCount * sizeof (struct iovec) ); + iovec = HeapAlloc (GetProcessHeap(), 0, dwBufferCount * sizeof (struct iovec) ); if ( !iovec ) { diff -ruNX ignore CVS/wine/server/file.c TMP/wine/server/file.c --- CVS/wine/server/file.c Thu Apr 25 20:20:36 2002 +++ TMP/wine/server/file.c Thu Apr 25 20:18:57 2002 @@ -389,6 +389,8 @@ if ( status == STATUS_PENDING ) { + struct pollfd pfd; + if ( !async ) async = create_async ( obj, current, ptr ); if ( !async ) @@ -397,6 +399,15 @@ async->status = STATUS_PENDING; if ( !async->q ) async_insert( q, async ); + + /* Check if the new pending request can be served immediately */ + pfd.fd = obj->fd; + pfd.events = file_get_poll_events ( obj ); + pfd.revents = 0; + poll ( &pfd, 1, 0 ); + + if ( pfd.revents ) + file_poll_event ( obj, pfd.revents ); } else if ( async ) destroy_async ( async ); else set_error ( STATUS_INVALID_PARAMETER ); diff -ruNX ignore CVS/wine/server/serial.c TMP/wine/server/serial.c --- CVS/wine/server/serial.c Thu Apr 25 20:20:36 2002 +++ TMP/wine/server/serial.c Thu Apr 25 20:27:11 2002 @@ -282,6 +282,8 @@ if ( status == STATUS_PENDING ) { + struct pollfd pfd; + if ( !async ) async = create_async ( obj, current, ptr ); if ( !async ) @@ -293,6 +295,19 @@ async_add_timeout(async,timeout); async_insert(q, async); } + + /* Check if the new pending request can be served immediately */ + pfd.fd = obj->fd; + pfd.events = serial_get_poll_events ( obj ); + pfd.revents = 0; + poll ( &pfd, 1, 0 ); + + if ( pfd.revents ) + /* serial_poll_event() calls set_select_events() */ + serial_poll_event ( obj, pfd.revents ); + else + set_select_events ( obj, pfd.events ); + return; } else if ( async ) destroy_async ( async ); else set_error ( STATUS_INVALID_PARAMETER ); diff -ruNX ignore CVS/wine/server/sock.c TMP/wine/server/sock.c --- CVS/wine/server/sock.c Thu Apr 25 20:20:36 2002 +++ TMP/wine/server/sock.c Thu Apr 25 15:10:54 2002 @@ -250,7 +250,6 @@ sock->errors[FD_CONNECT_BIT] = sock_error( sock->obj.fd ); if (debug_level) fprintf(stderr, "socket %d connection failure\n", sock->obj.fd); - set_select_events( &sock->obj, -1 ); } } else if (sock->state & FD_WINE_LISTENING) @@ -269,7 +268,6 @@ sock->pmask |= FD_ACCEPT; sock->errors[FD_ACCEPT_BIT] = sock_error( sock->obj.fd ); sock->hmask |= FD_ACCEPT; - set_select_events( &sock->obj, -1 ); } } else { @@ -335,11 +333,17 @@ if (debug_level) fprintf(stderr, "socket %d aborted by error %d, event: %x - removing from select loop\n", sock->obj.fd, sock->errors[FD_CLOSE_BIT], event); - set_select_events( &sock->obj, -1 ); } } - sock_reselect( sock ); + if ( sock->pmask & FD_CLOSE || event & (POLLERR|POLLHUP) ) + { + if ( debug_level ) + fprintf ( stderr, "removing socket %d from select loop\n", sock->obj.fd ); + set_select_events( &sock->obj, -1 ); + } + else + sock_reselect( sock ); /* wake up anyone waiting for whatever just happened */ if ( sock->pmask & sock->mask || sock->flags & FD_FLAG_OVERLAPPED ) sock_wake_up( sock, event );

3 2

Last header patch for Mingw32 I think (wingdi.h)
by Steven Edwards 26 Apr '02

26 Apr '02

cvs diff -u wingdi.h Index: wingdi.h =================================================================== RCS file: /home/wine/wine/include/wingdi.h,v retrieving revision 1.69 diff -u -r1.69 wingdi.h --- wingdi.h 3 Apr 2002 22:08:27 -0000 1.69 +++ wingdi.h 25 Apr 2002 16:48:19 -0000 @@ -24,6 +24,14 @@ extern "C" { #endif +#ifdef __MINGW__ +#undef _MAX_PATH +#undef _MAX_DIR +#undef _MAX_EXT +#undef _MAX_DRIVE +#include "stdlib.h" +#endif + typedef struct _ABCFLOAT { FLOAT abcfA; FLOAT abcfB; "Every revolution was once a thought in one man's mind" - Ralph Waldo Emerson

2 3

Re: Send the first two mingw32 patches to /dev/null and use these instead
by Alexandre Julliard 26 Apr '02

26 Apr '02

"Steven Edwards" <Steven_Ed4153(a)yahoo.com> writes: > Index: windef.h > =================================================================== > RCS file: /home/wine/wine/include/windef.h,v > retrieving revision 1.62 > diff -u -r1.62 windef.h > --- windef.h 10 Mar 2002 00:02:34 -0000 1.62 > +++ windef.h 25 Apr 2002 02:09:36 -0000 > @@ -157,8 +157,9 @@ > #define _MAX_EXT _MAX_FNAME > #define _MAX_PATH 260 > #endif > +#if ! defined (__MINGW__) > #define MAX_PATH _MAX_PATH > - > +#endif This seems to be a mingw32 bug, it is not supposed to define MAX_PATH, only _MAX_PATH. At least that's how it's done under Windows. -- Alexandre Julliard julliard(a)winehq.com

2 1

First attempt at unit testing. Victim of choice: _hread()
by Jakob Eriksson 25 Apr '02

25 Apr '02

Thanks to Vincent Béron and Francois Gouget I've managed to do my own little unit test. I post it here hoping for comments of any kind: possible improvements, additions, advice etc. (I guess I could add some more limit-tests, trying to read many small chunks in a row see that I still end up in the right place in the file. Things like that.) -------- #include "winbase.h" #include "winerror.h" #include "wine/test.h" static void test__hread( void ) { LPCSTR filename = "testfile.xxx"; LPCSTR sillytext = "en larvig liten text dx \033 gx hej 84 hej 4484 ! \001\033 bla bla..."; HFILE filehandle; char buffer[10000]; long bytes_read; UINT bytes_wanted; UINT i; filehandle = _lcreat( filename, 0 ); ok( HFILE_ERROR != filehandle, "_lcreat complains." ); ok( HFILE_ERROR != _hwrite( filehandle, sillytext, strlen( sillytext ) ), "_hwrite complains." ); ok( HFILE_ERROR != _lclose(filehandle), "_lclose complains." ); filehandle = _lopen( filename, OF_READ ); bytes_read = _hread( filehandle, buffer, 2 * strlen( sillytext )); ok( strlen( sillytext ) == bytes_read, "file has wrong size."); for (bytes_wanted = 0; bytes_wanted < strlen( sillytext ); bytes_wanted++) { ok( 0 == _llseek( filehandle, 0, FILE_BEGIN ), "_llseek complains." ); ok( _hread( filehandle, buffer, bytes_wanted ) == bytes_wanted, "erratic _hread return value." ); for (i = 0; i < bytes_wanted; i++) { ok( buffer[i] == sillytext[i], "that's not what's written." ); } } ok( HFILE_ERROR != _lclose( filehandle ), "_lclose complains." ); ok( DeleteFileA( filename ) != 0, "DeleteFile complains." ); } START_TEST(file) { test__hread( ); } -- regards, Jakob Eriksson The wages of sin is debugging. -- Ron Jeffries

1 0

Re: wine/ dlls/winsock/socket.c dlls/winsock/ws2_3 ...
by Michael Cardenas 25 Apr '02

25 Apr '02

do these patches include his fixes from today? On Thursday 25 April 2002 05:34 pm, you wrote: > ChangeSet ID: 1019770464826040353932516 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 02/04/25 16:34:24 > > Modified files: > dlls/winsock : socket.c ws2_32.spec > files : file.c > include : winbase.h > > Log message: > Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com> > Implemented overlapped WSARecvFrom(), WSASendTo(), and > WSAGetOverlappedResult(). > Fixed shutdown() to work correctly for overlapped sockets (do not > actually do a shutdown() system call as long as there are pending > overlapped requests). > Also added correct error reporting when trying to read or write on a > shut down connection, also for ReadFile()/WriteFile() calls. > > Patch: http://cvs.winehq.com/patch.py?id=1019770464826040353932516 > > Revision Changes Path > 1.92 +679 -122 wine/dlls/winsock/socket.c > 1.20 +1 -1 wine/dlls/winsock/ws2_32.spec > 1.143 +22 -5 wine/files/file.c > 1.142 +1 -1 wine/include/winbase.h -- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi

2 1

cprof Profiler
by John Levon 25 Apr '02

25 Apr '02

Hi, saw your question on the weekly news. I noticed nobody had pointed out that what was cprof is now available under the eazel-tools module of the Gnome CVS repository (I believe). It also has some changes from the old cprof version like shared library support regards john -- "I continue to be amazed at what Andrei can make templates do. Some of it still makes my head hurt." - Herb Sutter

1 0

Re: [PATCH UPDATE] tools/wineshelllink *METHOD 4*
by Paul Millar 25 Apr '02

25 Apr '02

On Thu, 25 Apr 2002, Speeddymon wrote: > + if [ -d "/usr/lib/menu" -a "$mode" = "menu" -a ! `whoami` = "root" ] > + then [...] > + elif [ `whoami` = "root" ] > + then > + mdk_entry >> "/usr/lib/menu/wine" > + fi Sorry, I haven't been following this but isn't the elif condition redundant? Also, AFAIK although its unusual, there's no reason an account name cannot have a space in it, so `whoami` should be "`whoami`" [spent too much time debugging strings in scripts ;^] ---- Paul Millar

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel