wine-devel

wine-devel@winehq.org

4 participants
84403 discussions

Re: small patch for ./tools/wineinstall
by Speeddymon 23 Apr '02

23 Apr '02

alright thanks, the reason i thought you needed internet/cvs was because of the way that the winehq patch-making page was worded...it says to use cvs diff (instead of regular diff). I thoguht that there may be a difference in the 2, so I didnt want to make the diffs with diff when they required cvs diff. But now that I know, i will submit in diff format... Maybe the winehq site maintainer (alexandre?) could make that a little more clear (for us patch-contributing newbies/relative newbies) --- Tony Lambregts <tony_lambregts(a)telusplanet.net> wrote: > Speeddymon wrote: > > >as I have said a couple times, i dont have any way > to > >make the proper diff's due to the fact that I have > no > >internet at home, thanks again for making them for > me, > >I will be submitting the 2 diff's tomorrow (can't > do > >it here due to the fact that this computer is at > >compusa and has downloading disabled) > > > >Would there be anyone willing to make diff's for me > >when I have a patch to post? if so, could you > please > >email me directly so I know who to talk to? > > > >Thanks in advance > > > Well I would be glad to make diffs for you but it > really is not required > that you have CVS or the Internet to make propper > diffs. > > diff -u wineinstall.old wineinstall > > wineinstall.dif > > Where wineinstall.old is the original file (that you > saved somewhere or > got from the tarball) and wineinstall is the file > with your changes. > "man diff" will give you more information but thats > about all that you > need to know. > > You can edit the wineinstall.dif to get rid of the > .old extention but > I'm not sure its required. I guess to be on the safe > side I would get > rid of it. > > Tony Lambregts > > > PS: dont feel too bad there are tons of stuff that I > don't know either. > > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

1 0

toolbar.c problem (ATTN: Duane)
by Dusan Vujosevic 23 Apr '02

23 Apr '02

Hi, I am having a problem with the way toolbar.c was modified between revisions 1.107 & 1.108. My application (Signlab) pops flyout toolbars that stay around until they lose focus. The parent toolbar receives a 'TBN_DROPDOWN' message when someone clicks on one of its flyout buttons (button style: TBSTYLE_DROPDOWN). It creates a flyout at that point. With revision 1.108 of toolbar.c in Wine the parent toolbar also receives an WN_COMMAND after TBN_DROPDOWN message which causes Wine (rightly so) to send an WM_SETFOCUS (and WM_ACTIVATE). That causes the parent to regain focus and kills the flyout. The line that sends the WN_COMMAND is in toolbar.c at line 4540 (TOOLBAR_LButtonUp() function): SendMessageA (infoPtr->hwndNotify, WM_COMMAND, MAKEWPARAM(infoPtr->buttons[nHit].idCommand, 0), (LPARAM)hwnd); In revision 1.107 it used to be: if (bSendMessage) SendMessageA (infoPtr->hwndNotify, WM_COMMAND, MAKEWPARAM(btnPtr->idCommand, 0), (LPARAM)hwnd); And that worked fine because it would never send WM_COMMAND for a flyout button. Note that WinXP (that's where I tested) doesn't send WM_COMMAND after TBN_DROPDOWN has been handled. I would like to suggest revert that line back to 1.106 because it is the correct way. If other apps are were having problems with 1.106 (Duane was mentioning Acrobat Reader - I will test that..) I suggest that the problem might be elsewhere. Should I supply a patch? Cheers, Dusan

4 12

Re:unit test (C) with WINAPIV function
by Eric Pouech 23 Apr '02

23 Apr '02

> ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); shouldn't it be wsprintfW (buf, fmt, -1) == 10 instead ? ^ | A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

1 0

unit test (C) with WINAPIV function
by Medland, Bill 23 Apr '02

23 Apr '02

Any chance of some help with this? Yesterday i submitted a unit test for wsprintfA. I didn't include wsprintfW because I couldn't get it to work right. I still can't. I think it's something to do with the calling convention (since wsprintf uses cdecl, not stdcall). Here's the test code itself; static BOOL wsprintfWTest (void) { WCHAR buf[25]; static const WCHAR fmt[] = {'%','0','1','0','l','d','\0'}; WCHAR target[] = {'-','0','0','0','0','0','0','0','0','1'}; printf ("%p %p\n", buf, fmt); ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); ok ((lstrcmpW (buf, target) == 0), "wsprintfW zero padded negative value failure\n"); return TRUE; } but if I print the addresses of buf and fmt from within wsprintfW I get the same values for buf but for fmt I get a smaller pointer (0x401ecac instead of 0x401ecae) (and I can't figure out how to get at it in gdb to see exactly what is going on). Am I missing something obvious? Bill

3 2

RE: unit test (C) with WINAPIV function - sorry
by Medland, Bill 23 Apr '02

23 Apr '02

> -----Original Message----- > From: Medland, Bill [mailto:Bill.Medland@accpac.com] SNIP > ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); DUH! > Am I missing something obvious? Yes Bill

1 0

Re: fixme:dialog:MSGBOX_OnInit task modal msgbox ! Not modal yet.
by David Yerger 23 Apr '02

23 Apr '02

Just wanted to say the winpos.c.diff patch of 12/25/2001 works like a charm for me. [Was my first experience actually building wine from source - took me about two days to figure out how to patch an SRPM and build the patched version. Apparently what you're supposed to do is put the patch in the SOURCES folder, modify the spec file, run rpm -bb <specfile> and let it rip. Had no success doing rpm -bp wine.spec, patching manually and then running configure manually, or using tools/wineconfig, and then running rpm -bi --short-circuit or make install - I could build the program but it complained when I tried to run it. Sorry, I thought I wrote down the complaint. . . Oh well, I'm pretty sure it's because of something I did wrong anyway.] Thanks Laurent! David Yerger

2 1

Please educate me
by Medland, Bill 23 Apr '02

23 Apr '02

Can anyone explain what is going on here please; this is obviously an area of bash etc I don't understand. This morning I was doing a fresh install on a totally clean machine from the Wine-20020411 tarball under Redhat 7.1. All went reasonable well until I saw a "..<something not write> .." go flashing past as I ran wineinstall and later on the regapi failed because it couldn't find libntdll.dll.so. OK so I guess it was the ldconfig that failed!! So I thought "lets fix it". Yes; in the last fix to wineinstall where we went with using "su root" instead the ldconfig was hard-coded (and wasn't on the path for simply "su root"). So I followed up on the machine I normally use and started messing about with $ac_cv_path_LDCONFIG. I got that working, consistant on hand-editing the config.cache to change "true" to "/sbin/ldconfig". So the remaining thing was to get the cache entry generated correctly. This is where the problem is. (I still don't understand why it should get set either to the name of an executable or to the value "true"; I dislike variables holding dissimilar types). Anyway I was watching the loop so see why it wasn't finding the /sbin/ldconfig and I noticed that for ac_dir in /sbin:/usr/sbin:$PATH was splitting as 1. /sbin:/usr/sbin:/usr/local/bin 2. /bin 3. /usr/bin etc. Now, I know I can force it to work by changing the for loop to for ac_dir in /sbin /usr/sbin $PATH However the original form used to work (I guess, since the cache is correct on my other machine) so I'd rather know why it isn't working currently and fix that Can anyone explain why it isn't splitting the for the way we want it to TIA Bill

4 3

Re: Enhancements and fixes for the rich text edit control
by Alexandre Julliard 22 Apr '02

22 Apr '02

ccrayne(a)crayne.org writes: > Because of this concept, it was necessay to make two small changes to > edit.c -- to move the definition of the EDITSTATE structure into (new > file) edit.h, and to add support in function EDIT_BuildLineDefs_ML to > recognize "\n" as an alternative soft line break. I don't think richedit should know about edit.c internal structures (and it seems your patch didn't require that anyway) so I haven't applied that part of the patch. If we really need to access the internal edit structure it will have to be made Windows-compatible so that we can still mix builtin and native dlls. But it's better to avoid it if possible. -- Alexandre Julliard julliard(a)winehq.com

1 0

dlls/kernel/comm.c build failure
by Gerald Pfeifer 22 Apr '02

22 Apr '02

The following patch revision 1.56 date: 2002/04/21 22:06:09; author: julliard; state: Exp; lines: +24 -0 <wine(a)gc2.kloepfer.org> Faster serial speed cases for non Linux systems. broke dlls/kernel/comm.c on FreeBSD 4.5 (and probably all non-Linux systems) /usr/bin/gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o comm.o comm.c comm.c: In function `SetCommState': comm.c:1063: `CBR_230400' undeclared (first use in this function) comm.c:1063: (Each undeclared identifier is reported only once comm.c:1063: for each function it appears in.) gmake[2]: *** [comm.o] Error 1 gmake[2]: Leaving directory `/.amd_mnt/vexpert/files8/test/wine/dlls/kernel' gmake[1]: *** [kernel/kernel32.dll.so] Error 2 apparently because CBR_230400 is not #defined in include/winbase.h. The patch below fixes this, but I suppose it's not what will go in finally... Gerald ChangeLog: Only use CBR_230400 and CBR_460800 if they have been defined. Index: dlls/kernel/comm.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/comm.c,v retrieving revision 1.56 diff -u -3 -p -r1.56 comm.c --- dlls/kernel/comm.c 21 Apr 2002 22:06:09 -0000 1.56 +++ dlls/kernel/comm.c 22 Apr 2002 06:44:43 -0000 @@ -1060,13 +1060,17 @@ BOOL WINAPI SetCommState( #endif #ifdef B230400 case 230400: +#ifdef CBR_230400 case CBR_230400: +#endif port.c_cflag |= B230400; break; #endif #ifdef B460800 case 460800: +#ifdef CBR_460800 case CBR_460800: +#endif port.c_cflag |= B460800; break; #endif

3 2

RE: bug?
by Medland, Bill 22 Apr '02

22 Apr '02

> -----Original Message----- > From: Rikard Björklind [mailto:olof@linux.nu] > Sent: Saturday, April 20, 2002 5:38 AM > To: wine-devel(a)winehq.com > Subject: bug? > > > Hi, I tried to use ./tools/wineinstall: > > Performing 'make install' as root to install binaries, enter > root password > Password: [here I wrote the password] > /bin/bash: - : unrecognized option > > What's wrong? > > Probably failed to run the ldconfig. Check the /etc/ld.so.conf to see that the location of the wine lib directory is included (probably /usr/local/lib) and su root and run /sbin/ldconfig. Bill

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel