wine-devel

wine-devel@winehq.org

3 participants
84399 discussions

HAVE_IPX cleanup
by Francois Gouget 12 Sep '01

12 Sep '01

This patch attempts to clean up the ws_sockaddr_ipx to sockaddr_ipx conversions (and vice versa). I would really like if people could try this out: I don't have a working IPX network here. At least my very rudimentary tests indicate that this should still work for the TCP/IP case. More details on the patch: * all ws_sockaddr structures must be considered to have a potentially different layout from their Unix counterparts. Sure for now we just borrow the Unix structs anyway but even sockaddr_in does not have the exact same fields on FreeBSD and Linux (although the binary layout is the same). And hopefully we will not borrow the Unix structs for long anyway. FreeBSD testing is another aspect I would appreciate help with (sin_len worries me). * the ws_sockaddr_ipx fields did not match those used by windows. Also ws_sockaddr_ipx was declared in the wrong header. * all conversions are now done in two functions: ws_sockaddr_ws2u and ws_sockaddr_u2ws. If there is a conversion to do then these are the only two places that should be affected. SUPPORTED_PF returns whether a given protocol family is supported or not. * the sockaddr* pointers may point to structures that are more than 16 bytes, typically 28 bytes for IP v6. I tried to take this into account, I hope I did not mess up (but I'm not sure Wine would support TCP/IP v6 anyway). * I modified WSOCK32_accept to call WSOCK32_getpeername thus avoiding the conversion issue entirely in WSOCK32_accept. * all other functions that were doing such conversions were modified to use the above functions. I also tried to make the error handling code more consistent wrt. WSAENOTSOCK, WSAEAFNOSUPPORT, etc. * removed ugly casts in the traces -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

1 0

Russian keyboard layout
by Andriy Palamarchuk 12 Sep '01

12 Sep '01

Hello everybody, I want to fix message about not found keyboard layout for my configuration. The FIXME message is not shown after I add a phantom key definition to russian keyboard layout main_key_RU in file windows/x11drv/keyboard.c I need your advise how to do it correctly. Should I change existing layout - main_key_RU or it is better to add a separate one with phantom key - main_key_RU_phantom, like it is presently done for US layouts? I could not suppress the FIXME message by changing keyboard model in XF86Config from "pc102" to "pc101". My system: Wine release 20010824, installed without Windows, gcc version 2.96 20000731 (Red Hat Linux 7.1 2.96-81) The layout, defined in XF86Config is "ru(winkeys)". Thank you, Andriy Palamarchuk

1 0

Solaris winsock support
by Robert Lunnon 12 Sep '01

12 Sep '01

Trying Eudora 4.3 on Solaris solicits this error err:winsock:WsControl Unable to open /proc filesystem to determine number of network interfaces! Looking about in the code WsControl grubs about in the /proc filesystem to get the names of, and count the number of network interfaces. Since /Proc only hosts processes on Solaris this constitutes a linux dependancy we don't need. Studying the ifconfig source gives another possibility instead which look like it may be more portable using ioctl SIOCGIFCONF on an arbitrary IP socket The return from this call is a structure containing the length of the reply buffer, which seems to contains an array of ifreq structures (one for each interface) which contains among other things the name of the interface. By dividing the size of the buffer by the size of the returned objects we know how many interfaces there are... Questions Anyone know if this is Is this workable ? Is this workable on linux, (I ask because I don't have linux and don't know linux ioctl implementation details)?

3 2

X output problem while displaying splash screen
by Andreas Schuldei 12 Sep '01

12 Sep '01

The part of the screen where the splash screen of the internet explorer should be displayed freezes, but the debug messages keep scrolling for some time. That is why I send the whole output. I used the command line wine -dll=ole2,ole2conv,ole2disp,ole2nls,ole32,oleaut32,olecli,olecli32,olecnv32,oledlg,olepro32,olesvr,olesvr32,olethk32,compobj,rpcrt4,shell,shell32,shfolder,shdocvw,commdlg,comdlg32,commctrl,comctl32,urlmon,SHLWAPI=n .wine/fake_windows/Program\ Files/Internet\ Explorer/IEXPLORE.EXE --debugmsg +relay,+x11

1 0

Re: Focus livelock
by Alexandre Julliard 11 Sep '01

11 Sep '01

Gerard Patel <gerard.patel(a)nerim.net> writes: > Now, when after all this the X events are processed, Wine handles a X > focusin event for A, that is generating a WM_GETFOCUS, then a focusout > for A, generating other WM_KILLFOCUS and WM_ GETFOCUS, > focusin for B, etc..; the sequence of events when creating windows is > perfect, but there are extra events after. > > IMO what's wrong is that X focus events are not ignored when they are the > following of program action. IMO the right fix is to add support for the take focus window manager protocol, and avoid messing with the X focus ourselves. This is somewhere on my todo list... -- Alexandre Julliard julliard(a)winehq.com

2 1

Re: Dialog painting
by Niclas Karlsson MATE 10 Sep '01

10 Sep '01

> Wine currently seems to have a problem painting splash dialogs properly > (or at all). I took a closer look at this. I just ripped out the interesting parts from Speak freely in order to find a simple program exhibiting the problems. What I ended up with was a program which does nothing interesting except to show a simple dialg using CreateDialog(). It still doesn't work under Wine. The source is attached. I'm somewhat at a loss about what to do now. I'm just not clear about what should happen and why it doesn't. Some browsing around in the source suggests that it may related to the focus problems Gerard has been talking about, but I'm far from sure. Any comments? Nicke -- -[ nkarlsso(a)abo.fi ]- Seek simplicity, and distrust it. (A. Whitehead)

1 0

Developer offering to help.
by Marco Bizzarri 10 Sep '01

10 Sep '01

Hi all. I've seen in the recent past a task list for newbie developer for wine. I would like to know what are still open, how I could contribute. I've very few skills in Windows development. However, I've good knowledge of development under linux, and usage of gnu tools (autoconf). Bye Marco -- Marco Bizzarri - Responsabile Tecnico - Icube S.r.l. Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia E-mail: m.bizzarri(a)icube.it WWW: www.icube.it Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588

2 1

Re: Focus livelock
by Gerard Patel 10 Sep '01

10 Sep '01

At 10:09 AM 09/09/2001 +0300, you wrote: >I posted a patch that would fix a focus related livelock. >However, I have to admit that the patch is quite hacky and likely >not to be included in Wine. Since I would like to get this bug fixed, >I thought to ask opinions about the correct way to fix the bug. > >The short description of the bug is that setting >active/foreground/focus window in Wine calls >X11DRV_SetFocus, which calls XSetInputFocus. >This makes Wine receive FocusIn event, the handler of >which calls SetForegroundWindow. Even though SetForegroundWindow >does nothing if its parameter matches current foreground window, >it can be easily seen that having more than one window can lead >into livelock. I think that the problem with focus is that when a window is shown by Wine, synthetic WM_GETFOCUS and WM_SETFOCUS events are generated, that are themselves generating X focus events. The X events are kept in the X queue until Wine finds time to handle them. Wine creates window A : WM_GETFOCUS for A Wine creates window B : WM_KILLFOCUS for A, WM_GETFOCUS for B Wine creates window C : WM_KILLFOCUS for B, WM_GETFOCUS for C Now, when after all this the X events are processed, Wine handles a X focusin event for A, that is generating a WM_GETFOCUS, then a focusout for A, generating other WM_KILLFOCUS and WM_ GETFOCUS, focusin for B, etc..; the sequence of events when creating windows is perfect, but there are extra events after. IMO what's wrong is that X focus events are not ignored when they are the following of program action. The following hack disables focus handling in this case. I have no clue on its value since I am currently struggling with other bugs. and I will not come to these problems until some time - maybe a lot of time if current Wine progress (aka regressions :-)) continues. --- event.c.orig Fri Aug 24 09:30:46 2001 +++ event.c Mon Sep 10 13:00:28 2001 @@ -534,6 +534,8 @@ if (!hWnd) return; + if (!event->send_event) return; + bIsDisabled = GetWindowLongA( hWnd, GWL_STYLE ) & WS_DISABLED; /* If the window has been disabled and we are in managed mode, HTH Gerard

1 0

Re: Monkey Island 3
by Gerard Patel 10 Sep '01

10 Sep '01

At 03:11 PM 09/09/2001 +0200, you wrote: >The installation of Curse of Monkey Island seems to be broken in latest >CVS. All I get is a dialog saying that setup requires a different version >of Windows. > >A trace is available on the web at >http://www.lysator.liu.se/~johane/monkey3.txt > >/Johan Gill, johane(a)lysator.liu.se > I have looked at your trace -the app is trying to use a Win32s function. Maybe the problem is that it succeeds. However, Win32s is present in Wine since years and has not been touched since a long time. I think unlikely that it could be a new problem - when was the last working Wine version before current Cvs ? You can find in documentation/cvs-regression a few tips on how to search for the exact date of a regression. FYI the Wine app database list this game as 'playing perfectly directly off the CD' :-) Gerard

1 0

Re: [PATCH] DestroyWindow16
by Gerard Patel 10 Sep '01

10 Sep '01

At 06:40 PM 30/08/2001 +0200, you wrote: >Gerard Patel wrote: >> >> As DestroyWindow does a lot of handle comparaisons, it is necessary >> to give it a real 32 bit handle. This avoids a systematic crash when >> ForteFreeAgent 16 bit exits. I have not looked for other places where >> this can be necessary - but it would not be surprising that this happens. >perhaps as an extension of the relay code ? >(it would mean typing >correctly >windows handles in spec files though) What do you mean by typing ? There is no hwnd type in the spec files, AFAICT. That's not a matter of typing GetWindow(hwnd word) instead of GetWindow(word word) - I think it is necessary to actually change winebuild to define a new type and write a bunch of code to support it. I have looked at the points where it current cvs crashes and it's necessary to fix 16 to 32 bits handles and I have found that 2 changes cure all my new crashes : the one in DestroyWindow16 and another in DefWindowProc16 The reason for these problems is the same : Wine is keeping window handles in several variables (active window, focus window) and Wine code does several comparisons between applications provided handles and these values. In the last case for example, the test /* activate hwndTop if needed. */ if (hwndTop != GetActiveWindow()) { in focus.c fails because of the high word part (and creates an infinite focus loop) I'd say that by adding also handle fixes in SetWindowPos16, SetFocus16 and SetActiveWindow16 as well as fixing the handles setters in queue.c, everything would be covered. IMO your solution is 1) somewhat complex for a fix to apps not widely used anymore 2) overkill because it's not necessary to convert window handles for each and every Api. OTOH your solution is more elegant. I don't know what to do. Gerard

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel