Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

[paulo lesgaz]

Maybe this function should be in util.c.

A+

David

--- En date de : Lun 19.4.10, Henri Verbeet  a écrit :

De: Henri Verbeet 
Objet: Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
À: [e-mail]
Date: Lundi 19 avril 2010, 11h43

On 19 April 2010 09:43, Christian Costa  wrote:
> +BOOL is_pow2(UINT num)
> +{
> +    UINT i;
> -
>
> +    if (!num) return FALSE;
> +    for (i = 0; num >> 1; i++) num >>= 1;
> -
>
> +    return (num << i) == num;
> +}

This should at least be static. You can also just replace it with
"return !(num & (num - 1));". You don't care about 0, since you
already check that earlier in D3DXCheckTextureRequirements().
make_pow2() can probably be simplified as well.