Yes that is very useful! I took a look at the first one I saw on the list. It goes:
==3551== 8 bytes in 1 blocks are definitely lost in loss record 63 of 766 ==3551== at 0x7BC51061: notify_alloc (heap.c:254) ==3551== by 0x7BC5554F: RtlAllocateHeap (heap.c:1716) ==3551== by 0x5C85281: XAudio2Create (xaudio_dll.c:2159) ==3551== by 0x4A1B741: func_xaudio2 (xaudio2.c:1150) ==3551== by 0x4A1C74F: run_test (test.h:603) ==3551== by 0x4A1CBAD: main (test.h:687) ==3551==
To fix it I looked at the XAudio2Create function and noticed that IClassFactory *cf was assigned in the call make_xaudio2_factory(&IID_IClassFactory, (void**)&cf); which contains struct xaudio2_cf *ret = HeapAlloc(GetProcessHeap(), 0, sizeof(struct xaudio2_cf));
Later in the code IClassFactory_Release(cf); is used, but this wouldn't free up the space on the heap because of how that function is implemented.
I'm typing this all out because I don't know how good my thought process is on this. I'm not used to it so trying to chase all these function calls around is kind of difficult. I would appreciate any feedback
On Sat, Mar 17, 2018 at 12:27 PM, Henri Verbeet hverbeet@gmail.com wrote:
On 17 March 2018 at 19:06, Kieran Duggan kieranduggan15@gmail.com wrote:
So I've gone off to look for some fixmes. I started looking at a game
I've
tried to run in the past with no success, Fortnite. Do any of the fixmes in the bug report look doable for a persons first patch?
In case it helps you or anyone else, we also have a number of issues found by Valgrind [1], most of which should be fairly straightforward to debug and most of which should only have a limited scope. If you're feeling a little more ambitious, I also have lists of Direct3D [2] and D3DX [3] bugs with various levels of analysis I'd love for someone to take a look at.
[1] https://bugs.winehq.org/buglist.cgi?bug_status= UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_ status=REOPENED&columnlist=bug_id%2Cshort_desc%2Cbug_ status%2Cresolution&keywords=valgrind&order=bug_id%20DESC [2] https://bugs.winehq.org/buglist.cgi?bug_status= UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_ status=REOPENED&columnlist=bug_id%2Cshort_desc%2Cbug_ status%2Cresolution&component=directx-d3d&keywords=download& order=bug_id%20DESC [3] https://bugs.winehq.org/buglist.cgi?bug_status= UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_ status=REOPENED&columnlist=bug_id%2Cshort_desc%2Cbug_ status%2Cresolution&component=directx-d3dx9&component= directx-d3dx10&keywords=download&order=bug_id%20DESC