On Wed, 30 Jan 2002, Gerhard W. Gruber wrote:
I just wrote a fix for a fixme located in MoveFileExA. Since this is the first time I'm writing something for wine I wanted to ask how I shall proceed now. Shall I simply add it into the CVS or does it have to go somewhere for revision?
Only Alexandre has commit access to the CVS. To submit code for inclusion in Wine you should post a 'diff -u' patch to '[email protected]'. There everyone will be able to review it and Alexandre will apply it if he thinks it's ok. The Wine Developpers Guide has slightly more detailed instructions:
http://wine.codeweavers.com/docs/wine-devel/patches.shtml
Also I don't want to submit it right now because my current fix is a bit ugly.
You can also post your patch to wine-devel if you want help. There we can all discuss what 'the right fix' is :-)
The fix is applied for files that should be moved or deleted when windows boots after an application is installed. Currently there was a message telling the user that he has to delete/rename the specified files. Now I added some code that writes an entry in (WINECONFIG)/bootmove and (WINECONFIG)/bootdel when these functions are called. I also added some code in loader/main.c that checks if these files exists and if they do it will open them and deletes/renames the specified files. I hope this solution is acceptable. :)
I believe that Windows stores the list of files to move/delete somewhere in the registry. We should probably do the same... It seems that adding keys in the registry would be better than creating new files in any case.
-- Francois Gouget [email protected] http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.