Re: msvcrt: remove errno EDOM from atan, exp and tanh

[Piotr Caban]

Hi,

On 03/22/15 14:50, Kevin Chan wrote:
> double CDECL MSVCRT_atan( double x )
>   {
> - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM;
>  return atan(x);
> }

I've done a little more testing. The function is not setting errno in 
INF and -INF case. It does set errno  to EDOM when argument is NAN.

Thanks,
Piotr

msvcrt: remove errno EDOM from atan, exp and tanh

[Zheng Chen]

Hi Piotr,

double CDECL MSVCRT_atan( double x )
> > {
> > - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM;
> >  return atan(x);
> > }
>
> I've done a little more testing. The function is not setting errno in INF
> and -INF case. It does set errno  to EDOM when argument is NAN.

Thanks for pointting out! Sorry I missed it. Sending a patch.

Regards,
Zheng