Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.

[paulo lesgaz]

The point is that the tests are uncorrect:
Here is I obtain in a real windows Vista box:

http://test.winehq.org/data/8d0cb61bc7760c4ab254c3a5bb751bded3a6f4ed/vista_j...

visual.c:183: Driver string: "nvd3dum.dll"
visual.c:184: Description string: "NVIDIA GeForce Go 7600"
visual.c:185: Device name string: "\.\DISPLAY1"
visual.c:186: Driver version 7.15.11.7692
visual.c:8868: Tests skipped: D3DFMT_R16F textures not supported
visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests
visual.c:9690: Test failed: Input 0xff000000: Got color 0x00008700 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x004bff1c for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00b30000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0xff0000ff: Got color 0x000030e1 for pixel 2/1, expected 0x004bffff, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0x00ffff00: Got color 0x00ffd01c for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0x0000ffff: Got color 0x004bffff for pixel 2/1, expected 0x000030e1, format D3DFMT_UYVY
visual.c:9690: Test failed: Input 0xffff00ff: Got color 0x00b300e1 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_UYVY
visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2
visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2
visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2
visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2
visual.c:9686: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2
visual.c:9686: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2
visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2

So, something is wrong in wined3d implementation.

David

--- En date de : Ven 5.6.09, Alexandre Julliard  a écrit :

De: Alexandre Julliard 
Objet: Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
À: "Henri Verbeet" 
Cc: [e-mail]
Date: Vendredi 5 Juin 2009, 14h38

Henri Verbeet  writes:
> Alexandre Julliard wrote:
> > It doesn't work here:
> >
> > ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok
> > visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests
> > visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY
> > visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY
> > visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY
> > visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY
> > visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY
> > visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY
> > visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY
> > [...many more...]
> > make: *** [visual.ok] Error 72
>
> Does the attached patch make it any better?

Yes, that fixes it.

[08/10] wined3d: Use FBOs for offscreen rendering by default.

[Roderick Colenbrander]

Sure the test fails on your system but I think it is a driver bug or
some change in Vista as a lot of other machines using different
windows versions and drivers work fine. Have you tried updating to a
newer driver version? Perhaps it also matters if you have desktop
effects (dwm?) turned on or off. It might make a difference. I might
be able to try the test on my ati laptop later on.

Roderick

On Fri, Jun 5, 2009 at 5:20 PM, paulo lesgaz wrote:
> The point is that the tests are uncorrect:
> Here is I obtain in a real windows Vista box:
>
> http://test.winehq.org/data/8d0cb61bc7760c4ab254c3a5bb751bded3a6f4ed/vista_j...
>
> visual.c:183: Driver string: "nvd3dum.dll"
> visual.c:184: Description string: "NVIDIA GeForce Go 7600"
> visual.c:185: Device name string: "\.\DISPLAY1"
> visual.c:186: Driver version 7.15.11.7692
> visual.c:8868: Tests skipped: D3DFMT_R16F textures not supported
> visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping
> conditional NP2 tests
> visual.c:9690: Test failed: Input 0xff000000: Got color 0x00008700 for pixel
> 2/1, expected 0x004bff1c, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x004bff1c for pixel
> 2/1, expected 0x00008700, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00b30000 for pixel
> 2/1, expected 0x00ffd01c, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0xff0000ff: Got color 0x000030e1 for pixel
> 2/1, expected 0x004bffff, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0x00ffff00: Got color 0x00ffd01c for pixel
> 2/1, expected 0x00b30000, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0x0000ffff: Got color 0x004bffff for pixel
> 2/1, expected 0x000030e1, format D3DFMT_UYVY
> visual.c:9690: Test failed: Input 0xffff00ff: Got color 0x00b300e1 for pixel
> 2/1, expected 0x00ff79ff, format D3DFMT_UYVY
> visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel
> 1/1, expected 0x00008700, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel
> 2/1, expected 0x00008700, format D3DFMT_YUY2
> visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel
> 1/1, expected 0x00b30000, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel
> 2/1, expected 0x00b30000, format D3DFMT_YUY2
> visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel
> 1/1, expected 0x00008700, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel
> 2/1, expected 0x004bff1c, format D3DFMT_YUY2
> visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel
> 1/1, expected 0x000030e1, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel
> 2/1, expected 0x000030e1, format D3DFMT_YUY2
> visual.c:9686: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel
> 1/1, expected 0x004bff1c, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel
> 2/1, expected 0x00008700, format D3DFMT_YUY2
> visual.c:9686: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel
> 1/1, expected 0x00b30000, format D3DFMT_YUY2
> visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel
> 2/1, expected 0x00ffd01c, format D3DFMT_YUY2
>
> So, something is wrong in wined3d implementation.
>
> David
>
> --- En date de : Ven 5.6.09, Alexandre Julliard  a
> écrit :
>
> De: Alexandre Julliard 
> Objet: Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
> À: "Henri Verbeet" 
> Cc: [e-mail]
> Date: Vendredi 5 Juin 2009, 14h38
>
> Henri Verbeet  writes:
> > Alexandre Julliard wrote:
> > > It doesn't work here:
> > >
> > > ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p
> > > d3d9_test.exe.so visual.c && touch visual.ok
> > > visual.c:7572: Tests skipped: Card has unconditional pow2 support,
> > > skipping conditional NP2 tests
> > > visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for
> > > pixel 1/1, expected 0x00008700, format D3DFMT_UYVY
> > > visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for
> > > pixel 2/1, expected 0x00008700, format D3DFMT_UYVY
> > > visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for
> > > pixel 1/1, expected 0x00008700, format D3DFMT_UYVY
> > > visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for
> > > pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY
> > > visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for
> > > pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY
> > > visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for
> > > pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY
> > > visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for
> > > pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY
> > > [...many more...]
> > > make: *** [visual.ok] Error 72
> >
> > Does the attached patch make it any better?
>
> Yes, that fixes it.
>
> --
> Alexandre Julliard
> [e-mail]