Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

[Sebastian Lackner]

On 28.04.2016 21:17, Aaryaman Vasishta wrote:
>  if (FAILED(hr = d3drm_texture_create(&object)))
> - {
> -
>    d3drm_texture_destroy(object);
>    return hr;
> - }

I have not reviewed the whole series, but it looks like you are calling
d3drm_texture_destroy on an uninitialized variable here.

[PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture.

[Aaryaman Vasishta]

Right, I'll send another patch to fix this.

Cheers,
Aaryaman

On Friday, April 29, 2016, Sebastian Lackner  wrote:
> On 28.04.2016 21:17, Aaryaman Vasishta wrote:
> >  if (FAILED(hr = d3drm_texture_create(&object)))
> > - {
> > -
> >    d3drm_texture_destroy(object);
> >    return hr;
> > - }
>
> I have not reviewed the whole series, but it looks like you are calling
> d3drm_texture_destroy on an uninitialized variable here.