[PATCH 1/2] api-ms-win-core-psapi-ansi-l1-1-0: Add K32GetModuleBaseNameA.

[Giovanni Mascellani]

It is required by the Mass Effect Legendary Edition launcher.

Signed-off-by: Giovanni Mascellani 
---
 .../api-ms-win-core-psapi-ansi-l1-1-0.spec                       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
index e4f758581f6..340198c6edf 100644
--- a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
+++ b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
@@ -4,3 +4,4 @@
 @ stdcall K32GetMappedFileNameA(long ptr ptr long) kernel32.K32GetMappedFileNameA
 @ stdcall K32GetProcessImageFileNameA(long ptr long) kernel32.K32GetProcessImageFileNameA
 @ stdcall QueryFullProcessImageNameA(ptr long ptr ptr) kernel32.QueryFullProcessImageNameA
+@ stdcall K32GetModuleBaseNameA(long long ptr long) kernel32.K32GetModuleBaseNameA

[PATCH 2/2] api-ms-win-core-psapi-l1-1-0: Implement a couple of calls.

[Giovanni Mascellani]

They are required by the Mass Effect Legendary Edition launcher.

Signed-off-by: Giovanni Mascellani 
---
 .../api-ms-win-core-psapi-l1-1-0.spec                           | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/api-ms-win-core-psapi-l1-1-0/api-ms-win-core-psapi-l1-1-0.spec b/dlls/api-ms-win-core-psapi-l1-1-0/api-ms-win-core-psapi-l1-1-0.spec
index c54c1077843..321fc3fe928 100644
--- a/dlls/api-ms-win-core-psapi-l1-1-0/api-ms-win-core-psapi-l1-1-0.spec
+++ b/dlls/api-ms-win-core-psapi-l1-1-0/api-ms-win-core-psapi-l1-1-0.spec
@@ -14,3 +14,5 @@
 @ stdcall K32QueryWorkingSet(long ptr long) kernel32.K32QueryWorkingSet
 @ stdcall K32QueryWorkingSetEx(long ptr long) kernel32.K32QueryWorkingSetEx
 @ stdcall QueryFullProcessImageNameW(ptr long ptr ptr) kernel32.QueryFullProcessImageNameW
+@ stdcall K32GetModuleBaseNameW(long long ptr long) kernel32.K32GetModuleBaseNameW
+@ stdcall K32GetModuleInformation(long long ptr long) kernel32.K32GetModuleInformation

[Alex Henrie]

On Wed, Sep 22, 2021 at 1:58 AM Giovanni Mascellani
 wrote:
> It is required by the Mass Effect Legendary Edition launcher.
> Signed-off-by: Giovanni Mascellani
>
> .../api-ms-win-core-psapi-ansi-l1-1-0.spec                       | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> index e4f758581f6..340198c6edf 100644
> --- a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> +++ b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> @@ -4,3 +4,4 @@
>  @ stdcall K32GetMappedFileNameA(long ptr ptr long) kernel32.K32GetMappedFileNameA
>  @ stdcall K32GetProcessImageFileNameA(long ptr long) kernel32.K32GetProcessImageFileNameA
>  @ stdcall QueryFullProcessImageNameA(ptr long ptr ptr) kernel32.QueryFullProcessImageNameA
> +@ stdcall K32GetModuleBaseNameA(long long ptr long) kernel32.K32GetModuleBaseNameA

Hi Giovanni, thanks for the patch. Please keep these lists
alphabetized: For example, K32GetModuleBaseNameA should be between
K32GetMappedFileNameA and K32GetProcessImageFileNameA.

-Alex

[Thomas Crider]

Forgot to reply all:

It should be noted I submitted this months ago:

https://bugs.winehq.org/show_bug.cgi?id=51199

It's currently in staging:

https://github.com/wine-staging/wine-staging/tree/master/patches/api-ms-win-...

And was originally submitted May 29 to upstream:

[PATCH 1/2] api-ms-win-core-psapi-l1-1-0: Add K32GetModuleBaseNameW and
K32GetModuleInformation.
[PATCH 2/2] api-ms-win-core-psapi-ansi-l1-1-0: add K32GetModuleBaseNameA

On Wed, Sep 22, 2021 at 11:27 AM Alex Henrie  wrote:
> On Wed, Sep 22, 2021 at 1:58 AM Giovanni Mascellani
>  wrote:
> > It is required by the Mass Effect Legendary Edition launcher.
> > Signed-off-by: Giovanni Mascellani
> >
> > .../api-ms-win-core-psapi-ansi-l1-1-0.spec                       | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
>
> a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> > index e4f758581f6..340198c6edf 100644
>
> a/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> > +++
>
> b/dlls/api-ms-win-core-psapi-ansi-l1-1-0/api-ms-win-core-psapi-ansi-l1-1-0.spec
> > @@ -4,3 +4,4 @@
> >  @ stdcall K32GetMappedFileNameA(long ptr ptr long)
>
> kernel32.K32GetMappedFileNameA
> > @ stdcall K32GetProcessImageFileNameA(long ptr long)
>
> kernel32.K32GetProcessImageFileNameA
> > @ stdcall QueryFullProcessImageNameA(ptr long ptr ptr)
>
> kernel32.QueryFullProcessImageNameA
> > +@ stdcall K32GetModuleBaseNameA(long long ptr long)
>
> kernel32.K32GetModuleBaseNameA
>
> Hi Giovanni, thanks for the patch. Please keep these lists
> alphabetized: For example, K32GetModuleBaseNameA should be between
> K32GetMappedFileNameA and K32GetProcessImageFileNameA.
>
> -Alex

[Giovanni Mascellani]

Hi,

Il 22/09/21 21:02, Thomas Crider ha scritto:
> Forgot to reply all:
>
> It should be noted I submitted this months ago:
>
> https://bugs.winehq.org/show_bug.cgi?id=51199 
> https://bugs.winehq.org/show_bug.cgi?id=51199

Sorry, I didn't want to take your credits. I hadn't noticed those 
patches had already been submitted.

Personally, it's totally ok for me to commit the patches crediting 
Thomas instead of me. The only thing I care about is having them 
committed, so that the game works.

Giovanni.